[go] go/types: fix suspect or

[Damian Gryski (Gerrit)]

Damian Gryski uploaded a change:
https://go-review.googlesource.com/12517

go/types: fix suspect or

In https://go-review.googlesource.com/#/c/8611/ , these tests were
supposed to be skipped only for linux and darwin, as the comment says.
This patch fixes the logic in the if test.

Change-Id: Iff0a32186267457a414912c4c3ee4495650891a2
---
M src/go/types/stdlib_test.go
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/go/types/stdlib_test.go b/src/go/types/stdlib_test.go
index 2014e98..c6c946e 100644
--- a/src/go/types/stdlib_test.go
+++ b/src/go/types/stdlib_test.go
@@ -129,7 +129,7 @@

// test/recover4.go is only built for Linux and Darwin.
// TODO(gri) Remove once tests consider +build tags (issue 10370).
- if runtime.GOOS != "linux" || runtime.GOOS != "darwin" {
+ if runtime.GOOS != "linux" && runtime.GOOS != "darwin" {
return
}


--
https://go-review.googlesource.com/12517

[Josh Bleecher Snyder (Gerrit)]

Josh Bleecher Snyder has posted comments on this change.

go/types: fix suspect or

Patch Set 1: Code-Review+1

R=gri

--
https://go-review.googlesource.com/12517
Gerrit-Reviewer: Josh Bleecher Snyder <josh...@gmail.com>
Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
Gerrit-HasComments: No

[Robert Griesemer (Gerrit)]

Robert Griesemer has posted comments on this change.

go/types: fix suspect or

Patch Set 1: Code-Review+2 Run-TryBot+1

LGTM

Before submitting, let's check that the test (which never ran) actually
works.

[Gobot Gobot (Gerrit)]

Gobot Gobot has posted comments on this change.

go/types: fix suspect or

Patch Set 1:

TryBots beginning. Status page: http://farmer.golang.org/try?commit=de5e1a76

--
https://go-review.googlesource.com/12517
Gerrit-Reviewer: Gobot Gobot <go...@golang.org>

[Gobot Gobot (Gerrit)]

Gobot Gobot has posted comments on this change.

go/types: fix suspect or

Patch Set 1:

This change failed on darwin-amd64-10_10:
See
https://storage.googleapis.com/go-build-log/de5e1a76/darwin-amd64-10_10_f07460f7.log

Consult https://build.golang.org/ to see whether it's a new failure. Other
builds still in progress; subsequent failure notices suppressed until final
report.

[Gobot Gobot (Gerrit)]

Gobot Gobot has posted comments on this change.

go/types: fix suspect or

Patch Set 1: TryBot-Result-1

1 of 14 TryBots failed:
Failed on darwin-amd64-10_10:
https://storage.googleapis.com/go-build-log/de5e1a76/darwin-amd64-10_10_f07460f7.log

Consult https://build.golang.org/ to see whether they are new failures.

[Robert Griesemer (Gerrit)]

Robert Griesemer has posted comments on this change.

go/types: fix suspect or

Patch Set 1:

> 1 of 14 TryBots failed:
> Failed on darwin-amd64-10_10:
https://storage.googleapis.com/go-build-log/de5e1a76/darwin-amd64-10_10_f07460f7.log
>
> Consult https://build.golang.org/ to see whether they are new
> failures.

unrelated.