[build] env/linux-arm64-trixie, env/linux-x86-trixie: add Debian Trixie images

10 views
Skip to first unread message

Carlos Amedee (Gerrit)

unread,
Sep 30, 2025, 2:34:02 PM (2 days ago) Sep 30
to goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov

Carlos Amedee voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dmitri Shuralyov
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I95f3db5d4e9dcab56740eb12a27d6563017d7a05
Gerrit-Change-Number: 708055
Gerrit-PatchSet: 2
Gerrit-Owner: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Comment-Date: Tue, 30 Sep 2025 18:33:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
Sep 30, 2025, 2:59:16 PM (2 days ago) Sep 30
to Carlos Amedee, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Go LUCI, golang-co...@googlegroups.com
Attention needed from Carlos Amedee

Dmitri Shuralyov voted and added 3 comments

Votes added by Dmitri Shuralyov

Code-Review+2

3 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Dmitri Shuralyov . resolved

Thanks.

Left some optional comments. Feel free to include them or leave to a future CL, whichever works out better.

File env/linux-arm64-trixie/Makefile
File-level comment, Patchset 2 (Latest):
Dmitri Shuralyov . unresolved

This Makefile determinutes the image name from the name of the directory it's in, and is identical to the linux-arm64-bookworm one. Instead of copying it, consider following what we have for x86 ones and making this a link to ../shared-makefile/Makefile.arm64 or something like that. (If we ever need to make them different, we can do that, otherwise the link makes it easier to see it's a common Makefile across multiple images.)

File env/linux-x86-trixie/Dockerfile
Line 55, Patchset 2 (Latest):# nano: for interactive debugging convenience
Dmitri Shuralyov . unresolved

Since this can be handy regardless of the GOARCH value, and isn't yet included in arm64 images, consider copying it over to make some progress on making them more similar. (Even if it's not included in the first image build, for future ones.)

Open in Gerrit

Related details

Attention is currently required from:
  • Carlos Amedee
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I95f3db5d4e9dcab56740eb12a27d6563017d7a05
Gerrit-Change-Number: 708055
Gerrit-PatchSet: 2
Gerrit-Owner: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Attention: Carlos Amedee <car...@golang.org>
Gerrit-Comment-Date: Tue, 30 Sep 2025 18:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
Sep 30, 2025, 2:59:24 PM (2 days ago) Sep 30
to Carlos Amedee, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Go LUCI, golang-co...@googlegroups.com
Attention needed from Carlos Amedee

Dmitri Shuralyov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Carlos Amedee
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: build
    Gerrit-Branch: master
    Gerrit-Change-Id: I95f3db5d4e9dcab56740eb12a27d6563017d7a05
    Gerrit-Change-Number: 708055
    Gerrit-PatchSet: 2
    Gerrit-Owner: Carlos Amedee <car...@golang.org>
    Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
    Gerrit-Attention: Carlos Amedee <car...@golang.org>
    Gerrit-Comment-Date: Tue, 30 Sep 2025 18:59:21 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Carlos Amedee (Gerrit)

    unread,
    Oct 1, 2025, 3:54:32 PM (12 hours ago) Oct 1
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Dmitri Shuralyov and Dmitri Shuralyov

    Carlos Amedee uploaded new patchset

    Carlos Amedee uploaded patch set #3 to this change.
    Following approvals got outdated and were removed:
    • Code-Review: +1 by Dmitri Shuralyov, +2 by Dmitri Shuralyov
    • TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dmitri Shuralyov
    • Dmitri Shuralyov
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: build
      Gerrit-Branch: master
      Gerrit-Change-Id: I95f3db5d4e9dcab56740eb12a27d6563017d7a05
      Gerrit-Change-Number: 708055
      Gerrit-PatchSet: 3
      Gerrit-Owner: Carlos Amedee <car...@golang.org>
      Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Attention: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Carlos Amedee (Gerrit)

      unread,
      Oct 1, 2025, 3:54:32 PM (12 hours ago) Oct 1
      to goph...@pubsubhelper.golang.org, Go LUCI, Dmitri Shuralyov, Dmitri Shuralyov, golang-co...@googlegroups.com
      Attention needed from Dmitri Shuralyov and Dmitri Shuralyov

      Carlos Amedee added 2 comments

      File env/linux-arm64-trixie/Makefile
      File-level comment, Patchset 2:
      Dmitri Shuralyov . resolved

      This Makefile determinutes the image name from the name of the directory it's in, and is identical to the linux-arm64-bookworm one. Instead of copying it, consider following what we have for x86 ones and making this a link to ../shared-makefile/Makefile.arm64 or something like that. (If we ever need to make them different, we can do that, otherwise the link makes it easier to see it's a common Makefile across multiple images.)

      Carlos Amedee

      Done

      File env/linux-x86-trixie/Dockerfile
      Line 55, Patchset 2:# nano: for interactive debugging convenience
      Dmitri Shuralyov . resolved

      Since this can be handy regardless of the GOARCH value, and isn't yet included in arm64 images, consider copying it over to make some progress on making them more similar. (Even if it's not included in the first image build, for future ones.)

      Carlos Amedee

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dmitri Shuralyov
      • Dmitri Shuralyov
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: build
      Gerrit-Branch: master
      Gerrit-Change-Id: I95f3db5d4e9dcab56740eb12a27d6563017d7a05
      Gerrit-Change-Number: 708055
      Gerrit-PatchSet: 3
      Gerrit-Owner: Carlos Amedee <car...@golang.org>
      Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Attention: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Comment-Date: Wed, 01 Oct 2025 19:54:28 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Dmitri Shuralyov <dmit...@golang.org>
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Carlos Amedee (Gerrit)

      unread,
      Oct 1, 2025, 3:59:14 PM (12 hours ago) Oct 1
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from Dmitri Shuralyov and Dmitri Shuralyov

      Carlos Amedee uploaded new patchset

      Carlos Amedee uploaded patch set #4 to this change.
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dmitri Shuralyov
      • Dmitri Shuralyov
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: build
      Gerrit-Branch: master
      Gerrit-Change-Id: I95f3db5d4e9dcab56740eb12a27d6563017d7a05
      Gerrit-Change-Number: 708055
      Gerrit-PatchSet: 4
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages