[go] cmd/internal/obj/loong64: add {,X}VSHUF.{H/W/V} instructions support
7 views
Skip to first unread message
abner chenc (Gerrit)
Oct 31, 2025, 6:22:06 AM (11 days ago) Oct 31
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
abner chenc has uploaded the change for review![]( "Open in Gerrit")
Commit message
cmd/internal/obj/loong64: add {,X}VSHUF.{H/W/V} instructions support
Go asm syntax:
VSHUF{H/W/V} V1, V2, V3
XVSHUF{H/W/V} X1, X2, X3
Equivalent platform assembler syntax:
vshuf.{h/w/d} v3, v1, v2
xvshuf.{h/w/d} x3, x1, x2Change-Id: I8983467495f587cf46083fd81cb024400c7dc2a7
Change diff
diff --git a/src/cmd/asm/internal/asm/testdata/loong64enc1.s b/src/cmd/asm/internal/asm/testdata/loong64enc1.s
index b440a64..f8105d6 100644
--- a/src/cmd/asm/internal/asm/testdata/loong64enc1.s
+++ b/src/cmd/asm/internal/asm/testdata/loong64enc1.s
@@ -1023,6 +1023,14 @@
XVSHUF4IV $8, X1, X2 // 22209c77
XVSHUF4IV $15, X1, X2 // 223c9c77
+ // [X]VSHUF.{H/W/V} instructions
+ VSHUFH V1, V2, V3 // 43847a71
+ VSHUFW V1, V2, V3 // 43047b71
+ VSHUFV V1, V2, V3 // 43847b71
+ XVSHUFH X1, X2, X3 // 43847a75
+ XVSHUFW X1, X2, X3 // 43047b75
+ XVSHUFV X1, X2, X3 // 43847b75
+
// VPERMIW, XVPERMI{W,V,Q} instructions
VPERMIW $0x1B, V1, V2 // VPERMIW $27, V1, V2 // 226ce473
XVPERMIW $0x2B, X1, X2 // XVPERMIW $43, X1, X2 // 22ace477
diff --git a/src/cmd/internal/obj/loong64/a.out.go b/src/cmd/internal/obj/loong64/a.out.go
index 48e60b6..d19809b 100644
--- a/src/cmd/internal/obj/loong64/a.out.go
+++ b/src/cmd/internal/obj/loong64/a.out.go
@@ -1115,6 +1115,13 @@
AXVSHUF4IW
AXVSHUF4IV
+ AVSHUFH
+ AVSHUFW
+ AVSHUFV
+ AXVSHUFH
+ AXVSHUFW
+ AXVSHUFV
+
AVPERMIW
AXVPERMIW
AXVPERMIV
diff --git a/src/cmd/internal/obj/loong64/anames.go b/src/cmd/internal/obj/loong64/anames.go
index 9580674..5a32c2c 100644
--- a/src/cmd/internal/obj/loong64/anames.go
+++ b/src/cmd/internal/obj/loong64/anames.go
@@ -586,6 +586,12 @@
"XVSHUF4IH",
"XVSHUF4IW",
"XVSHUF4IV",
+ "VSHUFH",
+ "VSHUFW",
+ "VSHUFV",
+ "XVSHUFH",
+ "XVSHUFW",
+ "XVSHUFV",
"VPERMIW",
"XVPERMIW",
"XVPERMIV",
diff --git a/src/cmd/internal/obj/loong64/asm.go b/src/cmd/internal/obj/loong64/asm.go
index 8bf8a1d..00f90c0 100644
--- a/src/cmd/internal/obj/loong64/asm.go
+++ b/src/cmd/internal/obj/loong64/asm.go
@@ -1698,6 +1698,9 @@
opset(AVMULD, r0)
opset(AVDIVF, r0)
opset(AVDIVD, r0)
+ opset(AVSHUFH, r0)
+ opset(AVSHUFW, r0)
+ opset(AVSHUFV, r0)
case AXVSEQB:
opset(AXVSEQH, r0)
@@ -1771,6 +1774,9 @@
opset(AXVMULD, r0)
opset(AXVDIVF, r0)
opset(AXVDIVD, r0)
+ opset(AXVSHUFH, r0)
+ opset(AXVSHUFW, r0)
+ opset(AXVSHUFV, r0)
case AVANDB:
opset(AVORB, r0)
@@ -3775,6 +3781,18 @@
return 0xea22 << 15 // xvbitrev.w
case AXVBITREVV:
return 0xea23 << 15 // xvbitrev.d
+ case AVSHUFH:
+ return 0x0E2F5 << 15 // vshuf.h
+ case AVSHUFW:
+ return 0x0E2F6 << 15 // vshuf.w
+ case AVSHUFV:
+ return 0x0E2F7 << 15 // vshuf.d
+ case AXVSHUFH:
+ return 0x0EAF5 << 15 // xvshuf.h
+ case AXVSHUFW:
+ return 0x0EAF6 << 15 // xvshuf.w
+ case AXVSHUFV:
+ return 0x0EAF7 << 15 // xvshuf.d
}
if a < 0 {
Change information
Files:
- M src/cmd/asm/internal/asm/testdata/loong64enc1.s
- M src/cmd/internal/obj/loong64/a.out.go
- M src/cmd/internal/obj/loong64/anames.go
- M src/cmd/internal/obj/loong64/asm.go
Change size: S
Delta: 4 files changed, 39 insertions(+), 0 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
abner chenc (Gerrit)
Nov 3, 2025, 9:58:48 PM (7 days ago) Nov 3
to goph...@pubsubhelper.golang.org, sophie zhao, Meidan Li, Cherry Mui, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Meidan Li and sophie zhao
abner chenc voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Meidan Li
- sophie zhao
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Meidan Li (Gerrit)
Nov 3, 2025, 10:26:38 PM (7 days ago) Nov 3
to abner chenc, goph...@pubsubhelper.golang.org, Go LUCI, sophie zhao, Cherry Mui, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Cherry Mui, abner chenc and sophie zhao
Meidan Li voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Cherry Mui
- abner chenc
- sophie zhao
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
sophie zhao (Gerrit)
Nov 4, 2025, 1:28:18 AM (7 days ago) Nov 4
to abner chenc, goph...@pubsubhelper.golang.org, Meidan Li, Go LUCI, Cherry Mui, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Cherry Mui and abner chenc
sophie zhao added 2 comments![]( "Open in Gerrit")
Commit Message
Line 14, Patchset 2 (Latest):
vshuf.{h/w/d} v3, v1, v2sophie zhao . unresolved
The register order is wrong.
Related details
Attention is currently required from:
- Cherry Mui
- abner chenc
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
abner chenc (Gerrit)
Nov 4, 2025, 3:23:48 AM (7 days ago) Nov 4
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui and abner chenc
abner chenc uploaded new patchset![]( "Open in Gerrit")
abner chenc uploaded patch set #3 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Related details
Attention is currently required from:
- Cherry Mui
- abner chenc
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
abner chenc (Gerrit)
Nov 4, 2025, 3:24:19 AM (7 days ago) Nov 4
to goph...@pubsubhelper.golang.org, Meidan Li, Go LUCI, sophie zhao, Cherry Mui, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Cherry Mui and sophie zhao
abner chenc voted and added 2 comments![]( "Open in Gerrit")
Votes added by abner chenc
| Commit-Queue | +1 |
The register order is wrong.
Attention is currently required from:
- Cherry Mui
- sophie zhao
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
sophie zhao (Gerrit)
Nov 4, 2025, 4:16:31 AM (7 days ago) Nov 4
to abner chenc, goph...@pubsubhelper.golang.org, Go LUCI, Meidan Li, Cherry Mui, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Cherry Mui and abner chenc
sophie zhao voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Cherry Mui
- abner chenc
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Knyszek (Gerrit)
Nov 4, 2025, 4:01:32 PM (7 days ago) Nov 4
to abner chenc, goph...@pubsubhelper.golang.org, sophie zhao, Go LUCI, Meidan Li, Cherry Mui, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Cherry Mui and abner chenc
Michael Knyszek voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- abner chenc
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
Nov 4, 2025, 4:58:22 PM (7 days ago) Nov 4
to abner chenc, goph...@pubsubhelper.golang.org, Michael Pratt, sophie zhao, Go LUCI, Meidan Li, Cherry Mui, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Cherry Mui and abner chenc
Michael Pratt voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- abner chenc
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
abner chenc (Gerrit)
Nov 5, 2025, 7:43:29 PM (6 days ago) Nov 5
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Pratt, Michael Knyszek, sophie zhao, Go LUCI, Meidan Li, Cherry Mui, Gopher Robot, golang-co...@googlegroups.com
abner chenc submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/cmd/internal/obj/loong64/anames.go
Insertions: 2, Deletions: 0.
@@ -586,9 +586,11 @@
"XVSHUF4IH",
"XVSHUF4IW",
"XVSHUF4IV",
+ "VSHUFB",
"VSHUFH",
"VSHUFW",
"VSHUFV",
+ "XVSHUFB",
"XVSHUFH",
"XVSHUFW",
"XVSHUFV",
```
```
The name of the file: src/cmd/internal/obj/loong64/a.out.go
Insertions: 2, Deletions: 0.
@@ -1115,9 +1115,11 @@
AXVSHUF4IW
AXVSHUF4IV
+ AVSHUFB
AVSHUFH
AVSHUFW
AVSHUFV
+ AXVSHUFB
AXVSHUFH
AXVSHUFW
AXVSHUFV
```
```
The name of the file: src/cmd/asm/internal/asm/testdata/loong64enc1.s
Insertions: 3, Deletions: 1.
@@ -1023,13 +1023,15 @@
XVSHUF4IV $8, X1, X2 // 22209c77
XVSHUF4IV $15, X1, X2 // 223c9c77
- // [X]VSHUF.{H/W/V} instructions
+ // [X]VSHUF.{B/H/W/V} instructions
VSHUFH V1, V2, V3 // 43847a71
VSHUFW V1, V2, V3 // 43047b71
VSHUFV V1, V2, V3 // 43847b71
XVSHUFH X1, X2, X3 // 43847a75
XVSHUFW X1, X2, X3 // 43047b75
XVSHUFV X1, X2, X3 // 43847b75
+ VSHUFB V1, V2, V3, V4 // 6488500d
+ XVSHUFB X1, X2, X3, X4 // 6488600d
// VPERMIW, XVPERMI{W,V,Q} instructions
VPERMIW $0x1B, V1, V2 // VPERMIW $27, V1, V2 // 226ce473
```
```
The name of the file: src/cmd/internal/obj/loong64/asm.go
Insertions: 8, Deletions: 0.
@@ -155,6 +155,8 @@
{AFMADDF, C_FREG, C_FREG, C_NONE, C_FREG, C_NONE, 37, 4, 0, 0},
{AFMADDF, C_FREG, C_FREG, C_FREG, C_FREG, C_NONE, 37, 4, 0, 0},
+ {AVSHUFB, C_VREG, C_VREG, C_VREG, C_VREG, C_NONE, 37, 4, 0, 0},
+ {AXVSHUFB, C_XREG, C_XREG, C_XREG, C_XREG, C_NONE, 37, 4, 0, 0},
{AFSEL, C_FCCREG, C_FREG, C_FREG, C_FREG, C_NONE, 33, 4, 0, 0},
{AFSEL, C_FCCREG, C_FREG, C_NONE, C_FREG, C_NONE, 33, 4, 0, 0},
@@ -1561,6 +1563,8 @@
AMOVWU,
AVMOVQ,
AXVMOVQ,
+ AVSHUFB,
+ AXVSHUFB,
ANEGW,
ANEGV,
AWORD,
@@ -3105,6 +3109,10 @@
return 0x8d << 20 // fnmsub.s
case AFNMSUBD:
return 0x8e << 20 // fnmsub.d
+ case AVSHUFB:
+ return 0x0D5 << 20 // vshuf.b
+ case AXVSHUFB:
+ return 0x0D6 << 20 // xvshuf.b
}
c.ctxt.Diag("bad rrrr opcode %v", a)
```
Change information
Commit message:
cmd/internal/obj/loong64: add {,X}VSHUF.{B/H/W/V} instructions support
Go asm syntax:
VSHUFB V1, V2, V3, V4
XVSHUFB X1, X2, X3, X4
VSHUF{H/W/V} V1, V2, V3
XVSHUF{H/W/V} X1, X2, X3
Equivalent platform assembler syntax:
vshuf.b v4, v3, v2, v1
xvshuf.b x4, x3, x2, x1
vshuf.{h/w/d} v3, v2, v1
xvshuf.{h/w/d} x3, x2, x1
Change-Id: I8983467495f587cf46083fd81cb024400c7dc2a7
Reviewed-on: https://go-review.googlesource.com/c/go/+/716804
Reviewed-by: Meidan Li <lime...@loongson.cn>
Reviewed-by: Michael Knyszek <mkny...@google.com>
Reviewed-by: Michael Pratt <mpr...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: sophie zhao <zhaox...@loongson.cn>
Files:
- M src/cmd/asm/internal/asm/testdata/loong64enc1.s
- M src/cmd/internal/obj/loong64/a.out.go
- M src/cmd/internal/obj/loong64/anames.go
- M src/cmd/internal/obj/loong64/asm.go
Change size: M
Delta: 4 files changed, 53 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by sophie zhao, +1 by Michael Pratt, +1 by Michael Knyszek, +2 by Meidan Li
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages