[net] http2: Move most tests from the http2 package to the http2_test package.
1 view
Skip to first unread message
Damien Neil (Gerrit)
Feb 26, 2026, 6:36:03 PM (21 hours ago) Feb 26
to goph...@pubsubhelper.golang.org, Nicholas Husin, Go LUCI, golang-co...@googlegroups.com
Attention needed from Nicholas Husin
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
12:43 PM (3 hours ago) 12:43 PM
to Damien Neil, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Damien Neil
Nicholas Husin voted and added 3 comments![]( "Open in Gerrit")
Votes added by Nicholas Husin
| Code-Review | +2 |
3 comments
Patchset-level comments
File http2/server_test.go
Line 396, Patchset 2 (Latest):
/*
func (st *serverTester) closeConn() {
st.scMu.Lock()
defer st.scMu.Unlock()
st.sc.conn.Close()
}
*/Nicholas Husin . unresolved
Forgot to delete?
File http2/transport_test.go
Line 4118, Patchset 2 (Latest):
type errorReader struct{ err error }Nicholas Husin . unresolved
Optional / nit / outside of this CL scope:
I remember you liking an [all-purpose reader more](https://go-review.googlesource.com/c/net/+/743600/comment/749fa567_8c44ea78/). Maybe we can just use one here too for consistency within x/net?
Entirely up to you.
Related details
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
12:43 PM (3 hours ago) 12:43 PM
to Damien Neil, goph...@pubsubhelper.golang.org, Nicholas Husin, Go LUCI, golang-co...@googlegroups.com
Attention needed from Damien Neil
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages