[tools] go/analysis/passes/modernize: fix doc URLs in newexpr.go and stringscurt.go

4 views
Skip to first unread message

Lin Lin (Gerrit)

unread,
Dec 18, 2025, 7:23:54 AM (yesterday) Dec 18
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Lin Lin has uploaded the change for review

Commit message

go/analysis/passes/modernize: fix doc URLs in newexpr.go and stringscurt.go

The real working URLs are under golang.org/x/tools/go instead of
golang.org/x/tools/gopls.
Change-Id: I648bcb2613a30fb55afab25623b0623bf0199ced

Change diff

diff --git a/go/analysis/passes/modernize/newexpr.go b/go/analysis/passes/modernize/newexpr.go
index 6cb75f2..cd924ec 100644
--- a/go/analysis/passes/modernize/newexpr.go
+++ b/go/analysis/passes/modernize/newexpr.go
@@ -25,7 +25,7 @@
 var NewExprAnalyzer = &analysis.Analyzer{
 	Name:      "newexpr",
 	Doc:       analyzerutil.MustExtractDoc(doc, "newexpr"),
-	URL:       "https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize#newexpr",
+	URL:       "https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/modernize#newexpr",
 	Requires:  []*analysis.Analyzer{inspect.Analyzer},
 	Run:       run,
 	FactTypes: []analysis.Fact{&newLike{}},
diff --git a/go/analysis/passes/modernize/stringscut.go b/go/analysis/passes/modernize/stringscut.go
index 954997a..08ce2a8 100644
--- a/go/analysis/passes/modernize/stringscut.go
+++ b/go/analysis/passes/modernize/stringscut.go
@@ -36,7 +36,7 @@
 		typeindexanalyzer.Analyzer,
 	},
 	Run: stringscut,
-	URL: "https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize#stringscut",
+	URL: "https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/modernize#stringscut",
 }
 
 func init() {

Change information

Files:
  • M go/analysis/passes/modernize/newexpr.go
  • M go/analysis/passes/modernize/stringscut.go
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I648bcb2613a30fb55afab25623b0623bf0199ced
Gerrit-Change-Number: 731060
Gerrit-PatchSet: 1
Gerrit-Owner: Lin Lin <linsite...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Alan Donovan (Gerrit)

unread,
Dec 18, 2025, 8:34:12 PM (14 hours ago) Dec 18
to Lin Lin, goph...@pubsubhelper.golang.org, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Lin Lin and Michael Matloob

Alan Donovan voted and added 1 comment

Votes added by Alan Donovan

Auto-Submit+1
Code-Review+2
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alan Donovan . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Lin Lin
  • Michael Matloob
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I648bcb2613a30fb55afab25623b0623bf0199ced
Gerrit-Change-Number: 731060
Gerrit-PatchSet: 1
Gerrit-Owner: Lin Lin <linsite...@gmail.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Attention: Michael Matloob <mat...@golang.org>
Gerrit-Attention: Lin Lin <linsite...@gmail.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 01:34:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alan Donovan (Gerrit)

unread,
Dec 18, 2025, 8:34:41 PM (14 hours ago) Dec 18
to goph...@pubsubhelper.golang.org, Lin Lin, golang-co...@googlegroups.com

Alan Donovan has uploaded the change for review

Commit message

[internal-branch.go1.26-vendor] go/analysis/passes/modernize: fix doc URLs in newexpr.go and stringscurt.go
Change-Id: I648bcb2613a30fb55afab25623b0623bf0199ced
 Open in Gerrit
Related details
Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit



 Gerrit-MessageType: newchange 


 Gerrit-Project: tools 


 Gerrit-Branch: internal-branch.go1.26-vendor 


 Gerrit-Change-Id: I648bcb2613a30fb55afab25623b0623bf0199ced 


 Gerrit-Change-Number: 731340 


 Gerrit-PatchSet: 1 


 Gerrit-Owner: Alan Donovan <adon...@google.com> 


 Gerrit-CC: Lin Lin <linsite...@gmail.com> 



unsatisfied_requirement
satisfied_requirement
open
diffy
Lin Lin (Gerrit)
unread,
Dec 18, 2025, 10:21:38 PM (12 hours ago) Dec 18
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Alan Donovan, Lin Lin and Michael Matloob
Lin Lin uploaded new patchset
Lin Lin uploaded patch set #2 to this change.
Following approvals got outdated and were removed:
  • Code-Review: +2 by Alan Donovan
  • TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
 Open in Gerrit
Related details
Attention is currently required from:
  • Alan Donovan
  • Lin Lin
  • Michael Matloob
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit



 Gerrit-MessageType: newpatchset 


 Gerrit-Project: tools 


 Gerrit-Branch: master 


 Gerrit-Change-Id: I648bcb2613a30fb55afab25623b0623bf0199ced 


 Gerrit-Change-Number: 731060 


 Gerrit-PatchSet: 2 


 Gerrit-Owner: Lin Lin <linsite...@gmail.com> 


 Gerrit-Reviewer: Alan Donovan <adon...@google.com> 




 Gerrit-Reviewer: Michael Matloob <mat...@golang.org> 


 Gerrit-Attention: Michael Matloob <mat...@golang.org> 


 Gerrit-Attention: Lin Lin <linsite...@gmail.com> 


 Gerrit-Attention: Alan Donovan <adon...@google.com> 



unsatisfied_requirement
satisfied_requirement
open
diffy
Lin Lin (Gerrit)
unread,
Dec 18, 2025, 10:23:35 PM (12 hours ago) Dec 18
to goph...@pubsubhelper.golang.org, Go LUCI, Alan Donovan, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Alan Donovan and Michael Matloob
Lin Lin added 1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Lin Lin . resolved
Done to update the gopls documentation.
Open in Gerrit
Related details
Attention is currently required from:
  • Alan Donovan
  • Michael Matloob
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit



 Gerrit-MessageType: comment 


 Gerrit-Project: tools 


 Gerrit-Branch: master 


 Gerrit-Change-Id: I648bcb2613a30fb55afab25623b0623bf0199ced 


 Gerrit-Change-Number: 731060 


 Gerrit-PatchSet: 2 


 Gerrit-Owner: Lin Lin <linsite...@gmail.com> 


 Gerrit-Reviewer: Alan Donovan <adon...@google.com> 



 Gerrit-Reviewer: Michael Matloob <mat...@golang.org> 


 Gerrit-Attention: Michael Matloob <mat...@golang.org> 


 Gerrit-Attention: Alan Donovan <adon...@google.com> 


 Gerrit-Comment-Date: Fri, 19 Dec 2025 03:23:28 +0000 


 Gerrit-HasComments: Yes 


 Gerrit-Has-Labels: No 



unsatisfied_requirement
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages