[go] cmd/asm/internal/asm: abort end to end test if assembly failed

5 views
Skip to first unread message

Joel Sing (Gerrit)

unread,
Dec 22, 2025, 8:55:28 AM (3 days ago) Dec 22
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Joel Sing has uploaded the change for review

Commit message

cmd/asm/internal/asm: abort end to end test if assembly failed

If errors are encountered during assembly, do not attempt to perform verification.
In this case the output is unlikely to be correct and all verification fails, which
means the real issue gets lost in the noise.
Change-Id: I62c1bf09fa025b0df4c06f0bfa424fb5d328184b

Change diff

diff --git a/src/cmd/asm/internal/asm/endtoend_test.go b/src/cmd/asm/internal/asm/endtoend_test.go
index e532633..944a7e6 100644
--- a/src/cmd/asm/internal/asm/endtoend_test.go
+++ b/src/cmd/asm/internal/asm/endtoend_test.go
@@ -199,6 +199,11 @@
 	}
 	obj.Flushplist(ctxt, pList, nil)
 
+	if !ok {
+		// If we've encountered errors, the output is unlikely to be sane.
+		return
+	}
+
 	for p := top; p != nil; p = p.Link {
 		if p.As == obj.ATEXT {
 			text = p.From.Sym

Change information

Files:
  • M src/cmd/asm/internal/asm/endtoend_test.go
Change size: XS
Delta: 1 file changed, 5 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I62c1bf09fa025b0df4c06f0bfa424fb5d328184b
Gerrit-Change-Number: 731920
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Sing <jo...@sing.id.au>
unsatisfied_requirement
satisfied_requirement
open
diffy

Joel Sing (Gerrit)

unread,
Dec 22, 2025, 9:15:21 AM (3 days ago) Dec 22
to goph...@pubsubhelper.golang.org, Cherry Mui, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Cherry Mui

Joel Sing voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I62c1bf09fa025b0df4c06f0bfa424fb5d328184b
Gerrit-Change-Number: 731920
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Sing <jo...@sing.id.au>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Attention: Cherry Mui <cher...@google.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 14:15:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Cherry Mui (Gerrit)

unread,
Dec 22, 2025, 11:44:34 AM (2 days ago) Dec 22
to Joel Sing, goph...@pubsubhelper.golang.org, Go LUCI, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Joel Sing

Cherry Mui voted and added 1 comment

Votes added by Cherry Mui

Code-Review+2

1 comment

File src/cmd/asm/internal/asm/endtoend_test.go
Line 204, Patchset 1 (Latest): return
Cherry Mui . unresolved

Maybe t.FailNow() ?

Open in Gerrit

Related details

Attention is currently required from:
  • Joel Sing
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I62c1bf09fa025b0df4c06f0bfa424fb5d328184b
Gerrit-Change-Number: 731920
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Sing <jo...@sing.id.au>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Attention: Joel Sing <jo...@sing.id.au>
Gerrit-Comment-Date: Mon, 22 Dec 2025 16:44:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joel Sing (Gerrit)

unread,
Dec 23, 2025, 5:29:43 AM (yesterday) Dec 23
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Joel Sing

Joel Sing uploaded new patchset

Joel Sing uploaded patch set #2 to this change.
Following approvals got outdated and were removed:
  • TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit

Related details

Attention is currently required from:
  • Joel Sing
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I62c1bf09fa025b0df4c06f0bfa424fb5d328184b
    Gerrit-Change-Number: 731920
    Gerrit-PatchSet: 2
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Joel Sing (Gerrit)

    unread,
    Dec 23, 2025, 5:32:04 AM (yesterday) Dec 23
    to goph...@pubsubhelper.golang.org, Cherry Mui, Go LUCI, Gopher Robot, golang-co...@googlegroups.com

    Joel Sing voted and added 1 comment

    Votes added by Joel Sing

    Auto-Submit+1
    Code-Review+2

    1 comment

    File src/cmd/asm/internal/asm/endtoend_test.go
    Line 204, Patchset 1: return
    Cherry Mui . resolved

    Maybe t.FailNow() ?

    Joel Sing

    Sure, done.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I62c1bf09fa025b0df4c06f0bfa424fb5d328184b
    Gerrit-Change-Number: 731920
    Gerrit-PatchSet: 2
    Gerrit-Owner: Joel Sing <jo...@sing.id.au>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Comment-Date: Tue, 23 Dec 2025 10:31:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Cherry Mui <cher...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Joel Sing (Gerrit)

    unread,
    Dec 23, 2025, 5:36:25 AM (yesterday) Dec 23
    to goph...@pubsubhelper.golang.org, Cherry Mui, Go LUCI, Gopher Robot, golang-co...@googlegroups.com

    Joel Sing voted

    Code-Review+0
    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I62c1bf09fa025b0df4c06f0bfa424fb5d328184b
    Gerrit-Change-Number: 731920
    Gerrit-PatchSet: 2
    Gerrit-Owner: Joel Sing <jo...@sing.id.au>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Comment-Date: Tue, 23 Dec 2025 10:36:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Michael Knyszek (Gerrit)

    unread,
    Dec 23, 2025, 1:44:38 PM (yesterday) Dec 23
    to Joel Sing, goph...@pubsubhelper.golang.org, Go LUCI, Cherry Mui, Gopher Robot, golang-co...@googlegroups.com
    Attention needed from Joel Sing

    Michael Knyszek voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Joel Sing
    Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I62c1bf09fa025b0df4c06f0bfa424fb5d328184b
      Gerrit-Change-Number: 731920
      Gerrit-PatchSet: 2
      Gerrit-Owner: Joel Sing <jo...@sing.id.au>
      Gerrit-Reviewer: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
      Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
      Gerrit-CC: Gopher Robot <go...@golang.org>
      Gerrit-Attention: Joel Sing <jo...@sing.id.au>
      Gerrit-Comment-Date: Tue, 23 Dec 2025 18:44:35 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Gopher Robot (Gerrit)

      unread,
      Dec 23, 2025, 1:45:50 PM (yesterday) Dec 23
      to Joel Sing, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Knyszek, Go LUCI, Cherry Mui, golang-co...@googlegroups.com

      Gopher Robot submitted the change with unreviewed changes

      Unreviewed changes

      1 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: src/cmd/asm/internal/asm/endtoend_test.go
      Insertions: 1, Deletions: 1.

      @@ -201,7 +201,7 @@
       
       	if !ok {

       		// If we've encountered errors, the output is unlikely to be sane.
      -		return
      +		t.FailNow()

       	}
       
       	for p := top; p != nil; p = p.Link {
      ```

      Change information

      Commit message:
      cmd/asm/internal/asm: abort end to end test if assembly failed

      If errors are encountered during assembly, do not attempt to perform verification.
      In this case the output is unlikely to be correct and all verification fails, which
      means the real issue gets lost in the noise.
      Change-Id: I62c1bf09fa025b0df4c06f0bfa424fb5d328184b
      Reviewed-by: Cherry Mui <cher...@google.com>
      Auto-Submit: Joel Sing <jo...@sing.id.au>
      Reviewed-by: Michael Knyszek <mkny...@google.com>
      Files:
      • M src/cmd/asm/internal/asm/endtoend_test.go
      Change size: XS
      Delta: 1 file changed, 5 insertions(+), 0 deletions(-)
      Branch: refs/heads/master
      Submit Requirements:
      • requirement satisfiedCode-Review: +2 by Cherry Mui, +0 by Joel Sing, +1 by Michael Knyszek
      • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I62c1bf09fa025b0df4c06f0bfa424fb5d328184b
      Gerrit-Change-Number: 731920
      Gerrit-PatchSet: 3
      Gerrit-Owner: Joel Sing <jo...@sing.id.au>
      Gerrit-Reviewer: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: Gopher Robot <go...@golang.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages