[go] os: rm unused code

3 views
Skip to first unread message

Kirill Kolyshkin (Gerrit)

unread,
Jul 26, 2024, 5:24:00 PM (15 hours ago) Jul 26
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Kirill Kolyshkin has uploaded the change for review

Commit message

os: rm unused code

CL 588675 removes pidfdRelease, but misses this one.
Change-Id: Id1d93d10baa5b26a42a2289e29624409c4e351f2

Change diff

diff --git a/src/os/pidfd_other.go b/src/os/pidfd_other.go
index dda4bd0..5780432 100644
--- a/src/os/pidfd_other.go
+++ b/src/os/pidfd_other.go
@@ -20,8 +20,6 @@
 	return 0, syscall.ENOSYS
 }
 
-func (p *Process) pidfdRelease() {}
-
 func (_ *Process) pidfdWait() (*ProcessState, error) {
 	panic("unreachable")
 }

Change information

Files:
  • M src/os/pidfd_other.go
Change size: XS
Delta: 1 file changed, 0 insertions(+), 2 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Id1d93d10baa5b26a42a2289e29624409c4e351f2
Gerrit-Change-Number: 601461
Gerrit-PatchSet: 1
Gerrit-Owner: Kirill Kolyshkin <koly...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Kirill Kolyshkin (Gerrit)

unread,
Jul 26, 2024, 5:24:14 PM (15 hours ago) Jul 26
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Kirill Kolyshkin voted

Commit-Queue+1
Run-TryBot+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedLegacy-TryBots-Pass
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Id1d93d10baa5b26a42a2289e29624409c4e351f2
    Gerrit-Change-Number: 601461
    Gerrit-PatchSet: 1
    Gerrit-Owner: Kirill Kolyshkin <koly...@gmail.com>
    Gerrit-Reviewer: Kirill Kolyshkin <koly...@gmail.com>
    Gerrit-Comment-Date: Fri, 26 Jul 2024 21:24:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Ian Lance Taylor (Gerrit)

    unread,
    Jul 26, 2024, 8:23:29 PM (12 hours ago) Jul 26
    to Kirill Kolyshkin, goph...@pubsubhelper.golang.org, Go LUCI, Brad Fitzpatrick, Ian Lance Taylor, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
    Attention needed from Brad Fitzpatrick, Ian Lance Taylor, Kirill Kolyshkin and Russ Cox

    Ian Lance Taylor voted and added 1 comment

    Votes added by Ian Lance Taylor

    Auto-Submit+1
    Code-Review+2
    Commit-Queue+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Ian Lance Taylor . resolved

    Thanks.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brad Fitzpatrick
    • Ian Lance Taylor
    • Kirill Kolyshkin
    • Russ Cox
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedLegacy-TryBots-Pass
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Id1d93d10baa5b26a42a2289e29624409c4e351f2
    Gerrit-Change-Number: 601461
    Gerrit-PatchSet: 1
    Gerrit-Owner: Kirill Kolyshkin <koly...@gmail.com>
    Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
    Gerrit-Reviewer: Gopher Robot <go...@golang.org>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@google.com>
    Gerrit-Reviewer: Kirill Kolyshkin <koly...@gmail.com>
    Gerrit-Reviewer: Russ Cox <r...@golang.org>
    Gerrit-Attention: Brad Fitzpatrick <brad...@golang.org>
    Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Attention: Russ Cox <r...@golang.org>
    Gerrit-Attention: Kirill Kolyshkin <koly...@gmail.com>
    Gerrit-Comment-Date: Sat, 27 Jul 2024 00:23:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dmitri Shuralyov (Gerrit)

    unread,
    Jul 26, 2024, 8:57:07 PM (12 hours ago) Jul 26
    to Kirill Kolyshkin, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Go LUCI, Brad Fitzpatrick, Ian Lance Taylor, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
    Attention needed from Brad Fitzpatrick, Ian Lance Taylor, Kirill Kolyshkin and Russ Cox

    Dmitri Shuralyov voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brad Fitzpatrick
    • Ian Lance Taylor
    • Kirill Kolyshkin
    • Russ Cox
    Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedLegacy-TryBots-Pass
      • requirement satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Id1d93d10baa5b26a42a2289e29624409c4e351f2
      Gerrit-Change-Number: 601461
      Gerrit-PatchSet: 1
      Gerrit-Owner: Kirill Kolyshkin <koly...@gmail.com>
      Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Reviewer: Gopher Robot <go...@golang.org>
      Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
      Gerrit-Reviewer: Ian Lance Taylor <ia...@google.com>
      Gerrit-Reviewer: Kirill Kolyshkin <koly...@gmail.com>
      Gerrit-Reviewer: Russ Cox <r...@golang.org>
      Gerrit-CC: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Attention: Brad Fitzpatrick <brad...@golang.org>
      Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
      Gerrit-Attention: Russ Cox <r...@golang.org>
      Gerrit-Attention: Kirill Kolyshkin <koly...@gmail.com>
      Gerrit-Comment-Date: Sat, 27 Jul 2024 00:57:01 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Gopher Robot (Gerrit)

      unread,
      Jul 26, 2024, 8:57:49 PM (12 hours ago) Jul 26
      to Kirill Kolyshkin, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Dmitri Shuralyov, Go LUCI, Brad Fitzpatrick, Ian Lance Taylor, Russ Cox, golang-co...@googlegroups.com

      Gopher Robot submitted the change

      Change information

      Commit message:
      os: rm unused code

      CL 588675 removes pidfdRelease, but misses this one.
      Change-Id: Id1d93d10baa5b26a42a2289e29624409c4e351f2
      Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
      Run-TryBot: Kirill Kolyshkin <koly...@gmail.com>
      TryBot-Result: Gopher Robot <go...@golang.org>
      Reviewed-by: Ian Lance Taylor <ia...@google.com>
      Auto-Submit: Ian Lance Taylor <ia...@google.com>
      Files:
      • M src/os/pidfd_other.go
      Change size: XS
      Delta: 1 file changed, 0 insertions(+), 2 deletions(-)
      Branch: refs/heads/master
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Dmitri Shuralyov, +2 by Ian Lance Taylor
      • requirement satisfiedLegacy-TryBots-Pass: TryBot-Result+1 by Gopher Robot, Run-TryBot+1 by Kirill Kolyshkin
      • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Id1d93d10baa5b26a42a2289e29624409c4e351f2
      Gerrit-Change-Number: 601461
      Gerrit-PatchSet: 2
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages