[go] sync/atomic: correct Uintptr.Or return doc
5 views
Skip to first unread message
Michael Pratt (Gerrit)
Sep 25, 2025, 1:12:17 PM (6 days ago) Sep 25
to goph...@pubsubhelper.golang.org, Michael Pratt, golang-co...@googlegroups.com
Michael Pratt has uploaded the change for review![]( "Open in Gerrit")
Commit message
sync/atomic: correct Uintptr.Or return doc
Uintptr.Or returns the old value, just like all of the other Or
functions. This was a typo in the original CL 544455.
Fixes #75607.
Change-Id: I260959e7e32e51f1152b5271df6cc51adfa02a4d
Change diff
diff --git a/src/sync/atomic/type.go b/src/sync/atomic/type.go
index 40a29fe..4a74150 100644
--- a/src/sync/atomic/type.go
+++ b/src/sync/atomic/type.go
@@ -232,7 +232,7 @@
func (x *Uintptr) And(mask uintptr) (old uintptr) { return AndUintptr(&x.v, mask) }
// Or atomically performs a bitwise OR operation on x using the bitmask
-// provided as mask and returns the updated value after the OR operation.
+// provided as mask and returns the old value.
func (x *Uintptr) Or(mask uintptr) (old uintptr) { return OrUintptr(&x.v, mask) }
// noCopy may be added to structs which must not be copied
Change information
Files:
- M src/sync/atomic/type.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
Sep 25, 2025, 1:12:20 PM (6 days ago) Sep 25
to Michael Pratt, goph...@pubsubhelper.golang.org, Mauri de Souza Meneguzzo, Michael Knyszek, golang-co...@googlegroups.com
Attention needed from Mauri de Souza Meneguzzo and Michael Knyszek
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Mauri de Souza Meneguzzo
- Michael Knyszek
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
Sep 25, 2025, 1:12:38 PM (6 days ago) Sep 25
to Michael Pratt, goph...@pubsubhelper.golang.org, Mauri de Souza Meneguzzo, Michael Knyszek, golang-co...@googlegroups.com
Attention needed from Mauri de Souza Meneguzzo and Michael Knyszek
Michael Pratt voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Mauri de Souza Meneguzzo
- Michael Knyszek
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Knyszek (Gerrit)
Sep 25, 2025, 1:13:01 PM (6 days ago) Sep 25
to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, Mauri de Souza Meneguzzo, golang-co...@googlegroups.com
Attention needed from Mauri de Souza Meneguzzo and Michael Pratt
Michael Knyszek voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Knyszek
| Code-Review | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Mauri de Souza Meneguzzo
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
Sep 25, 2025, 1:17:19 PM (6 days ago) Sep 25
to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, Mauri de Souza Meneguzzo, golang-co...@googlegroups.com
Attention needed from Mauri de Souza Meneguzzo
Michael Pratt voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Pratt
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Michael Knyszek . resolved
should this be backported?
Michael Pratt
Sure
Related details
Attention is currently required from:
- Mauri de Souza Meneguzzo
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mauri de Souza Meneguzzo (Gerrit)
Sep 25, 2025, 1:20:16 PM (6 days ago) Sep 25
to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Pratt
Mauri de Souza Meneguzzo voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Sep 25, 2025, 1:29:48 PM (6 days ago) Sep 25
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Mauri de Souza Meneguzzo, Michael Knyszek, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
sync/atomic: correct Uintptr.Or return doc
Uintptr.Or returns the old value, just like all of the other Or
functions. This was a typo in the original CL 544455.
Fixes #75607.
Change-Id: I260959e7e32e51f1152b5271df6cc51adfa02a4d
Reviewed-on: https://go-review.googlesource.com/c/go/+/706816
Reviewed-by: Michael Knyszek <mkny...@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <maur...@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Pratt <mpr...@google.com>
Files:
- M src/sync/atomic/type.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Michael Knyszek, +1 by Mauri de Souza Meneguzzo
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
Sep 25, 2025, 1:31:29 PM (6 days ago) Sep 25
to goph...@pubsubhelper.golang.org, Michael Pratt, golang-co...@googlegroups.com
Michael Pratt has uploaded the change for review![]( "Open in Gerrit")
Commit message
[release-branch.go1.24] sync/atomic: correct Uintptr.Or return doc
Uintptr.Or returns the old value, just like all of the other Or
functions. This was a typo in the original CL 544455.
For #75607.
Fixes #75609.
Change-Id: I260959e7e32e51f1152b5271df6cc51adfa02a4d
Reviewed-on: https://go-review.googlesource.com/c/go/+/706816
Reviewed-by: Michael Knyszek <mkny...@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <maur...@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Pratt <mpr...@google.com>
(cherry picked from commit d70ad4e740e24b4b76961c4b56d698fa23668aa2)
Change diff
diff --git a/src/sync/atomic/type.go b/src/sync/atomic/type.go
index f487cb9..56da592 100644
--- a/src/sync/atomic/type.go
+++ b/src/sync/atomic/type.go
@@ -218,7 +218,7 @@
func (x *Uintptr) And(mask uintptr) (old uintptr) { return AndUintptr(&x.v, mask) }
// Or atomically performs a bitwise OR operation on x using the bitmask
-// provided as mask and returns the updated value after the OR operation.
+// provided as mask and returns the old value.
func (x *Uintptr) Or(mask uintptr) (old uintptr) { return OrUintptr(&x.v, mask) }
// noCopy may be added to structs which must not be copied
Change information
Files:
- M src/sync/atomic/type.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
Sep 25, 2025, 1:31:40 PM (6 days ago) Sep 25
to Michael Pratt, goph...@pubsubhelper.golang.org, Michael Knyszek, golang-co...@googlegroups.com
Attention needed from Michael Knyszek
Michael Pratt voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Michael Knyszek
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
Sep 25, 2025, 1:32:05 PM (6 days ago) Sep 25
to goph...@pubsubhelper.golang.org, Michael Pratt, golang-co...@googlegroups.com
Michael Pratt has uploaded the change for review![]( "Open in Gerrit")
Commit message
[release-branch.go1.25] sync/atomic: correct Uintptr.Or return doc
Uintptr.Or returns the old value, just like all of the other Or
functions. This was a typo in the original CL 544455.
For #75607.
Fixes #75610.
Change-Id: I260959e7e32e51f1152b5271df6cc51adfa02a4d
Reviewed-on: https://go-review.googlesource.com/c/go/+/706816
Reviewed-by: Michael Knyszek <mkny...@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <maur...@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Pratt <mpr...@google.com>
(cherry picked from commit d70ad4e740e24b4b76961c4b56d698fa23668aa2)
Change diff
diff --git a/src/sync/atomic/type.go b/src/sync/atomic/type.go
index 40a29fe..4a74150 100644
--- a/src/sync/atomic/type.go
+++ b/src/sync/atomic/type.go
@@ -232,7 +232,7 @@
func (x *Uintptr) And(mask uintptr) (old uintptr) { return AndUintptr(&x.v, mask) }
// Or atomically performs a bitwise OR operation on x using the bitmask
-// provided as mask and returns the updated value after the OR operation.
+// provided as mask and returns the old value.
func (x *Uintptr) Or(mask uintptr) (old uintptr) { return OrUintptr(&x.v, mask) }
// noCopy may be added to structs which must not be copied
Change information
Files:
- M src/sync/atomic/type.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
Sep 25, 2025, 1:32:18 PM (6 days ago) Sep 25
to Michael Pratt, goph...@pubsubhelper.golang.org, Michael Knyszek, golang-co...@googlegroups.com
Attention needed from Michael Knyszek
Michael Pratt voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Michael Knyszek
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Knyszek (Gerrit)
Sep 25, 2025, 1:47:59 PM (6 days ago) Sep 25
to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Pratt
Michael Knyszek voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Knyszek (Gerrit)
Sep 25, 2025, 1:48:05 PM (6 days ago) Sep 25
to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Pratt
Michael Knyszek voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
11:37 AM (11 hours ago) 11:37 AM
to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Pratt
Carlos Amedee voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
12:40 PM (10 hours ago) 12:40 PM
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Knyszek, Go LUCI, golang-co...@googlegroups.com
Carlos Amedee submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[release-branch.go1.24] sync/atomic: correct Uintptr.Or return doc
Uintptr.Or returns the old value, just like all of the other Or
functions. This was a typo in the original CL 544455.
For #75607.
Fixes #75609.
Change-Id: I260959e7e32e51f1152b5271df6cc51adfa02a4d
Reviewed-on: https://go-review.googlesource.com/c/go/+/706816
Reviewed-by: Michael Knyszek <mkny...@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <maur...@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Pratt <mpr...@google.com>
(cherry picked from commit d70ad4e740e24b4b76961c4b56d698fa23668aa2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/706855
Reviewed-by: Carlos Amedee <car...@golang.org>
Files:
- M src/sync/atomic/type.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/release-branch.go1.24
Submit Requirements:
Code-Review: +2 by Michael Knyszek, +1 by Carlos Amedee
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
12:40 PM (10 hours ago) 12:40 PM
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Michael Knyszek, golang-co...@googlegroups.com
Carlos Amedee submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[release-branch.go1.25] sync/atomic: correct Uintptr.Or return doc
Uintptr.Or returns the old value, just like all of the other Or
functions. This was a typo in the original CL 544455.
For #75607.
Fixes #75610.
Change-Id: I260959e7e32e51f1152b5271df6cc51adfa02a4d
Reviewed-on: https://go-review.googlesource.com/c/go/+/706816
Reviewed-by: Michael Knyszek <mkny...@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <maur...@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Pratt <mpr...@google.com>
(cherry picked from commit d70ad4e740e24b4b76961c4b56d698fa23668aa2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/706856
Files:
- M src/sync/atomic/type.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/release-branch.go1.25
Submit Requirements:
Code-Review: +2 by Michael Knyszek
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages