[website] solutions: update urfave/cli link to v3 GitHub URL
Gerrit Bot (Gerrit)
Gerrit Bot has uploaded the change for review![]( "Open in Gerrit")
Commit message
solutions: update urfave/cli link to v3 GitHub URL
Fixes golang/website#344
The pkg.go.dev URL redirects to v1.22.17 but the latest stable
version is v3.6.2. Update to the canonical GitHub URL which
automatically shows the latest version on pkg.go.dev.
Change diff
diff --git a/_content/solutions/clis.md b/_content/solutions/clis.md
index 9fe98da..676f18b 100644
--- a/_content/solutions/clis.md
+++ b/_content/solutions/clis.md
@@ -157,7 +157,7 @@
url: https://pkg.go.dev/github.com/spf13/viper?tab=overview
desc: A complete configuration solution for Go applications, designed to work within an app to handle configuration needs and formats
- text: urfave/cli
- url: https://pkg.go.dev/github.com/urfave/cli?tab=overview
+ url: https://github.com/urfave/cli
desc: A minimal framework for creating and organizing command line Go applications
- text: delve
url: https://pkg.go.dev/github.com/go-delve/delve?tab=overview
diff --git a/_content/solutions/devops.md b/_content/solutions/devops.md
index ebd57c2..621bb88 100644
--- a/_content/solutions/devops.md
+++ b/_content/solutions/devops.md
@@ -168,7 +168,7 @@
url: https://pkg.go.dev/github.com/spf13/viper?tab=overview
desc: A complete configuration solution for Go applications, designed to work within an app to handle configuration needs and formats
- text: urfave/cli
- url: https://pkg.go.dev/github.com/urfave/cli?tab=overview
+ url: https://github.com/urfave/cli
desc: A minimal framework for creating and organizing command line Go applications
- title: Other projects
items:
Change information
- M _content/solutions/clis.md
- M _content/solutions/devops.md
Related details
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Gopher Robot added 1 comment![]( "Open in Gerrit")
I spotted some possible problems with your PR:
1. You usually need to reference a bug number for all but trivial or cosmetic fixes. For the website repo, the format is usually 'Fixes golang/go#12345' or 'Updates golang/go#12345' at the end of the commit message. Should you have a bug reference?
Please address any problems by updating the GitHub PR.
When complete, mark this comment as 'Done' and click the [blue 'Reply' button](https://go.dev/wiki/GerritBot#i-left-a-reply-to-a-comment-in-gerrit-but-no-one-but-me-can-see-it) above. These findings are based on heuristics; if a finding does not apply, briefly reply here saying so.
To update the commit title or commit message body shown here in Gerrit, you must edit the GitHub PR title and PR description (the first comment) in the GitHub web interface using the 'Edit' button or 'Edit' menu entry there. Note: pushing a new commit to the PR will not automatically update the commit message used by Gerrit.
For more details, see:
- [how to update commit messages](https://go.dev/wiki/GerritBot/#how-does-gerritbot-determine-the-final-commit-message) for PRs imported into Gerrit.
- the Go project's [conventions for commit messages](https://go.dev/doc/contribute#commit_messages) that you should follow.
(In general for Gerrit code reviews, the change author is expected to [log in to Gerrit](https://go-review.googlesource.com/login/) with a Gmail or other Google account and then close out each piece of feedback by marking it as 'Done' if implemented as suggested or otherwise reply to each review comment. See the [Review](https://go.dev/doc/contribute#review) section of the Contributing Guide for details.)
Related details
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
Dmitri Shuralyov added 6 comments![]( "Open in Gerrit")
I spotted some possible problems with your PR:
1. You usually need to reference a bug number for all but trivial or cosmetic fixes. For the website repo, the format is usually 'Fixes golang/go#12345' or 'Updates golang/go#12345' at the end of the commit message. Should you have a bug reference?Please address any problems by updating the GitHub PR.
When complete, mark this comment as 'Done' and click the [blue 'Reply' button](https://go.dev/wiki/GerritBot#i-left-a-reply-to-a-comment-in-gerrit-but-no-one-but-me-can-see-it) above. These findings are based on heuristics; if a finding does not apply, briefly reply here saying so.
To update the commit title or commit message body shown here in Gerrit, you must edit the GitHub PR title and PR description (the first comment) in the GitHub web interface using the 'Edit' button or 'Edit' menu entry there. Note: pushing a new commit to the PR will not automatically update the commit message used by Gerrit.
For more details, see:
- [how to update commit messages](https://go.dev/wiki/GerritBot/#how-does-gerritbot-determine-the-final-commit-message) for PRs imported into Gerrit.
- the Go project's [conventions for commit messages](https://go.dev/doc/contribute#commit_messages) that you should follow.
(In general for Gerrit code reviews, the change author is expected to [log in to Gerrit](https://go-review.googlesource.com/login/) with a Gmail or other Google account and then close out each piece of feedback by marking it as 'Done' if implemented as suggested or otherwise reply to each review comment. See the [Review](https://go.dev/doc/contribute#review) section of the Contributing Guide for details.)
Moved the 'Fixes' line to the bottom of the commit message. Done.
Thanks for updating this entry. See inline comments for a few suggestions.
- text: urfave/cliMaybe it's worth it to include "v3" here too, since this is a different major version of this package. I'm fine with leaving it out if you don't think this is an improvement. Up to you.
```suggestion
- text: urfave/cli/v3
```
url: https://github.com/urfave/cliAll of the links here point to package documentation on pkg.go.dev. I think we shouldn't try to change that, rather update the module path to the v3 one. No need tor '?tab=overview' suffix since it's the default by now.
```suggestion
url: https://pkg.go.dev/github.com/urfave/cli/v3
```
desc: A minimal framework for creating and organizing command line Go applicationsThe package description has changed, consider updating this to its latest text:
```suggestion
desc: A declarative, simple, fast, and fun package for building command line tools in Go
```
- text: urfave/cli
url: https://github.com/urfave/cli
desc: A minimal framework for creating and organizing command line Go applicationsSame suggestion here:
```suggestion
- text: urfave/cli/v3
url: https://pkg.go.dev/github.com/urfave/cli/v3
desc: A declarative, simple, fast, and fun package for building command line tools in Go
```
Related details
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gerrit Bot (Gerrit)
Gerrit Bot uploaded new patchset![]( "Open in Gerrit")
Related details
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |