[go/release-branch.go1.25] [release-branch.go1.25] internal/poll: don't call Seek for overlapped Windows handles

4 views

Skip to first unread message

Michael Knyszek (Gerrit)

unread,

Sep 16, 2025, 12:26:04 PMSep 16

to Quim Muntal, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Michael Knyszek voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Damien Neil (Gerrit)

unread,

Sep 22, 2025, 12:35:56 PM (9 days ago) Sep 22

to Quim Muntal, Michael Knyszek, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com

Attention needed from Michael Knyszek and Quim Muntal

Damien Neil voted Code-Review+2

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Michael Knyszek
Quim Muntal

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Carlos Amedee (Gerrit)

unread,

11:06 AM (7 hours ago) 11:06 AM

to Quim Muntal, Michael Knyszek, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Damien Neil, Go LUCI, golang-co...@googlegroups.com

Carlos Amedee submitted the change

Change information

Commit message:

[release-branch.go1.25] internal/poll: don't call Seek for overlapped Windows handles

Overlapped handles don't have the file pointer updated when performing
I/O operations, so there is no need to call FD.Seek to reset the file
pointer.

Also, some overlapped file handles don't support seeking. See #74951.

For #74951.
Fixes #75111.

Change-Id: I0edd53beed7d3862730f3b2ed5fe9ba490e66c06
Reviewed-on: https://go-review.googlesource.com/c/go/+/697295
Reviewed-by: Damien Neil <dn...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
(cherry picked from commit 509d5f647ffc413bd874c2e2bf6d1b33f9bc0ac2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/704315

Files:

M src/internal/poll/fd_windows.go
M src/os/os_windows_test.go

Change size: M

Delta: 2 files changed, 58 insertions(+), 10 deletions(-)

Branch: refs/heads/release-branch.go1.25

Submit Requirements:

Code-Review: +2 by Damien Neil
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages