[pkgsite] cmd/internal/doc: increase x/pkgsite dependency to CL 729900
6 views
Skip to first unread message
Michael Matloob (Gerrit)
Dec 23, 2025, 11:09:44 AM (2 days ago) Dec 23
to goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Go LUCI, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Dmitri Shuralyov
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Dec 23, 2025, 11:11:37 AM (2 days ago) Dec 23
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #4 to this change.
Related details
Attention is currently required from:
- Dmitri Shuralyov
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Dec 23, 2025, 11:12:11 AM (2 days ago) Dec 23
to Michael Matloob, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Go LUCI, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov and Michael Matloob
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dmitri Shuralyov
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
Dec 23, 2025, 11:25:55 AM (2 days ago) Dec 23
to Michael Matloob, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, kokoro, Michael Matloob, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Dmitri Shuralyov voted and added 3 comments![]( "Open in Gerrit")
Votes added by Dmitri Shuralyov
| Code-Review | +2 |
3 comments
Patchset-level comments
Commit Message
Line 18, Patchset 4 (Latest):
go get golang.org/x/pkgsite@4eb0af2Dmitri Shuralyov . resolved
By now there are newer commits, but I understand they don't have similar notable changes and that's why they're not being included here.
Line 19, Patchset 4 (Latest):
go mod tidyDmitri Shuralyov . resolved
(nit) Inconsistent leading space here (2 tabs vs 4 spaces).
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
Dec 23, 2025, 11:26:29 AM (2 days ago) Dec 23
to Michael Matloob, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, kokoro, Michael Matloob, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Dmitri Shuralyov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Dec 23, 2025, 11:27:52 AM (2 days ago) Dec 23
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #5 to this change.
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Dec 23, 2025, 11:28:21 AM (2 days ago) Dec 23
to goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Dmitri Shuralyov, kokoro, Michael Matloob, Go LUCI, golang-co...@googlegroups.com
Michael Matloob voted Auto-Submit+1![]( "Open in Gerrit")
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Dec 23, 2025, 11:28:34 AM (2 days ago) Dec 23
to Michael Matloob, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Dmitri Shuralyov, kokoro, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Michael Matloob voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michael Matloob
| Code-Review | +1 |
Dmitri Shuralyov . resolved
By now there are newer commits, but I understand they don't have similar notable changes and that's why they're not being included here.
Michael Matloob
yeah i figured we should include the minimum we need
Line 19, Patchset 4:
go mod tidyDmitri Shuralyov . resolved
(nit) Inconsistent leading space here (2 tabs vs 4 spaces).
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kokoro (Gerrit)
Dec 23, 2025, 11:33:09 AM (2 days ago) Dec 23
to Michael Matloob, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Dmitri Shuralyov, Michael Matloob, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Matloob
kokoro voted kokoro-CI-1![]( "Open in Gerrit")
Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/b2ff6fa8-fd43-4c33-985b-f323fc72b1ac
| kokoro-CI | -1 |
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kokoro (Gerrit)
Dec 23, 2025, 11:48:16 AM (2 days ago) Dec 23
to Michael Matloob, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Dmitri Shuralyov, Michael Matloob, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Matloob
kokoro voted kokoro-CI-1![]( "Open in Gerrit")
Kokoro presubmit build finished with status: FAILURE
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Liao (Gerrit)
Dec 23, 2025, 12:19:20 PM (2 days ago) Dec 23
to Michael Matloob, goph...@pubsubhelper.golang.org, kokoro, Dmitri Shuralyov, Dmitri Shuralyov, Michael Matloob, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Sean Liao voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Dec 23, 2025, 2:58:04 PM (2 days ago) Dec 23
to Michael Matloob, goph...@pubsubhelper.golang.org, kokoro, Dmitri Shuralyov, Dmitri Shuralyov, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Michael Matloob voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Matloob
| TryBot-Bypass | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Michael Matloob . resolved
Passed regular trybots. Kokoro build is very flaky.
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Dec 23, 2025, 2:58:10 PM (2 days ago) Dec 23
to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Matloob, kokoro, Dmitri Shuralyov, Dmitri Shuralyov, Go LUCI, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
cmd/internal/doc: increase x/pkgsite dependency to CL 729900
So that go/doc could show docs for the new experiments.
I updated the go command to use the latest commit of the doc module but
id didn't yet have a dependency on a version of pkgsite that included
Sean's changes. This CL adds that dependency, and then we'll have to
re-update 'go doc' to depend on a version of this module that includes
this CL.
Commands run from cmd/internal/doc:
go get golang.org/x/pkgsite@4eb0af2
go mod tidy
For golang/go#71488
Change-Id: I228ba4477876a26bca8c91b44c254ce16a6a6964
Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>
Auto-Submit: Michael Matloob <mat...@golang.org>
Reviewed-by: Sean Liao <se...@liao.dev>
Reviewed-by: Michael Matloob <mat...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
TryBot-Bypass: Michael Matloob <mat...@google.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Files:
- M cmd/internal/doc/go.mod
- M cmd/internal/doc/go.sum
Change size: XS
Delta: 2 files changed, 3 insertions(+), 3 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Michael Matloob, +1 by Dmitri Shuralyov, +2 by Dmitri Shuralyov, +1 by Sean Liao
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI, TryBot-Bypass+1 by Michael Matloob
kokoro-CI-Passes: kokoro-CI-1 by kokoro, TryBot-Bypass+1 by Michael Matloob
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages