[go] cmd/compile/internal/escape: avoid interface method call receivers always escaping
3 views
Skip to first unread message
t hepudds (Gerrit)
May 17, 2026, 11:57:32 PM (2 days ago) May 17
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
t hepudds uploaded new patchset![]( "Open in Gerrit")
t hepudds uploaded patch set #12 to this change.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
t hepudds (Gerrit)
May 17, 2026, 11:59:21 PM (2 days ago) May 17
to goph...@pubsubhelper.golang.org, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Keith Randall
t hepudds added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 12 (Latest):
t hepudds . resolved
Hi @k...@golang.org, PTAL. This is ready for review. (This is the main interface receiver CL, which teaches the compiler to avoid always escaping the value in an interface conversion that is later used as the receiver in a interface method call.)
Related details
Attention is currently required from:
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
May 18, 2026, 8:02:15 PM (12 hours ago) May 18
to t hepudds, goph...@pubsubhelper.golang.org, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from t hepudds
Keith Randall added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Keith Randall . resolved
Looks pretty good. I'm excited to see what allocations this could remove.
File src/cmd/compile/internal/escape/call.go
Line 479, Patchset 12 (Latest):
continueKeith Randall . unresolved
we could probably break at this point.
(or maybe we can only do that if also derefs==0?)
Line 511, Patchset 12 (Latest):
esc.Optimize()Keith Randall . unresolved
I don't see any mention of the Mutator or Callee parts of the leaks descriptor. How do those get updated? With `f` as in the CL description
```
type T struct {
x int
}
func (t *T) String() string {
t.x++
return "foo"
}
t := T{x:7}
f(&t)
```
We need to have `t` flow to the mutate hole, I think, because we mutate it.
But maybe mutates only matters for byte slices?
Similarly for Calls, I can't think of an obvious case where this matters, but maybe it would be safer to flow to the callee hole just in case.
Related details
Attention is currently required from:
- t hepudds
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
t hepudds (Gerrit)
12:48 AM (7 hours ago) 12:48 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from t hepudds
t hepudds uploaded new patchset![]( "Open in Gerrit")
t hepudds uploaded patch set #13 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- t hepudds
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
t hepudds (Gerrit)
12:49 AM (7 hours ago) 12:49 AM
to goph...@pubsubhelper.golang.org, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
t hepudds voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages