[go] runtime,runtime/cgo: port ios/arm64 workind dir setup from C to Go

7 views
Skip to first unread message

Quim Muntal (Gerrit)

unread,
Apr 21, 2026, 9:24:38 AMApr 21
to goph...@pubsubhelper.golang.org, Michael Pratt, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Michael Pratt

Quim Muntal voted and added 1 comment

Votes added by Quim Muntal

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Quim Muntal . resolved

The iOS builder is down, but I've tested these changes locally.

Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
  • Michael Pratt
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ica72c98c05262ee692f6fca0762136abaefbca34
Gerrit-Change-Number: 769360
Gerrit-PatchSet: 1
Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Cherry Mui <cher...@google.com>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 13:24:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Quim Muntal (Gerrit)

unread,
Apr 21, 2026, 9:29:50 AMApr 21
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Michael Pratt and Quim Muntal

Quim Muntal uploaded new patchset

Quim Muntal uploaded patch set #2 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
  • Michael Pratt
  • Quim Muntal
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ica72c98c05262ee692f6fca0762136abaefbca34
Gerrit-Change-Number: 769360
Gerrit-PatchSet: 2
Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Quim Muntal (Gerrit)

unread,
Apr 21, 2026, 9:29:58 AMApr 21
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Pratt, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Michael Pratt

Quim Muntal voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
  • Michael Pratt
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ica72c98c05262ee692f6fca0762136abaefbca34
Gerrit-Change-Number: 769360
Gerrit-PatchSet: 2
Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Cherry Mui <cher...@google.com>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 13:29:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Cherry Mui (Gerrit)

unread,
Apr 21, 2026, 10:14:27 AMApr 21
to Quim Muntal, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Pratt, golang-co...@googlegroups.com
Attention needed from Michael Pratt and Quim Muntal

Cherry Mui added 1 comment

File src/runtime/sys_darwin.go
Line 705, Patchset 2 (Latest)://go:cgo_import_dynamic libc_CFBundleGetMainBundle CFBundleGetMainBundle "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
//go:cgo_import_dynamic libc_CFBundleCopyBundleURL CFBundleCopyBundleURL "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
//go:cgo_import_dynamic libc_CFURLGetFileSystemRepresentation CFURLGetFileSystemRepresentation "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
//go:cgo_import_dynamic libc_CFStringCreateWithCString CFStringCreateWithCString "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
//go:cgo_import_dynamic libc_CFBundleGetValueForInfoDictionaryKey CFBundleGetValueForInfoDictionaryKey "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
//go:cgo_import_dynamic libc_CFStringGetCString CFStringGetCString "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
//go:cgo_import_dynamic libc_CFRelease CFRelease "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
Cherry Mui . unresolved

Do they cause it to unconditionally link with CoreFoundation even on macOS? Currently it doesn't need to. Maybe put these to an iOS-specific file.

Also the cgo_ldflag.

This also makes it clearer that these are only used on iOS.

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Pratt
  • Quim Muntal
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ica72c98c05262ee692f6fca0762136abaefbca34
    Gerrit-Change-Number: 769360
    Gerrit-PatchSet: 2
    Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Michael Pratt <mpr...@google.com>
    Gerrit-Comment-Date: Tue, 21 Apr 2026 14:14:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Quim Muntal (Gerrit)

    unread,
    Apr 21, 2026, 10:31:35 AMApr 21
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Michael Pratt and Quim Muntal

    Quim Muntal uploaded new patchset

    Quim Muntal uploaded patch set #3 to this change.
    Following approvals got outdated and were removed:
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Pratt
    • Quim Muntal
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Ica72c98c05262ee692f6fca0762136abaefbca34
      Gerrit-Change-Number: 769360
      Gerrit-PatchSet: 3
      unsatisfied_requirement
      open
      diffy

      Quim Muntal (Gerrit)

      unread,
      Apr 21, 2026, 10:34:54 AMApr 21
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from Michael Pratt and Quim Muntal

      Quim Muntal uploaded new patchset

      Quim Muntal uploaded patch set #4 to this change.
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Michael Pratt
      • Quim Muntal
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Ica72c98c05262ee692f6fca0762136abaefbca34
      Gerrit-Change-Number: 769360
      Gerrit-PatchSet: 4
      unsatisfied_requirement
      open
      diffy

      Quim Muntal (Gerrit)

      unread,
      Apr 21, 2026, 10:37:29 AMApr 21
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from Michael Pratt and Quim Muntal

      Quim Muntal uploaded new patchset

      Quim Muntal uploaded patch set #5 to this change.
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Michael Pratt
      • Quim Muntal
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Ica72c98c05262ee692f6fca0762136abaefbca34
      Gerrit-Change-Number: 769360
      Gerrit-PatchSet: 5
      unsatisfied_requirement
      open
      diffy

      Quim Muntal (Gerrit)

      unread,
      Apr 21, 2026, 10:38:47 AMApr 21
      to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Pratt, Cherry Mui, golang-co...@googlegroups.com
      Attention needed from Cherry Mui and Michael Pratt

      Quim Muntal voted and added 1 comment

      Votes added by Quim Muntal

      Commit-Queue+1

      1 comment

      File src/runtime/sys_darwin.go
      Line 705, Patchset 2://go:cgo_import_dynamic libc_CFBundleGetMainBundle CFBundleGetMainBundle "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"

      //go:cgo_import_dynamic libc_CFBundleCopyBundleURL CFBundleCopyBundleURL "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
      //go:cgo_import_dynamic libc_CFURLGetFileSystemRepresentation CFURLGetFileSystemRepresentation "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
      //go:cgo_import_dynamic libc_CFStringCreateWithCString CFStringCreateWithCString "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
      //go:cgo_import_dynamic libc_CFBundleGetValueForInfoDictionaryKey CFBundleGetValueForInfoDictionaryKey "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
      //go:cgo_import_dynamic libc_CFStringGetCString CFStringGetCString "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
      //go:cgo_import_dynamic libc_CFRelease CFRelease "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
      Cherry Mui . unresolved

      Do they cause it to unconditionally link with CoreFoundation even on macOS? Currently it doesn't need to. Maybe put these to an iOS-specific file.

      Also the cgo_ldflag.

      This also makes it clearer that these are only used on iOS.

      Quim Muntal

      Good shot. This also means there is no need to implement the go/assembly wrappers for the new libc calls on amd64.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Cherry Mui
      • Michael Pratt
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Ica72c98c05262ee692f6fca0762136abaefbca34
      Gerrit-Change-Number: 769360
      Gerrit-PatchSet: 5
      Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
      Gerrit-Reviewer: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
      Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
      Gerrit-Attention: Cherry Mui <cher...@google.com>
      Gerrit-Attention: Michael Pratt <mpr...@google.com>
      Gerrit-Comment-Date: Tue, 21 Apr 2026 14:38:39 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Cherry Mui <cher...@google.com>
      unsatisfied_requirement
      open
      diffy

      Quim Muntal (Gerrit)

      unread,
      Apr 21, 2026, 10:39:04 AMApr 21
      to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Pratt, Cherry Mui, golang-co...@googlegroups.com
      Attention needed from Cherry Mui and Michael Pratt

      Quim Muntal added 1 comment

      File src/runtime/sys_darwin.go
      Line 705, Patchset 2://go:cgo_import_dynamic libc_CFBundleGetMainBundle CFBundleGetMainBundle "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
      //go:cgo_import_dynamic libc_CFBundleCopyBundleURL CFBundleCopyBundleURL "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
      //go:cgo_import_dynamic libc_CFURLGetFileSystemRepresentation CFURLGetFileSystemRepresentation "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
      //go:cgo_import_dynamic libc_CFStringCreateWithCString CFStringCreateWithCString "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
      //go:cgo_import_dynamic libc_CFBundleGetValueForInfoDictionaryKey CFBundleGetValueForInfoDictionaryKey "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
      //go:cgo_import_dynamic libc_CFStringGetCString CFStringGetCString "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
      //go:cgo_import_dynamic libc_CFRelease CFRelease "/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation"
      Cherry Mui . resolved

      Do they cause it to unconditionally link with CoreFoundation even on macOS? Currently it doesn't need to. Maybe put these to an iOS-specific file.

      Also the cgo_ldflag.

      This also makes it clearer that these are only used on iOS.

      Quim Muntal

      Good shot. This also means there is no need to implement the go/assembly wrappers for the new libc calls on amd64.

      Quim Muntal

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Cherry Mui
      • Michael Pratt
      Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: Ica72c98c05262ee692f6fca0762136abaefbca34
        Gerrit-Change-Number: 769360
        Gerrit-PatchSet: 5
        Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
        Gerrit-Reviewer: Cherry Mui <cher...@google.com>
        Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
        Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
        Gerrit-Attention: Cherry Mui <cher...@google.com>
        Gerrit-Attention: Michael Pratt <mpr...@google.com>
        Gerrit-Comment-Date: Tue, 21 Apr 2026 14:38:49 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Quim Muntal <quimm...@gmail.com>
        Comment-In-Reply-To: Cherry Mui <cher...@google.com>
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Quim Muntal (Gerrit)

        unread,
        Apr 27, 2026, 3:40:34 AMApr 27
        to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Pratt, Cherry Mui, golang-co...@googlegroups.com
        Attention needed from Cherry Mui and Michael Pratt

        Quim Muntal added 1 comment

        Patchset-level comments
        File-level comment, Patchset 5 (Latest):
        Quim Muntal . resolved

        Friendly ping

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Cherry Mui
        • Michael Pratt
        Submit Requirements:
          • requirement is not satisfiedCode-Review
          • requirement satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: Ica72c98c05262ee692f6fca0762136abaefbca34
          Gerrit-Change-Number: 769360
          Gerrit-PatchSet: 5
          Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
          Gerrit-Reviewer: Cherry Mui <cher...@google.com>
          Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
          Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
          Gerrit-Attention: Cherry Mui <cher...@google.com>
          Gerrit-Attention: Michael Pratt <mpr...@google.com>
          Gerrit-Comment-Date: Mon, 27 Apr 2026 07:40:27 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          unsatisfied_requirement
          satisfied_requirement
          open
          diffy

          Quim Muntal (Gerrit)

          unread,
          May 5, 2026, 10:36:07 AM (14 days ago) May 5
          to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Pratt, Cherry Mui, golang-co...@googlegroups.com
          Attention needed from Cherry Mui and Michael Pratt

          Quim Muntal added 1 comment

          Patchset-level comments
          Quim Muntal . resolved

          Code-freeze is coming, friendly ping 😊

          Gerrit-Comment-Date: Tue, 05 May 2026 14:35:56 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          unsatisfied_requirement
          satisfied_requirement
          open
          diffy

          Quim Muntal (Gerrit)

          unread,
          May 18, 2026, 5:43:24 AM (yesterday) May 18
          to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Pratt, Cherry Mui, golang-co...@googlegroups.com
          Attention needed from Cherry Mui and Michael Pratt

          Quim Muntal added 1 comment

          Patchset-level comments
          File-level comment, Patchset 6 (Latest):
          Quim Muntal . resolved

          Any chance this is reviewed before freeze? Thanks!

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Cherry Mui
          • Michael Pratt
          Submit Requirements:
            • requirement is not satisfiedCode-Review
            • requirement satisfiedNo-Unresolved-Comments
            • requirement is not satisfiedReview-Enforcement
            • requirement is not satisfiedTryBots-Pass
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: go
            Gerrit-Branch: master
            Gerrit-Change-Id: Ica72c98c05262ee692f6fca0762136abaefbca34
            Gerrit-Change-Number: 769360
            Gerrit-PatchSet: 6
            Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
            Gerrit-Reviewer: Cherry Mui <cher...@google.com>
            Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
            Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
            Gerrit-Attention: Cherry Mui <cher...@google.com>
            Gerrit-Attention: Michael Pratt <mpr...@google.com>
            Gerrit-Comment-Date: Mon, 18 May 2026 09:43:17 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            unsatisfied_requirement
            satisfied_requirement
            open
            diffy

            Cherry Mui (Gerrit)

            unread,
            May 18, 2026, 1:29:13 PM (19 hours ago) May 18
            to Quim Muntal, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Pratt, golang-co...@googlegroups.com
            Attention needed from Michael Pratt and Quim Muntal

            Cherry Mui voted and added 7 comments

            Votes added by Cherry Mui

            Code-Review+1
            Commit-Queue+1

            7 comments

            Patchset-level comments
            Cherry Mui . unresolved

            Looks good overall. Just wonder if/how you have tested this on iOS. The Go iOS builders have been down for a long time (sorry).

            Thanks.

            File src/runtime/os_workdir_ios_arm64.go
            Line 5, Patchset 6 (Latest)://go:build ios && arm64
            Cherry Mui . unresolved

            This is unnecessary as it is implied by the file name.

            Also other files.

            File src/runtime/os_workdir_stub.go
            Line 5, Patchset 6 (Latest)://go:build (darwin || ios) && !(ios && arm64)
            Cherry Mui . unresolved

            `darwin` includes ios, so this is redundant. I think you can just write `darwin`.

            File src/runtime/sys_ios_arm64.go
            Line 20, Patchset 6 (Latest)://go:cgo_unsafe_args
            Cherry Mui . unresolved

            This is probably unnecessary as there is only one argument.

            Line 47, Patchset 6 (Latest)://go:cgo_unsafe_args
            Cherry Mui . unresolved

            Since we copy args below to a struct, there is no need to mark this with cgo_unsafe_args.

            Line 69, Patchset 6 (Latest)://go:cgo_unsafe_args
            Cherry Mui . unresolved

            Also here.

            Line 103, Patchset 6 (Latest)://go:cgo_unsafe_args
            Cherry Mui . unresolved

            Also here.

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Michael Pratt
            • Quim Muntal
            Submit Requirements:
              • requirement is not satisfiedCode-Review
              • requirement is not satisfiedNo-Unresolved-Comments
              • requirement is not satisfiedReview-Enforcement
              • requirement is not satisfiedTryBots-Pass
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: go
              Gerrit-Branch: master
              Gerrit-Change-Id: Ica72c98c05262ee692f6fca0762136abaefbca34
              Gerrit-Change-Number: 769360
              Gerrit-PatchSet: 6
              Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
              Gerrit-Reviewer: Cherry Mui <cher...@google.com>
              Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
              Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
              Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
              Gerrit-Attention: Michael Pratt <mpr...@google.com>
              Gerrit-Comment-Date: Mon, 18 May 2026 17:29:09 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: Yes
              unsatisfied_requirement
              open
              diffy

              Quim Muntal (Gerrit)

              unread,
              3:22 AM (5 hours ago) 3:22 AM
              to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
              Attention needed from Michael Pratt and Quim Muntal

              Quim Muntal uploaded new patchset

              Quim Muntal uploaded patch set #7 to this change.
              Following approvals got outdated and were removed:
              Open in Gerrit

              Related details

              Attention is currently required from:
              • Michael Pratt
              • Quim Muntal
              Submit Requirements:
              • requirement is not satisfiedCode-Review
              • requirement is not satisfiedNo-Unresolved-Comments
              • requirement is not satisfiedReview-Enforcement
              • requirement is not satisfiedTryBots-Pass
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: newpatchset
              Gerrit-Project: go
              Gerrit-Branch: master
              Gerrit-Change-Id: Ica72c98c05262ee692f6fca0762136abaefbca34
              Gerrit-Change-Number: 769360
              Gerrit-PatchSet: 7
              unsatisfied_requirement
              open
              diffy

              Quim Muntal (Gerrit)

              unread,
              3:23 AM (5 hours ago) 3:23 AM
              to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, Michael Pratt, golang-co...@googlegroups.com
              Attention needed from Cherry Mui and Michael Pratt

              Quim Muntal voted and added 7 comments

              Votes added by Quim Muntal

              Commit-Queue+1

              7 comments

              Patchset-level comments
              File-level comment, Patchset 6:
              Cherry Mui . resolved

              Looks good overall. Just wonder if/how you have tested this on iOS. The Go iOS builders have been down for a long time (sorry).

              Thanks.

              Quim Muntal

              The missing ios builder is unfortunate, yes. I have tested these changes locally, so I'm confident they are sane.

              File src/runtime/os_workdir_ios_arm64.go
              Line 5, Patchset 6://go:build ios && arm64
              Cherry Mui . resolved

              This is unnecessary as it is implied by the file name.

              Also other files.

              Quim Muntal

              Done

              File src/runtime/os_workdir_stub.go
              Line 5, Patchset 6://go:build (darwin || ios) && !(ios && arm64)
              Cherry Mui . resolved

              `darwin` includes ios, so this is redundant. I think you can just write `darwin`.

              Quim Muntal

              Done

              File src/runtime/sys_ios_arm64.go
              Line 20, Patchset 6://go:cgo_unsafe_args
              Cherry Mui . resolved

              This is probably unnecessary as there is only one argument.

              Quim Muntal

              Done

              Line 47, Patchset 6://go:cgo_unsafe_args
              Cherry Mui . resolved

              Since we copy args below to a struct, there is no need to mark this with cgo_unsafe_args.

              Quim Muntal

              Done

              Line 69, Patchset 6://go:cgo_unsafe_args
              Cherry Mui . resolved

              Also here.

              Quim Muntal

              Done

              Line 103, Patchset 6://go:cgo_unsafe_args
              Cherry Mui . resolved

              Also here.

              Quim Muntal

              Done

              Open in Gerrit

              Related details

              Attention is currently required from:
              • Cherry Mui
              • Michael Pratt
              Submit Requirements:
                • requirement is not satisfiedCode-Review
                • requirement satisfiedNo-Unresolved-Comments
                • requirement is not satisfiedReview-Enforcement
                • requirement is not satisfiedTryBots-Pass
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: go
                Gerrit-Branch: master
                Gerrit-Change-Id: Ica72c98c05262ee692f6fca0762136abaefbca34
                Gerrit-Change-Number: 769360
                Gerrit-PatchSet: 7
                Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
                Gerrit-Reviewer: Cherry Mui <cher...@google.com>
                Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
                Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
                Gerrit-Attention: Cherry Mui <cher...@google.com>
                Gerrit-Attention: Michael Pratt <mpr...@google.com>
                Gerrit-Comment-Date: Tue, 19 May 2026 07:23:02 +0000
                Gerrit-HasComments: Yes
                Gerrit-Has-Labels: Yes
                Comment-In-Reply-To: Cherry Mui <cher...@google.com>
                unsatisfied_requirement
                satisfied_requirement
                open
                diffy
                Reply all
                Reply to author
                Forward
                0 new messages