[go] cmd/compile: don't clear ptrmask in fillptrmask

[Ian Lance Taylor (Gerrit)]

Ian Lance Taylor has uploaded the change for review

Commit message

cmd/compile: don't clear ptrmask in fillptrmask

It is only ever called with a newly allocated slice.

This clearing code dates back to the C version of the compiler,
in which the function started like this:

static void
gengcmask(Type *t, uint8 gcmask[16])
{
	...

	memset(gcmask, 0, 16);
	if(!haspointers(t))
		return;

That memset was required for C, but not for Go.

Change-Id: I6fceb99b2dc8682685dca2e4289fcd58e2e5a0e0

Change diff

diff --git a/src/cmd/compile/internal/reflectdata/reflect.go b/src/cmd/compile/internal/reflectdata/reflect.go
index 38b9391..324007e 100644
--- a/src/cmd/compile/internal/reflectdata/reflect.go
+++ b/src/cmd/compile/internal/reflectdata/reflect.go
@@ -1282,7 +1282,6 @@
 // word offsets in t that hold pointers.
 // ptrmask is assumed to fit at least types.PtrDataSize(t)/PtrSize bits.
 func fillptrmask(t *types.Type, ptrmask []byte) {
-	clear(ptrmask)
 	if !t.HasPointers() {
 		return
 	}

Change information

Files:

• M src/cmd/compile/internal/reflectdata/reflect.go

Change size: XS

Delta: 1 file changed, 0 insertions(+), 1 deletion(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement
• TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: I6fceb99b2dc8682685dca2e4289fcd58e2e5a0e0

Gerrit-Change-Number: 718340

Gerrit-PatchSet: 1

Gerrit-Owner: Ian Lance Taylor <ia...@golang.org>

Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>