[tools] gopls/internal/golang: improve if-else folding range for vscode
6 views
Skip to first unread message
Xie Yuchen (Gerrit)
Sep 16, 2025, 7:24:25 AMSep 16
to goph...@pubsubhelper.golang.org, Alan Donovan, Hongxiang Jiang, Robert Findley, golang-co...@googlegroups.com
Attention needed from Alan Donovan, Hongxiang Jiang and Robert Findley
Xie Yuchen voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Alan Donovan
- Hongxiang Jiang
- Robert Findley
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Findley (Gerrit)
Sep 17, 2025, 6:08:24 PMSep 17
to Xie Yuchen, goph...@pubsubhelper.golang.org, Go LUCI, Alan Donovan, Hongxiang Jiang, golang-co...@googlegroups.com
Attention needed from Alan Donovan, Hongxiang Jiang and Xie Yuchen
Robert Findley added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Alan Donovan
- Hongxiang Jiang
- Xie Yuchen
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alan Donovan (Gerrit)
Sep 18, 2025, 11:01:23 AMSep 18
to Xie Yuchen, goph...@pubsubhelper.golang.org, Robert Findley, Go LUCI, Hongxiang Jiang, golang-co...@googlegroups.com
Attention needed from Hongxiang Jiang and Xie Yuchen
Alan Donovan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alan Donovan
| Hold | +1 |
1 comment
File gopls/internal/golang/folding_range.go
Line 69, Patchset 1 (Latest):
// gopls now offers folding for each block stmt, in if-else statements,
// each block will get its own folding range.
// because go forces to put the close bracket with else like '} else {' or '} else if cond {'
// the offered folding ranges have an overlapping place between the end of if block and the start of else block.
// in vscode now, if the folding ranges have overlapping places, the later one will be ignored,
// so users can only fold the if block and cannot fold the else block.
//
// The workaround adjusts the end position of a if block stmt from Rbrace to the end of the last statement in the block,
// so folding ranges do not have overlapping places.
// note that a single if block stmt isn't necessarily required this logic, but for simplicity,
// we apply this logic to all block stmts inside an if statement.Alan Donovan . unresolved
Can you describe the expected behavior of FoldingRange, from first principles, as if for the user manual? Unless I'm missing something, I feel like we ought to be able to specify the entire behavior in fewer words than this.
Gopls seems to produce sensible information in the scenario of interest, so I suspect the problem is on the client side. Let's come to a consensus on the problem in the issue tracker before we attempt a fix.
Related details
Attention is currently required from:
- Hongxiang Jiang
- Xie Yuchen
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xie Yuchen (Gerrit)
Nov 27, 2025, 6:25:41 AM (3 days ago) Nov 27
to goph...@pubsubhelper.golang.org, Alan Donovan, Robert Findley, Go LUCI, Hongxiang Jiang, golang-co...@googlegroups.com
Xie Yuchen abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages