[go] cmd/go: include the "-trimpath" flag in the stamped build settings
Bryan Mills (Gerrit)
Bryan Mills has uploaded this change for review.
cmd/go: include the "-trimpath" flag in the stamped build settings
The -trimpath flag has a strong effect on the resulting binary:
in particular, it determines whether runtime.GOROOT can report
a meaningful path in the absence of an explicit GOROOT environment variable.
For #51461
Change-Id: Id0d55572c0a0a4e2e4724363ed80dfa05b202186
---
M src/cmd/go/internal/load/pkg.go
1 file changed, 18 insertions(+), 0 deletions(-)
diff --git a/src/cmd/go/internal/load/pkg.go b/src/cmd/go/internal/load/pkg.go
index 4e60bcd..b6a0af7 100644
--- a/src/cmd/go/internal/load/pkg.go
+++ b/src/cmd/go/internal/load/pkg.go
@@ -2317,6 +2317,9 @@
if tags := cfg.BuildContext.BuildTags; len(tags) > 0 {
appendSetting("-tags", strings.Join(tags, ","))
}
+ if cfg.BuildTrimpath {
+ appendSetting("-trimpath", "true")
+ }
cgo := "0"
if cfg.BuildContext.CgoEnabled {
cgo = "1"
To view, visit change 391810. To unsubscribe, or for help writing mail filters, visit settings.
Bryan Mills (Gerrit)
1 comment:
Commit Message:
Patch Set #1, Line 7:
cmd/go: include the "-trimpath" flag in the stamped build settingsThis ought to have a unit test.
To view, visit change 391810. To unsubscribe, or for help writing mail filters, visit settings.
Bryan Mills (Gerrit)
Attention is currently required from: Bryan Mills, Michael Matloob.
Bryan Mills uploaded patch set #6 to this change.
cmd/go: include the "-trimpath" flag in the stamped build settings
The -trimpath flag has a strong effect on the resulting binary:
in particular, it determines whether runtime.GOROOT can report
a meaningful path in the absence of an explicit GOROOT environment variable.
For #51461
Change-Id: Id0d55572c0a0a4e2e4724363ed80dfa05b202186
---
M src/cmd/go/internal/load/pkg.go
1 file changed, 18 insertions(+), 0 deletions(-)
To view, visit change 391810. To unsubscribe, or for help writing mail filters, visit settings.
Bryan Mills (Gerrit)
Attention is currently required from: Bryan Mills, Michael Matloob.
Bryan Mills uploaded patch set #15 to this change.
cmd/go: include the "-trimpath" flag in the stamped build settings
The -trimpath flag has a strong effect on the resulting binary:
in particular, it determines whether runtime.GOROOT can report
a meaningful path in the absence of an explicit GOROOT environment variable.
For #51461
Change-Id: Id0d55572c0a0a4e2e4724363ed80dfa05b202186
---
M src/cmd/go/internal/load/pkg.go
1 file changed, 18 insertions(+), 0 deletions(-)
To view, visit change 391810. To unsubscribe, or for help writing mail filters, visit settings.
Bryan Mills (Gerrit)
Attention is currently required from: Bryan Mills, Michael Matloob.
Bryan Mills uploaded patch set #16 to this change.
cmd/go: include the "-trimpath" flag in the stamped build settings
The -trimpath flag has a strong effect on the resulting binary:
in particular, it determines whether runtime.GOROOT can report
a meaningful path in the absence of an explicit GOROOT environment variable.
For #51461
Change-Id: Id0d55572c0a0a4e2e4724363ed80dfa05b202186
---
M src/cmd/go/internal/load/pkg.go
1 file changed, 18 insertions(+), 0 deletions(-)
To view, visit change 391810. To unsubscribe, or for help writing mail filters, visit settings.
Bryan Mills (Gerrit)
Attention is currently required from: Michael Matloob.
1 comment:
Commit Message:
Patch Set #1, Line 7:
cmd/go: include the "-trimpath" flag in the stamped build settingsThis ought to have a unit test.
Done
To view, visit change 391810. To unsubscribe, or for help writing mail filters, visit settings.
Bryan Mills (Gerrit)
Attention is currently required from: Michael Matloob.
Bryan Mills uploaded patch set #18 to this change.
cmd/go: include the "-trimpath" flag in the stamped build settings
The -trimpath flag has a strong effect on the resulting binary:
in particular, it determines whether runtime.GOROOT can report
a meaningful path in the absence of an explicit GOROOT environment variable.
For #51461
Change-Id: Id0d55572c0a0a4e2e4724363ed80dfa05b202186
---
M src/cmd/go/internal/load/pkg.go
1 file changed, 18 insertions(+), 0 deletions(-)
To view, visit change 391810. To unsubscribe, or for help writing mail filters, visit settings.
Bryan Mills (Gerrit)
Attention is currently required from: Michael Matloob.
Bryan Mills uploaded patch set #19 to this change.
cmd/go: include the "-trimpath" flag in the stamped build settings
The -trimpath flag has a strong effect on the resulting binary:
in particular, it determines whether runtime.GOROOT can report
a meaningful path in the absence of an explicit GOROOT environment variable.
For #51461
Change-Id: Id0d55572c0a0a4e2e4724363ed80dfa05b202186
---
M src/cmd/go/internal/load/pkg.go
M src/cmd/go/testdata/script/version_build_settings.txt
2 files changed, 22 insertions(+), 0 deletions(-)
To view, visit change 391810. To unsubscribe, or for help writing mail filters, visit settings.
Bryan Mills (Gerrit)
Attention is currently required from: Michael Matloob.
Patch set 19:Run-TryBot +1
1 comment:
Patchset:
TRY=longtest,windows-amd64-longtest
To view, visit change 391810. To unsubscribe, or for help writing mail filters, visit settings.
Bryan Mills (Gerrit)
Bryan Mills submitted this change.
16 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/cmd/go/testdata/script/version_build_settings.txt
Insertions: 4, Deletions: 0.
The diff is too large to show. Please review the diff.
```
cmd/go: include the "-trimpath" flag in the stamped build settings
The -trimpath flag has a strong effect on the resulting binary:
in particular, it determines whether runtime.GOROOT can report
a meaningful path in the absence of an explicit GOROOT environment variable.
For #51461
Change-Id: Id0d55572c0a0a4e2e4724363ed80dfa05b202186
Reviewed-on: https://go-review.googlesource.com/c/go/+/391810
Trust: Bryan Mills <bcm...@google.com>
Reviewed-by: Russ Cox <r...@golang.org>
Run-TryBot: Bryan Mills <bcm...@google.com>
TryBot-Result: Gopher Robot <go...@golang.org>
---
M src/cmd/go/internal/load/pkg.go
M src/cmd/go/testdata/script/version_build_settings.txt
2 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/src/cmd/go/internal/load/pkg.go b/src/cmd/go/internal/load/pkg.go
index ab70845..2592cf5 100644
--- a/src/cmd/go/internal/load/pkg.go
+++ b/src/cmd/go/internal/load/pkg.go
@@ -2333,6 +2333,9 @@
if tags := cfg.BuildContext.BuildTags; len(tags) > 0 {
appendSetting("-tags", strings.Join(tags, ","))
}
+ if cfg.BuildTrimpath {
+ appendSetting("-trimpath", "true")
+ }
cgo := "0"
if cfg.BuildContext.CgoEnabled {
cgo = "1"
diff --git a/src/cmd/go/testdata/script/version_build_settings.txt b/src/cmd/go/testdata/script/version_build_settings.txt
index dc9e676..90c72537 100644
--- a/src/cmd/go/testdata/script/version_build_settings.txt
+++ b/src/cmd/go/testdata/script/version_build_settings.txt
@@ -23,6 +23,10 @@
go version -m m$GOEXE
stdout '^\tbuild\t-ldflags=example\.com/m=-w$'
+go build -trimpath
+go version -m m$GOEXE
+stdout '\tbuild\t-trimpath=true$'
+
# gccgoflags are not added when gc is used, and vice versa.
# TODO: test gccgo.
go build -gccgoflags=all=UNUSED
To view, visit change 391810. To unsubscribe, or for help writing mail filters, visit settings.