[go/dev.simd] [dev.simd] simd: repair go.mod and import paths

1 view
Skip to first unread message

David Chase (Gerrit)

unread,
4:56 PM (6 hours ago) 4:56 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

David Chase has uploaded the change for review

Commit message

[dev.simd] simd: repair go.mod and import paths

Root the generator at _gen, just like it is done
in ssa/_gen.  This seems to work better once it is
done.

The command to update the files quickly was
(after git grep to confirm contents and git grep -l
to list them)

sed -e '1,$s?simd/archsimd/_gen?_gen?g;' -i "" <thefiles>
Change-Id: Ieefae140db0da2b37869170fce59fd24440b936b

Change diff

diff --git a/src/simd/archsimd/_gen/simdgen/arm64/emit.go b/src/simd/archsimd/_gen/simdgen/arm64/emit.go
index 09b9237..1bf1281 100644
--- a/src/simd/archsimd/_gen/simdgen/arm64/emit.go
+++ b/src/simd/archsimd/_gen/simdgen/arm64/emit.go
@@ -8,7 +8,7 @@
 	"fmt"
 	"strings"
 
-	"simd/archsimd/_gen/unify"
+	"_gen/unify"
 )
 
 // asComment formats text as a comment
diff --git a/src/simd/archsimd/_gen/simdgen/arm64/load.go b/src/simd/archsimd/_gen/simdgen/arm64/load.go
index aaf2e40..75b4c80 100644
--- a/src/simd/archsimd/_gen/simdgen/arm64/load.go
+++ b/src/simd/archsimd/_gen/simdgen/arm64/load.go
@@ -9,7 +9,7 @@
 import (
 	"sort"
 
-	"simd/archsimd/_gen/unify"
+	"_gen/unify"
 
 	"golang.org/x/arch/arm64/instgen/xmlspec"
 )
diff --git a/src/simd/archsimd/_gen/simdgen/gen_simdGenericOps.go b/src/simd/archsimd/_gen/simdgen/gen_simdGenericOps.go
index aa8b48fe..cfaeda6 100644
--- a/src/simd/archsimd/_gen/simdgen/gen_simdGenericOps.go
+++ b/src/simd/archsimd/_gen/simdgen/gen_simdGenericOps.go
@@ -5,8 +5,8 @@
 package main
 
 import (
+	"_gen/sgutil"
 	"bytes"
-	"simd/archsimd/_gen/sgutil"
 )
 
 // writeSIMDGenericOps generates the generic ops and writes it to simdAMD64ops.go
diff --git a/src/simd/archsimd/_gen/simdgen/gen_simdIntrinsics.go b/src/simd/archsimd/_gen/simdgen/gen_simdIntrinsics.go
index a0f3a2d..b64b4c8 100644
--- a/src/simd/archsimd/_gen/simdgen/gen_simdIntrinsics.go
+++ b/src/simd/archsimd/_gen/simdgen/gen_simdIntrinsics.go
@@ -5,9 +5,9 @@
 package main
 
 import (
+	"_gen/sgutil"
 	"bytes"
 	"fmt"
-	"simd/archsimd/_gen/sgutil"
 	"slices"
 )
 
diff --git a/src/simd/archsimd/_gen/simdgen/gen_simdTypes.go b/src/simd/archsimd/_gen/simdgen/gen_simdTypes.go
index ba4fa82..a64b556 100644
--- a/src/simd/archsimd/_gen/simdgen/gen_simdTypes.go
+++ b/src/simd/archsimd/_gen/simdgen/gen_simdTypes.go
@@ -14,7 +14,7 @@
 	"strings"
 	"unicode"
 
-	"simd/archsimd/_gen/sgutil"
+	"_gen/sgutil"
 )
 
 type simdType struct {
diff --git a/src/simd/archsimd/_gen/simdgen/godefs.go b/src/simd/archsimd/_gen/simdgen/godefs.go
index b12cd9d..2ed3a97 100644
--- a/src/simd/archsimd/_gen/simdgen/godefs.go
+++ b/src/simd/archsimd/_gen/simdgen/godefs.go
@@ -13,7 +13,7 @@
 	"strings"
 	"unicode"
 
-	"simd/archsimd/_gen/unify"
+	"_gen/unify"
 )
 
 type Operation struct {
diff --git a/src/simd/archsimd/_gen/simdgen/main.go b/src/simd/archsimd/_gen/simdgen/main.go
index ed5f14f..8dd7ffb 100644
--- a/src/simd/archsimd/_gen/simdgen/main.go
+++ b/src/simd/archsimd/_gen/simdgen/main.go
@@ -104,8 +104,8 @@
 	"slices"
 	"strings"
 
-	"simd/archsimd/_gen/simdgen/arm64"
-	"simd/archsimd/_gen/unify"
+	"_gen/simdgen/arm64"
+	"_gen/unify"
 
 	"gopkg.in/yaml.v3"
 )
diff --git a/src/simd/archsimd/_gen/simdgen/xed.go b/src/simd/archsimd/_gen/simdgen/xed.go
index 2175fa4..9a3e460 100644
--- a/src/simd/archsimd/_gen/simdgen/xed.go
+++ b/src/simd/archsimd/_gen/simdgen/xed.go
@@ -14,7 +14,7 @@
 	"strconv"
 	"strings"
 
-	"simd/archsimd/_gen/unify"
+	"_gen/unify"
 
 	"golang.org/x/arch/x86/xeddata"
 	"gopkg.in/yaml.v3"

Change information

Files:
  • M src/simd/archsimd/_gen/simdgen/arm64/emit.go
  • M src/simd/archsimd/_gen/simdgen/arm64/load.go
  • M src/simd/archsimd/_gen/simdgen/gen_simdGenericOps.go
  • M src/simd/archsimd/_gen/simdgen/gen_simdIntrinsics.go
  • M src/simd/archsimd/_gen/simdgen/gen_simdTypes.go
  • M src/simd/archsimd/_gen/simdgen/godefs.go
  • M src/simd/archsimd/_gen/simdgen/main.go
  • M src/simd/archsimd/_gen/simdgen/xed.go
Change size: S
Delta: 8 files changed, 9 insertions(+), 9 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: dev.simd
Gerrit-Change-Id: Ieefae140db0da2b37869170fce59fd24440b936b
Gerrit-Change-Number: 776961
Gerrit-PatchSet: 1
Gerrit-Owner: David Chase <drc...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

David Chase (Gerrit)

unread,
5:01 PM (6 hours ago) 5:01 PM
to goph...@pubsubhelper.golang.org, Junyang Shao, Cherry Mui, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Junyang Shao

David Chase added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
David Chase . resolved

I kept running into problems with the imports and go.mod, I think I broke it some number of CLs back, this fixes it and makes it like ssa/_gen. I re-ran "go run ." in simd/archsim/_gen and "go run ." in ssa/_gen and "./make.bash" in the src directory, and then checked that simd_test still worked right, for this CL and several above it up to the WASM cl.

Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
  • Junyang Shao
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: dev.simd
Gerrit-Change-Id: Ieefae140db0da2b37869170fce59fd24440b936b
Gerrit-Change-Number: 776961
Gerrit-PatchSet: 1
Gerrit-Owner: David Chase <drc...@google.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Junyang Shao <shaoj...@google.com>
Gerrit-Attention: Cherry Mui <cher...@google.com>
Gerrit-Attention: Junyang Shao <shaoj...@google.com>
Gerrit-Comment-Date: Mon, 11 May 2026 21:01:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Junyang Shao (Gerrit)

unread,
5:12 PM (6 hours ago) 5:12 PM
to David Chase, goph...@pubsubhelper.golang.org, Cherry Mui, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Cherry Mui and David Chase

Junyang Shao voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
  • David Chase
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: dev.simd
Gerrit-Change-Id: Ieefae140db0da2b37869170fce59fd24440b936b
Gerrit-Change-Number: 776961
Gerrit-PatchSet: 1
Gerrit-Owner: David Chase <drc...@google.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Junyang Shao <shaoj...@google.com>
Gerrit-Attention: Cherry Mui <cher...@google.com>
Gerrit-Attention: David Chase <drc...@google.com>
Gerrit-Comment-Date: Mon, 11 May 2026 21:12:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

David Chase (Gerrit)

unread,
5:40 PM (5 hours ago) 5:40 PM
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Junyang Shao, Cherry Mui, golang-co...@googlegroups.com

David Chase submitted the change

Change information

Commit message:
[dev.simd] simd: repair go.mod and import paths

Root the generator at _gen, just like it is done
in ssa/_gen.  This seems to work better once it is
done.

The command to update the files quickly was
(after git grep to confirm contents and git grep -l
to list them)

sed -e '1,$s?simd/archsimd/_gen?_gen?g;' -i "" <thefiles>
Change-Id: Ieefae140db0da2b37869170fce59fd24440b936b
Files:
  • M src/simd/archsimd/_gen/simdgen/arm64/emit.go
  • M src/simd/archsimd/_gen/simdgen/arm64/load.go
  • M src/simd/archsimd/_gen/simdgen/gen_simdGenericOps.go
  • M src/simd/archsimd/_gen/simdgen/gen_simdIntrinsics.go
  • M src/simd/archsimd/_gen/simdgen/gen_simdTypes.go
  • M src/simd/archsimd/_gen/simdgen/godefs.go
  • M src/simd/archsimd/_gen/simdgen/main.go
  • M src/simd/archsimd/_gen/simdgen/xed.go
Change size: S
Delta: 8 files changed, 9 insertions(+), 9 deletions(-)
Branch: refs/heads/dev.simd
Submit Requirements:
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: dev.simd
Gerrit-Change-Id: Ieefae140db0da2b37869170fce59fd24440b936b
Gerrit-Change-Number: 776961
Gerrit-PatchSet: 2
Gerrit-Owner: David Chase <drc...@google.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Junyang Shao <shaoj...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages