[telemetry] cmd/stacks: record current predicate in each "claimed by comment
1 view
Skip to first unread message
Alan Donovan (Gerrit)
9:23 AM (9 hours ago) 9:23 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Alan Donovan has uploaded the change for review![]( "Open in Gerrit")
Commit message
cmd/stacks: record current predicate in each "claimed by comment
The predicate in the issue body evolves over time, losing history.
This change causes each "claimed by" appendage to an existing
issue to record the predicate as it was at that moment.
Change-Id: Ie667f228c3ba257ad167cdefe316050a0427f19b
Change diff
diff --git a/cmd/stacks/stacks.go b/cmd/stacks/stacks.go
index bc70189..37d3524 100644
--- a/cmd/stacks/stacks.go
+++ b/cmd/stacks/stacks.go
@@ -435,7 +435,8 @@
issue.Number, err, block)
continue
}
- issue.predicate = pred
+ issue.predicate = block
+ issue.matches = pred
}
}
@@ -569,7 +570,7 @@
byPredicate := false
if strings.Contains(issue.Body, id) {
// nop
- } else if issue.predicate != nil && issue.predicate(stack) {
+ } else if issue.matches != nil && issue.matches(stack) {
byPredicate = true
} else {
continue
@@ -605,7 +606,16 @@
// Add a comment to the existing issue listing all its new stacks.
// (Save the ID of each stack for the second step.)
+ //
+ // We record the predicate expression at the time of
+ // the match, as the predicate in the issue body will
+ // evolve as users edit it and we need to leave a
+ // record of its history.
comment := new(bytes.Buffer)
+ if issue.predicate != "" {
+ fmt.Fprintf(comment, "\n\nFound new stacks for predicate:\n")
+ fmt.Fprintf(comment, "```\n#!stacks\n%s\n```\n\n", strings.TrimSpace(issue.predicate))
+ }
var newStackIDs []string
for _, stack := range issue.newStacks {
id := stackID(stack)
@@ -638,7 +648,7 @@
continue
}
- log.Printf("added stacks %s to issue #%d", newStackIDs, issue.Number)
+ log.Printf("added stacks %s to issue #%d (%s)", newStackIDs, issue.Number, issue.Title)
}
}
@@ -1156,7 +1166,8 @@
Milestone *Milestone
// Set by readIssues.
- predicate func(string) bool // matching predicate over stack text
+ predicate string // predicate source expression
+ matches func(string) bool // reports whether predicate over stack text
// Set by claimIssues.
newStacks []string // new stacks to add to existing issue (comments and IDs)
Change information
Files:
- M cmd/stacks/stacks.go
Change size: S
Delta: 1 file changed, 15 insertions(+), 4 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alan Donovan (Gerrit)
9:23 AM (9 hours ago) 9:23 AM
to goph...@pubsubhelper.golang.org, Michael Pratt, Madeline Kalil, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Pratt
Alan Donovan voted Auto-Submit+1![]( "Open in Gerrit")
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alan Donovan (Gerrit)
9:24 AM (9 hours ago) 9:24 AM
to goph...@pubsubhelper.golang.org, Michael Pratt, Madeline Kalil, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Pratt
Alan Donovan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alan Donovan (Gerrit)
9:25 AM (9 hours ago) 9:25 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Alan Donovan and Michael Pratt
Alan Donovan uploaded new patchset![]( "Open in Gerrit")
Attention is currently required from:
- Alan Donovan
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alan Donovan (Gerrit)
9:27 AM (9 hours ago) 9:27 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Alan Donovan and Michael Pratt
Alan Donovan uploaded new patchset![]( "Open in Gerrit")
Alan Donovan uploaded patch set #3 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
Related details
Attention is currently required from:
- Alan Donovan
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages