[go] cmd/cgo: clarify C.GoStringN and C.GoBytes docs

101 views
Skip to first unread message

Minux Ma (Gerrit)

unread,
Oct 16, 2015, 5:49:09 PM10/16/15
to Ian Lance Taylor, Minux Ma, golang-co...@googlegroups.com
Minux Ma uploaded a change:
https://go-review.googlesource.com/15997

cmd/cgo: clarify C.GoStringN and C.GoBytes docs

Fixes #12427.

Change-Id: I46725620c1e163f3b60ffcd85e5388fa646f074d
---
M src/cmd/cgo/doc.go
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/src/cmd/cgo/doc.go b/src/cmd/cgo/doc.go
index f82d782..bbb0d95 100644
--- a/src/cmd/cgo/doc.go
+++ b/src/cmd/cgo/doc.go
@@ -188,10 +188,10 @@
// C string to Go string
func C.GoString(*C.char) string

- // C string, length to Go string
+ // C data with explicit length to Go string
func C.GoStringN(*C.char, C.int) string

- // C pointer, length to Go []byte
+ // C data with explicit length to Go []byte
func C.GoBytes(unsafe.Pointer, C.int) []byte

C references to Go

--
https://go-review.googlesource.com/15997

Brad Fitzpatrick (Gerrit)

unread,
Oct 16, 2015, 6:05:08 PM10/16/15
to Minux Ma, Brad Fitzpatrick, golang-co...@googlegroups.com
Brad Fitzpatrick has posted comments on this change.

cmd/cgo: clarify C.GoStringN and C.GoBytes docs

Patch Set 1: Code-Review+2

--
https://go-review.googlesource.com/15997
Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
Gerrit-HasComments: No

Minux Ma (Gerrit)

unread,
Oct 23, 2015, 6:23:12 PM10/23/15
to Minux Ma, golang-...@googlegroups.com, Brad Fitzpatrick, golang-co...@googlegroups.com
Minux Ma has submitted this change and it was merged.

cmd/cgo: clarify C.GoStringN and C.GoBytes docs

Fixes #12427.

Change-Id: I46725620c1e163f3b60ffcd85e5388fa646f074d
Reviewed-on: https://go-review.googlesource.com/15997
Reviewed-by: Brad Fitzpatrick <brad...@golang.org>
---
M src/cmd/cgo/doc.go
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
Brad Fitzpatrick: Looks good to me, approved


--
https://go-review.googlesource.com/15997
Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
Gerrit-Reviewer: Minux Ma <mi...@golang.org>
Reply all
Reply to author
Forward
0 new messages