[go] cmd/go/internal/envcmd: report GOPACKAGESDRIVER

2 views
Skip to first unread message

Sean Liao (Gerrit)

unread,
May 16, 2026, 4:27:10 PM (3 days ago) May 16
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Sean Liao has uploaded the change for review

Commit message

cmd/go/internal/envcmd: report GOPACKAGESDRIVER

While not recognized by cmd/go, this helps with
bug reports around the tooling ecosystem.

Fixes #75930
Change-Id: I23018d0bb9fcb13df7060d5bf6e11abd6a6a6964

Change diff

diff --git a/src/cmd/go/internal/envcmd/env.go b/src/cmd/go/internal/envcmd/env.go
index e950c65..3238a8b 100644
--- a/src/cmd/go/internal/envcmd/env.go
+++ b/src/cmd/go/internal/envcmd/env.go
@@ -106,6 +106,13 @@
 		{Name: "GONOPROXY", Value: cfg.GONOPROXY, Changed: cfg.GONOPROXYChanged},
 		{Name: "GONOSUMDB", Value: cfg.GONOSUMDB, Changed: cfg.GONOSUMDBChanged},
 		{Name: "GOOS", Value: cfg.Goos, Changed: cfg.Goos != runtime.GOOS},
+
+		// GOPACKAGESDRIVER isn't read or used by cmd/go, so it can only
+		// be sourced from environment variables.
+		// We include it for bug reports.
+		// go.dev/issue/75930
+		{Name: "GOPACKAGESDRIVER", Value: os.Getenv("GOPACKAGESDRIVER")},
+
 		{Name: "GOPATH", Value: cfg.BuildContext.GOPATH, Changed: cfg.GOPATHChanged},
 		{Name: "GOPRIVATE", Value: cfg.GOPRIVATE},
 		{Name: "GOPROXY", Value: cfg.GOPROXY, Changed: cfg.GOPROXYChanged},

Change information

Files:
  • M src/cmd/go/internal/envcmd/env.go
Change size: XS
Delta: 1 file changed, 7 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I23018d0bb9fcb13df7060d5bf6e11abd6a6a6964
Gerrit-Change-Number: 778600
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Liao <se...@liao.dev>
Gerrit-Reviewer: Sean Liao <se...@liao.dev>
unsatisfied_requirement
satisfied_requirement
open
diffy

Alan Donovan (Gerrit)

unread,
May 18, 2026, 4:55:33 PM (15 hours ago) May 18
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov and Sean Liao

Alan Donovan added 2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alan Donovan . resolved

Thanks for contributing this fix.

File src/cmd/go/internal/envcmd/env.go
Line 136, Patchset 1 (Latest): case "GOBIN", "GOEXPERIMENT", "GOFLAGS", "GOINSECURE", "GOPRIVATE", "GOTMPDIR", "GOVCS":
Alan Donovan . unresolved

I think you'll need to add GOPACKAGESDRIVER here to ensure that its Changed flag is correctly set (see CL 563137).

Open in Gerrit

Related details

Attention is currently required from:
  • Dmitri Shuralyov
  • Sean Liao
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I23018d0bb9fcb13df7060d5bf6e11abd6a6a6964
    Gerrit-Change-Number: 778600
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sean Liao <se...@liao.dev>
    Gerrit-Reviewer: Alan Donovan <adon...@google.com>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Sean Liao <se...@liao.dev>
    Gerrit-Attention: Sean Liao <se...@liao.dev>
    Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Comment-Date: Mon, 18 May 2026 20:55:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Sean Liao (Gerrit)

    unread,
    May 18, 2026, 10:03:27 PM (10 hours ago) May 18
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Dmitri Shuralyov and Sean Liao

    Sean Liao uploaded new patchset

    Sean Liao uploaded patch set #2 to this change.
    Following approvals got outdated and were removed:
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dmitri Shuralyov
    • Sean Liao
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I23018d0bb9fcb13df7060d5bf6e11abd6a6a6964
      Gerrit-Change-Number: 778600
      Gerrit-PatchSet: 2
      Gerrit-Owner: Sean Liao <se...@liao.dev>
      Gerrit-Reviewer: Alan Donovan <adon...@google.com>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Reviewer: Sean Liao <se...@liao.dev>
      Gerrit-CC: Michael Matloob <mat...@golang.org>
      unsatisfied_requirement
      open
      diffy

      Sean Liao (Gerrit)

      unread,
      May 18, 2026, 10:03:39 PM (10 hours ago) May 18
      to goph...@pubsubhelper.golang.org, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, Alan Donovan, Dmitri Shuralyov, golang-co...@googlegroups.com
      Attention needed from Alan Donovan and Dmitri Shuralyov

      Sean Liao added 1 comment

      File src/cmd/go/internal/envcmd/env.go
      Line 136, Patchset 1: case "GOBIN", "GOEXPERIMENT", "GOFLAGS", "GOINSECURE", "GOPRIVATE", "GOTMPDIR", "GOVCS":
      Alan Donovan . resolved

      I think you'll need to add GOPACKAGESDRIVER here to ensure that its Changed flag is correctly set (see CL 563137).

      Sean Liao

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alan Donovan
      • Dmitri Shuralyov
      Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I23018d0bb9fcb13df7060d5bf6e11abd6a6a6964
        Gerrit-Change-Number: 778600
        Gerrit-PatchSet: 2
        Gerrit-Owner: Sean Liao <se...@liao.dev>
        Gerrit-Reviewer: Alan Donovan <adon...@google.com>
        Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
        Gerrit-Reviewer: Sean Liao <se...@liao.dev>
        Gerrit-CC: Michael Matloob <mat...@golang.org>
        Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
        Gerrit-Attention: Alan Donovan <adon...@google.com>
        Gerrit-Comment-Date: Tue, 19 May 2026 02:03:32 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Alan Donovan <adon...@google.com>
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        qiu laidongfeng (Gerrit)

        unread,
        May 18, 2026, 10:32:22 PM (10 hours ago) May 18
        to goph...@pubsubhelper.golang.org, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, Alan Donovan, Dmitri Shuralyov, golang-co...@googlegroups.com
        Attention needed from Alan Donovan, Dmitri Shuralyov and Sean Liao

        qiu laidongfeng voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alan Donovan
        • Dmitri Shuralyov
        • Sean Liao
        Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I23018d0bb9fcb13df7060d5bf6e11abd6a6a6964
        Gerrit-Change-Number: 778600
        Gerrit-PatchSet: 2
        Gerrit-Owner: Sean Liao <se...@liao.dev>
        Gerrit-Reviewer: Alan Donovan <adon...@google.com>
        Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
        Gerrit-Reviewer: Sean Liao <se...@liao.dev>
        Gerrit-Reviewer: qiu laidongfeng <26454...@qq.com>
        Gerrit-CC: Michael Matloob <mat...@golang.org>
        Gerrit-Attention: Sean Liao <se...@liao.dev>
        Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
        Gerrit-Attention: Alan Donovan <adon...@google.com>
        Gerrit-Comment-Date: Tue, 19 May 2026 02:32:14 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages