[go] os,internal/syscall/windows: support O_* flags in Root.OpenFile

5 views
Skip to first unread message

Quim Muntal (Gerrit)

unread,
Nov 26, 2025, 6:12:59 AM (4 days ago) Nov 26
to goph...@pubsubhelper.golang.org, Damien Neil, Alex Brainman, golang-co...@googlegroups.com
Attention needed from Alex Brainman and Damien Neil

Quim Muntal voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Brainman
  • Damien Neil
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ib37102a565f538d394d2a94bd605d6c6004f3028
Gerrit-Change-Number: 724621
Gerrit-PatchSet: 1
Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Damien Neil <dn...@google.com>
Gerrit-Attention: Alex Brainman <alex.b...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Nov 2025 11:12:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Quim Muntal (Gerrit)

unread,
Nov 26, 2025, 6:49:19 AM (4 days ago) Nov 26
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Alex Brainman, Damien Neil and Quim Muntal

Quim Muntal uploaded new patchset

Quim Muntal uploaded patch set #2 to this change.
Following approvals got outdated and were removed:
  • TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Brainman
  • Damien Neil
  • Quim Muntal
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ib37102a565f538d394d2a94bd605d6c6004f3028
Gerrit-Change-Number: 724621
Gerrit-PatchSet: 2
Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Quim Muntal (Gerrit)

unread,
Nov 26, 2025, 6:49:28 AM (4 days ago) Nov 26
to goph...@pubsubhelper.golang.org, Go LUCI, Damien Neil, Alex Brainman, golang-co...@googlegroups.com
Attention needed from Alex Brainman and Damien Neil

Quim Muntal voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Brainman
  • Damien Neil
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ib37102a565f538d394d2a94bd605d6c6004f3028
Gerrit-Change-Number: 724621
Gerrit-PatchSet: 2
Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Damien Neil <dn...@google.com>
Gerrit-Attention: Alex Brainman <alex.b...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Nov 2025 11:49:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Damien Neil (Gerrit)

unread,
Nov 26, 2025, 11:44:14 AM (3 days ago) Nov 26
to Quim Muntal, goph...@pubsubhelper.golang.org, Go LUCI, Alex Brainman, golang-co...@googlegroups.com
Attention needed from Alex Brainman and Quim Muntal

Damien Neil voted

Auto-Submit+1
Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Brainman
  • Quim Muntal
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ib37102a565f538d394d2a94bd605d6c6004f3028
Gerrit-Change-Number: 724621
Gerrit-PatchSet: 2
Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Alex Brainman <alex.b...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Nov 2025 16:44:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Cherry Mui (Gerrit)

unread,
Nov 26, 2025, 1:13:11 PM (3 days ago) Nov 26
to Quim Muntal, goph...@pubsubhelper.golang.org, Damien Neil, Go LUCI, Alex Brainman, golang-co...@googlegroups.com
Attention needed from Alex Brainman and Quim Muntal

Cherry Mui voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Brainman
  • Quim Muntal
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ib37102a565f538d394d2a94bd605d6c6004f3028
    Gerrit-Change-Number: 724621
    Gerrit-PatchSet: 2
    Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
    Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Damien Neil <dn...@google.com>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Alex Brainman <alex.b...@gmail.com>
    Gerrit-Comment-Date: Wed, 26 Nov 2025 18:13:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Cherry Mui (Gerrit)

    unread,
    Nov 26, 2025, 1:17:11 PM (3 days ago) Nov 26
    to Quim Muntal, goph...@pubsubhelper.golang.org, Damien Neil, Go LUCI, Alex Brainman, golang-co...@googlegroups.com
    Attention needed from Alex Brainman and Quim Muntal

    Cherry Mui added 1 comment

    Commit Message
    Line 11, Patchset 2 (Latest):Closes #73676
    Cherry Mui . unresolved

    Just to confirm, does this CL fix 73676? At a surface level, this CL applies to only Root, whereas 73676 doesn't need Root.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Brainman
    • Quim Muntal
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ib37102a565f538d394d2a94bd605d6c6004f3028
    Gerrit-Change-Number: 724621
    Gerrit-PatchSet: 2
    Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
    Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Damien Neil <dn...@google.com>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Alex Brainman <alex.b...@gmail.com>
    Gerrit-Comment-Date: Wed, 26 Nov 2025 18:17:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Quim Muntal (Gerrit)

    unread,
    Nov 26, 2025, 2:56:41 PM (3 days ago) Nov 26
    to goph...@pubsubhelper.golang.org, Cherry Mui, Damien Neil, Go LUCI, Alex Brainman, golang-co...@googlegroups.com
    Attention needed from Alex Brainman and Cherry Mui

    Quim Muntal added 1 comment

    Commit Message
    Cherry Mui . resolved

    Just to confirm, does this CL fix 73676? At a surface level, this CL applies to only Root, whereas 73676 doesn't need Root.

    Quim Muntal

    Root.OpenFile is mentioned in the proposal, but not in the final comment from Austin. That's an oversight, as Root.OpenFile should mimic os.OpenFile. The latter already supports the new flags, so this CL closes the issue.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Brainman
    • Cherry Mui
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ib37102a565f538d394d2a94bd605d6c6004f3028
    Gerrit-Change-Number: 724621
    Gerrit-PatchSet: 2
    Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
    Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Damien Neil <dn...@google.com>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Cherry Mui <cher...@google.com>
    Gerrit-Attention: Alex Brainman <alex.b...@gmail.com>
    Gerrit-Comment-Date: Wed, 26 Nov 2025 19:56:31 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Cherry Mui <cher...@google.com>
    satisfied_requirement
    open
    diffy

    Gopher Robot (Gerrit)

    unread,
    Nov 26, 2025, 2:57:00 PM (3 days ago) Nov 26
    to Quim Muntal, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Cherry Mui, Damien Neil, Go LUCI, Alex Brainman, golang-co...@googlegroups.com

    Gopher Robot submitted the change

    Change information

    Commit message:
    os,internal/syscall/windows: support O_* flags in Root.OpenFile

    These file flags are supported by os.OpenFile since CL 699415.

    Closes #73676
    Change-Id: Ib37102a565f538d394d2a94bd605d6c6004f3028
    Auto-Submit: Damien Neil <dn...@google.com>
    Reviewed-by: Damien Neil <dn...@google.com>
    Reviewed-by: Cherry Mui <cher...@google.com>
    Files:
    • M src/internal/syscall/windows/at_windows.go
    • M src/internal/syscall/windows/types_windows.go
    • M src/os/root_windows.go
    • M src/os/root_windows_test.go
    • M src/syscall/types_windows.go
    Change size: M
    Delta: 5 files changed, 148 insertions(+), 18 deletions(-)
    Branch: refs/heads/master
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Damien Neil, +1 by Cherry Mui
    • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ib37102a565f538d394d2a94bd605d6c6004f3028
    Gerrit-Change-Number: 724621
    Gerrit-PatchSet: 3
    Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
    Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Damien Neil <dn...@google.com>
    Gerrit-Reviewer: Gopher Robot <go...@golang.org>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    open
    diffy
    satisfied_requirement

    Alex Brainman (Gerrit)

    unread,
    Nov 27, 2025, 4:12:57 AM (3 days ago) Nov 27
    to Quim Muntal, Gopher Robot, goph...@pubsubhelper.golang.org, Cherry Mui, Damien Neil, Go LUCI, golang-co...@googlegroups.com

    Alex Brainman voted and added 1 comment

    Votes added by Alex Brainman

    Code-Review+2

    1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Alex Brainman . resolved

    LGTM.

    Alex

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ib37102a565f538d394d2a94bd605d6c6004f3028
    Gerrit-Change-Number: 724621
    Gerrit-PatchSet: 3
    Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
    Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Damien Neil <dn...@google.com>
    Gerrit-Reviewer: Gopher Robot <go...@golang.org>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-Comment-Date: Thu, 27 Nov 2025 09:12:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages