[benchmarks] sweet: increase context for tail of log

2 views
Skip to first unread message

Daniel Morsing (Gerrit)

unread,
Mar 10, 2026, 6:15:22 AM (9 days ago) Mar 10
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Daniel Morsing has uploaded the change for review

Commit message

sweet: increase context for tail of log

For tracking down #72037.
Change-Id: Ie85334c2d8fa5bae198ba046bcc329176a6a6964

Change diff

diff --git a/sweet/cmd/sweet/benchmark.go b/sweet/cmd/sweet/benchmark.go
index fcc29b1..1d9ff02 100644
--- a/sweet/cmd/sweet/benchmark.go
+++ b/sweet/cmd/sweet/benchmark.go
@@ -161,7 +161,7 @@
 }
 
 func readFileTail(f *os.File) (data string, err error) {
-	const maxLines = 20
+	const maxLines = 300
 	const maxBytes = 16 << 10
 	const block = 4096

Change information

Files:
  • M sweet/cmd/sweet/benchmark.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: benchmarks
Gerrit-Branch: master
Gerrit-Change-Id: Ie85334c2d8fa5bae198ba046bcc329176a6a6964
Gerrit-Change-Number: 753580
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Morsing <daniel....@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Michael Pratt (Gerrit)

unread,
Mar 17, 2026, 1:19:54 PM (yesterday) Mar 17
to Daniel Morsing, goph...@pubsubhelper.golang.org, Michael Pratt, golang-co...@googlegroups.com
Attention needed from Daniel Morsing

Michael Pratt voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Morsing
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: benchmarks
Gerrit-Branch: master
Gerrit-Change-Id: Ie85334c2d8fa5bae198ba046bcc329176a6a6964
Gerrit-Change-Number: 753580
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Morsing <daniel....@gmail.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Daniel Morsing <daniel....@gmail.com>
Gerrit-Comment-Date: Tue, 17 Mar 2026 17:19:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Morsing (Gerrit)

unread,
Mar 17, 2026, 1:38:07 PM (yesterday) Mar 17
to goph...@pubsubhelper.golang.org, Michael Pratt, golang-co...@googlegroups.com

Daniel Morsing voted

Auto-Submit+1
Run-TryBot+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedLegacy-TryBots-Pass
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: benchmarks
Gerrit-Branch: master
Gerrit-Change-Id: Ie85334c2d8fa5bae198ba046bcc329176a6a6964
Gerrit-Change-Number: 753580
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Morsing <daniel....@gmail.com>
Gerrit-Reviewer: Daniel Morsing <daniel....@gmail.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Tue, 17 Mar 2026 17:38:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Morsing (Gerrit)

unread,
Mar 17, 2026, 1:49:30 PM (yesterday) Mar 17
to goph...@pubsubhelper.golang.org, Gopher Robot, Michael Pratt, golang-co...@googlegroups.com

Daniel Morsing voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedLegacy-TryBots-Pass
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: benchmarks
    Gerrit-Branch: master
    Gerrit-Change-Id: Ie85334c2d8fa5bae198ba046bcc329176a6a6964
    Gerrit-Change-Number: 753580
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Morsing <daniel....@gmail.com>
    Gerrit-Reviewer: Daniel Morsing <daniel....@gmail.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Comment-Date: Tue, 17 Mar 2026 17:49:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Morsing (Gerrit)

    unread,
    6:01 AM (16 hours ago) 6:01 AM
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Daniel Morsing and Michael Pratt

    Daniel Morsing uploaded new patchset

    Daniel Morsing uploaded patch set #2 to this change.
    Following approvals got outdated and were removed:
    • Code-Review: +2 by Michael Pratt
    • Legacy-TryBots-Pass: Run-TryBot+1 by Daniel Morsing
    • TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Morsing
    • Michael Pratt
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: benchmarks
    Gerrit-Branch: master
    Gerrit-Change-Id: Ie85334c2d8fa5bae198ba046bcc329176a6a6964
    Gerrit-Change-Number: 753580
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Morsing <daniel....@gmail.com>
    Gerrit-Reviewer: Daniel Morsing <daniel....@gmail.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Attention: Michael Pratt <mpr...@google.com>
    Gerrit-Attention: Daniel Morsing <daniel....@gmail.com>
    unsatisfied_requirement
    open
    diffy

    Daniel Morsing (Gerrit)

    unread,
    6:02 AM (16 hours ago) 6:02 AM
    to goph...@pubsubhelper.golang.org, Go LUCI, Gopher Robot, Michael Pratt, golang-co...@googlegroups.com
    Attention needed from Michael Pratt

    Daniel Morsing voted

    Auto-Submit+1
    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Pratt
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: benchmarks
    Gerrit-Branch: master
    Gerrit-Change-Id: Ie85334c2d8fa5bae198ba046bcc329176a6a6964
    Gerrit-Change-Number: 753580
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Morsing <daniel....@gmail.com>
    Gerrit-Reviewer: Daniel Morsing <daniel....@gmail.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Attention: Michael Pratt <mpr...@google.com>
    Gerrit-Comment-Date: Wed, 18 Mar 2026 10:02:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    open
    diffy

    Daniel Morsing (Gerrit)

    unread,
    6:51 AM (15 hours ago) 6:51 AM
    to goph...@pubsubhelper.golang.org, Go LUCI, Gopher Robot, Michael Pratt, golang-co...@googlegroups.com
    Attention needed from Michael Pratt

    Daniel Morsing added 1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Gopher Robot . resolved

    TryBots beginning. Status page: https://farmer.golang.org/try?commit=9c179613

    Daniel Morsing

    accidentally try-botted when I should have commit-queued

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Pratt
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: benchmarks
      Gerrit-Branch: master
      Gerrit-Change-Id: Ie85334c2d8fa5bae198ba046bcc329176a6a6964
      Gerrit-Change-Number: 753580
      Gerrit-PatchSet: 2
      Gerrit-Owner: Daniel Morsing <daniel....@gmail.com>
      Gerrit-Reviewer: Daniel Morsing <daniel....@gmail.com>
      Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
      Gerrit-CC: Gopher Robot <go...@golang.org>
      Gerrit-Attention: Michael Pratt <mpr...@google.com>
      Gerrit-Comment-Date: Wed, 18 Mar 2026 10:51:31 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Gopher Robot <go...@golang.org>
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages