[go] cmd/go: add tlskyber godebug back with no effect
10 views
Skip to first unread message
Michael Matloob (Gerrit)
Apr 3, 2025, 12:19:03 PMApr 3
to goph...@pubsubhelper.golang.org, Roland Shoemaker, Sam Thanawalla, Go LUCI, golang-co...@googlegroups.com
Attention needed from Roland Shoemaker and Sam Thanawalla
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Roland Shoemaker
- Sam Thanawalla
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Filippo Valsorda (Gerrit)
Apr 3, 2025, 12:23:21 PMApr 3
to Michael Matloob, goph...@pubsubhelper.golang.org, Roland Shoemaker, Sam Thanawalla, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Matloob, Roland Shoemaker and Sam Thanawalla
Filippo Valsorda added 1 comment![]( "Open in Gerrit")
File src/internal/godebugs/table.go
Line 60, Patchset 4 (Latest):
{Name: "tlskyber", Package: "cd/go"}, // Has no effect. See #72111Filippo Valsorda . unresolved
cd/go?
Related details
Attention is currently required from:
- Michael Matloob
- Roland Shoemaker
- Sam Thanawalla
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Apr 3, 2025, 12:24:04 PMApr 3
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Matloob, Roland Shoemaker and Sam Thanawalla
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #5 to this change.
Related details
Attention is currently required from:
- Michael Matloob
- Roland Shoemaker
- Sam Thanawalla
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Apr 3, 2025, 12:25:09 PMApr 3
to goph...@pubsubhelper.golang.org, Go LUCI, Roland Shoemaker, Sam Thanawalla, golang-co...@googlegroups.com
Attention needed from Filippo Valsorda, Roland Shoemaker and Sam Thanawalla
Michael Matloob voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Matloob
| Commit-Queue | +1 |
1 comment
File src/internal/godebugs/table.go
Line 60, Patchset 4:
{Name: "tlskyber", Package: "cd/go"}, // Has no effect. See #72111Filippo Valsorda . unresolved
cd/go?
Attention is currently required from:
- Filippo Valsorda
- Roland Shoemaker
- Sam Thanawalla
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Apr 3, 2025, 12:38:37 PMApr 3
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Filippo Valsorda, Michael Matloob, Roland Shoemaker and Sam Thanawalla
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #6 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
Related details
Attention is currently required from:
- Filippo Valsorda
- Michael Matloob
- Roland Shoemaker
- Sam Thanawalla
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Apr 4, 2025, 5:34:58 PMApr 4
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Filippo Valsorda, Michael Matloob, Roland Shoemaker and Sam Thanawalla
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #7 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
Related details
Attention is currently required from:
- Filippo Valsorda
- Michael Matloob
- Roland Shoemaker
- Sam Thanawalla
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sam Thanawalla (Gerrit)
Apr 8, 2025, 1:10:23 PMApr 8
to Michael Matloob, goph...@pubsubhelper.golang.org, Go LUCI, Roland Shoemaker, golang-co...@googlegroups.com
Attention needed from Filippo Valsorda, Michael Matloob and Roland Shoemaker
Sam Thanawalla voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Filippo Valsorda
- Michael Matloob
- Roland Shoemaker
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Apr 17, 2025, 12:14:48 PMApr 17
to goph...@pubsubhelper.golang.org, Sam Thanawalla, Go LUCI, Roland Shoemaker, golang-co...@googlegroups.com
Attention needed from Filippo Valsorda and Roland Shoemaker
Michael Matloob added 1 comment![]( "Open in Gerrit")
File src/internal/godebugs/table.go
Line 60, Patchset 4:
{Name: "tlskyber", Package: "cd/go"}, // Has no effect. See #72111Filippo Valsorda . resolved
Michael Matloobcd/go?
Oh sorry. This should be crypto/tls.
Attention is currently required from:
- Filippo Valsorda
- Roland Shoemaker
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Apr 17, 2025, 12:15:33 PMApr 17
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Filippo Valsorda and Roland Shoemaker
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #8 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Related details
Attention is currently required from:
- Filippo Valsorda
- Roland Shoemaker
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Filippo Valsorda (Gerrit)
Apr 17, 2025, 12:27:26 PMApr 17
to Michael Matloob, goph...@pubsubhelper.golang.org, Sam Thanawalla, Go LUCI, Roland Shoemaker, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Roland Shoemaker
Filippo Valsorda added 1 comment![]( "Open in Gerrit")
File src/internal/godebugs/table.go
Line 60, Patchset 4:
{Name: "tlskyber", Package: "cd/go"}, // Has no effect. See #72111Filippo Valsorda . unresolved
Michael Matloobcd/go?
Michael MatloobOh sorry. This should be crypto/tls.
Removed from here and made it an undocumented GODEBUG.
Filippo Valsorda
How does this CL solve the issue now? CheckGodebug in modload looks at the All table to decide if a godebug is known, no?
Related details
Attention is currently required from:
- Michael Matloob
- Roland Shoemaker
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Dec 16, 2025, 1:58:14 PM (2 days ago) Dec 16
to Michael Matloob, goph...@pubsubhelper.golang.org, Go LUCI, Sam Thanawalla, Filippo Valsorda, Roland Shoemaker, golang-co...@googlegroups.com
Michael Matloob abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages