[wiki] CreatingSubRepository: update for migration to LUCI
0 views
Skip to first unread message
Dmitri Shuralyov (Gerrit)
2:19 PM (7 hours ago) 2:19 PM
to Than McIntosh, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Than McIntosh
Dmitri Shuralyov has uploaded the change for review![]( "Open in Gerrit")
Dmitri Shuralyov would like Than McIntosh to review this change.
Commit message
CreatingSubRepository: update for migration to LUCI
Include a few changes that are relevant now that LUCI is used for
testing. Notably, the luci-config branch needs to be updated, and
it's fine not to redeploy coordinator. Also clarify that x/website
deployments are automatic.
Change-Id: Idc49c555cc527c23aa348bc42597064c78e52d25
Change diff
diff --git a/CreatingSubRepository.md b/CreatingSubRepository.md
index a200268..e92c64d 100644
--- a/CreatingSubRepository.md
+++ b/CreatingSubRepository.md
@@ -6,6 +6,7 @@
- a golang.org/x redirect
- automatic git mirroring from Gerrit to GitHub
- automatic importing of GitHub PRs into Gerrit CLs
+- automatic testing on appropraite Go builders
## Steps
@@ -18,13 +19,13 @@
- Add "golang org admins" team with Admin access.
- Add "google-go-team" team with Write access.
- Add "robots" team with Write access (can only be done by a maintainer of golang organization; ask someone else if you're not).
-3. Modify the `x/build/repos` package.
-4. Update x/website's version of x/build to include modified `x/build/repos` package.
-5. Redeploy all affected commands (or ask an x/build [owner](https://dev.golang.org/owners) to deploy if you're not; the order shouldn't matter):
+3. Modify the [`x/build/repos`](https://https://golang.org/x/build/repos) package.
+4. Modify the [`PROJECTS` map](https://cs.opensource.google/go/x/build/+/luci-config:main.star;l=644-675;drc=67d27da0c4496ee84405c96517dfdaaf4e960cfc) on [luci-config](https://cs.opensource.google/go/x/build/+/luci-config:README) branch.
+5. Update x/website's version of x/build to include modified `x/build/repos` package.
+ - `x/website/cmd/golangorg` will [deploy automatically](https://go.googlesource.com/website#deploying) on CL submission.
+6. Redeploy all affected commands (or ask an x/build [owner](https://dev.golang.org/owners) to deploy if you're not; the order shouldn't matter):
1. `x/build/cmd/gitmirror`
2. `x/build/maintner/maintnerd`
- Note that it's expected for the new repo not to appear in maintner until first issue or PR is created (see [#25744](https://go.dev/issue/25744)).
3. `x/build/cmd/gerritbot`
- 4. `x/build/cmd/coordinator`
- 5. `x/website/cmd/golangorg`
6. You're done.
Change information
Files:
- M CreatingSubRepository.md
Change size: S
Delta: 1 file changed, 6 insertions(+), 5 deletions(-)
Related details
Attention is currently required from:
- Than McIntosh
Submit Requirements:
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
2:21 PM (7 hours ago) 2:21 PM
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Than McIntosh
Dmitri Shuralyov uploaded new patchset![]( "Open in Gerrit")
Dmitri Shuralyov uploaded patch set #2 to this change.
Related details
Attention is currently required from:
- Than McIntosh
Submit Requirements:
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Than McIntosh (Gerrit)
2:24 PM (7 hours ago) 2:24 PM
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Than McIntosh, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov
Than McIntosh voted and added 1 comment![]( "Open in Gerrit")
Votes added by Than McIntosh
| Code-Review | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Than McIntosh . resolved
This looks good.
Maybe also add something about adding the new "x/<blahblah>" to the Go code owners table?
Related details
Attention is currently required from:
- Dmitri Shuralyov
Submit Requirements:
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
2:30 PM (7 hours ago) 2:30 PM
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Than McIntosh, golang-co...@googlegroups.com
Attention needed from Than McIntosh
Dmitri Shuralyov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Than McIntosh . resolved
This looks good.
Maybe also add something about adding the new "x/<blahblah>" to the Go code owners table?
Dmitri Shuralyov
Good idea, it's best to do that earlier when it's easier to determine the repo owner(s). Added a point for it in PS 3.
Related details
Attention is currently required from:
- Than McIntosh
Submit Requirements:
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
2:30 PM (7 hours ago) 2:30 PM
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Than McIntosh
Dmitri Shuralyov uploaded new patchset![]( "Open in Gerrit")
Dmitri Shuralyov uploaded patch set #3 to this change.
Related details
Attention is currently required from:
- Than McIntosh
Submit Requirements:
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
2:32 PM (7 hours ago) 2:32 PM
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Than McIntosh, golang-co...@googlegroups.com
Gopher Robot submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: CreatingSubRepository.md
Insertions: 2, Deletions: 0.
@@ -20,6 +20,7 @@
- Add "google-go-team" team with Write access.
- Add "robots" team with Write access (can only be done by a maintainer of golang organization; ask someone else if you're not).
3. Modify the [`x/build/repos`](https://golang.org/x/build/repos) package.
+ - Also modify the [`x/build/devapp/owners`](https://dev.golang.org/owners) to include the owner(s) of the new repository. (Both can be updated in one CL.)
4. Modify the [`PROJECTS` map](https://cs.opensource.google/go/x/build/+/luci-config:main.star;l=644-675;drc=67d27da0c4496ee84405c96517dfdaaf4e960cfc) on [luci-config](https://cs.opensource.google/go/x/build/+/luci-config:README) branch.
5. Update x/website's version of x/build to include modified `x/build/repos` package.
- `x/website/cmd/golangorg` will [deploy automatically](https://go.googlesource.com/website#deploying) on CL submission.
@@ -28,4 +29,5 @@
2. `x/build/maintner/maintnerd`
- Note that it's expected for the new repo not to appear in maintner until first issue or PR is created (see [#25744](https://go.dev/issue/25744)).
3. `x/build/cmd/gerritbot`
+ 4. `x/build/devapp`
6. You're done.
```
Change information
Commit message:
CreatingSubRepository: update for migration to LUCI
Include a few changes that are relevant now that LUCI is used for
testing. Notably, the luci-config branch needs to be updated, and
it's fine not to redeploy coordinator. Clarify that the x/website
deployments are automatic, and add a reminder to add repo owner(s).
Change-Id: Idc49c555cc527c23aa348bc42597064c78e52d25
Reviewed-on: https://go-review.googlesource.com/c/wiki/+/596595
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
Reviewed-by: Than McIntosh <th...@google.com>
Files:
- M CreatingSubRepository.md
Change size: S
Delta: 1 file changed, 8 insertions(+), 5 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Than McIntosh
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages