[go] cmd/compile: use BEXTI for bit tests on riscv64

9 views
Skip to first unread message

Joel Sing (Gerrit)

unread,
Sep 1, 2026, 11:03:07 AMSep 1
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Joel Sing

Message from Joel Sing

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Joel Sing
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
Gerrit-Change-Number: 821221
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Sing <jo...@sing.id.au>
Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
Gerrit-Attention: Joel Sing <jo...@sing.id.au>
Gerrit-Comment-Date: Tue, 01 Sep 2026 15:02:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Joel Sing (Gerrit)

unread,
Sep 1, 2026, 11:04:43 AMSep 1
to goph...@pubsubhelper.golang.org, Mark Ryan, Julian Zhu, Meng Zhuo, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Julian Zhu, Mark Ryan and Meng Zhuo

Joel Sing voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Julian Zhu
  • Mark Ryan
  • Meng Zhuo
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
Gerrit-Change-Number: 821221
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Sing <jo...@sing.id.au>
Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
Gerrit-Reviewer: Julian Zhu <jz53...@gmail.com>
Gerrit-Reviewer: Mark Ryan <mark...@meta.com>
Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Attention: Julian Zhu <jz53...@gmail.com>
Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Attention: Mark Ryan <mark...@meta.com>
Gerrit-Comment-Date: Tue, 01 Sep 2026 15:04:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Joel Sing (Gerrit)

unread,
Sep 3, 2026, 5:51:14 AMSep 3
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Mark Ryan, Julian Zhu, Meng Zhuo, golang-co...@googlegroups.com
Attention needed from Julian Zhu, Mark Ryan and Meng Zhuo

Joel Sing voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Julian Zhu
  • Mark Ryan
  • Meng Zhuo
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
Gerrit-Change-Number: 821221
Gerrit-PatchSet: 3
Gerrit-Owner: Joel Sing <jo...@sing.id.au>
Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
Gerrit-Reviewer: Julian Zhu <jz53...@gmail.com>
Gerrit-Reviewer: Mark Ryan <mark...@meta.com>
Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Attention: Julian Zhu <jz53...@gmail.com>
Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Attention: Mark Ryan <mark...@meta.com>
Gerrit-Comment-Date: Thu, 03 Sep 2026 09:51:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Joel Sing (Gerrit)

unread,
Sep 12, 2026, 12:28:10 AMSep 12
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Julian Zhu, Mark Ryan and Meng Zhuo

Joel Sing uploaded new patchset

Joel Sing uploaded patch set #4 to this change.
Following approvals got outdated and were removed:
Open in Gerrit

Related details

Attention is currently required from:
  • Julian Zhu
  • Mark Ryan
  • Meng Zhuo
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
Gerrit-Change-Number: 821221
Gerrit-PatchSet: 4
unsatisfied_requirement
satisfied_requirement
open
diffy

Joel Sing (Gerrit)

unread,
Sep 12, 2026, 12:43:02 AMSep 12
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Julian Zhu, Mark Ryan and Meng Zhuo

Joel Sing uploaded new patchset

Joel Sing uploaded patch set #6 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Julian Zhu
  • Mark Ryan
  • Meng Zhuo
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
Gerrit-Change-Number: 821221
Gerrit-PatchSet: 6
unsatisfied_requirement
satisfied_requirement
open
diffy

Joel Sing (Gerrit)

unread,
Sep 12, 2026, 12:43:42 AMSep 12
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Mark Ryan, Julian Zhu, Meng Zhuo, golang-co...@googlegroups.com
Attention needed from Julian Zhu, Mark Ryan and Meng Zhuo

Joel Sing voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Julian Zhu
  • Mark Ryan
  • Meng Zhuo
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
Gerrit-Change-Number: 821221
Gerrit-PatchSet: 6
Gerrit-Owner: Joel Sing <jo...@sing.id.au>
Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
Gerrit-Reviewer: Julian Zhu <jz53...@gmail.com>
Gerrit-Reviewer: Mark Ryan <mark...@meta.com>
Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Attention: Julian Zhu <jz53...@gmail.com>
Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Attention: Mark Ryan <mark...@meta.com>
Gerrit-Comment-Date: Sat, 12 Sep 2026 04:43:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Meng Zhuo (Gerrit)

unread,
Sep 23, 2026, 12:13:43 AMSep 23
to Joel Sing, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Mark Ryan, Julian Zhu, Meng Zhuo, golang-co...@googlegroups.com
Attention needed from Joel Sing, Julian Zhu and Mark Ryan

Meng Zhuo added 1 comment

File test/codegen/bits.go
Line 19, Patchset 6 (Latest): // riscv64/rva20u64:"SRLI [$]63," "ANDI [$]1," "BNEZ" -"MOV [$]"
Meng Zhuo . unresolved
```suggestion
	// riscv64/rva20u64,riscv64/rva22u64:"SRLI [$]63," "ANDI [$]1," "BNEZ" -"MOV [$]"
```
Open in Gerrit

Related details

Attention is currently required from:
  • Joel Sing
  • Julian Zhu
  • Mark Ryan
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
    Gerrit-Change-Number: 821221
    Gerrit-PatchSet: 6
    Gerrit-Owner: Joel Sing <jo...@sing.id.au>
    Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
    Gerrit-Reviewer: Julian Zhu <jz53...@gmail.com>
    Gerrit-Reviewer: Mark Ryan <mark...@meta.com>
    Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Attention: Julian Zhu <jz53...@gmail.com>
    Gerrit-Attention: Joel Sing <jo...@sing.id.au>
    Gerrit-Attention: Mark Ryan <mark...@meta.com>
    Gerrit-Comment-Date: Wed, 23 Sep 2026 04:13:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Joel Sing (Gerrit)

    unread,
    Oct 4, 2026, 8:00:43 AMOct 4
    to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Mark Ryan, Julian Zhu, Meng Zhuo, golang-co...@googlegroups.com
    Attention needed from Julian Zhu, Mark Ryan and Meng Zhuo

    Joel Sing added 1 comment

    File test/codegen/bits.go
    Line 19, Patchset 6 (Latest): // riscv64/rva20u64:"SRLI [$]63," "ANDI [$]1," "BNEZ" -"MOV [$]"
    Meng Zhuo . resolved
    ```suggestion
    	// riscv64/rva20u64,riscv64/rva22u64:"SRLI [$]63," "ANDI [$]1," "BNEZ" -"MOV [$]"
    ```
    Joel Sing

    This does not work as expected - the first entry is silently ignored and only the second entry is tested... I started fixing this, however it's a non-trivial amount of effort, which I'll pick up again at some point.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Julian Zhu
    • Mark Ryan
    • Meng Zhuo
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
      Gerrit-Change-Number: 821221
      Gerrit-PatchSet: 6
      Gerrit-Owner: Joel Sing <jo...@sing.id.au>
      Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
      Gerrit-Reviewer: Julian Zhu <jz53...@gmail.com>
      Gerrit-Reviewer: Mark Ryan <mark...@meta.com>
      Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Attention: Julian Zhu <jz53...@gmail.com>
      Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Attention: Mark Ryan <mark...@meta.com>
      Gerrit-Comment-Date: Sun, 04 Oct 2026 12:00:30 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Meng Zhuo <mengzh...@gmail.com>
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Julian Zhu (Gerrit)

      unread,
      Oct 5, 2026, 4:48:17 AMOct 5
      to Joel Sing, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Mark Ryan, Meng Zhuo, golang-co...@googlegroups.com
      Attention needed from Joel Sing, Mark Ryan and Meng Zhuo

      Julian Zhu added 1 comment

      File src/cmd/compile/internal/ssa/_gen/RISCV64latelower.rules
      Line 36, Patchset 6 (Latest):(ANDI [1] (SRLI [c] x)) && buildcfg.GORISCV64 >= 23 => (BEXTI [c] x)
      Julian Zhu . unresolved

      Do we need more a rule about `(ANDI [1] (SRLIW [c] x)) && buildcfg.GORISCV64 >= 23 => (BEXTI [c] x)` ?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Joel Sing
      • Mark Ryan
      • Meng Zhuo
      Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
        Gerrit-Change-Number: 821221
        Gerrit-PatchSet: 6
        Gerrit-Owner: Joel Sing <jo...@sing.id.au>
        Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
        Gerrit-Reviewer: Julian Zhu <jz53...@gmail.com>
        Gerrit-Reviewer: Mark Ryan <mark...@meta.com>
        Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Attention: Joel Sing <jo...@sing.id.au>
        Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Attention: Mark Ryan <mark...@meta.com>
        Gerrit-Comment-Date: Mon, 05 Oct 2026 08:48:10 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Mark Ryan (Gerrit)

        unread,
        Oct 6, 2026, 5:04:56 AMOct 6
        to Joel Sing, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Julian Zhu, Meng Zhuo, golang-co...@googlegroups.com
        Attention needed from Joel Sing and Meng Zhuo

        Mark Ryan added 2 comments

        File src/cmd/compile/internal/ssa/_gen/RISCV64latelower.rules
        Line 42, Patchset 6 (Latest):(B(EQ|NE)Z (ANDI [1] (SRLW x y)) yes no) && buildcfg.GORISCV64 >= 23 => (B(EQ|NE)Z (BEXT <typ.UInt64> x (ANDI <typ.UInt64> [31] y)) yes no)
        Mark Ryan . unresolved

        I'm not sure this rule is worth it as we end up with the same number of instructions, and actually more bytes. Here's what I get with this rule

        ```
          bits.go:343		0x11b29			01f57493		ANDI $31, X10, X9	
          bits.go:343		0x11b2d			4895d4b3		BEXT X9, X11, X9	
          bits.go:343		0x11b31			00048463		BEQZ X9, 2(PC)		
        ```

        and without

        ```
          bits.go:343		0x11b3b			00a5d4bb		SRLW X10, X11, X9	
          bits.go:343		0x11b3f			8588			ANDI $1, X9, X9		
          bits.go:343		0x11b41			00048463		BEQZ X9, 2(PC)		
        ```

        I hacked the function to remove the first check so the line numbers aren't correct.

        File test/codegen/bits.go
        Line 351, Patchset 6 (Latest): // riscv64/rva23u64:"ANDI [$]31," "BEXT" "BEQZ" -"SRL" -"AND "
        Mark Ryan . unresolved

        I think there's a space missing after the BEXT instruction, i.e., we've got

        "BEXT"

        but we want

        "BEXT "

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Joel Sing
        • Meng Zhuo
        Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
        Gerrit-Change-Number: 821221
        Gerrit-PatchSet: 6
        Gerrit-Owner: Joel Sing <jo...@sing.id.au>
        Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
        Gerrit-Reviewer: Julian Zhu <jz53...@gmail.com>
        Gerrit-Reviewer: Mark Ryan <mark...@meta.com>
        Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Attention: Joel Sing <jo...@sing.id.au>
        Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Comment-Date: Tue, 06 Oct 2026 09:04:44 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Joel Sing (Gerrit)

        unread,
        Oct 14, 2026, 3:10:56 AM (9 days ago) Oct 14
        to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
        Attention needed from Joel Sing and Meng Zhuo

        Joel Sing uploaded new patchset

        Joel Sing <jo...@sing.id.au> uploaded patch set #7 to this change.
        Following approvals got outdated and were removed:

        Related details

        Attention is currently required from:
        • Joel Sing
        • Meng Zhuo
        Submit Requirements:
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement is not satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: newpatchset
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
          Gerrit-Change-Number: 821221
          Gerrit-PatchSet: 7
          Gerrit-Owner: Joel Sing <jo...@sing.id.au>
          Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
          Gerrit-Reviewer: Julian Zhu <jz53...@gmail.com>
          Gerrit-Reviewer: Mark Ryan <marku...@gmail.com>
          unsatisfied_requirement
          open
          diffy

          Joel Sing (Gerrit)

          unread,
          Oct 14, 2026, 3:21:44 AM (9 days ago) Oct 14
          to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Mark Ryan, Julian Zhu, Meng Zhuo, golang-co...@googlegroups.com
          Attention needed from Julian Zhu, Mark Ryan and Meng Zhuo

          Joel Sing voted and added 3 comments

          Votes added by Joel Sing <jo...@sing.id.au>

          Commit-Queue+1

          3 comments

          File src/cmd/compile/internal/ssa/_gen/RISCV64latelower.rules
          Line 36, Patchset 6:(ANDI [1] (SRLI [c] x)) && buildcfg.GORISCV64 >= 23 => (BEXTI [c] x)
          Julian Zhu . resolved

          Do we need more a rule about `(ANDI [1] (SRLIW [c] x)) && buildcfg.GORISCV64 >= 23 => (BEXTI [c] x)` ?

          Joel Sing

          Good call.

          Line 42, Patchset 6:(B(EQ|NE)Z (ANDI [1] (SRLW x y)) yes no) && buildcfg.GORISCV64 >= 23 => (B(EQ|NE)Z (BEXT <typ.UInt64> x (ANDI <typ.UInt64> [31] y)) yes no)
          Mark Ryan . resolved

          I'm not sure this rule is worth it as we end up with the same number of instructions, and actually more bytes. Here's what I get with this rule

          ```
            bits.go:343		0x11b29			01f57493		ANDI $31, X10, X9	
            bits.go:343		0x11b2d			4895d4b3		BEXT X9, X11, X9	
            bits.go:343		0x11b31			00048463		BEQZ X9, 2(PC)		
          ```

          and without

          ```
            bits.go:343		0x11b3b			00a5d4bb		SRLW X10, X11, X9	
            bits.go:343		0x11b3f			8588			ANDI $1, X9, X9		
            bits.go:343		0x11b41			00048463		BEQZ X9, 2(PC)		
          ```

          I hacked the function to remove the first check so the line numbers aren't correct.

          Joel Sing

          Fair - there is a small possibility that the ANDI can be eliminated, but not guaranteed. This also points out that we can optimise register based shifts more broadly - have raised https://go-review.googlesource.com/c/go/+/849005 for this (although I don't seem to be able to add you as a reviewer currently).

          File test/codegen/bits.go
          Line 351, Patchset 6: // riscv64/rva23u64:"ANDI [$]31," "BEXT" "BEQZ" -"SRL" -"AND "
          Mark Ryan . resolved

          I think there's a space missing after the BEXT instruction, i.e., we've got

          "BEXT"

          but we want

          "BEXT "

          Joel Sing

          Acknowledged

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Julian Zhu
          • Mark Ryan
          • Meng Zhuo
          Submit Requirements:
            • requirement is not satisfiedCode-Review
            • requirement satisfiedNo-Unresolved-Comments
            • requirement is not satisfiedReview-Enforcement
            • requirement is not satisfiedTryBots-Pass
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: go
            Gerrit-Branch: master
            Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
            Gerrit-Change-Number: 821221
            Gerrit-PatchSet: 7
            Gerrit-Owner: Joel Sing <jo...@sing.id.au>
            Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
            Gerrit-Reviewer: Julian Zhu <jz53...@gmail.com>
            Gerrit-Reviewer: Mark Ryan <marku...@gmail.com>
            Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
            Gerrit-Attention: Julian Zhu <jz53...@gmail.com>
            Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
            Gerrit-Attention: Mark Ryan <marku...@gmail.com>
            Gerrit-Comment-Date: Wed, 14 Oct 2026 07:21:20 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            Comment-In-Reply-To: Julian Zhu <jz53...@gmail.com>
            Comment-In-Reply-To: Mark Ryan <marku...@gmail.com>
            unsatisfied_requirement
            satisfied_requirement
            open
            diffy

            Joel Sing (Gerrit)

            unread,
            Oct 14, 2026, 3:24:50 AM (9 days ago) Oct 14
            to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Mark Ryan, Julian Zhu, Meng Zhuo, golang-co...@googlegroups.com
            Attention needed from Julian Zhu, Mark Ryan and Meng Zhuo

            Joel Sing voted Commit-Queue+1

            Commit-Queue+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Julian Zhu
            • Mark Ryan
            • Meng Zhuo
            Submit Requirements:
            • requirement is not satisfiedCode-Review
            • requirement satisfiedNo-Unresolved-Comments
            • requirement is not satisfiedReview-Enforcement
            • requirement is not satisfiedTryBots-Pass
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: go
            Gerrit-Branch: master
            Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
            Gerrit-Change-Number: 821221
            Gerrit-PatchSet: 8
            Gerrit-Owner: Joel Sing <jo...@sing.id.au>
            Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
            Gerrit-Reviewer: Julian Zhu <jz53...@gmail.com>
            Gerrit-Reviewer: Mark Ryan <marku...@gmail.com>
            Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
            Gerrit-Attention: Julian Zhu <jz53...@gmail.com>
            Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
            Gerrit-Attention: Mark Ryan <marku...@gmail.com>
            Gerrit-Comment-Date: Wed, 14 Oct 2026 07:24:27 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            unsatisfied_requirement
            satisfied_requirement
            open
            diffy

            Julian Zhu (Gerrit)

            unread,
            Oct 14, 2026, 7:15:27 AM (9 days ago) Oct 14
            to Joel Sing, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Mark Ryan, Meng Zhuo, golang-co...@googlegroups.com
            Attention needed from Joel Sing

            Julian Zhu added 1 comment

            File src/cmd/compile/internal/ssa/_gen/RISCV64latelower.rules
            Line 41, Patchset 8 (Latest):(SNEZ (ANDI [1] (SRLI [c] x))) && buildcfg.GORISCV64 >= 23 => (BEXTI [c] x)
            Julian Zhu . unresolved

            This rule will never be triggered since it was covered by CL 849005

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Joel Sing
            Submit Requirements:
              • requirement is not satisfiedCode-Review
              • requirement is not satisfiedNo-Unresolved-Comments
              • requirement is not satisfiedReview-Enforcement
              • requirement satisfiedTryBots-Pass
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: go
              Gerrit-Branch: master
              Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
              Gerrit-Change-Number: 821221
              Gerrit-PatchSet: 8
              Gerrit-Owner: Joel Sing <jo...@sing.id.au>
              Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
              Gerrit-Reviewer: Julian Zhu <jz53...@gmail.com>
              Gerrit-Reviewer: Mark Ryan <marku...@gmail.com>
              Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
              Gerrit-Attention: Joel Sing <jo...@sing.id.au>
              Gerrit-Comment-Date: Wed, 14 Oct 2026 11:15:13 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: No
              unsatisfied_requirement
              satisfied_requirement
              open
              diffy

              Joel Sing (Gerrit)

              unread,
              Oct 15, 2026, 3:14:03 AM (8 days ago) Oct 15
              to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
              Attention needed from Joel Sing

              Joel Sing uploaded new patchset

              Joel Sing <jo...@sing.id.au> uploaded patch set #9 to this change.
              Following approvals got outdated and were removed:

              Related details

              Attention is currently required from:
              • Joel Sing
              Submit Requirements:
                • requirement is not satisfiedCode-Review
                • requirement is not satisfiedNo-Unresolved-Comments
                • requirement is not satisfiedReview-Enforcement
                • requirement is not satisfiedTryBots-Pass
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: newpatchset
                Gerrit-Project: go
                Gerrit-Branch: master
                Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
                Gerrit-Change-Number: 821221
                Gerrit-PatchSet: 9
                unsatisfied_requirement
                open
                diffy

                Joel Sing (Gerrit)

                unread,
                Oct 15, 2026, 3:15:03 AM (8 days ago) Oct 15
                to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Mark Ryan, Julian Zhu, Meng Zhuo, golang-co...@googlegroups.com
                Attention needed from Julian Zhu

                Joel Sing voted and added 1 comment

                Votes added by Joel Sing <jo...@sing.id.au>

                Commit-Queue+1

                1 comment

                File src/cmd/compile/internal/ssa/_gen/RISCV64latelower.rules
                Line 41, Patchset 8:(SNEZ (ANDI [1] (SRLI [c] x))) && buildcfg.GORISCV64 >= 23 => (BEXTI [c] x)
                Julian Zhu . resolved

                This rule will never be triggered since it was covered by CL 849005

                Joel Sing

                Indeed, removed.

                Open in Gerrit

                Related details

                Attention is currently required from:
                • Julian Zhu
                Submit Requirements:
                  • requirement is not satisfiedCode-Review
                  • requirement satisfiedNo-Unresolved-Comments
                  • requirement is not satisfiedReview-Enforcement
                  • requirement is not satisfiedTryBots-Pass
                  Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                  Gerrit-MessageType: comment
                  Gerrit-Project: go
                  Gerrit-Branch: master
                  Gerrit-Change-Id: I96a6b4cb0947f6145556f79a61cc368ee12b247c
                  Gerrit-Change-Number: 821221
                  Gerrit-PatchSet: 9
                  Gerrit-Owner: Joel Sing <jo...@sing.id.au>
                  Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
                  Gerrit-Reviewer: Julian Zhu <jz53...@gmail.com>
                  Gerrit-Reviewer: Mark Ryan <marku...@gmail.com>
                  Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
                  Gerrit-Attention: Julian Zhu <jz53...@gmail.com>
                  Gerrit-Comment-Date: Thu, 15 Oct 2026 07:14:36 +0000
                  unsatisfied_requirement
                  satisfied_requirement
                  open
                  diffy
                  Reply all
                  Reply to author
                  Forward
                  0 new messages