[build] devapp/owners: remove Rob Pike from various packages

1 view
Skip to first unread message

Russ Cox (Gerrit)

unread,
Jun 30, 2026, 10:06:16 AM (14 hours ago) Jun 30
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Russ Cox, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov

Russ Cox has uploaded the change for review

Russ Cox would like Dmitri Shuralyov to review this change.

Commit message

devapp/owners: remove Rob Pike from various packages

At Rob's request, remove him as owner from various packages.
Change-Id: I37c94b8b8accd6e2a2c73da9ed2ce3eb08ddfc27

Change diff

diff --git a/devapp/owners/table.go b/devapp/owners/table.go
index b3b6eb7..75fbd59 100644
--- a/devapp/owners/table.go
+++ b/devapp/owners/table.go
@@ -186,7 +186,7 @@
 		Secondary: []Owner{compilerTeam},
 	},
 	"go/src/cmd/doc": {
-		Primary: []Owner{r},
+		Primary: []Owner{commandlineTeam},
 	},
 	"go/src/cmd/go": {
 		Primary: []Owner{commandlineTeam},
@@ -361,7 +361,6 @@
 		Primary: []Owner{r},
 	},
 	"go/src/fmt": {
-		// Same as internal/fmtsort.
 		Primary:   []Owner{r},
 		Secondary: []Owner{martisch},
 	},
@@ -421,8 +420,7 @@
 		Primary: []Owner{securityTeam},
 	},
 	"go/src/image": {
-		Primary:   []Owner{nigeltao},
-		Secondary: []Owner{r},
+		Primary: []Owner{nigeltao},
 	},
 	"go/src/index/suffixarray": {
 		Primary: []Owner{gri},
@@ -488,8 +486,7 @@
 		Secondary: []Owner{neild},
 	},
 	"go/src/internal/fmtsort": {
-		// Same as fmt.
-		Primary:   []Owner{r},
+		Primary:   []Owner{runtimeTeam},
 		Secondary: []Owner{martisch},
 	},
 	"go/src/internal/fuzz": {
@@ -691,7 +688,7 @@
 		Secondary: []Owner{iant, bradfitz},
 	},
 	"go/src/log": {
-		Primary: []Owner{r},
+		Primary: []Owner{jba},
 	},
 	"go/src/log/slog": {
 		Primary: []Owner{jba},
@@ -744,10 +741,10 @@
 		Secondary: []Owner{bradfitz},
 	},
 	"go/src/net/rpc": {
-		Primary: []Owner{r},
+		Primary: []Owner{rsc},
 	},
 	"go/src/net/rpc/jsonrpc": {
-		Primary: []Owner{r},
+		Primary: []Owner{rsc},
 	},
 	"go/src/net/smtp": {
 		Primary:   []Owner{},
@@ -776,10 +773,10 @@
 		Secondary: []Owner{kevinburke},
 	},
 	"go/src/path": {
-		Primary: []Owner{r, rsc},
+		Primary: []Owner{rsc},
 	},
 	"go/src/path/filepath": {
-		Primary: []Owner{r, rsc},
+		Primary: []Owner{rsc},
 	},
 	"go/src/plugin": {
 		Primary:   []Owner{runtimeTeam},
@@ -874,7 +871,7 @@
 		Primary: []Owner{rsc},
 	},
 	"go/src/unicode": {
-		Primary:   []Owner{securityTeam, r},
+		Primary:   []Owner{securityTeam},
 		Secondary: []Owner{mpvl},
 	},
 	"go/src/unicode/utf16": {

Change information

Files:
  • M devapp/owners/table.go
Change size: S
Delta: 1 file changed, 9 insertions(+), 12 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Dmitri Shuralyov
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I37c94b8b8accd6e2a2c73da9ed2ce3eb08ddfc27
Gerrit-Change-Number: 795700
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
unsatisfied_requirement
satisfied_requirement
open
diffy

Russ Cox (Gerrit)

unread,
Jun 30, 2026, 10:06:52 AM (14 hours ago) Jun 30
to Russ Cox, goph...@pubsubhelper.golang.org, Rob Pike, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov

Russ Cox voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dmitri Shuralyov
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I37c94b8b8accd6e2a2c73da9ed2ce3eb08ddfc27
Gerrit-Change-Number: 795700
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Russ Cox <r...@golang.org>
Gerrit-CC: Rob Pike <r...@golang.org>
Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Comment-Date: Tue, 30 Jun 2026 14:06:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
Jun 30, 2026, 10:32:24 AM (14 hours ago) Jun 30
to Russ Cox, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Rob Pike, golang-co...@googlegroups.com
Attention needed from Russ Cox

Dmitri Shuralyov voted and added 2 comments

Votes added by Dmitri Shuralyov

Code-Review+2

2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Dmitri Shuralyov . resolved

Thanks.

File devapp/owners/table.go
Line 188, Patchset 1 (Latest): "go/src/cmd/doc": {
Dmitri Shuralyov . unresolved

cmd/doc was deleted in CL 689835 ('go doc' continues to handle its functionality), so this entire entry can also be removed.

Open in Gerrit

Related details

Attention is currently required from:
  • Russ Cox
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I37c94b8b8accd6e2a2c73da9ed2ce3eb08ddfc27
Gerrit-Change-Number: 795700
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Russ Cox <r...@golang.org>
Gerrit-CC: Rob Pike <r...@golang.org>
Gerrit-Attention: Russ Cox <r...@golang.org>
Gerrit-Comment-Date: Tue, 30 Jun 2026 14:32:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
Jun 30, 2026, 10:33:19 AM (14 hours ago) Jun 30
to Russ Cox, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Rob Pike, golang-co...@googlegroups.com
Attention needed from Russ Cox

Dmitri Shuralyov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Russ Cox
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: build
    Gerrit-Branch: master
    Gerrit-Change-Id: I37c94b8b8accd6e2a2c73da9ed2ce3eb08ddfc27
    Gerrit-Change-Number: 795700
    Gerrit-PatchSet: 1
    Gerrit-Owner: Russ Cox <r...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
    Gerrit-Reviewer: Russ Cox <r...@golang.org>
    Gerrit-CC: Rob Pike <r...@golang.org>
    Gerrit-Attention: Russ Cox <r...@golang.org>
    Gerrit-Comment-Date: Tue, 30 Jun 2026 14:32:37 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Russ Cox (Gerrit)

    unread,
    Jun 30, 2026, 3:24:49 PM (9 hours ago) Jun 30
    to Russ Cox, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Russ Cox

    Russ Cox uploaded new patchset

    Russ Cox uploaded patch set #2 to this change.
    Following approvals got outdated and were removed:
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Russ Cox
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: build
    Gerrit-Branch: master
    Gerrit-Change-Id: I37c94b8b8accd6e2a2c73da9ed2ce3eb08ddfc27
    Gerrit-Change-Number: 795700
    Gerrit-PatchSet: 2
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Russ Cox (Gerrit)

    unread,
    Jun 30, 2026, 3:24:49 PM (9 hours ago) Jun 30
    to Russ Cox, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Rob Pike, golang-co...@googlegroups.com
    Attention needed from Russ Cox

    Russ Cox added 1 comment

    File devapp/owners/table.go
    Line 188, Patchset 1: "go/src/cmd/doc": {
    Dmitri Shuralyov . resolved

    cmd/doc was deleted in CL 689835 ('go doc' continues to handle its functionality), so this entire entry can also be removed.

    Russ Cox

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Russ Cox
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: build
    Gerrit-Branch: master
    Gerrit-Change-Id: I37c94b8b8accd6e2a2c73da9ed2ce3eb08ddfc27
    Gerrit-Change-Number: 795700
    Gerrit-PatchSet: 2
    Gerrit-Owner: Russ Cox <r...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
    Gerrit-Reviewer: Russ Cox <r...@golang.org>
    Gerrit-CC: Rob Pike <r...@golang.org>
    Gerrit-Attention: Russ Cox <r...@golang.org>
    Gerrit-Comment-Date: Tue, 30 Jun 2026 19:24:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Dmitri Shuralyov <dmit...@golang.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Russ Cox (Gerrit)

    unread,
    Jun 30, 2026, 4:05:17 PM (8 hours ago) Jun 30
    to Russ Cox, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Rob Pike, golang-co...@googlegroups.com

    Russ Cox voted

    Auto-Submit+1
    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: build
    Gerrit-Branch: master
    Gerrit-Change-Id: I37c94b8b8accd6e2a2c73da9ed2ce3eb08ddfc27
    Gerrit-Change-Number: 795700
    Gerrit-PatchSet: 2
    Gerrit-Owner: Russ Cox <r...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
    Gerrit-Reviewer: Russ Cox <r...@golang.org>
    Gerrit-CC: Rob Pike <r...@golang.org>
    Gerrit-Comment-Date: Tue, 30 Jun 2026 20:05:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gopher Robot (Gerrit)

    unread,
    Jun 30, 2026, 4:19:33 PM (8 hours ago) Jun 30
    to Russ Cox, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Dmitri Shuralyov, Rob Pike, golang-co...@googlegroups.com

    Gopher Robot submitted the change with unreviewed changes

    Unreviewed changes

    1 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: devapp/owners/table.go
    Insertions: 0, Deletions: 3.

    @@ -185,9 +185,6 @@
     		Primary:   []Owner{thanm},

     		Secondary: []Owner{compilerTeam},
     	},
    -	"go/src/cmd/doc": {
    -		Primary: []Owner{commandlineTeam},
    -	},

     	"go/src/cmd/go": {
     		Primary: []Owner{commandlineTeam},
     	},
    ```

    Change information

    Commit message:
    devapp/owners: remove Rob Pike from various packages

    At Rob's request, remove him as owner from various packages.
    cmd/doc is no more, so delete it outright.
    Change-Id: I37c94b8b8accd6e2a2c73da9ed2ce3eb08ddfc27
    Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>
    Auto-Submit: Russ Cox <r...@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
    Files:
    • M devapp/owners/table.go
    Change size: S
    Delta: 1 file changed, 8 insertions(+), 14 deletions(-)
    Branch: refs/heads/master
    Submit Requirements:
     Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: merged 
    

     Gerrit-Project: build 
    

     Gerrit-Branch: master 
    

     Gerrit-Change-Id: I37c94b8b8accd6e2a2c73da9ed2ce3eb08ddfc27 
    

     Gerrit-Change-Number: 795700 
    

     Gerrit-PatchSet: 3 
    

     Gerrit-Owner: Russ Cox <r...@golang.org> 
    

     Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org> 
    

     Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com> 
    

     Gerrit-Reviewer: Gopher Robot <go...@golang.org> 
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages