Meidan Li (Gerrit)

unread,

Feb 24, 2026, 2:54:34 AM (yesterday) Feb 24

to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Meidan Li has uploaded the change for review

Commit message

cmd/link, cmd/internal: remove the R_JMPLOONG64 relocation of loong64

R_JMPLOONG64 and R_CALLLOONG64 have the same functionality, and R_JMPLOONG64 is not used.

Change-Id: Id6ac0bfa67025de45f9c51349931142d945134d7

Change diff

diff --git a/src/cmd/internal/obj/fips140.go b/src/cmd/internal/obj/fips140.go
index 8f5b0c4..b888396 100644
--- a/src/cmd/internal/obj/fips140.go
+++ b/src/cmd/internal/obj/fips140.go
@@ -366,7 +366,6 @@
 		objabi.R_LOONG64_GOT_LO,
 		objabi.R_JMP16LOONG64,
 		objabi.R_JMP21LOONG64,
-		objabi.R_JMPLOONG64,
 		objabi.R_PCREL,
 		objabi.R_PCRELDBL,
 		objabi.R_POWER_TLS_LE,
diff --git a/src/cmd/internal/objabi/reloctype.go b/src/cmd/internal/objabi/reloctype.go
index aef8900..8e95b5d 100644
--- a/src/cmd/internal/objabi/reloctype.go
+++ b/src/cmd/internal/objabi/reloctype.go
@@ -377,10 +377,6 @@
 	// address of a BEQZ/BNEZ instruction, by encoding it into the instruction.
 	R_JMP21LOONG64
 
-	// R_JMPLOONG64 resolves to the 28-bit 4-byte aligned PC-relative target
-	// address of a B instruction, by encoding it into the instruction.
-	R_JMPLOONG64
-
 	// R_ADDRMIPSU (only used on mips/mips64) resolves to the sign-adjusted "upper" 16
 	// bits (bit 16-31) of an external address, by encoding it into the instruction.
 	R_ADDRMIPSU
@@ -459,8 +455,6 @@
 	switch r {
 	case R_JMPMIPS:
 		return true
-	case R_JMPLOONG64:
-		return true
 	}
 	return false
 }
diff --git a/src/cmd/internal/objabi/reloctype_string.go b/src/cmd/internal/objabi/reloctype_string.go
index 9137bae..4152afd 100644
--- a/src/cmd/internal/objabi/reloctype_string.go
+++ b/src/cmd/internal/objabi/reloctype_string.go
@@ -99,23 +99,22 @@
 	_ = x[R_LOONG64_SUB64-89]
 	_ = x[R_JMP16LOONG64-90]
 	_ = x[R_JMP21LOONG64-91]
-	_ = x[R_JMPLOONG64-92]
-	_ = x[R_ADDRMIPSU-93]
-	_ = x[R_ADDRMIPSTLS-94]
-	_ = x[R_ADDRCUOFF-95]
-	_ = x[R_WASMIMPORT-96]
-	_ = x[R_XCOFFREF-97]
-	_ = x[R_PEIMAGEOFF-98]
-	_ = x[R_INITORDER-99]
-	_ = x[R_DWTXTADDR_U1-100]
-	_ = x[R_DWTXTADDR_U2-101]
-	_ = x[R_DWTXTADDR_U3-102]
-	_ = x[R_DWTXTADDR_U4-103]
+	_ = x[R_ADDRMIPSU-92]
+	_ = x[R_ADDRMIPSTLS-93]
+	_ = x[R_ADDRCUOFF-94]
+	_ = x[R_WASMIMPORT-95]
+	_ = x[R_XCOFFREF-96]
+	_ = x[R_PEIMAGEOFF-97]
+	_ = x[R_INITORDER-98]
+	_ = x[R_DWTXTADDR_U1-99]
+	_ = x[R_DWTXTADDR_U2-100]
+	_ = x[R_DWTXTADDR_U3-101]
+	_ = x[R_DWTXTADDR_U4-102]
 }
 
-const _RelocType_name = "R_ADDRR_ADDRPOWERR_ADDRARM64R_ADDRMIPSR_ADDROFFR_SIZER_CALLR_CALLARMR_CALLARM64R_CALLINDR_CALLPOWERR_CALLMIPSR_CONSTR_PCRELR_TLS_LER_TLS_IER_GOTOFFR_PLT0R_PLT1R_PLT2R_USEFIELDR_USETYPER_USEIFACER_USEIFACEMETHODR_USENAMEDMETHODR_METHODOFFR_KEEPR_POWER_TOCR_GOTPCRELR_JMPMIPSR_DWARFSECREFR_ARM64_TLS_LER_ARM64_TLS_IER_ARM64_GOTPCRELR_ARM64_GOTR_ARM64_PCRELR_ARM64_PCREL_LDST8R_ARM64_PCREL_LDST16R_ARM64_PCREL_LDST32R_ARM64_PCREL_LDST64R_ARM64_LDST8R_ARM64_LDST16R_ARM64_LDST32R_ARM64_LDST64R_ARM64_LDST128R_POWER_TLS_LER_POWER_TLS_IER_POWER_TLSR_POWER_TLS_IE_PCREL34R_POWER_TLS_LE_TPREL34R_ADDRPOWER_DSR_ADDRPOWER_GOTR_ADDRPOWER_GOT_PCREL34R_ADDRPOWER_PCRELR_ADDRPOWER_TOCRELR_ADDRPOWER_TOCREL_DSR_ADDRPOWER_D34R_ADDRPOWER_PCREL34R_RISCV_JALR_RISCV_JAL_TRAMPR_RISCV_CALLR_RISCV_PCREL_ITYPER_RISCV_PCREL_STYPER_RISCV_TLS_IER_RISCV_TLS_LER_RISCV_GOT_HI20R_RISCV_GOT_PCREL_ITYPER_RISCV_PCREL_HI20R_RISCV_PCREL_LO12_IR_RISCV_PCREL_LO12_SR_RISCV_BRANCHR_RISCV_ADD32R_RISCV_SUB32R_RISCV_RVC_BRANCHR_RISCV_RVC_JUMPR_PCRELDBLR_LOONG64_ADDR_HIR_LOONG64_ADDR_LOR_LOONG64_ADDR_PCREL20_S2R_LOONG64_TLS_LE_HIR_LOONG64_TLS_LE_LOR_CALLLOONG64R_LOONG64_CALL36R_LOONG64_TLS_IE_HIR_LOONG64_TLS_IE_LOR_LOONG64_GOT_HIR_LOONG64_GOT_LOR_LOONG64_ADD64R_LOONG64_SUB64R_JMP16LOONG64R_JMP21LOONG64R_JMPLOONG64R_ADDRMIPSUR_ADDRMIPSTLSR_ADDRCUOFFR_WASMIMPORTR_XCOFFREFR_PEIMAGEOFFR_INITORDERR_DWTXTADDR_U1R_DWTXTADDR_U2R_DWTXTADDR_U3R_DWTXTADDR_U4"
+const _RelocType_name = "R_ADDRR_ADDRPOWERR_ADDRARM64R_ADDRMIPSR_ADDROFFR_SIZER_CALLR_CALLARMR_CALLARM64R_CALLINDR_CALLPOWERR_CALLMIPSR_CONSTR_PCRELR_TLS_LER_TLS_IER_GOTOFFR_PLT0R_PLT1R_PLT2R_USEFIELDR_USETYPER_USEIFACER_USEIFACEMETHODR_USENAMEDMETHODR_METHODOFFR_KEEPR_POWER_TOCR_GOTPCRELR_JMPMIPSR_DWARFSECREFR_ARM64_TLS_LER_ARM64_TLS_IER_ARM64_GOTPCRELR_ARM64_GOTR_ARM64_PCRELR_ARM64_PCREL_LDST8R_ARM64_PCREL_LDST16R_ARM64_PCREL_LDST32R_ARM64_PCREL_LDST64R_ARM64_LDST8R_ARM64_LDST16R_ARM64_LDST32R_ARM64_LDST64R_ARM64_LDST128R_POWER_TLS_LER_POWER_TLS_IER_POWER_TLSR_POWER_TLS_IE_PCREL34R_POWER_TLS_LE_TPREL34R_ADDRPOWER_DSR_ADDRPOWER_GOTR_ADDRPOWER_GOT_PCREL34R_ADDRPOWER_PCRELR_ADDRPOWER_TOCRELR_ADDRPOWER_TOCREL_DSR_ADDRPOWER_D34R_ADDRPOWER_PCREL34R_RISCV_JALR_RISCV_JAL_TRAMPR_RISCV_CALLR_RISCV_PCREL_ITYPER_RISCV_PCREL_STYPER_RISCV_TLS_IER_RISCV_TLS_LER_RISCV_GOT_HI20R_RISCV_GOT_PCREL_ITYPER_RISCV_PCREL_HI20R_RISCV_PCREL_LO12_IR_RISCV_PCREL_LO12_SR_RISCV_BRANCHR_RISCV_ADD32R_RISCV_SUB32R_RISCV_RVC_BRANCHR_RISCV_RVC_JUMPR_PCRELDBLR_LOONG64_ADDR_HIR_LOONG64_ADDR_LOR_LOONG64_ADDR_PCREL20_S2R_LOONG64_TLS_LE_HIR_LOONG64_TLS_LE_LOR_CALLLOONG64R_LOONG64_CALL36R_LOONG64_TLS_IE_HIR_LOONG64_TLS_IE_LOR_LOONG64_GOT_HIR_LOONG64_GOT_LOR_LOONG64_ADD64R_LOONG64_SUB64R_JMP16LOONG64R_JMP21LOONG64R_ADDRMIPSUR_ADDRMIPSTLSR_ADDRCUOFFR_WASMIMPORTR_XCOFFREFR_PEIMAGEOFFR_INITORDERR_DWTXTADDR_U1R_DWTXTADDR_U2R_DWTXTADDR_U3R_DWTXTADDR_U4"
 
-var _RelocType_index = [...]uint16{0, 6, 17, 28, 38, 47, 53, 59, 68, 79, 88, 99, 109, 116, 123, 131, 139, 147, 153, 159, 165, 175, 184, 194, 210, 226, 237, 243, 254, 264, 273, 286, 300, 314, 330, 341, 354, 373, 393, 413, 433, 446, 460, 474, 488, 503, 517, 531, 542, 564, 586, 600, 615, 638, 655, 673, 694, 709, 728, 739, 756, 768, 787, 806, 820, 834, 850, 873, 891, 911, 931, 945, 958, 971, 989, 1005, 1015, 1032, 1049, 1074, 1093, 1112, 1125, 1141, 1160, 1179, 1195, 1211, 1226, 1241, 1255, 1269, 1281, 1292, 1305, 1316, 1328, 1338, 1350, 1361, 1375, 1389, 1403, 1417}
+var _RelocType_index = [...]uint16{0, 6, 17, 28, 38, 47, 53, 59, 68, 79, 88, 99, 109, 116, 123, 131, 139, 147, 153, 159, 165, 175, 184, 194, 210, 226, 237, 243, 254, 264, 273, 286, 300, 314, 330, 341, 354, 373, 393, 413, 433, 446, 460, 474, 488, 503, 517, 531, 542, 564, 586, 600, 615, 638, 655, 673, 694, 709, 728, 739, 756, 768, 787, 806, 820, 834, 850, 873, 891, 911, 931, 945, 958, 971, 989, 1005, 1015, 1032, 1049, 1074, 1093, 1112, 1125, 1141, 1160, 1179, 1195, 1211, 1226, 1241, 1255, 1269, 1280, 1293, 1304, 1316, 1326, 1338, 1349, 1363, 1377, 1391, 1405}
 
 func (i RelocType) String() string {
 	i -= 1
diff --git a/src/cmd/link/internal/loong64/asm.go b/src/cmd/link/internal/loong64/asm.go
index 142578b..9881e37 100644
--- a/src/cmd/link/internal/loong64/asm.go
+++ b/src/cmd/link/internal/loong64/asm.go
@@ -497,7 +497,6 @@
 			objabi.R_LOONG64_TLS_LE_LO,
 			objabi.R_CALLLOONG64,
 			objabi.R_LOONG64_CALL36,
-			objabi.R_JMPLOONG64,
 			objabi.R_LOONG64_TLS_IE_HI,
 			objabi.R_LOONG64_TLS_IE_LO,
 			objabi.R_LOONG64_GOT_HI,
@@ -533,8 +532,7 @@
 			return val&0xffc003ff | ((t & 0xfff) << 10), noExtReloc, isOk
 		}
 		return val&0xfe00001f | (((t) >> 12 << 5) & 0x1ffffe0), noExtReloc, isOk
-	case objabi.R_CALLLOONG64,
-		objabi.R_JMPLOONG64:
+	case objabi.R_CALLLOONG64:
 		pc := ldr.SymValue(s) + int64(r.Off())
 		t := ldr.SymAddr(rs) + r.Add() - pc
 		return val&0xfc000000 | (((t >> 2) & 0xffff) << 10) | (((t >> 2) & 0x3ff0000) >> 16), noExtReloc, isOk
@@ -600,7 +598,6 @@
 		objabi.R_CONST,
 		objabi.R_GOTOFF,
 		objabi.R_CALLLOONG64,
-		objabi.R_JMPLOONG64,
 		objabi.R_LOONG64_TLS_IE_HI,
 		objabi.R_LOONG64_TLS_IE_LO:
 		return ld.ExtrelocSimple(ldr, r), true

Change information

Files:

M src/cmd/internal/obj/fips140.go
M src/cmd/internal/objabi/reloctype.go
M src/cmd/internal/objabi/reloctype_string.go
M src/cmd/link/internal/loong64/asm.go

Change size: S

Delta: 4 files changed, 14 insertions(+), 25 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

abner chenc (Gerrit)

unread,

Feb 24, 2026, 8:05:18 AM (21 hours ago) Feb 24

to Meidan Li, goph...@pubsubhelper.golang.org, Cherry Mui, Ian Lance Taylor, Russ Cox, Gopher Robot, golang-co...@googlegroups.com

Attention needed from Cherry Mui, Ian Lance Taylor, Meidan Li and Russ Cox

abner chenc voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Cherry Mui
Ian Lance Taylor
Meidan Li
Russ Cox

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

abner chenc (Gerrit)

unread,

Feb 24, 2026, 8:05:28 PM (9 hours ago) Feb 24

to Meidan Li, goph...@pubsubhelper.golang.org, Go LUCI, Cherry Mui, Ian Lance Taylor, Russ Cox, Gopher Robot, golang-co...@googlegroups.com

Attention needed from Cherry Mui, Ian Lance Taylor, Meidan Li and Russ Cox

abner chenc voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

Cherry Mui
Ian Lance Taylor
Meidan Li
Russ Cox

Submit Requirements:

Code-Review

No-Unresolved-Comments
Review-Enforcement

TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Cherry Mui (Gerrit)

unread,

Feb 24, 2026, 8:16:31 PM (9 hours ago) Feb 24

to Meidan Li, goph...@pubsubhelper.golang.org, abner chenc, Go LUCI, Ian Lance Taylor, Russ Cox, Gopher Robot, golang-co...@googlegroups.com

Attention needed from Ian Lance Taylor, Meidan Li and Russ Cox

Cherry Mui voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

Ian Lance Taylor
Meidan Li
Russ Cox

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[go] cmd/link, cmd/internal: remove the R_JMPLOONG64 relocation of loong64

Meidan Li (Gerrit)

Meidan Li has uploaded the change for review

Commit message

Change diff

Change information

Related details

abner chenc (Gerrit)

abner chenc voted Commit-Queue+1

Related details

abner chenc (Gerrit)

abner chenc voted Code-Review+2

Related details

Cherry Mui (Gerrit)

Cherry Mui voted Code-Review+2

Related details