[go] cmd/compile: elide sign-extend after zero-extend for wasm

0 views
Skip to first unread message

George Adams (Gerrit)

unread,
5:21 AM (10 hours ago) 5:21 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

George Adams voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ia54d67358756e47ca7635a6a8ca4beadb003820a
Gerrit-Change-Number: 756320
Gerrit-PatchSet: 1
Gerrit-Owner: George Adams <georgea...@gmail.com>
Gerrit-Reviewer: George Adams <georgea...@gmail.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 09:20:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Keith Randall (Gerrit)

unread,
1:56 PM (2 hours ago) 1:56 PM
to George Adams, goph...@pubsubhelper.golang.org, Keith Randall, Go LUCI, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com
Attention needed from George Adams and Martin Möhrmann

Keith Randall voted and added 1 comment

Votes added by Keith Randall

Auto-Submit+1
Code-Review+2

1 comment

File src/cmd/compile/internal/ssa/_gen/Wasm.rules
Line 416, Patchset 1 (Latest):// E.g. (I64Extend32S (I64And x (I64Const [0xff]))) — top 32 bits are already
Keith Randall . unresolved

33

Open in Gerrit

Related details

Attention is currently required from:
  • George Adams
  • Martin Möhrmann
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ia54d67358756e47ca7635a6a8ca4beadb003820a
Gerrit-Change-Number: 756320
Gerrit-PatchSet: 1
Gerrit-Owner: George Adams <georgea...@gmail.com>
Gerrit-Reviewer: George Adams <georgea...@gmail.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Attention: Martin Möhrmann <moeh...@google.com>
Gerrit-Attention: George Adams <georgea...@gmail.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 17:56:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keith Randall (Gerrit)

unread,
1:57 PM (2 hours ago) 1:57 PM
to George Adams, goph...@pubsubhelper.golang.org, Keith Randall, Go LUCI, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com
Attention needed from George Adams and Martin Möhrmann

Keith Randall voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • George Adams
  • Martin Möhrmann
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ia54d67358756e47ca7635a6a8ca4beadb003820a
Gerrit-Change-Number: 756320
Gerrit-PatchSet: 1
Gerrit-Owner: George Adams <georgea...@gmail.com>
Gerrit-Reviewer: George Adams <georgea...@gmail.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@google.com>
Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Attention: Martin Möhrmann <moeh...@google.com>
Gerrit-Attention: George Adams <georgea...@gmail.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 17:57:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages