[go] cmd/compile: redo how equality functions are generated

5 views
Skip to first unread message

Keith Randall (Gerrit)

unread,
Dec 1, 2025, 3:29:49 PM (2 days ago) Dec 1
to Keith Randall, goph...@pubsubhelper.golang.org, Go LUCI, Vyacheslav Pachkov, Cuong Manh Le, golang-co...@googlegroups.com
Attention needed from Cuong Manh Le and Vyacheslav Pachkov

Keith Randall voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Cuong Manh Le
  • Vyacheslav Pachkov
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I202bd6424cb6bf7c745a62c9603d4f01dc1a1fc8
Gerrit-Change-Number: 725380
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Cuong Manh Le <cuong.m...@gmail.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Vyacheslav Pachkov <slava...@gmail.com>
Gerrit-Attention: Vyacheslav Pachkov <slava...@gmail.com>
Gerrit-Attention: Cuong Manh Le <cuong.m...@gmail.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 20:29:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Cuong Manh Le (Gerrit)

unread,
Dec 2, 2025, 1:01:54 AM (yesterday) Dec 2
to Keith Randall, goph...@pubsubhelper.golang.org, Go LUCI, Vyacheslav Pachkov, golang-co...@googlegroups.com
Attention needed from Keith Randall and Vyacheslav Pachkov

Cuong Manh Le voted and added 2 comments

Votes added by Cuong Manh Le

Code-Review+2

2 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Cuong Manh Le . resolved

This is brilliant.

File src/cmd/compile/internal/reflectdata/alg.go
Line 461, Patchset 3 (Latest): case 'M':
Cuong Manh Le . resolved

nit: we use 'M' (and other signature symbols) in some places below, probably folding all of them into constants, so they are self-documented.

Open in Gerrit

Related details

Attention is currently required from:
  • Keith Randall
  • Vyacheslav Pachkov
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedNo-Wait-Release
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I202bd6424cb6bf7c745a62c9603d4f01dc1a1fc8
Gerrit-Change-Number: 725380
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Cuong Manh Le <cuong.m...@gmail.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Vyacheslav Pachkov <slava...@gmail.com>
Gerrit-Attention: Keith Randall <k...@golang.org>
Gerrit-Attention: Vyacheslav Pachkov <slava...@gmail.com>
Gerrit-Comment-Date: Tue, 02 Dec 2025 06:01:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
Dec 2, 2025, 3:33:25 PM (12 hours ago) Dec 2
to Keith Randall, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Cuong Manh Le, Go LUCI, Vyacheslav Pachkov, golang-co...@googlegroups.com
Attention needed from Keith Randall and Vyacheslav Pachkov

Dmitri Shuralyov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keith Randall
  • Vyacheslav Pachkov
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedNo-Wait-Release
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I202bd6424cb6bf7c745a62c9603d4f01dc1a1fc8
Gerrit-Change-Number: 725380
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Cuong Manh Le <cuong.m...@gmail.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Vyacheslav Pachkov <slava...@gmail.com>
Gerrit-CC: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Attention: Keith Randall <k...@golang.org>
Gerrit-Attention: Vyacheslav Pachkov <slava...@gmail.com>
Gerrit-Comment-Date: Tue, 02 Dec 2025 20:33:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keith Randall (Gerrit)

unread,
Dec 2, 2025, 4:01:49 PM (12 hours ago) Dec 2
to Keith Randall, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Dmitri Shuralyov, Cuong Manh Le, Go LUCI, Vyacheslav Pachkov, golang-co...@googlegroups.com
Attention needed from Keith Randall and Vyacheslav Pachkov

Keith Randall voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keith Randall
  • Vyacheslav Pachkov
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedNo-Wait-Release
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I202bd6424cb6bf7c745a62c9603d4f01dc1a1fc8
    Gerrit-Change-Number: 725380
    Gerrit-PatchSet: 3
    Gerrit-Owner: Keith Randall <k...@golang.org>
    Gerrit-Reviewer: Cuong Manh Le <cuong.m...@gmail.com>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
    Gerrit-Reviewer: Keith Randall <k...@golang.org>
    Gerrit-Reviewer: Keith Randall <k...@google.com>
    Gerrit-Reviewer: Vyacheslav Pachkov <slava...@gmail.com>
    Gerrit-CC: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Attention: Keith Randall <k...@golang.org>
    Gerrit-Attention: Vyacheslav Pachkov <slava...@gmail.com>
    Gerrit-Comment-Date: Tue, 02 Dec 2025 21:01:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages