[go] cmd/compile: (mips64x) optimize float32(abs|sqrt64(float64(x)))
4 views
Skip to first unread message
Julian Zhu (Gerrit)
Jan 27, 2026, 8:46:33 AMJan 27
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Julian Zhu has uploaded the change for review![]( "Open in Gerrit")
Commit message
cmd/compile: (mips64x) optimize float32(abs|sqrt64(float64(x)))
Ref: #733621
Updates #75463
Change-Id: I439f92aa3d940fa4979e76845c0893e43bf584af
Change diff
diff --git a/src/cmd/compile/internal/mips64/ssa.go b/src/cmd/compile/internal/mips64/ssa.go
index 6eae8fe..e3f9c17 100644
--- a/src/cmd/compile/internal/mips64/ssa.go
+++ b/src/cmd/compile/internal/mips64/ssa.go
@@ -353,6 +353,7 @@
ssa.OpMIPS64MOVVgpfp,
ssa.OpMIPS64NEGF,
ssa.OpMIPS64NEGD,
+ ssa.OpMIPS64ABSF,
ssa.OpMIPS64ABSD,
ssa.OpMIPS64SQRTF,
ssa.OpMIPS64SQRTD:
diff --git a/src/cmd/compile/internal/ssa/_gen/MIPS64.rules b/src/cmd/compile/internal/ssa/_gen/MIPS64.rules
index da6ae94..d0a60c6 100644
--- a/src/cmd/compile/internal/ssa/_gen/MIPS64.rules
+++ b/src/cmd/compile/internal/ssa/_gen/MIPS64.rules
@@ -692,6 +692,9 @@
(Select0 (DIVVU _ (MOVVconst [1]))) => (MOVVconst [0]) // mod
(Select0 (DIVVU x (MOVVconst [c]))) && isPowerOfTwo(c) => (ANDconst [c-1] x) // mod
+// Absorb conversion between 32 bit and 64 bit if both src and dst are 32 bit.
+(MOVDF ((ABS|SQRT)D (MOVFD x))) => ((ABS|SQRT)F x)
+
// generic simplifications
(ADDV x (NEGV y)) => (SUBV x y)
(SUBV x (NEGV y)) => (ADDV x y)
diff --git a/src/cmd/compile/internal/ssa/_gen/MIPS64Ops.go b/src/cmd/compile/internal/ssa/_gen/MIPS64Ops.go
index fe3afba..151ecc3 100644
--- a/src/cmd/compile/internal/ssa/_gen/MIPS64Ops.go
+++ b/src/cmd/compile/internal/ssa/_gen/MIPS64Ops.go
@@ -194,6 +194,7 @@
{name: "NEGV", argLength: 1, reg: gp11}, // -arg0
{name: "NEGF", argLength: 1, reg: fp11, asm: "NEGF"}, // -arg0, float32
{name: "NEGD", argLength: 1, reg: fp11, asm: "NEGD"}, // -arg0, float64
+ {name: "ABSF", argLength: 1, reg: fp11, asm: "ABSF"}, // abs(arg0), float32
{name: "ABSD", argLength: 1, reg: fp11, asm: "ABSD"}, // abs(arg0), float64
{name: "SQRTD", argLength: 1, reg: fp11, asm: "SQRTD"}, // sqrt(arg0), float64
{name: "SQRTF", argLength: 1, reg: fp11, asm: "SQRTF"}, // sqrt(arg0), float32
diff --git a/src/cmd/compile/internal/ssa/opGen.go b/src/cmd/compile/internal/ssa/opGen.go
index a84fc16..bd03718 100644
--- a/src/cmd/compile/internal/ssa/opGen.go
+++ b/src/cmd/compile/internal/ssa/opGen.go
@@ -4829,6 +4829,7 @@
OpMIPS64NEGV
OpMIPS64NEGF
OpMIPS64NEGD
+ OpMIPS64ABSF
OpMIPS64ABSD
OpMIPS64SQRTD
OpMIPS64SQRTF
@@ -74329,6 +74330,19 @@
},
},
{
+ name: "ABSF",
+ argLen: 1,
+ asm: mips.AABSF,
+ reg: regInfo{
+ inputs: []inputInfo{
+ {0, 1152921504338411520}, // F0 F1 F2 F3 F4 F5 F6 F7 F8 F9 F10 F11 F12 F13 F14 F15 F16 F17 F18 F19 F20 F21 F22 F23 F24 F25 F26 F27 F28 F29 F30 F31
+ },
+ outputs: []outputInfo{
+ {0, 1152921504338411520}, // F0 F1 F2 F3 F4 F5 F6 F7 F8 F9 F10 F11 F12 F13 F14 F15 F16 F17 F18 F19 F20 F21 F22 F23 F24 F25 F26 F27 F28 F29 F30 F31
+ },
+ },
+ },
+ {
name: "ABSD",
argLen: 1,
asm: mips.AABSD,
diff --git a/src/cmd/compile/internal/ssa/rewriteMIPS64.go b/src/cmd/compile/internal/ssa/rewriteMIPS64.go
index eae67a2..59e6d2e 100644
--- a/src/cmd/compile/internal/ssa/rewriteMIPS64.go
+++ b/src/cmd/compile/internal/ssa/rewriteMIPS64.go
@@ -332,6 +332,8 @@
return rewriteValueMIPS64_OpMIPS64MOVBreg(v)
case OpMIPS64MOVBstore:
return rewriteValueMIPS64_OpMIPS64MOVBstore(v)
+ case OpMIPS64MOVDF:
+ return rewriteValueMIPS64_OpMIPS64MOVDF(v)
case OpMIPS64MOVDload:
return rewriteValueMIPS64_OpMIPS64MOVDload(v)
case OpMIPS64MOVDstore:
@@ -3191,6 +3193,40 @@
}
return false
}
+func rewriteValueMIPS64_OpMIPS64MOVDF(v *Value) bool {
+ v_0 := v.Args[0]
+ // match: (MOVDF (ABSD (MOVFD x)))
+ // result: (ABSF x)
+ for {
+ if v_0.Op != OpMIPS64ABSD {
+ break
+ }
+ v_0_0 := v_0.Args[0]
+ if v_0_0.Op != OpMIPS64MOVFD {
+ break
+ }
+ x := v_0_0.Args[0]
+ v.reset(OpMIPS64ABSF)
+ v.AddArg(x)
+ return true
+ }
+ // match: (MOVDF (SQRTD (MOVFD x)))
+ // result: (SQRTF x)
+ for {
+ if v_0.Op != OpMIPS64SQRTD {
+ break
+ }
+ v_0_0 := v_0.Args[0]
+ if v_0_0.Op != OpMIPS64MOVFD {
+ break
+ }
+ x := v_0_0.Args[0]
+ v.reset(OpMIPS64SQRTF)
+ v.AddArg(x)
+ return true
+ }
+ return false
+}
func rewriteValueMIPS64_OpMIPS64MOVDload(v *Value) bool {
v_1 := v.Args[1]
v_0 := v.Args[0]
Change information
Files:
- M src/cmd/compile/internal/mips64/ssa.go
- M src/cmd/compile/internal/ssa/_gen/MIPS64.rules
- M src/cmd/compile/internal/ssa/_gen/MIPS64Ops.go
- M src/cmd/compile/internal/ssa/opGen.go
- M src/cmd/compile/internal/ssa/rewriteMIPS64.go
Change size: M
Delta: 5 files changed, 55 insertions(+), 0 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Julian Zhu (Gerrit)
Jan 27, 2026, 10:33:24 AMJan 27
to goph...@pubsubhelper.golang.org, Keith Randall, Martin Möhrmann, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Keith Randall, Martin Möhrmann and Russ Cox
Julian Zhu voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Keith Randall
- Martin Möhrmann
- Russ Cox
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Chase (Gerrit)
Jan 28, 2026, 8:26:10 AMJan 28
to Julian Zhu, goph...@pubsubhelper.golang.org, Go LUCI, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Julian Zhu
David Chase voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Julian Zhu
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Chase (Gerrit)
Jan 28, 2026, 8:27:50 AMJan 28
to Julian Zhu, goph...@pubsubhelper.golang.org, Go LUCI, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Julian Zhu
David Chase voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Chase
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
David Chase . resolved
Added a mips64 trybot because trust-but-verify
Related details
Attention is currently required from:
- Julian Zhu
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Julian Zhu (Gerrit)
Jan 28, 2026, 10:37:38 AMJan 28
to goph...@pubsubhelper.golang.org, David Chase, Go LUCI, Gopher Robot, golang-co...@googlegroups.com
Julian Zhu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Julian Zhu
| Run-TryBot | +1 |
1 comment
Patchset-level comments
Julian Zhu . resolved
TRY=mips64,mips64le
Related details
Attention set is empty
Submit Requirements:
Code-Review
Legacy-TryBots-Pass
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
Feb 18, 2026, 6:20:35 PMFeb 18
to Julian Zhu, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, David Chase, Go LUCI, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Julian Zhu
Dmitri Shuralyov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Gopher Robot . unresolved
Gopher RobotSlowBots beginning. Status page: https://farmer.golang.org/try?commit=95c8964e
Dmitri ShuralyovBuild is still in progress... Status page: https://farmer.golang.org/try?commit=95c8964e
Failed on linux-mips64-rtrk: https://storage.googleapis.com/go-build-log/95c8964e/linux-mips64-rtrk_1385efad.log
Other builds still in progress; subsequent failure notices suppressed until final report.Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test *exactly* your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
The requested legacy slowbots keep not completing on patch set 1. Removing Run-TryBot+1 vote since it's not adding new information.
Related details
Attention is currently required from:
- Julian Zhu
Submit Requirements:
Code-Review
Legacy-TryBots-Pass
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
Feb 18, 2026, 6:20:38 PMFeb 18
to Julian Zhu, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, David Chase, Go LUCI, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Julian Zhu
Dmitri Shuralyov removed a vote from this change![]( "Open in Gerrit")
Removed Run-TryBot+1 by Julian Zhu <jz53...@gmail.com>
Related details
Attention is currently required from:
- Julian Zhu
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joel Sing (Gerrit)
Mar 11, 2026, 9:06:38 AM (9 days ago) Mar 11
to Julian Zhu, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, David Chase, Go LUCI, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov and Julian Zhu
Joel Sing voted and added 4 comments![]( "Open in Gerrit")
Votes added by Joel Sing
| Code-Review | +2 |
4 comments
Patchset-level comments
Gopher Robot . resolved
Gopher RobotSlowBots beginning. Status page: https://farmer.golang.org/try?commit=95c8964e
Dmitri ShuralyovBuild is still in progress... Status page: https://farmer.golang.org/try?commit=95c8964e
Failed on linux-mips64-rtrk: https://storage.googleapis.com/go-build-log/95c8964e/linux-mips64-rtrk_1385efad.log
Other builds still in progress; subsequent failure notices suppressed until final report.Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test *exactly* your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
The requested legacy slowbots keep not completing on patch set 1. Removing Run-TryBot+1 vote since it's not adding new information.
Joel Sing
They're broken due to https://github.com/golang/go/issues/77284 - it progressed sufficiently that this seems to be okay.
Joel Sing . unresolved
Would also be worth adding codegen to test/codegen/floats.go (probably need to stack on https://go-review.googlesource.com/c/go/+/733621 or wait for it to land though).
Commit Message
Line 8, Patchset 1 (Latest):
Joel Sing . unresolved
Absorb unnecessary conversion between float32 and float64
if both src and dst are 32 bit.
Line 9, Patchset 1 (Latest):
Ref: #733621Joel Sing . unresolved
I believe the correct syntax (for linking) is:
```suggestion
Ref: CL 733621
```
Related details
Attention is currently required from:
- Dmitri Shuralyov
- Julian Zhu
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Julian Zhu (Gerrit)
12:09 PM (10 hours ago) 12:09 PM
to goph...@pubsubhelper.golang.org, Joel Sing, Dmitri Shuralyov, David Chase, Go LUCI, Gopher Robot, golang-co...@googlegroups.com
Julian Zhu added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Joel Sing . resolved
Would also be worth adding codegen to test/codegen/floats.go (probably need to stack on https://go-review.googlesource.com/c/go/+/733621 or wait for it to land though).
Julian Zhu
I will add codegen in the later CL.
Commit Message
Joel Sing . resolved
Absorb unnecessary conversion between float32 and float64
if both src and dst are 32 bit.
Julian Zhu
Done
Line 9, Patchset 1 (Latest):
Ref: #733621Joel Sing . resolved
I believe the correct syntax (for linking) is:
```suggestion
Ref: CL 733621
```
Julian Zhu
Fix applied.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Chase (Gerrit)
4:28 PM (6 hours ago) 4:28 PM
to Julian Zhu, goph...@pubsubhelper.golang.org, Joel Sing, Dmitri Shuralyov, Go LUCI, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Julian Zhu
David Chase voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Julian Zhu
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
5:51 PM (4 hours ago) 5:51 PM
to Julian Zhu, goph...@pubsubhelper.golang.org, Joel Sing, Dmitri Shuralyov, David Chase, Go LUCI, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Julian Zhu
Dmitri Shuralyov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Julian Zhu
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages