[telemetry] internal/chartconfig: update config to add vulncheck codelens counter
11 views
Skip to first unread message
Ethan Lee (Gerrit)
Sep 19, 2025, 2:45:15 PMSep 19
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Ethan Lee has uploaded the change for review![]( "Open in Gerrit")
Commit message
internal/chartconfig: update config to add vulncheck codelens counter
Change-Id: I6724cdf0baa54dbf342bccef113ca0de669e40bc
Change diff
diff --git a/internal/chartconfig/config.txt b/internal/chartconfig/config.txt
index e6394e5..7e95178 100644
--- a/internal/chartconfig/config.txt
+++ b/internal/chartconfig/config.txt
@@ -287,4 +287,22 @@
issue: https://go.dev/issue/74869
program: github.com/golang/vscode-go/vscgo
module: github.com/golang/vscode-go
-version: v0.49.1
\ No newline at end of file
+version: v0.49.1
+---
+counter: codelens/vulncheck:{true,false}
+title: Vulncheck Codelens Usage
+description: counts vulncheck codelens settings
+type: partition
+issue:
+program: golang.org/x/tools/gopls
+module: golang.org/x/tools/gopls
+version: v0.21.0
+---
+counter: codelenses/vulncheck:{true,false}
+title: Vulncheck Codelenses Usage
+description: counts vulncheck codelens settings
+type: partition
+issue:
+program: golang.org/x/tools/gopls
+module: golang.org/x/tools/gopls
+version: v0.21.0
\ No newline at end of file
Change information
Files:
- M internal/chartconfig/config.txt
Change size: S
Delta: 1 file changed, 19 insertions(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Sep 19, 2025, 2:46:52 PMSep 19
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Ethan Lee
Ethan Lee uploaded new patchset![]( "Open in Gerrit")
Ethan Lee uploaded patch set #2 to this change.
Related details
Attention is currently required from:
- Ethan Lee
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Sep 19, 2025, 2:47:56 PMSep 19
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Ethan Lee
Ethan Lee uploaded new patchset![]( "Open in Gerrit")
Ethan Lee uploaded patch set #3 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
Related details
Attention is currently required from:
- Ethan Lee
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Sep 19, 2025, 2:49:33 PMSep 19
to goph...@pubsubhelper.golang.org, Robert Findley, Go LUCI, golang-co...@googlegroups.com
Attention needed from Robert Findley
Ethan Lee added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Ethan Lee . resolved
The instrumentation for tracking vulncheck codelens settings already exists in https://cs.opensource.google/go/x/tools/+/master:gopls/internal/settings/settings.go;l=515?q=vulncheck%20enable&ss=go%2Fx%2Ftools:gopls%2Finternal%2F
Related details
Attention is currently required from:
- Robert Findley
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Sep 29, 2025, 6:01:45 PMSep 29
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Ethan Lee and Robert Findley
Ethan Lee uploaded new patchset![]( "Open in Gerrit")
Ethan Lee uploaded patch set #4 to this change.
Following approvals got outdated and were removed:
Attention is currently required from:
- Ethan Lee
- Robert Findley
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Findley (Gerrit)
Sep 30, 2025, 2:33:11 PMSep 30
to Ethan Lee, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Ethan Lee
Robert Findley voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Ethan Lee
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Sep 30, 2025, 2:35:33 PMSep 30
to Ethan Lee, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Robert Findley, Go LUCI, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
internal/chartconfig: update config to add vulncheck codelens counter
Fixes golang/go#75546
Change-Id: I6724cdf0baa54dbf342bccef113ca0de669e40bc
Auto-Submit: Ethan Lee <etha...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfin...@google.com>
Files:
- M internal/chartconfig/config.txt
Change size: S
Delta: 1 file changed, 19 insertions(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Robert Findley
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Findley (Gerrit)
Sep 30, 2025, 3:57:31 PMSep 30
to Gopher Robot, Ethan Lee, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Ethan Lee
Robert Findley added 1 comment![]( "Open in Gerrit")
File internal/chartconfig/config.txt
Line 300, Patchset 5 (Latest):
---
counter: gopls/setting/codelenses/vulncheck:{true,false}
title: Vulncheck Codelenses Usage
description: counts vulncheck codelens settings
type: partition
issue: https://github.com/golang/go/issues/75546
program: golang.org/x/tools/gopls
module: golang.org/x/tools/gopls
version: v0.21.0Robert Findley . unresolved
Err, is this redundant?
Related details
Attention is currently required from:
- Ethan Lee
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Sep 30, 2025, 4:19:10 PMSep 30
to Gopher Robot, goph...@pubsubhelper.golang.org, Robert Findley, Go LUCI, golang-co...@googlegroups.com
Ethan Lee added 1 comment![]( "Open in Gerrit")
File internal/chartconfig/config.txt
Line 300, Patchset 5 (Latest):
---
counter: gopls/setting/codelenses/vulncheck:{true,false}
title: Vulncheck Codelenses Usage
description: counts vulncheck codelens settings
type: partition
issue: https://github.com/golang/go/issues/75546
program: golang.org/x/tools/gopls
module: golang.org/x/tools/gopls
version: v0.21.0Robert Findley . unresolved
Err, is this redundant?
Ethan Lee
We have to support both paths it seems like: https://cs.opensource.google/go/x/tools/+/master:gopls/internal/settings/settings.go;l=1226-1245?q=settings.go&ss=go%2Fx%2Ftools:gopls%2Finternal%2F
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Oct 7, 2025, 4:43:27 PMOct 7
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Ethan Lee has uploaded the change for review![]( "Open in Gerrit")
Commit message
internal/chartconfig: update config to add vulncheck codelens counter
Fixes go/golang#75794
Change-Id: I125034bbcb8b0f70b97d23e9a3358be396426bf0
Change diff
diff --git a/internal/chartconfig/config.txt b/internal/chartconfig/config.txt
index 0279224..34a70c5 100644
--- a/internal/chartconfig/config.txt
+++ b/internal/chartconfig/config.txt
@@ -290,7 +290,7 @@
version: v0.49.1
---
counter: gopls/setting/codelens/vulncheck:{true,false}
-title: Vulncheck Codelens Usage
+title: Vulncheck Codelens Settings Usage
description: counts vulncheck codelens settings
type: partition
issue: https://github.com/golang/go/issues/75546
@@ -299,7 +299,7 @@
version: v0.21.0
---
counter: gopls/setting/codelenses/vulncheck:{true,false}
-title: Vulncheck Codelenses Usage
+title: Vulncheck Codelenses Settings Usage
description: counts vulncheck codelens settings
type: partition
issue: https://github.com/golang/go/issues/75546
@@ -324,3 +324,12 @@
program: golang.org/x/tools/gopls
module: golang.org/x/tools/gopls
version: v0.21.0
+---
+counter: gopls/mod/codelenses:{vulncheck,go_vulncheck}
+title: Vulncheck Mod Codelenses Usage
+description: counts vulncheck codelens usage
+type: partition
+issue: https://github.com/golang/go/issues/75794
+program: golang.org/x/tools/gopls
+module: golang.org/x/tools/gopls
+version: v0.21.0
Change information
Files:
- M internal/chartconfig/config.txt
Change size: S
Delta: 1 file changed, 11 insertions(+), 2 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Oct 7, 2025, 4:43:59 PMOct 7
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Ethan Lee
Ethan Lee uploaded new patchset![]( "Open in Gerrit")
Attention is currently required from:
- Ethan Lee
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Oct 7, 2025, 4:46:48 PMOct 7
to goph...@pubsubhelper.golang.org, Hongxiang Jiang, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hongxiang Jiang
Ethan Lee voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Hongxiang Jiang
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Oct 8, 2025, 12:27:20 PMOct 8
to Ethan Lee, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Ethan Lee
Hongxiang Jiang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Hongxiang Jiang
| Hold | +1 |
2 comments
Commit Message
Line 9, Patchset 2 (Latest):
Fixes golang/go#75794Hongxiang Jiang . unresolved
Let's send an email to telemetry approver for this issue and get approvals. This issue is not accepted yet.
Once approved, we can proceed with this CL. Before then, I will put this on Hold.
File internal/chartconfig/config.txt
Line 330, Patchset 2 (Latest):
description: counts vulncheck codelens usageHongxiang Jiang . unresolved
I think this should be counts of codelens usage in go mod file.
We can easily add new codelenses like `go mod tidy` available in go mode file and this description will be invalid.
Related details
Attention is currently required from:
- Ethan Lee
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Oct 8, 2025, 12:29:01 PMOct 8
to Ethan Lee, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Ethan Lee
Hongxiang Jiang added 1 comment![]( "Open in Gerrit")
Commit Message
Line 7, Patchset 2 (Latest):
internal/chartconfig: update config to add vulncheck codelens counterHongxiang Jiang . unresolved
same as below, go mod codelens usage counter
Related details
Attention is currently required from:
- Ethan Lee
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Oct 13, 2025, 7:16:04 AMOct 13
to goph...@pubsubhelper.golang.org, Hongxiang Jiang, Go LUCI, golang-co...@googlegroups.com
Attention needed from Ethan Lee and Hongxiang Jiang
Message from Ethan Lee![]( "Open in Gerrit")
Attention is currently required from:
- Ethan Lee
- Hongxiang Jiang
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Oct 13, 2025, 7:26:37 AMOct 13
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Ethan Lee and Hongxiang Jiang
Ethan Lee uploaded new patchset![]( "Open in Gerrit")
Ethan Lee uploaded patch set #5 to this change.
Related details
Attention is currently required from:
- Ethan Lee
- Hongxiang Jiang
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Oct 13, 2025, 7:29:36 AMOct 13
to goph...@pubsubhelper.golang.org, Hongxiang Jiang, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hongxiang Jiang
Ethan Lee added 3 comments![]( "Open in Gerrit")
Commit Message
Line 7, Patchset 2:
internal/chartconfig: update config to add vulncheck codelens counterHongxiang Jiang . resolved
same as below, go mod codelens usage counter
Ethan Lee
Done
Line 9, Patchset 2:
Fixes golang/go#75794Hongxiang Jiang . unresolved
Let's send an email to telemetry approver for this issue and get approvals. This issue is not accepted yet.
Once approved, we can proceed with this CL. Before then, I will put this on Hold.
Ethan Lee
Yeah that makes sense thank, let's wait for the email review.
File internal/chartconfig/config.txt
I think this should be counts of codelens usage in go mod file.
We can easily add new codelenses like `go mod tidy` available in go mode file and this description will be invalid.
Attention is currently required from:
- Hongxiang Jiang
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Oct 22, 2025, 10:39:20 PMOct 22
to goph...@pubsubhelper.golang.org, Hongxiang Jiang, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hongxiang Jiang
Ethan Lee added 1 comment![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 2:
Fixes golang/go#75794Hongxiang Jiang . resolved
Ethan LeeLet's send an email to telemetry approver for this issue and get approvals. This issue is not accepted yet.
Once approved, we can proceed with this CL. Before then, I will put this on Hold.
Yeah that makes sense thank, let's wait for the email review.
Ethan Lee
Related details
Attention is currently required from:
- Hongxiang Jiang
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Oct 28, 2025, 8:58:46 PM (8 days ago) Oct 28
to Ethan Lee, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Ethan Lee
Hongxiang Jiang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hongxiang Jiang
| Hold | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Hongxiang Jiang . resolved
Let's finish the implementation first then merge this CL.
Related details
Attention is currently required from:
- Ethan Lee
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hongxiang Jiang (Gerrit)
Nov 3, 2025, 5:05:44 PM (3 days ago) Nov 3
to Ethan Lee, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Ethan Lee
Hongxiang Jiang voted![]( "Open in Gerrit")
| Code-Review | +2 |
| Hold | +0 |
Related details
Attention is currently required from:
- Ethan Lee
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Nov 4, 2025, 9:21:06 AM (2 days ago) Nov 4
to goph...@pubsubhelper.golang.org, Hongxiang Jiang, Go LUCI, golang-co...@googlegroups.com
Ethan Lee voted![]( "Open in Gerrit")
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Nov 4, 2025, 9:29:32 AM (2 days ago) Nov 4
to Ethan Lee, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Hongxiang Jiang, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
internal/chartconfig: update config to add command usage counter
Fixes golang/go#75794
Change-Id: I125034bbcb8b0f70b97d23e9a3358be396426bf0
Auto-Submit: Ethan Lee <etha...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hongxiang Jiang <hxj...@golang.org>
Files:
- M internal/chartconfig/config.txt
Change size: S
Delta: 1 file changed, 12 insertions(+), 4 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Hongxiang Jiang
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages