[pkgsite] pkgsite-cli: fetch module details concurrently in module command
2 views
Skip to first unread message
Hyang-Ah Hana Kim (Gerrit)
Apr 21, 2026, 10:21:06 PM (7 days ago) Apr 21
to goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com
Hyang-Ah Hana Kim has uploaded the change for review![]( "Open in Gerrit")
Commit message
pkgsite-cli: fetch module details concurrently in module command
For golang/go#78690
Change-Id: If381903054da1352ff55aaf141ff6ad8c492b69a
Change diff
diff --git a/cmd/internal/pkgsite-cli/main_test.go b/cmd/internal/pkgsite-cli/main_test.go
index 0f75b50..ab82473 100644
--- a/cmd/internal/pkgsite-cli/main_test.go
+++ b/cmd/internal/pkgsite-cli/main_test.go
@@ -284,7 +284,7 @@
}
for _, imp := range f.Imports {
path := strings.Trim(imp.Path.Value, `"`)
- if strings.Contains(path, ".") && !strings.HasPrefix(path, "golang.org/x/pkgsite") {
+ if strings.Contains(path, ".") && !strings.HasPrefix(path, "golang.org/x/pkgsite") && path != "golang.org/x/sync/errgroup" {
t.Errorf("%s imports third-party package %q", e.Name(), path)
}
}
diff --git a/cmd/internal/pkgsite-cli/module.go b/cmd/internal/pkgsite-cli/module.go
index dd8ce55..1c7f2b8 100644
--- a/cmd/internal/pkgsite-cli/module.go
+++ b/cmd/internal/pkgsite-cli/module.go
@@ -11,6 +11,7 @@
"time"
"golang.org/x/pkgsite/cmd/internal/pkgsite-cli/client"
+ "golang.org/x/sync/errgroup"
)
func runModule(fs *flag.FlagSet, m *moduleFlags, stdout, stderr io.Writer) int {
@@ -33,38 +34,53 @@
}
result := moduleResult{Module: mod}
- // TODO: run concurrently ?
+ var (
+ vers *client.PaginatedResponse[client.VersionResponse]
+ vulns *client.PaginatedResponse[client.Vulnerability]
+ pkgs *client.PaginatedResponse[client.ModulePackageResponse]
+ )
+
+ g, gctx := errgroup.WithContext(ctx)
+
if m.versions {
- vers, err := c.GetVersions(ctx, path, client.PaginationOptions{
- Limit: m.effectiveLimit(),
- Token: m.token,
+ g.Go(func() error {
+ var err error
+ vers, err = c.GetVersions(gctx, path, client.PaginationOptions{
+ Limit: m.effectiveLimit(),
+ Token: m.token,
+ })
+ return err
})
- if err != nil {
- return handleErr(stdout, stderr, err, m.jsonOut)
- }
- result.Versions = vers
}
if m.vulns {
- vulns, err := c.GetVulns(ctx, path, version, client.PaginationOptions{
- Limit: m.effectiveLimit(),
- Token: m.token,
+ g.Go(func() error {
+ var err error
+ vulns, err = c.GetVulns(gctx, path, version, client.PaginationOptions{
+ Limit: m.effectiveLimit(),
+ Token: m.token,
+ })
+ return err
})
- if err != nil {
- return handleErr(stdout, stderr, err, m.jsonOut)
- }
- result.Vulns = vulns
}
if m.packages {
- pkgs, err := c.GetPackages(ctx, path, version, client.PaginationOptions{
- Limit: m.effectiveLimit(),
- Token: m.token,
+ g.Go(func() error {
+ var err error
+ pkgs, err = c.GetPackages(gctx, path, version, client.PaginationOptions{
+ Limit: m.effectiveLimit(),
+ Token: m.token,
+ })
+ return err
})
- if err != nil {
- return handleErr(stdout, stderr, err, m.jsonOut)
- }
- result.Packages = pkgs
}
+ if err := g.Wait(); err != nil {
+ return handleErr(stdout, stderr, err, m.jsonOut)
+ }
+
+ result.Versions = vers
+ result.Vulns = vulns
+ result.Packages = pkgs
+
if m.jsonOut {
return writeJSON(stdout, stderr, result)
}
Change information
Files:
- M cmd/internal/pkgsite-cli/main_test.go
- M cmd/internal/pkgsite-cli/module.go
Change size: M
Delta: 2 files changed, 39 insertions(+), 23 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kokoro (Gerrit)
Apr 21, 2026, 10:33:43 PM (7 days ago) Apr 21
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
kokoro voted kokoro-CI-1![]( "Open in Gerrit")
Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/c7c8be3f-fd08-480f-ab8d-e130db55b971
| kokoro-CI | -1 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kokoro (Gerrit)
Apr 27, 2026, 5:24:05 PM (2 days ago) Apr 27
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
kokoro voted kokoro-CI-1![]( "Open in Gerrit")
Kokoro presubmit build finished with status: FAILURE
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyang-Ah Hana Kim (Gerrit)
Apr 27, 2026, 5:32:58 PM (2 days ago) Apr 27
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Hyang-Ah Hana Kim uploaded new patchset![]( "Open in Gerrit")
Hyang-Ah Hana Kim uploaded patch set #3 to this change.
Following approvals got outdated and were removed:
- kokoro-CI-Passes: kokoro-CI-1 by kokoro
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kokoro (Gerrit)
Apr 27, 2026, 5:43:15 PM (2 days ago) Apr 27
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
kokoro voted kokoro-CI-1![]( "Open in Gerrit")
Kokoro presubmit build finished with status: FAILURE
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyang-Ah Hana Kim (Gerrit)
Apr 27, 2026, 6:32:34 PM (2 days ago) Apr 27
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Hyang-Ah Hana Kim uploaded new patchset![]( "Open in Gerrit")
Hyang-Ah Hana Kim uploaded patch set #4 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
- kokoro-CI-Passes: kokoro-CI-1 by kokoro
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kokoro (Gerrit)
Apr 27, 2026, 6:57:24 PM (2 days ago) Apr 27
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
kokoro voted kokoro-CI+1![]( "Open in Gerrit")
Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/36b95f24-3ab7-4029-8ede-416048fc802c
| kokoro-CI | +1 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jonathan Amsterdam (Gerrit)
Apr 28, 2026, 12:26:46 PM (17 hours ago) Apr 28
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, kokoro, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Jonathan Amsterdam voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ethan Lee (Gerrit)
Apr 28, 2026, 4:08:38 PM (13 hours ago) Apr 28
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Jonathan Amsterdam, kokoro, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Ethan Lee voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyang-Ah Hana Kim (Gerrit)
Apr 28, 2026, 6:24:39 PM (11 hours ago) Apr 28
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Hyang-Ah Hana Kim uploaded new patchset![]( "Open in Gerrit")
Hyang-Ah Hana Kim uploaded patch set #5 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
- kokoro-CI-Passes: kokoro-CI+1 by kokoro
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyang-Ah Hana Kim (Gerrit)
Apr 28, 2026, 6:25:19 PM (11 hours ago) Apr 28
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ethan Lee, Jonathan Amsterdam, kokoro, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Hyang-Ah Hana Kim voted Auto-Submit+1![]( "Open in Gerrit")
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kokoro (Gerrit)
Apr 28, 2026, 6:50:53 PM (10 hours ago) Apr 28
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Ethan Lee, Jonathan Amsterdam, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
kokoro voted kokoro-CI+1![]( "Open in Gerrit")
Kokoro presubmit build finished with status: SUCCESS
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
kokoro-CI-Passes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Apr 28, 2026, 6:53:04 PM (10 hours ago) Apr 28
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, kokoro, golang...@luci-project-accounts.iam.gserviceaccount.com, Ethan Lee, Jonathan Amsterdam, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
cmd/internal/pkgsite-cli: fetch module details concurrently in module command
For golang/go#78690
Change-Id: If381903054da1352ff55aaf141ff6ad8c492b69a
Reviewed-by: Jonathan Amsterdam <j...@google.com>
kokoro-CI: kokoro <noreply...@google.com>
Auto-Submit: Hyang-Ah Hana Kim <hya...@gmail.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ethan Lee <etha...@google.com>
Files:
- M cmd/internal/pkgsite-cli/main_test.go
- M cmd/internal/pkgsite-cli/module.go
Change size: M
Delta: 2 files changed, 40 insertions(+), 26 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Jonathan Amsterdam, +2 by Ethan Lee
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
kokoro-CI-Passes: kokoro-CI+1 by kokoro
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages