[go] internal/abi, cmd/link: centralize type descriptor size calculation

0 views
Skip to first unread message

Jake Bailey (Gerrit)

unread,
1:16 PM (2 hours ago) 1:16 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Message from Jake Bailey

Set Ready For Review

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Iaa66055061b68ec93c9912ae6aa6e605260f52a8
Gerrit-Change-Number: 749961
Gerrit-PatchSet: 1
Gerrit-Owner: Jake Bailey <jacob.b...@gmail.com>
Gerrit-Comment-Date: Fri, 27 Feb 2026 18:16:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Cherry Mui (Gerrit)

unread,
2:33 PM (1 hour ago) 2:33 PM
to Jake Bailey, goph...@pubsubhelper.golang.org, Keith Randall, David Chase, Gopher Robot, golang-co...@googlegroups.com
Attention needed from David Chase, Jake Bailey and Keith Randall

Cherry Mui added 1 comment

File src/internal/abi/compiletype.go
Line 30, Patchset 2 (Latest):// KindTypeSize returns sizeof(kindType) for a compilation target with a given ptrSize.
Cherry Mui . unresolved

"KindType" seems an unusual phrase. Maybe TypeDescSize? RTypeSize?

Open in Gerrit

Related details

Attention is currently required from:
  • David Chase
  • Jake Bailey
  • Keith Randall
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Iaa66055061b68ec93c9912ae6aa6e605260f52a8
    Gerrit-Change-Number: 749961
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jake Bailey <jacob.b...@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: David Chase <drc...@google.com>
    Gerrit-Reviewer: Keith Randall <k...@golang.org>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Attention: Keith Randall <k...@golang.org>
    Gerrit-Attention: Jake Bailey <jacob.b...@gmail.com>
    Gerrit-Attention: David Chase <drc...@google.com>
    Gerrit-Comment-Date: Fri, 27 Feb 2026 19:33:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Jake Bailey (Gerrit)

    unread,
    2:41 PM (1 hour ago) 2:41 PM
    to goph...@pubsubhelper.golang.org, Keith Randall, David Chase, Cherry Mui, Gopher Robot, golang-co...@googlegroups.com
    Attention needed from Cherry Mui, David Chase and Keith Randall

    Jake Bailey added 1 comment

    File src/internal/abi/compiletype.go
    Line 30, Patchset 2 (Latest):// KindTypeSize returns sizeof(kindType) for a compilation target with a given ptrSize.
    Cherry Mui . unresolved

    "KindType" seems an unusual phrase. Maybe TypeDescSize? RTypeSize?

    Jake Bailey

    I like RTypeSize. Will update.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Cherry Mui
    • David Chase
    • Keith Randall
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Iaa66055061b68ec93c9912ae6aa6e605260f52a8
    Gerrit-Change-Number: 749961
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jake Bailey <jacob.b...@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: David Chase <drc...@google.com>
    Gerrit-Reviewer: Keith Randall <k...@golang.org>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Attention: Keith Randall <k...@golang.org>
    Gerrit-Attention: Cherry Mui <cher...@google.com>
    Gerrit-Attention: David Chase <drc...@google.com>
    Gerrit-Comment-Date: Fri, 27 Feb 2026 19:41:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Cherry Mui <cher...@google.com>
    unsatisfied_requirement
    open
    diffy

    Jake Bailey (Gerrit)

    unread,
    2:43 PM (1 hour ago) 2:43 PM
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Cherry Mui, David Chase and Keith Randall

    Jake Bailey uploaded new patchset

    Jake Bailey uploaded patch set #3 to this change.
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Cherry Mui
    • David Chase
    • Keith Randall
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Iaa66055061b68ec93c9912ae6aa6e605260f52a8
    Gerrit-Change-Number: 749961
    Gerrit-PatchSet: 3
    unsatisfied_requirement
    open
    diffy

    Jake Bailey (Gerrit)

    unread,
    2:43 PM (1 hour ago) 2:43 PM
    to goph...@pubsubhelper.golang.org, Keith Randall, David Chase, Cherry Mui, Gopher Robot, golang-co...@googlegroups.com
    Attention needed from Cherry Mui, David Chase and Keith Randall

    Jake Bailey added 1 comment

    File src/internal/abi/compiletype.go
    Line 30, Patchset 2:// KindTypeSize returns sizeof(kindType) for a compilation target with a given ptrSize.
    Cherry Mui . resolved

    "KindType" seems an unusual phrase. Maybe TypeDescSize? RTypeSize?

    Jake Bailey

    I like RTypeSize. Will update.

    Jake Bailey

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Cherry Mui
    • David Chase
    • Keith Randall
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Iaa66055061b68ec93c9912ae6aa6e605260f52a8
      Gerrit-Change-Number: 749961
      Gerrit-PatchSet: 2
      Gerrit-Owner: Jake Bailey <jacob.b...@gmail.com>
      Gerrit-Reviewer: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: David Chase <drc...@google.com>
      Gerrit-Reviewer: Keith Randall <k...@golang.org>
      Gerrit-CC: Gopher Robot <go...@golang.org>
      Gerrit-Attention: Keith Randall <k...@golang.org>
      Gerrit-Attention: Cherry Mui <cher...@google.com>
      Gerrit-Attention: David Chase <drc...@google.com>
      Gerrit-Comment-Date: Fri, 27 Feb 2026 19:43:37 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Jake Bailey <jacob.b...@gmail.com>
      Comment-In-Reply-To: Cherry Mui <cher...@google.com>
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages