[net] quic: avoid usage of net.ReadMsgUDPAddrPort in non-linux and darwin builds

0 views
Skip to first unread message

Nicholas Husin (Gerrit)

unread,
4:40 PM (5 hours ago) 4:40 PM
to goph...@pubsubhelper.golang.org, Richard Miller, Go LUCI, golang-co...@googlegroups.com
Attention needed from Richard Miller

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Richard Miller
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: net
Gerrit-Branch: master
Gerrit-Change-Id: Id397f28368f0cc291b12c6e06df3de64321a623b
Gerrit-Change-Number: 757100
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Husin <n...@golang.org>
Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
Gerrit-Reviewer: Richard Miller <millerr...@gmail.com>
Gerrit-Attention: Richard Miller <millerr...@gmail.com>
Gerrit-Comment-Date: Thu, 19 Mar 2026 20:40:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Nicholas Husin (Gerrit)

unread,
4:50 PM (5 hours ago) 4:50 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Richard Miller

Nicholas Husin uploaded new patchset

Nicholas Husin uploaded patch set #3 to this change.
Following approvals got outdated and were removed:
  • TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit

Related details

Attention is currently required from:
  • Richard Miller
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: net
Gerrit-Branch: master
Gerrit-Change-Id: Id397f28368f0cc291b12c6e06df3de64321a623b
Gerrit-Change-Number: 757100
Gerrit-PatchSet: 3
unsatisfied_requirement
satisfied_requirement
open
diffy

Richard Miller (Gerrit)

unread,
5:48 PM (4 hours ago) 5:48 PM
to Nicholas Husin, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Nicholas Husin

Richard Miller voted and added 1 comment

Votes added by Richard Miller

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Richard Miller . resolved

Good to remove the special cases, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Nicholas Husin
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: net
    Gerrit-Branch: master
    Gerrit-Change-Id: Id397f28368f0cc291b12c6e06df3de64321a623b
    Gerrit-Change-Number: 757100
    Gerrit-PatchSet: 3
    Gerrit-Owner: Nicholas Husin <n...@golang.org>
    Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
    Gerrit-Reviewer: Richard Miller <millerr...@gmail.com>
    Gerrit-Attention: Nicholas Husin <n...@golang.org>
    Gerrit-Comment-Date: Thu, 19 Mar 2026 21:48:21 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Nicholas Husin (Gerrit)

    unread,
    5:59 PM (4 hours ago) 5:59 PM
    to goph...@pubsubhelper.golang.org, Ethan Lee, Richard Miller, Go LUCI, golang-co...@googlegroups.com
    Attention needed from Ethan Lee

    Nicholas Husin voted and added 1 comment

    Votes added by Nicholas Husin

    Auto-Submit+1

    1 comment

    Patchset-level comments
    Richard Miller . resolved

    Good to remove the special cases, thanks!

    Nicholas Husin

    Thanks for all the help!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ethan Lee
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: net
    Gerrit-Branch: master
    Gerrit-Change-Id: Id397f28368f0cc291b12c6e06df3de64321a623b
    Gerrit-Change-Number: 757100
    Gerrit-PatchSet: 3
    Gerrit-Owner: Nicholas Husin <n...@golang.org>
    Gerrit-Reviewer: Ethan Lee <etha...@google.com>
    Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
    Gerrit-Reviewer: Richard Miller <millerr...@gmail.com>
    Gerrit-Attention: Ethan Lee <etha...@google.com>
    Gerrit-Comment-Date: Thu, 19 Mar 2026 21:59:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Richard Miller <millerr...@gmail.com>
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Ethan Lee (Gerrit)

    unread,
    8:58 PM (1 hour ago) 8:58 PM
    to Nicholas Husin, goph...@pubsubhelper.golang.org, Richard Miller, Go LUCI, golang-co...@googlegroups.com
    Attention needed from Nicholas Husin

    Ethan Lee voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nicholas Husin
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: net
    Gerrit-Branch: master
    Gerrit-Change-Id: Id397f28368f0cc291b12c6e06df3de64321a623b
    Gerrit-Change-Number: 757100
    Gerrit-PatchSet: 3
    Gerrit-Owner: Nicholas Husin <n...@golang.org>
    Gerrit-Reviewer: Ethan Lee <etha...@google.com>
    Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
    Gerrit-Reviewer: Richard Miller <millerr...@gmail.com>
    Gerrit-Attention: Nicholas Husin <n...@golang.org>
    Gerrit-Comment-Date: Fri, 20 Mar 2026 00:58:07 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages