[go] wip: net/http: add support for running HTTP tests against HTTP/3

1 view
Skip to first unread message

Nicholas Husin (Gerrit)

unread,
Apr 7, 2026, 10:57:55 AM (2 days ago) Apr 7
to goph...@pubsubhelper.golang.org, Go LUCI, Damien Neil, golang-co...@googlegroups.com
Attention needed from Damien Neil and Nicholas Husin

Message from Nicholas Husin

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Damien Neil
  • Nicholas Husin
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ibc5fc83287b6a04b46e668a54924761a92b620a4
Gerrit-Change-Number: 740122
Gerrit-PatchSet: 7
Gerrit-Owner: Nicholas Husin <n...@golang.org>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
Gerrit-Attention: Damien Neil <dn...@google.com>
Gerrit-Attention: Nicholas Husin <n...@golang.org>
Gerrit-Comment-Date: Tue, 07 Apr 2026 14:57:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Damien Neil (Gerrit)

unread,
Apr 8, 2026, 5:27:42 PM (7 hours ago) Apr 8
to Nicholas Husin, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Nicholas Husin

Damien Neil added 3 comments

File src/net/http/clientserver_test.go
Line 219, Patchset 9 (Latest): }
Damien Neil . unresolved

I'd really like us to support fakenet+HTTP/3, but doesn't have to be in this CL.

(What I want, I think, is to put the nettest package from https://go.dev/cl/740100 into std/internal, and then replace the custom fakenet implementations in net/http and net/http/internal/http2 with it. This would also give us a fake PacketConn for HTTP/3.)

Line 260, Patchset 9 (Latest): case http3Mode:
Damien Neil . unresolved

Match the pattern of the above cases?

```
http.ProtocolSetHTTP3(p, true)
```

...instead of cst.ts.Config.Protocols below.

Line 291, Patchset 9 (Latest): http.ProtocolSetHTTP3(cst.tr.Protocols)
Damien Neil . unresolved

This part shouldn't be necessary if we adjust p above.

Open in Gerrit

Related details

Attention is currently required from:
  • Nicholas Husin
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ibc5fc83287b6a04b46e668a54924761a92b620a4
    Gerrit-Change-Number: 740122
    Gerrit-PatchSet: 9
    Gerrit-Owner: Nicholas Husin <n...@golang.org>
    Gerrit-Reviewer: Damien Neil <dn...@google.com>
    Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
    Gerrit-Attention: Nicholas Husin <n...@golang.org>
    Gerrit-Comment-Date: Wed, 08 Apr 2026 21:27:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Nicholas Husin (Gerrit)

    unread,
    Apr 8, 2026, 5:34:03 PM (7 hours ago) Apr 8
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Nicholas Husin

    Nicholas Husin uploaded new patchset

    Nicholas Husin uploaded patch set #10 to this change.
    Following approvals got outdated and were removed:
    • TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nicholas Husin
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Ibc5fc83287b6a04b46e668a54924761a92b620a4
      Gerrit-Change-Number: 740122
      Gerrit-PatchSet: 10
      unsatisfied_requirement
      open
      diffy

      Nicholas Husin (Gerrit)

      unread,
      Apr 8, 2026, 5:34:40 PM (7 hours ago) Apr 8
      to goph...@pubsubhelper.golang.org, Go LUCI, Damien Neil, golang-co...@googlegroups.com
      Attention needed from Damien Neil

      Nicholas Husin added 3 comments

      File src/net/http/clientserver_test.go
      Line 219, Patchset 9: }
      Damien Neil . resolved

      I'd really like us to support fakenet+HTTP/3, but doesn't have to be in this CL.

      (What I want, I think, is to put the nettest package from https://go.dev/cl/740100 into std/internal, and then replace the custom fakenet implementations in net/http and net/http/internal/http2 with it. This would also give us a fake PacketConn for HTTP/3.)

      Nicholas Husin

      SGTM, added a TODO.

      Line 260, Patchset 9: case http3Mode:
      Damien Neil . resolved

      Match the pattern of the above cases?

      ```
      http.ProtocolSetHTTP3(p, true)
      ```

      ...instead of cst.ts.Config.Protocols below.

      Nicholas Husin

      Oh, good catch, thanks!

      Line 291, Patchset 9: http.ProtocolSetHTTP3(cst.tr.Protocols)
      Damien Neil . resolved

      This part shouldn't be necessary if we adjust p above.

      Nicholas Husin

      Done.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Damien Neil
      Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: Ibc5fc83287b6a04b46e668a54924761a92b620a4
        Gerrit-Change-Number: 740122
        Gerrit-PatchSet: 10
        Gerrit-Owner: Nicholas Husin <n...@golang.org>
        Gerrit-Reviewer: Damien Neil <dn...@google.com>
        Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
        Gerrit-Attention: Damien Neil <dn...@google.com>
        Gerrit-Comment-Date: Wed, 08 Apr 2026 21:34:37 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Damien Neil <dn...@google.com>
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Damien Neil (Gerrit)

        unread,
        Apr 8, 2026, 5:38:45 PM (7 hours ago) Apr 8
        to Nicholas Husin, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
        Attention needed from Nicholas Husin

        Damien Neil voted Code-Review+2

        Code-Review+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Nicholas Husin
        Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: Ibc5fc83287b6a04b46e668a54924761a92b620a4
        Gerrit-Change-Number: 740122
        Gerrit-PatchSet: 10
        Gerrit-Owner: Nicholas Husin <n...@golang.org>
        Gerrit-Reviewer: Damien Neil <dn...@google.com>
        Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
        Gerrit-Attention: Nicholas Husin <n...@golang.org>
        Gerrit-Comment-Date: Wed, 08 Apr 2026 21:38:41 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Nicholas Husin (Gerrit)

        unread,
        Apr 8, 2026, 5:47:36 PM (7 hours ago) Apr 8
        to goph...@pubsubhelper.golang.org, Damien Neil, Go LUCI, golang-co...@googlegroups.com

        Nicholas Husin voted and added 1 comment

        Votes added by Nicholas Husin

        Hold+1

        1 comment

        Patchset-level comments
        File-level comment, Patchset 10 (Latest):
        Nicholas Husin . unresolved

        Hold: check on how folks feel about vendoring `x/net/quic` and `x/net/internal/http3` for testing purposes.

        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Holds
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: Ibc5fc83287b6a04b46e668a54924761a92b620a4
        Gerrit-Change-Number: 740122
        Gerrit-PatchSet: 10
        Gerrit-Owner: Nicholas Husin <n...@golang.org>
        Gerrit-Reviewer: Damien Neil <dn...@google.com>
        Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
        Gerrit-Comment-Date: Wed, 08 Apr 2026 21:47:33 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Nicholas Husin (Gerrit)

        unread,
        Apr 8, 2026, 5:47:43 PM (7 hours ago) Apr 8
        to Nicholas Husin, goph...@pubsubhelper.golang.org, Damien Neil, Go LUCI, golang-co...@googlegroups.com
        Attention needed from Nicholas Husin

        Nicholas Husin voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Nicholas Husin
        Submit Requirements:
          • requirement satisfiedCode-Review
          • requirement is not satisfiedNo-Holds
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement satisfiedReview-Enforcement
          • requirement is not satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: Ibc5fc83287b6a04b46e668a54924761a92b620a4
          Gerrit-Change-Number: 740122
          Gerrit-PatchSet: 10
          Gerrit-Owner: Nicholas Husin <n...@golang.org>
          Gerrit-Reviewer: Damien Neil <dn...@google.com>
          Gerrit-Reviewer: Nicholas Husin <hu...@google.com>
          Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
          Gerrit-Attention: Nicholas Husin <n...@golang.org>
          Gerrit-Comment-Date: Wed, 08 Apr 2026 21:47:39 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy
          Reply all
          Reply to author
          Forward
          0 new messages