[vscode-go] src/goInstallTools: remove dlv-dap from missing tools
147 views
Skip to first unread message
Suzy Mueller (Gerrit)
Apr 2, 2021, 3:53:01 PM4/2/21
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Suzy Mueller has uploaded this change for review.
src/goInstallTools: remove dlv-dap from missing tools
We hoped to use missing analysis tools to prompt users to update
dlv-dap since we want users to be using master. This results in
the Missing Analysis Tools notification to be constantly displayed,
which is distracting. We should replace this with other update
logic to keep users getting updates.
Change-Id: I71a99dc0e47ce1447acec2cda223ab10e3f3100e
---
M src/goInstallTools.ts
1 file changed, 0 insertions(+), 11 deletions(-)
diff --git a/src/goInstallTools.ts b/src/goInstallTools.ts
index ab09bbf..287489e 100644
--- a/src/goInstallTools.ts
+++ b/src/goInstallTools.ts
@@ -567,17 +567,6 @@
(tool) =>
new Promise<Tool>((resolve, reject) => {
const toolPath = getBinPath(tool.name);
- if (tool.name === 'dlv-dap') {
- // Check if user already has dlv-dap binary.
- // If so, it's likely the user may be interested in updating the tool,
- // so we should mark it as important and return as a missing tool.
- if (path.isAbsolute(toolPath)) {
- tool.isImportant = true;
- resolve(tool);
- return;
- }
- tool.isImportant = false;
- }
resolve(path.isAbsolute(toolPath) ? null : tool);
})
)
To view, visit change 306990. To unsubscribe, or for help writing mail filters, visit settings.
kokoro (Gerrit)
Apr 2, 2021, 4:07:23 PM4/2/21
to Suzy Mueller, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/8b1b0322-395e-4bf8-993f-22d0d1f15dc4
Patch set 1:TryBot-Result +1
Hyang-Ah Hana Kim (Gerrit)
Apr 2, 2021, 4:40:25 PM4/2/21
to Suzy Mueller, goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, kokoro, golang-co...@googlegroups.com
Attention is currently required from: Suzy Mueller.
Patch set 1:Code-Review +2
Suzy Mueller (Gerrit)
Apr 2, 2021, 6:20:21 PM4/2/21
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Hyang-Ah Hana Kim, kokoro, golang-co...@googlegroups.com
Suzy Mueller submitted this change.
Approvals:
Hyang-Ah Hana Kim: Looks good to me, approved
Suzy Mueller: Trusted; Run TryBots
kokoro: TryBots succeeded
src/goInstallTools: remove dlv-dap from missing tools
We hoped to use missing analysis tools to prompt users to update
dlv-dap since we want users to be using master. This results in
the Missing Analysis Tools notification to be constantly displayed,
which is distracting. We should replace this with other update
logic to keep users getting updates.
Change-Id: I71a99dc0e47ce1447acec2cda223ab10e3f3100e
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/306990
Trust: Suzy Mueller <suz...@golang.org>
Run-TryBot: Suzy Mueller <suz...@golang.org>
TryBot-Result: kokoro <noreply...@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hya...@gmail.com>
To view, visit change 306990. To unsubscribe, or for help writing mail filters, visit settings.
Suzy Mueller (Gerrit)
Apr 2, 2021, 6:20:31 PM4/2/21
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Suzy Mueller has uploaded this change for review.
src/goInstallTools: remove dlv-dap from missing tools
We hoped to use missing analysis tools to prompt users to update
dlv-dap since we want users to be using master. This results in
the Missing Analysis Tools notification to be constantly displayed,
which is distracting. We should replace this with other update
logic to keep users getting updates.
Change-Id: I71a99dc0e47ce1447acec2cda223ab10e3f3100e
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/306990
Trust: Suzy Mueller <suz...@golang.org>
Run-TryBot: Suzy Mueller <suz...@golang.org>
TryBot-Result: kokoro <noreply...@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hya...@gmail.com>
(cherry picked from commit d9fca4df1d08c8d5b5559f955cb918354769a3d4)
---
M src/goInstallTools.ts
1 file changed, 0 insertions(+), 11 deletions(-)
diff --git a/src/goInstallTools.ts b/src/goInstallTools.ts
index 8cae7d8..542eac6 100644
--- a/src/goInstallTools.ts
+++ b/src/goInstallTools.ts
@@ -568,17 +568,6 @@
(tool) =>
new Promise<Tool>((resolve, reject) => {
const toolPath = getBinPath(tool.name);
- if (tool.name === 'dlv-dap') {
- // Check if user already has dlv-dap binary.
- // If so, it's likely the user may be interested in updating the tool,
- // so we should mark it as important and return as a missing tool.
- if (path.isAbsolute(toolPath)) {
- tool.isImportant = true;
- resolve(tool);
- return;
- }
- tool.isImportant = false;
- }
resolve(path.isAbsolute(toolPath) ? null : tool);
})
)
To view, visit change 306970. To unsubscribe, or for help writing mail filters, visit settings.
Suzy Mueller (Gerrit)
Apr 2, 2021, 6:49:38 PM4/2/21
to goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com
Attention is currently required from: Hyang-Ah Hana Kim.
Patch set 1:Run-TryBot +1Trust +1
kokoro (Gerrit)
Apr 2, 2021, 7:01:43 PM4/2/21
to Suzy Mueller, goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com
Attention is currently required from: Hyang-Ah Hana Kim.
Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/9cf501d7-5d80-4593-857b-212699957ab5
Patch set 1:TryBot-Result +1
Hyang-Ah Hana Kim (Gerrit)
Apr 2, 2021, 7:42:43 PM4/2/21
to Suzy Mueller, Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention is currently required from: Hyang-Ah Hana Kim.
Hyang-Ah Hana Kim uploaded patch set #2 to the change originally created by Suzy Mueller.
[release] src/goInstallTools: remove dlv-dap from missing tools
We hoped to use missing analysis tools to prompt users to update
dlv-dap since we want users to be using master. This results in
the Missing Analysis Tools notification to be constantly displayed,
which is distracting. We should replace this with other update
logic to keep users getting updates.
Change-Id: I71a99dc0e47ce1447acec2cda223ab10e3f3100e
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/306990
Trust: Suzy Mueller <suz...@golang.org>
Run-TryBot: Suzy Mueller <suz...@golang.org>
TryBot-Result: kokoro <noreply...@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hya...@gmail.com>
(cherry picked from commit d9fca4df1d08c8d5b5559f955cb918354769a3d4)
---
M src/goInstallTools.ts
1 file changed, 0 insertions(+), 11 deletions(-)
To view, visit change 306970. To unsubscribe, or for help writing mail filters, visit settings.
Hyang-Ah Hana Kim (Gerrit)
Apr 2, 2021, 7:42:51 PM4/2/21
to Suzy Mueller, Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, kokoro, golang-co...@googlegroups.com
Attention is currently required from: Suzy Mueller.
Patch set 2:Code-Review +2
Hyang-Ah Hana Kim (Gerrit)
Apr 6, 2021, 2:14:54 AM4/6/21
to Suzy Mueller, Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, kokoro, golang-co...@googlegroups.com
Hyang-Ah Hana Kim submitted this change.
Approvals:
Hyang-Ah Hana Kim: Looks good to me, approved
Suzy Mueller: Trusted
[release] src/goInstallTools: remove dlv-dap from missing tools
We hoped to use missing analysis tools to prompt users to update
dlv-dap since we want users to be using master. This results in
the Missing Analysis Tools notification to be constantly displayed,
which is distracting. We should replace this with other update
logic to keep users getting updates.
Change-Id: I71a99dc0e47ce1447acec2cda223ab10e3f3100e
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/306990
Trust: Suzy Mueller <suz...@golang.org>
Run-TryBot: Suzy Mueller <suz...@golang.org>
TryBot-Result: kokoro <noreply...@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hya...@gmail.com>
(cherry picked from commit d9fca4df1d08c8d5b5559f955cb918354769a3d4)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/306970
---
M src/goInstallTools.ts
1 file changed, 0 insertions(+), 11 deletions(-)
diff --git a/src/goInstallTools.ts b/src/goInstallTools.ts
index 8cae7d8..542eac6 100644
--- a/src/goInstallTools.ts
+++ b/src/goInstallTools.ts
@@ -568,17 +568,6 @@
(tool) =>
new Promise<Tool>((resolve, reject) => {
const toolPath = getBinPath(tool.name);
- if (tool.name === 'dlv-dap') {
- // Check if user already has dlv-dap binary.
- // If so, it's likely the user may be interested in updating the tool,
- // so we should mark it as important and return as a missing tool.
- if (path.isAbsolute(toolPath)) {
- tool.isImportant = true;
- resolve(tool);
- return;
- }
- tool.isImportant = false;
- }
resolve(path.isAbsolute(toolPath) ? null : tool);
})
)
To view, visit change 306970. To unsubscribe, or for help writing mail filters, visit settings.
Reply all
Reply to author
Forward
0 new messages