[go] cmd: fix unused errors reported by ineffassign

3 views
Skip to first unread message

Lin Lin (Gerrit)

unread,
Dec 18, 2025, 12:18:50 AM (yesterday) Dec 18
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Lin Lin has uploaded the change for review

Commit message

cmd: fix unused errors reported by ineffassign

Updates golang/go#35136
Change-Id: I36d26089d29933e363d9fa50f3174530b698450e

Change diff

diff --git a/src/cmd/internal/bootstrap_test/overlaydir_test.go b/src/cmd/internal/bootstrap_test/overlaydir_test.go
index 5812c45..bee3214 100644
--- a/src/cmd/internal/bootstrap_test/overlaydir_test.go
+++ b/src/cmd/internal/bootstrap_test/overlaydir_test.go
@@ -43,6 +43,9 @@
 		dstPath := filepath.Join(dstRoot, suffix)
 
 		info, err := entry.Info()
+		if err != nil {
+			return err
+		}
 		perm := info.Mode() & os.ModePerm
 		if info.Mode()&os.ModeSymlink != 0 {
 			info, err = os.Stat(srcPath)
diff --git a/src/cmd/link/link_test.go b/src/cmd/link/link_test.go
index bc7504e..036eda1 100644
--- a/src/cmd/link/link_test.go
+++ b/src/cmd/link/link_test.go
@@ -869,6 +869,9 @@
 			"_main.bar": false,
 			"_main.baz": false}
 		syms, err := f.Symbols()
+		if err != nil {
+			t.Errorf("failed to get symbols with err %v", err)
+		}
 		for _, s := range syms {
 			fn := s.Name
 			if _, ok := fname[fn]; !ok {

Change information

Files:
  • M src/cmd/internal/bootstrap_test/overlaydir_test.go
  • M src/cmd/link/link_test.go
Change size: XS
Delta: 2 files changed, 6 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I36d26089d29933e363d9fa50f3174530b698450e
Gerrit-Change-Number: 731040
Gerrit-PatchSet: 1
Gerrit-Owner: Lin Lin <linsite...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Cherry Mui (Gerrit)

unread,
Dec 18, 2025, 11:41:17 AM (yesterday) Dec 18
to Lin Lin, goph...@pubsubhelper.golang.org, Than McIntosh, golang-co...@googlegroups.com
Attention needed from Lin Lin and Than McIntosh

Cherry Mui voted

Code-Review+2
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lin Lin
  • Than McIntosh
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I36d26089d29933e363d9fa50f3174530b698450e
Gerrit-Change-Number: 731040
Gerrit-PatchSet: 1
Gerrit-Owner: Lin Lin <linsite...@gmail.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Than McIntosh <th...@golang.org>
Gerrit-Attention: Than McIntosh <th...@golang.org>
Gerrit-Attention: Lin Lin <linsite...@gmail.com>
Gerrit-Comment-Date: Thu, 18 Dec 2025 16:41:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Knyszek (Gerrit)

unread,
Dec 18, 2025, 4:41:41 PM (20 hours ago) Dec 18
to Lin Lin, goph...@pubsubhelper.golang.org, Go LUCI, Cherry Mui, Than McIntosh, golang-co...@googlegroups.com
Attention needed from Lin Lin and Than McIntosh

Michael Knyszek voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lin Lin
  • Than McIntosh
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I36d26089d29933e363d9fa50f3174530b698450e
    Gerrit-Change-Number: 731040
    Gerrit-PatchSet: 1
    Gerrit-Owner: Lin Lin <linsite...@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
    Gerrit-Reviewer: Than McIntosh <th...@golang.org>
    Gerrit-Attention: Than McIntosh <th...@golang.org>
    Gerrit-Attention: Lin Lin <linsite...@gmail.com>
    Gerrit-Comment-Date: Thu, 18 Dec 2025 21:41:37 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Lin Lin (Gerrit)

    unread,
    3:43 AM (9 hours ago) 3:43 AM
    to goph...@pubsubhelper.golang.org, Go LUCI, Cherry Mui, Than McIntosh, golang-co...@googlegroups.com
    Attention needed from Than McIntosh

    Lin Lin added 1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Lin Lin . resolved

    CL is ready to merge

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Than McIntosh
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I36d26089d29933e363d9fa50f3174530b698450e
    Gerrit-Change-Number: 731040
    Gerrit-PatchSet: 1
    Gerrit-Owner: Lin Lin <linsite...@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
    Gerrit-Reviewer: Than McIntosh <th...@golang.org>
    Gerrit-Attention: Than McIntosh <th...@golang.org>
    Gerrit-Comment-Date: Fri, 19 Dec 2025 08:43:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages