[go] runtime/cgo: deduplicate x_cgo_init and crosscall1

2 views
Skip to first unread message

Quim Muntal (Gerrit)

unread,
Oct 1, 2025, 5:06:29 AM (23 hours ago) Oct 1
to goph...@pubsubhelper.golang.org, Ian Lance Taylor, Keith Randall, Go LUCI, golang-co...@googlegroups.com
Attention needed from Ian Lance Taylor and Keith Randall

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Ian Lance Taylor
  • Keith Randall
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ib2eeb6456caa5c055e1ac1907c2fdf63db58dafc
Gerrit-Change-Number: 708035
Gerrit-PatchSet: 15
Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Keith Randall <k...@google.com>
Gerrit-Comment-Date: Wed, 01 Oct 2025 09:06:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Ingo Oeser (Gerrit)

unread,
Oct 1, 2025, 4:34:12 PM (12 hours ago) Oct 1
to Quim Muntal, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Keith Randall, Go LUCI, golang-co...@googlegroups.com
Attention needed from Ian Lance Taylor, Keith Randall and Quim Muntal

Ingo Oeser added 3 comments

Patchset-level comments
File-level comment, Patchset 15 (Latest):
Ingo Oeser . resolved

I wouldn't do the iOS/Darwin merge.

But let others chime in, if you consider it worth it

File src/runtime/cgo/gcc_ios_arm64.c
Line 16, Patchset 15 (Parent):#if TARGET_OS_IPHONE
Ingo Oeser . unresolved

I wouldn't share the iOS and Darwin part if the cost is a large ifdef section.

Line 25, Patchset 15 (Latest):#if TARGET_OS_IPHONE
Ingo Oeser . unresolved

Isn't this ifdef the same as in line 15? So I doubt it has the intended effect.

Open in Gerrit

Related details

Attention is currently required from:
  • Ian Lance Taylor
  • Keith Randall
  • Quim Muntal
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ib2eeb6456caa5c055e1ac1907c2fdf63db58dafc
    Gerrit-Change-Number: 708035
    Gerrit-PatchSet: 15
    Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Reviewer: Keith Randall <k...@google.com>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-CC: Ingo Oeser <night...@googlemail.com>
    Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Attention: Keith Randall <k...@google.com>
    Gerrit-Comment-Date: Wed, 01 Oct 2025 20:34:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages