[website] _content/doc/go1.26: add note for http.Client cookie Host change

1 view
Skip to first unread message

Sean Liao (Gerrit)

unread,
Dec 15, 2025, 5:59:36 PM (21 hours ago) Dec 15
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Sean Liao has uploaded the change for review

Commit message

_content/doc/go1.26: add note for http.Client cookie Host change

For #38988
Change-Id: I5fef28163bccd10a5f7163b2a6fbf0f26a6a6964

Change diff

diff --git a/_content/doc/go1.26.md b/_content/doc/go1.26.md
index 8a1ce85..0536a2c 100644
--- a/_content/doc/go1.26.md
+++ b/_content/doc/go1.26.md
@@ -517,6 +517,10 @@
 which manages a pool of connections.
 `NewClientConn` is useful for users who need to implement their own connection management.
 
+[`Client`](/pkg/net/http#Client) now uses and sets cookies scoped to URLs with the host portion matching
+[`Request.Host`](/pkg/net/http#Request.Host) when available.
+Previously, the connection address host was always used.
+
 #### [`net/http/httptest`](/pkg/net/http/httptest/)
 
 The HTTP client returned by [`Server.Client`](/pkg/net/http/httptest#Server.Client) will now redirect requests for

Change information

Files:
Change size: XS
Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: website
Gerrit-Branch: master
Gerrit-Change-Id: I5fef28163bccd10a5f7163b2a6fbf0f26a6a6964
Gerrit-Change-Number: 730280
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Liao <se...@liao.dev>
unsatisfied_requirement
satisfied_requirement
open
diffy

Sean Liao (Gerrit)

unread,
Dec 15, 2025, 5:59:51 PM (21 hours ago) Dec 15
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Sean Liao uploaded new patchset

Sean Liao uploaded patch set #2 to this change.
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: website
Gerrit-Branch: master
Gerrit-Change-Id: I5fef28163bccd10a5f7163b2a6fbf0f26a6a6964
Gerrit-Change-Number: 730280
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Liao <se...@liao.dev>
unsatisfied_requirement
satisfied_requirement
open
diffy

Sean Liao (Gerrit)

unread,
Dec 15, 2025, 6:00:18 PM (21 hours ago) Dec 15
to goph...@pubsubhelper.golang.org, Damien Neil, Ian Lance Taylor, golang-co...@googlegroups.com
Attention needed from Damien Neil and Ian Lance Taylor

Sean Liao voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Damien Neil
  • Ian Lance Taylor
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: website
Gerrit-Branch: master
Gerrit-Change-Id: I5fef28163bccd10a5f7163b2a6fbf0f26a6a6964
Gerrit-Change-Number: 730280
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Liao <se...@liao.dev>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Sean Liao <se...@liao.dev>
Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Damien Neil <dn...@google.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 23:00:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Ian Lance Taylor (Gerrit)

unread,
Dec 15, 2025, 6:00:52 PM (21 hours ago) Dec 15
to goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, Damien Neil, golang-co...@googlegroups.com
Attention needed from Damien Neil and Sean Liao

Ian Lance Taylor voted and added 1 comment

Votes added by Ian Lance Taylor

Code-Review+2

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Ian Lance Taylor . resolved

Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Damien Neil
  • Sean Liao
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: website
Gerrit-Branch: master
Gerrit-Change-Id: I5fef28163bccd10a5f7163b2a6fbf0f26a6a6964
Gerrit-Change-Number: 730280
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Liao <se...@liao.dev>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Sean Liao <se...@liao.dev>
Gerrit-Attention: Sean Liao <se...@liao.dev>
Gerrit-Attention: Damien Neil <dn...@google.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 23:00:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Knyszek (Gerrit)

unread,
11:16 AM (3 hours ago) 11:16 AM
to goph...@pubsubhelper.golang.org, Go LUCI, Ian Lance Taylor, Damien Neil, golang-co...@googlegroups.com
Attention needed from Damien Neil and Sean Liao

Michael Knyszek voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Damien Neil
  • Sean Liao
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: website
    Gerrit-Branch: master
    Gerrit-Change-Id: I5fef28163bccd10a5f7163b2a6fbf0f26a6a6964
    Gerrit-Change-Number: 730280
    Gerrit-PatchSet: 2
    Gerrit-Owner: Sean Liao <se...@liao.dev>
    Gerrit-Reviewer: Damien Neil <dn...@google.com>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
    Gerrit-Reviewer: Sean Liao <se...@liao.dev>
    Gerrit-Attention: Sean Liao <se...@liao.dev>
    Gerrit-Attention: Damien Neil <dn...@google.com>
    Gerrit-Comment-Date: Tue, 16 Dec 2025 16:16:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Damien Neil (Gerrit)

    unread,
    12:05 PM (3 hours ago) 12:05 PM
    to goph...@pubsubhelper.golang.org, Go LUCI, Ian Lance Taylor, golang-co...@googlegroups.com
    Attention needed from Sean Liao

    Damien Neil voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sean Liao
    Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: website
      Gerrit-Branch: master
      Gerrit-Change-Id: I5fef28163bccd10a5f7163b2a6fbf0f26a6a6964
      Gerrit-Change-Number: 730280
      Gerrit-PatchSet: 2
      Gerrit-Owner: Sean Liao <se...@liao.dev>
      Gerrit-Reviewer: Damien Neil <dn...@google.com>
      Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
      Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
      Gerrit-Reviewer: Sean Liao <se...@liao.dev>
      Gerrit-Attention: Sean Liao <se...@liao.dev>
      Gerrit-Comment-Date: Tue, 16 Dec 2025 17:05:13 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Sean Liao (Gerrit)

      unread,
      12:18 PM (2 hours ago) 12:18 PM
      to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Damien Neil, Michael Knyszek, Go LUCI, Ian Lance Taylor, golang-co...@googlegroups.com

      Sean Liao submitted the change

      Change information

      Commit message:
      _content/doc/go1.26: add note for http.Client cookie Host change

      For golang/go#38988
      Change-Id: I5fef28163bccd10a5f7163b2a6fbf0f26a6a6964
      Reviewed-by: Michael Knyszek <mkny...@google.com>
      Reviewed-by: Damien Neil <dn...@google.com>
      Reviewed-by: Ian Lance Taylor <ia...@golang.org>
      Files:
      Change size: XS
      Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
      Branch: refs/heads/master
      Submit Requirements:
      • requirement satisfiedCode-Review: +2 by Damien Neil, +2 by Michael Knyszek, +2 by Ian Lance Taylor
      • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
       Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      


       Gerrit-MessageType: merged 
      

       Gerrit-Project: website 
      

       Gerrit-Branch: master 
      

       Gerrit-Change-Id: I5fef28163bccd10a5f7163b2a6fbf0f26a6a6964 
      

       Gerrit-Change-Number: 730280 
      

       Gerrit-PatchSet: 3 
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages