[go] cmd/compile: enable CSE of pure calls.

7 views
Skip to first unread message

David Chase (Gerrit)

unread,
Oct 6, 2023, 5:17:36 PM10/6/23
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

David Chase has uploaded this change for review.

View Change

cmd/compile: enable CSE of pure calls.

Change-Id: Ifbd2c42d08e6a11fae93b355dd858685a7745084
---
M src/cmd/compile/internal/ssa/cse.go
1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/cmd/compile/internal/ssa/cse.go b/src/cmd/compile/internal/ssa/cse.go
index d649797..53f315d 100644
--- a/src/cmd/compile/internal/ssa/cse.go
+++ b/src/cmd/compile/internal/ssa/cse.go
@@ -310,7 +310,16 @@
 		}
 	}
 
-	if v.Aux != w.Aux {
+	if v.Op == OpPureLECall {
+		va := v.Aux.(*AuxCall)
+		wa := w.Aux.(*AuxCall)
+		if va.Fn.Name != wa.Fn.Name {
+			if va.Fn.Name < wa.Fn.Name {
+				return types.CMPlt
+			}
+			return types.CMPgt
+		}
+	} else if v.Aux != w.Aux {
 		if v.Aux == nil {
 			return types.CMPlt
 		}

To view, visit change 533266. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ifbd2c42d08e6a11fae93b355dd858685a7745084
Gerrit-Change-Number: 533266
Gerrit-PatchSet: 1
Gerrit-Owner: David Chase <drc...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>

David Chase (Gerrit)

unread,
Oct 27, 2023, 6:06:27 PM10/27/23
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention is currently required from: David Chase, Keith Randall, Martin Möhrmann.

David Chase uploaded patch set #2 to this change.

View Change

The following approvals got outdated and were removed: Run-TryBot+1 by David Chase, TryBot-Result-1 by Gopher Robot

cmd/compile: enable CSE of const calls.


Change-Id: Ifbd2c42d08e6a11fae93b355dd858685a7745084
---
M src/cmd/compile/internal/ssa/cse.go
1 file changed, 10 insertions(+), 1 deletion(-)

To view, visit change 533266. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ifbd2c42d08e6a11fae93b355dd858685a7745084
Gerrit-Change-Number: 533266
Gerrit-PatchSet: 2
Gerrit-Owner: David Chase <drc...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>
Gerrit-Attention: David Chase <drc...@google.com>
Gerrit-Attention: Martin Möhrmann <moeh...@google.com>
Gerrit-Attention: Keith Randall <k...@golang.org>

Keith Randall (Gerrit)

unread,
Oct 30, 2023, 5:15:04 PM10/30/23
to David Chase, goph...@pubsubhelper.golang.org, Keith Randall, Gopher Robot, Martin Möhrmann, golang-co...@googlegroups.com

Attention is currently required from: David Chase, Martin Möhrmann.

Patch set 2:Code-Review +2

View Change

    To view, visit change 533266. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ifbd2c42d08e6a11fae93b355dd858685a7745084
    Gerrit-Change-Number: 533266
    Gerrit-PatchSet: 2
    Gerrit-Owner: David Chase <drc...@google.com>
    Gerrit-Reviewer: David Chase <drc...@google.com>
    Gerrit-Reviewer: Gopher Robot <go...@golang.org>
    Gerrit-Reviewer: Keith Randall <k...@golang.org>
    Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>
    Gerrit-Attention: David Chase <drc...@google.com>
    Gerrit-Attention: Martin Möhrmann <moeh...@google.com>
    Gerrit-Comment-Date: Mon, 30 Oct 2023 21:14:59 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    Cherry Mui (Gerrit)

    unread,
    Nov 2, 2023, 2:44:03 PM11/2/23
    to David Chase, goph...@pubsubhelper.golang.org, Gopher Robot, Keith Randall, Martin Möhrmann, golang-co...@googlegroups.com

    Attention is currently required from: David Chase, Martin Möhrmann.

    Patch set 3:Code-Review +1

    View Change

      To view, visit change 533266. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Ifbd2c42d08e6a11fae93b355dd858685a7745084
      Gerrit-Change-Number: 533266
      Gerrit-PatchSet: 3
      Gerrit-Owner: David Chase <drc...@google.com>
      Gerrit-Reviewer: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: David Chase <drc...@google.com>
      Gerrit-Reviewer: Gopher Robot <go...@golang.org>
      Gerrit-Reviewer: Keith Randall <k...@golang.org>
      Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>
      Gerrit-Attention: David Chase <drc...@google.com>
      Gerrit-Attention: Martin Möhrmann <moeh...@google.com>
      Gerrit-Comment-Date: Thu, 02 Nov 2023 18:43:58 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes

      David Chase (Gerrit)

      unread,
      3:22 PM (6 hours ago) 3:22 PM
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from Martin Möhrmann

      David Chase uploaded new patchset

      David Chase uploaded patch set #5 to this change.
      Following approvals got outdated and were removed:
      • TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Martin Möhrmann
      Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Ifbd2c42d08e6a11fae93b355dd858685a7745084
      Gerrit-Change-Number: 533266
      Gerrit-PatchSet: 5
      Gerrit-Owner: David Chase <drc...@google.com>
      Gerrit-Reviewer: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: David Chase <drc...@google.com>
      Gerrit-Reviewer: Gopher Robot <go...@golang.org>
      Gerrit-Reviewer: Keith Randall <k...@golang.org>
      Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>
      Gerrit-Attention: Martin Möhrmann <moeh...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages