[oscar] all: go fix -fmtappendf ./...
1 view
Skip to first unread message
Hyang-Ah Hana Kim (Gerrit)
Feb 26, 2026, 10:07:56 PM (20 hours ago) Feb 26
to goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com
Hyang-Ah Hana Kim has uploaded the change for review![]( "Open in Gerrit")
Commit message
all: go fix -fmtappendf ./...
Change-Id: If035ab3dc9b53381f3b6ca5bd524f3988ff491f1
Change diff
diff --git a/internal/gaby/actionlog.go b/internal/gaby/actionlog.go
index e81581d..d1b96a3 100644
--- a/internal/gaby/actionlog.go
+++ b/internal/gaby/actionlog.go
@@ -272,7 +272,7 @@
Approved: decision == "Approve",
}
actions.AddDecision(g.db, kind, key, d)
- return []byte(fmt.Sprintf("decision: %+v", d)), http.StatusOK, nil
+ return fmt.Appendf(nil, "decision: %+v", d), http.StatusOK, nil
}
func (g *Gaby) handleActionRerun(w http.ResponseWriter, r *http.Request) {
diff --git a/internal/pebble/pebble_test.go b/internal/pebble/pebble_test.go
index 56a93ed..a2b7a78 100644
--- a/internal/pebble/pebble_test.go
+++ b/internal/pebble/pebble_test.go
@@ -66,7 +66,7 @@
binary.BigEndian.PutUint64(val[i:], pcg.Uint64())
}
binary.BigEndian.PutUint64(val, uint64(key))
- b.Set([]byte(fmt.Sprint(key)), val)
+ b.Set(fmt.Append(nil, key), val)
if b.MaybeApply() {
if applied++; applied == 2 {
break
@@ -76,7 +76,7 @@
b.Apply()
for key := range 200 {
- val, ok := db.Get([]byte(fmt.Sprint(key)))
+ val, ok := db.Get(fmt.Append(nil, key))
if !ok {
t.Fatalf("after batch, missing key %d", key)
}
diff --git a/internal/storage/test.go b/internal/storage/test.go
index e56acd1..8e9ddd8 100644
--- a/internal/storage/test.go
+++ b/internal/storage/test.go
@@ -42,7 +42,7 @@
b := db.Batch()
for i := range 10 {
- b.Set(ordered.Encode(i), []byte(fmt.Sprint(i)))
+ b.Set(ordered.Encode(i), fmt.Append(nil, i))
b.MaybeApply()
}
b.Apply()
@@ -102,7 +102,7 @@
b = db.Batch()
for i := range 5 {
b.Delete(ordered.Encode(i))
- b.Set(ordered.Encode(2*i), []byte(fmt.Sprint(2*i)))
+ b.Set(ordered.Encode(2*i), fmt.Append(nil, 2*i))
}
b.DeleteRange(ordered.Encode(0), ordered.Encode(0))
b.Apply()
Change information
Files:
- M internal/gaby/actionlog.go
- M internal/pebble/pebble_test.go
- M internal/storage/test.go
Change size: S
Delta: 3 files changed, 5 insertions(+), 5 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Lance Taylor (Gerrit)
Feb 26, 2026, 11:34:24 PM (19 hours ago) Feb 26
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Ian Lance Taylor voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
4:39 PM (2 hours ago) 4:39 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Nicholas Husin, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Cherry Mui voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
4:39 PM (2 hours ago) 4:39 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyang-Ah Hana Kim (Gerrit)
4:44 PM (2 hours ago) 4:44 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Cherry Mui, Nicholas Husin, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Hyang-Ah Hana Kim submitted the change![]( "Open in Gerrit")
Change information
Commit message:
all: go fix -fmtappendf ./...
Change-Id: If035ab3dc9b53381f3b6ca5bd524f3988ff491f1
Reviewed-on: https://go-review.googlesource.com/c/oscar/+/749642
Reviewed-by: Ian Lance Taylor <ia...@golang.org>
Reviewed-by: Nicholas Husin <hu...@google.com>
Commit-Queue: Cherry Mui <cher...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M internal/gaby/actionlog.go
- M internal/pebble/pebble_test.go
- M internal/storage/test.go
Change size: S
Delta: 3 files changed, 5 insertions(+), 5 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Ian Lance Taylor, +1 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages