[go] syscall: enable netlink support on FreeBSD
Gopher Robot (Gerrit)
Gopher Robot added 1 comment![]( "Open in Gerrit")
I spotted some possible problems.
These findings are based on simple heuristics. If a finding appears wrong, briefly reply here saying so. Otherwise, please address any problems and update the GitHub PR. When complete, mark this comment as 'Done' and click the [blue 'Reply' button](https://go.dev/wiki/GerritBot#i-left-a-reply-to-a-comment-in-gerrit-but-no-one-but-me-can-see-it) above.
Possible problems detected:
1. You usually need to reference a bug number for all but trivial or cosmetic fixes. For this repo, the format is usually 'Fixes #12345' or 'Updates #12345' at the end of the commit message. Should you have a bug reference?
The commit title and commit message body come from the GitHub PR title and description, and must be edited in the GitHub web interface (not via git). For instructions, see [here](https://go.dev/wiki/GerritBot/#how-does-gerritbot-determine-the-final-commit-message). For guidelines on commit messages for the Go project, see [here](https://go.dev/doc/contribute#commit_messages).
(In general for Gerrit code reviews, the change author is expected to [log in to Gerrit](https://go-review.googlesource.com/login/) with a Gmail or other Google account and then close out each piece of feedback by marking it as 'Done' if implemented as suggested or otherwise reply to each review comment. See the [Review](https://go.dev/doc/contribute#review) section of the Contributing Guide for details.)
Related details
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gerrit Bot (Gerrit)
Gerrit Bot has uploaded the change for review![]( "Open in Gerrit")
Commit message
syscall: enable netlink support on FreeBSD
- enable netlink support on FreeBSD
- rebuild syscalls for Tier 1 architectures (arm64 & amd64) and 386
Change diff
Change information
- M src/syscall/netlink_linux.go
- M src/syscall/types_freebsd.go
- M src/syscall/zerrors_freebsd_386.go
- M src/syscall/zerrors_freebsd_amd64.go
- M src/syscall/zerrors_freebsd_arm64.go
- M src/syscall/zsysnum_freebsd_386.go
- M src/syscall/zsysnum_freebsd_amd64.go
- M src/syscall/zsysnum_freebsd_arm64.go
- M src/syscall/ztypes_freebsd_386.go
- M src/syscall/ztypes_freebsd_amd64.go
- M src/syscall/ztypes_freebsd_arm64.go
Related details
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Message from Gopher Robot![]( "Open in Gerrit")
Congratulations on opening your first change. Thank you for your contribution!
Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.
Related details
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jorropo (Gerrit)
Jorropo voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Brad Fitzpatrick
- Ian Lance Taylor
- Tobias Klauser
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gerrit Bot (Gerrit)
Gerrit Bot uploaded new patchset![]( "Open in Gerrit")
- TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
Related details
- Brad Fitzpatrick
- Ian Lance Taylor
- Jorropo
- Tobias Klauser
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Lance Taylor (Gerrit)
Ian Lance Taylor added 2 comments![]( "Open in Gerrit")
//!build linux freebsdThis isn't going to do anything. How did you test this?
AF_APPLETALK = 0x10In general we don't want to arbitrarily update these files. We want people to use the golang.org/x/sys/unix package if they need any newer funtionality. We should only update these files where they are incorrect.
Related details
- Brad Fitzpatrick
- Jorropo
- Tobias Klauser
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mina Galić (Gerrit)
Mina Galić added 2 comments![]( "Open in Gerrit")
//!build linux freebsdThis isn't going to do anything. How did you test this?
There was quite a lot of strange and bogus changes that mkall.sh produced, I must've missed this one.
AF_APPLETALK = 0x10In general we don't want to arbitrarily update these files. We want people to use the golang.org/x/sys/unix package if they need any newer funtionality. We should only update these files where they are incorrect.
I guess I would have to be way more selective about to commit in such a change.
re newer functionality: the main purpose is to add AF_NETLINK as known constant to FreeBSD, and thus allow FreeBSD to use the existing netlink related syscalls.
Related details
- Brad Fitzpatrick
- Ian Lance Taylor
- Jorropo
- Tobias Klauser
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |