[go] cmd/go/internal/doc: clean up after merge with cmd/internal/doc
6 views
Skip to first unread message
Michael Matloob (Gerrit)
Jul 23, 2025, 3:55:51 PMJul 23
to goph...@pubsubhelper.golang.org, Michael Pratt, Ian Alexander, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Pratt
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
Jul 23, 2025, 5:09:13 PMJul 23
to Michael Matloob, goph...@pubsubhelper.golang.org, Michael Pratt, Go LUCI, Ian Alexander, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Michael Pratt voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Pratt
| Code-Review | +2 |
1 comment
File src/cmd/go/internal/doc/doc.go
Line 10, Patchset 5 (Latest):
"cmd/go/internal/base"Michael Pratt . unresolved
nit: any reason cmd/go is up here but cmd/internal is below?
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 24, 2025, 10:51:51 AMJul 24
to goph...@pubsubhelper.golang.org, Michael Pratt, Go LUCI, Ian Alexander, golang-co...@googlegroups.com
Michael Matloob added 1 comment![]( "Open in Gerrit")
File src/cmd/go/internal/doc/doc.go
nit: any reason cmd/go is up here but cmd/internal is below?
Michael Matloob
was an oversight. fixed.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 24, 2025, 10:51:51 AMJul 24
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #6 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 24, 2025, 10:52:27 AMJul 24
to goph...@pubsubhelper.golang.org, Michael Pratt, Go LUCI, Ian Alexander, golang-co...@googlegroups.com
Michael Matloob voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
No-Wait-Release
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 24, 2025, 12:59:32 PMJul 24
to Michael Matloob, goph...@pubsubhelper.golang.org, Go LUCI, Michael Pratt, Ian Alexander, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 24, 2025, 12:59:50 PMJul 24
to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Michael Pratt, Ian Alexander, golang-co...@googlegroups.com
Michael Matloob submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/cmd/go/internal/doc/doc.go
Insertions: 1, Deletions: 1.
@@ -7,7 +7,6 @@
import (
"bytes"
- "cmd/go/internal/base"
"context"
"flag"
"fmt"
@@ -21,6 +20,7 @@
"path/filepath"
"strings"
+ "cmd/go/internal/base"
"cmd/internal/telemetry/counter"
)
```
Change information
Commit message:
cmd/go/internal/doc: clean up after merge with cmd/internal/doc
This is done in a separate CL to reduce the diffs from the previous CL.
Merge the main.go and doc.go files, and isolate the bootstrap-tagged
code to one file.
For #74667
Change-Id: I11bf0aa18beeb898937135f49f473c1ba1b7e756
Reviewed-on: https://go-review.googlesource.com/c/go/+/689875
Reviewed-by: Michael Matloob <mat...@google.com>
Auto-Submit: Michael Matloob <mat...@golang.org>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpr...@google.com>
Files:
- M src/cmd/go/internal/doc/dirs.go
- M src/cmd/go/internal/doc/doc.go
- D src/cmd/go/internal/doc/main.go
- M src/cmd/go/internal/doc/pkg.go
- A src/cmd/go/internal/doc/pkgsite.go
- R src/cmd/go/internal/doc/pkgsite_bootstrap.go
Change size: XL
Delta: 6 files changed, 524 insertions(+), 531 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Michael Matloob, +2 by Michael Pratt
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tadeusz Cieślik (Gerrit)
Dec 27, 2025, 6:38:25 AM (yesterday) Dec 27
to Michael Matloob, Michael Matloob, goph...@pubsubhelper.golang.org, Go LUCI, Michael Pratt, Ian Alexander, golang-co...@googlegroups.com
Tadeusz Cieślik voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages