[crypto] ssh: permit empty but non-nil HostKeyAlgorithms, KeyExchanges, Ciphers, MACs
3 views
Skip to first unread message
Ian Chen (Gerrit)
Jul 13, 2026, 8:09:11 AM (9 days ago) Jul 13
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Ian Chen has uploaded the change for review![]( "Open in Gerrit")
Commit message
ssh: permit empty but non-nil HostKeyAlgorithms, KeyExchanges, Ciphers, MACs
The documentation of ClientConfig.HostKeyAlgorithms says:
If empty, a reasonable default is used.
However, if HostKeyAlgorithms is empty but non-nil, the reasonable default
won't be applied, and the SSH handshake will fail. Fix this by changing the nil
check to a length check.
While here, do the same for KeyExchanges, Ciphers, MACs in Config.
Change-Id: I1b3d2d2159f3c7d57a9a690ad04f1f6818b39a5c
Change diff
diff --git a/ssh/common.go b/ssh/common.go
index 2e44e9c..613b7db 100644
--- a/ssh/common.go
+++ b/ssh/common.go
@@ -544,7 +544,7 @@
if c.Rand == nil {
c.Rand = rand.Reader
}
- if c.Ciphers == nil {
+ if len(c.Ciphers) == 0 {
c.Ciphers = defaultCiphers
}
var ciphers []string
@@ -556,7 +556,7 @@
}
c.Ciphers = ciphers
- if c.KeyExchanges == nil {
+ if len(c.KeyExchanges) == 0 {
c.KeyExchanges = defaultKexAlgos
}
var kexs []string
@@ -571,7 +571,7 @@
}
c.KeyExchanges = kexs
- if c.MACs == nil {
+ if len(c.MACs) == 0 {
c.MACs = defaultMACs
}
var macs []string
diff --git a/ssh/handshake.go b/ssh/handshake.go
index 4be3cbb..711a7f7 100644
--- a/ssh/handshake.go
+++ b/ssh/handshake.go
@@ -162,7 +162,7 @@
t.remoteAddr = addr
t.hostKeyCallback = config.HostKeyCallback
t.bannerCallback = config.BannerCallback
- if config.HostKeyAlgorithms != nil {
+ if len(config.HostKeyAlgorithms) > 0 {
t.hostKeyAlgorithms = config.HostKeyAlgorithms
} else {
t.hostKeyAlgorithms = defaultHostKeyAlgos
Change information
Files:
- M ssh/common.go
- M ssh/handshake.go
Change size: XS
Delta: 2 files changed, 4 insertions(+), 4 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Chen (Gerrit)
Jul 13, 2026, 8:10:57 AM (9 days ago) Jul 13
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Ian Chen uploaded new patchset![]( "Open in Gerrit")
Ian Chen uploaded patch set #2 to this change.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Filippo Valsorda (Gerrit)
Jul 21, 2026, 6:23:14 AM (18 hours ago) Jul 21
to Ian Chen, goph...@pubsubhelper.golang.org, Filippo Valsorda, Nicola Murino, Roland Shoemaker, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Ian Chen and Nicola Murino
Filippo Valsorda voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Ian Chen
- Nicola Murino
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicola Murino (Gerrit)
Jul 21, 2026, 6:23:19 AM (18 hours ago) Jul 21
to Ian Chen, goph...@pubsubhelper.golang.org, Filippo Valsorda, Roland Shoemaker, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Ian Chen
Nicola Murino voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Ian Chen
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicola Murino (Gerrit)
Jul 21, 2026, 6:23:33 AM (18 hours ago) Jul 21
to Ian Chen, goph...@pubsubhelper.golang.org, Filippo Valsorda, Roland Shoemaker, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Ian Chen
Nicola Murino voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Ian Chen
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
Jul 21, 2026, 5:31:59 PM (7 hours ago) Jul 21
to Ian Chen, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Nicola Murino, Filippo Valsorda, Roland Shoemaker, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Ian Chen
Carlos Amedee voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Ian Chen
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
Jul 21, 2026, 7:25:17 PM (5 hours ago) Jul 21
to Ian Chen, goph...@pubsubhelper.golang.org, Carlos Amedee, golang...@luci-project-accounts.iam.gserviceaccount.com, Nicola Murino, Filippo Valsorda, Roland Shoemaker, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Ian Chen
Cherry Mui voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Ian Chen
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages