[go] internal/trace/version: change message to lowercase idiomatic go
Gopher Robot (Gerrit)
Gopher Robot added 1 comment![]( "Open in Gerrit")
I spotted some possible problems with your PR:
1. You usually need to reference a bug number for all but trivial or cosmetic fixes. For this repo, the format is usually 'Fixes #12345' or 'Updates #12345' at the end of the commit message. Should you have a bug reference?
Please address any problems by updating the GitHub PR.
When complete, mark this comment as 'Done' and click the [blue 'Reply' button](https://go.dev/wiki/GerritBot#i-left-a-reply-to-a-comment-in-gerrit-but-no-one-but-me-can-see-it) above. These findings are based on heuristics; if a finding does not apply, briefly reply here saying so.
To update the commit title or commit message body shown here in Gerrit, you must edit the GitHub PR title and PR description (the first comment) in the GitHub web interface using the 'Edit' button or 'Edit' menu entry there. Note: pushing a new commit to the PR will not automatically update the commit message used by Gerrit.
For more details, see:
- [how to update commit messages](https://go.dev/wiki/GerritBot/#how-does-gerritbot-determine-the-final-commit-message) for PRs imported into Gerrit.
- the Go project's [conventions for commit messages](https://go.dev/doc/contribute#commit_messages) that you should follow.
(In general for Gerrit code reviews, the change author is expected to [log in to Gerrit](https://go-review.googlesource.com/login/) with a Gmail or other Google account and then close out each piece of feedback by marking it as 'Done' if implemented as suggested or otherwise reply to each review comment. See the [Review](https://go.dev/doc/contribute#review) section of the Contributing Guide for details.)
Related details
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gerrit Bot (Gerrit)
Gerrit Bot has uploaded the change for review![]( "Open in Gerrit")
Commit message
internal/trace/version: change message to lowercase idiomatic go
Change message to lowercase idiomatic go.
Change diff
diff --git a/src/internal/trace/version/version.go b/src/internal/trace/version/version.go
index 328a261..c350260b 100644
--- a/src/internal/trace/version/version.go
+++ b/src/internal/trace/version/version.go
@@ -56,7 +56,7 @@
if int(typ) < len(s) && s[typ].Name != "" {
return s[typ].Name
}
- return fmt.Sprintf("Invalid(%d)", typ)
+ return fmt.Sprintf("invalid(%d)", typ)
}
func (v Version) Valid() bool {
Change information
- M src/internal/trace/version/version.go
Related details
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jorge Pinto (Gerrit)
Jorge Pinto added 1 comment![]( "Open in Gerrit")
I spotted some possible problems with your PR:
1. You usually need to reference a bug number for all but trivial or cosmetic fixes. For this repo, the format is usually 'Fixes #12345' or 'Updates #12345' at the end of the commit message. Should you have a bug reference?Please address any problems by updating the GitHub PR.
When complete, mark this comment as 'Done' and click the [blue 'Reply' button](https://go.dev/wiki/GerritBot#i-left-a-reply-to-a-comment-in-gerrit-but-no-one-but-me-can-see-it) above. These findings are based on heuristics; if a finding does not apply, briefly reply here saying so.
To update the commit title or commit message body shown here in Gerrit, you must edit the GitHub PR title and PR description (the first comment) in the GitHub web interface using the 'Edit' button or 'Edit' menu entry there. Note: pushing a new commit to the PR will not automatically update the commit message used by Gerrit.
For more details, see:
- [how to update commit messages](https://go.dev/wiki/GerritBot/#how-does-gerritbot-determine-the-final-commit-message) for PRs imported into Gerrit.
- the Go project's [conventions for commit messages](https://go.dev/doc/contribute#commit_messages) that you should follow.
(In general for Gerrit code reviews, the change author is expected to [log in to Gerrit](https://go-review.googlesource.com/login/) with a Gmail or other Google account and then close out each piece of feedback by marking it as 'Done' if implemented as suggested or otherwise reply to each review comment. See the [Review](https://go.dev/doc/contribute#review) section of the Contributing Guide for details.)
Done
Related details
- Michael Knyszek
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
t hepudds (Gerrit)
t hepudds added 1 comment![]( "Open in Gerrit")
return fmt.Sprintf("invalid(%d)", typ)I suspect the original author of this code intended to use a capital letter here for `Invalid` (which would make it match valid `s[typ].Name` values, which might be strings like `CPUSamples`, `Frequency`, `ProcStart`, etc.).
If so, changing the case here would not be an improvement.
Separately, I noticed you have sent [a dozen or so changes](https://go-review.googlesource.com/q/author:jorg...@gmail.com) in the last day or so that make similar type of changes (e.g., changing the casing of test failure messages, etc.).
From a quick look, not all of them are improvements.
I would suggest you hold off on sending more changes until you get feedback on what you've already sent.
This can help make it more efficient for everyone, including for you and the maintainers. And thank you for your interest in helping to improve Go.
Related details
- Michael Knyszek
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jorge Pinto (Gerrit)
Jorge Pinto added 1 comment![]( "Open in Gerrit")
return fmt.Sprintf("invalid(%d)", typ)I suspect the original author of this code intended to use a capital letter here for `Invalid` (which would make it match valid `s[typ].Name` values, which might be strings like `CPUSamples`, `Frequency`, `ProcStart`, etc.).
If so, changing the case here would not be an improvement.
Separately, I noticed you have sent [a dozen or so changes](https://go-review.googlesource.com/q/author:jorg...@gmail.com) in the last day or so that make similar type of changes (e.g., changing the casing of test failure messages, etc.).
From a quick look, not all of them are improvements.
I would suggest you hold off on sending more changes until you get feedback on what you've already sent.
This can help make it more efficient for everyone, including for you and the maintainers. And thank you for your interest in helping to improve Go.
- Michael Knyszek
- Michael Pratt
- t hepudds
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |