[go] runtime: try shortening malloc path
1 view
Skip to first unread message
Michael Matloob (Gerrit)
May 18, 2026, 9:48:55 AM (22 hours ago) May 18
to goph...@pubsubhelper.golang.org, Michael Pratt, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Michael Pratt
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
May 18, 2026, 1:59:12 PM (18 hours ago) May 18
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Michael Pratt
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Attention is currently required from:
- Michael Matloob
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
May 18, 2026, 4:00:17 PM (16 hours ago) May 18
to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Pratt, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Michael Pratt
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Michael Matloob
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
May 18, 2026, 4:07:34 PM (16 hours ago) May 18
to Michael Matloob, goph...@pubsubhelper.golang.org, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Pratt, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Michael Pratt added 3 comments![]( "Open in Gerrit")
File src/runtime/malloc_generated.go
Line 2638, Patchset 49 (Latest):
deductAssistCredit(size)Michael Pratt . resolved
Is it intentional that this came back? (I think it's fine given that this is the slow path, just checking)
Line 2686, Patchset 49 (Latest):
const nbytes = npages_ * 8192Michael Pratt . unresolved
Where are this and noscanint_ defined? It seems like they should be undefined to avoid invalid uses like this sneaking in (i.e., if the generator fails to replace these due to a bug, it results in a build failure).
I know this is dead code, but it looks confusing to have something totally bogus in the generated code.
File src/runtime/malloc_stubs.go
Line 86, Patchset 49 (Latest):
if !isTiny_ {Michael Pratt . unresolved
Drop this branch to make this a bit cleaner, it's unnecessary since the case above returns.
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
May 18, 2026, 4:36:05 PM (16 hours ago) May 18
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #51 to this change.
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
May 18, 2026, 4:56:24 PM (15 hours ago) May 18
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Michael Pratt
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Attention is currently required from:
- Michael Matloob
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
May 18, 2026, 4:56:24 PM (15 hours ago) May 18
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, Michael Pratt, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Michael Pratt
Michael Matloob added 3 comments![]( "Open in Gerrit")
File src/runtime/malloc_generated.go
Line 2638, Patchset 49:
deductAssistCredit(size)Michael Pratt . resolved
Is it intentional that this came back? (I think it's fine given that this is the slow path, just checking)
Michael Matloob
Oh it's not! Thanks!
Where are this and noscanint_ defined? It seems like they should be undefined to avoid invalid uses like this sneaking in (i.e., if the generator fails to replace these due to a bug, it results in a build failure).
I know this is dead code, but it looks confusing to have something totally bogus in the generated code.
Michael Matloob
I updated the stub to leave this out in the slow path case.
File src/runtime/malloc_stubs.go
Drop this branch to make this a bit cleaner, it's unnecessary since the case above returns.
Michael Matloob
Done
Related details
Attention is currently required from:
- Michael Matloob
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
May 18, 2026, 10:07:21 PM (10 hours ago) May 18
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Michael Pratt
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #54 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result-1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Michael Matloob
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
7:59 AM (10 minutes ago) 7:59 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Michael Pratt
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #55 to this change.
Related details
Attention is currently required from:
- Michael Matloob
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages