[go] cmd/compile/internal/ir: handle RHS = nil in static value
5 views
Skip to first unread message
Cuong Manh Le (Gerrit)
May 28, 2026, 4:24:56 AM (13 days ago) May 28
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Cuong Manh Le has uploaded the change for review![]( "Open in Gerrit")
Commit message
cmd/compile/internal/ir: handle RHS = nil in static value
For #5370
Change-Id: I04ca4e38e5e4d54814eb5ec50e698d190c67a652
Change diff
diff --git a/src/cmd/compile/internal/ir/expr.go b/src/cmd/compile/internal/ir/expr.go
index 9b4577b..b5ab950 100644
--- a/src/cmd/compile/internal/ir/expr.go
+++ b/src/cmd/compile/internal/ir/expr.go
@@ -916,16 +916,19 @@
return nil
}
+ var lhs Node
var rhs Node
FindRHS:
switch defn.Op() {
case OAS:
defn := defn.(*AssignStmt)
+ lhs = defn.X
rhs = defn.Y
case OAS2:
defn := defn.(*AssignListStmt)
for i, lhs := range defn.Lhs {
if lhs == n {
+ lhs = defn.Lhs[i]
rhs = defn.Rhs[i]
break FindRHS
}
@@ -935,6 +938,9 @@
return nil
}
if rhs == nil {
+ if name, ok := lhs.(*Name); ok && name.AutoTemp() {
+ return nil
+ }
base.FatalfAt(defn.Pos(), "RHS is nil: %v", defn)
}
diff --git a/src/cmd/compile/internal/ir/reassignment.go b/src/cmd/compile/internal/ir/reassignment.go
index ff3d08c..97c55e4 100644
--- a/src/cmd/compile/internal/ir/reassignment.go
+++ b/src/cmd/compile/internal/ir/reassignment.go
@@ -202,16 +202,19 @@
return nil
}
+ var lhs Node
var rhs Node
FindRHS:
switch defn.Op() {
case OAS:
defn := defn.(*AssignStmt)
+ lhs = defn.X
rhs = defn.Y
case OAS2:
defn := defn.(*AssignListStmt)
for i, lhs := range defn.Lhs {
if lhs == n {
+ lhs = defn.Lhs[i]
rhs = defn.Rhs[i]
break FindRHS
}
@@ -221,6 +224,9 @@
return nil
}
if rhs == nil {
+ if name, ok := lhs.(*Name); ok && name.AutoTemp() {
+ return nil
+ }
base.FatalfAt(defn.Pos(), "RHS is nil: %v", defn)
}
Change information
Files:
- M src/cmd/compile/internal/ir/expr.go
- M src/cmd/compile/internal/ir/reassignment.go
Change size: S
Delta: 2 files changed, 12 insertions(+), 0 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cuong Manh Le (Gerrit)
May 28, 2026, 4:25:22 AM (13 days ago) May 28
to goph...@pubsubhelper.golang.org, Keith Randall, t hepudds, golang-co...@googlegroups.com
Attention needed from Keith Randall and t hepudds
Cuong Manh Le voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Keith Randall
- t hepudds
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
May 29, 2026, 12:35:41 PM (12 days ago) May 29
to Cuong Manh Le, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, t hepudds, golang-co...@googlegroups.com
Attention needed from Cuong Manh Le and t hepudds
Keith Randall added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Cuong Manh Le
- t hepudds
Submit Requirements:
Code-Review
No-Unresolved-Comments
No-Wait-Release
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cuong Manh Le (Gerrit)
May 29, 2026, 7:31:57 PM (11 days ago) May 29
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Cuong Manh Le and t hepudds
Cuong Manh Le uploaded new patchset![]( "Open in Gerrit")
Cuong Manh Le uploaded patch set #2 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Cuong Manh Le
- t hepudds
Submit Requirements:
Code-Review
No-Unresolved-Comments
No-Wait-Release
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cuong Manh Le (Gerrit)
May 29, 2026, 7:32:29 PM (11 days ago) May 29
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, t hepudds, golang-co...@googlegroups.com
Attention needed from t hepudds
Cuong Manh Le voted![]( "Open in Gerrit")
Attention is currently required from:
- t hepudds
Submit Requirements:
Code-Review
No-Unresolved-Comments
No-Wait-Release
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cuong Manh Le (Gerrit)
May 29, 2026, 7:32:44 PM (11 days ago) May 29
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, t hepudds, golang-co...@googlegroups.com
Attention needed from Keith Randall and t hepudds
Cuong Manh Le added 1 comment![]( "Open in Gerrit")
File src/cmd/compile/internal/ir/expr.go
Won't `lhs` always be `n`?
Attention is currently required from:
- Keith Randall
- t hepudds
Submit Requirements:
Code-Review
No-Unresolved-Comments
No-Wait-Release
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Jun 8, 2026, 6:46:58 PM (2 days ago) Jun 8
to Cuong Manh Le, goph...@pubsubhelper.golang.org, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, t hepudds, golang-co...@googlegroups.com
Attention needed from Cuong Manh Le and t hepudds
Keith Randall voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Cuong Manh Le
- t hepudds
Submit Requirements:
Code-Review
No-Unresolved-Comments
No-Wait-Release
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cuong Manh Le (Gerrit)
3:38 AM (2 hours ago) 3:38 AM
to goph...@pubsubhelper.golang.org, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, t hepudds, golang-co...@googlegroups.com
Attention needed from t hepudds
Cuong Manh Le voted![]( "Open in Gerrit")
Attention is currently required from:
- t hepudds
Submit Requirements:
Code-Review
No-Unresolved-Comments
No-Wait-Release
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages