golang-codereviews - Google Groups

Groups

Contact owners and managers

1–30 of 114148

0 selected

Gerrit Bot (Gerrit)

8:50 PM

[tools] go/ssa: cache method sets by type value

Gerrit Bot has uploaded the change for review Commit message go/ssa: cache method sets by type value

unread,

[tools] go/ssa: cache method sets by type value

Gerrit Bot has uploaded the change for review Commit message go/ssa: cache method sets by type value

8:50 PM

Hongxiang Jiang (Gerrit)3

8:41 PM

[tools] gopls/internal/server: support multiple questions for the same id

Attention needed from Alex Putman and Madeline Kalil Hongxiang Jiang uploaded new patchset Hongxiang

unread,

[tools] gopls/internal/server: support multiple questions for the same id

Attention needed from Alex Putman and Madeline Kalil Hongxiang Jiang uploaded new patchset Hongxiang

8:41 PM

Hongxiang Jiang (Gerrit), Alex Putman (Gerrit)6

8:41 PM

[tools] gopls/internal/server: refactor for better ergnomic

Attention needed from Hongxiang Jiang and Madeline Kalil Hongxiang Jiang uploaded new patchset

unread,

[tools] gopls/internal/server: refactor for better ergnomic

Attention needed from Hongxiang Jiang and Madeline Kalil Hongxiang Jiang uploaded new patchset

8:41 PM

Hongxiang Jiang (Gerrit), … Alan Donovan (Gerrit)9

8:29 PM

[tools] internal/packagepath, inline: add TrimVersionSuffix to handle major version package paths

Hongxiang Jiang submitted the change Change information Commit message: internal/refactor/inline:

unread,

[tools] internal/packagepath, inline: add TrimVersionSuffix to handle major version package paths

Hongxiang Jiang submitted the change Change information Commit message: internal/refactor/inline:

8:29 PM

Gerrit Bot (Gerrit), … Rhys Hiltner (Gerrit)3

8:15 PM

[go] runtime: retake syscall Ps in stopTheWorld's and forEachP's wait loops

Attention needed from Carlos Amedee, Michael Knyszek and Michael Pratt Rhys Hiltner voted Commit-

unread,

[go] runtime: retake syscall Ps in stopTheWorld's and forEachP's wait loops

Attention needed from Carlos Amedee, Michael Knyszek and Michael Pratt Rhys Hiltner voted Commit-

8:15 PM

Gerrit Bot (Gerrit)

8:10 PM

[tools] go/ssa, cmd/deadcode: release type information once functions are built

Gerrit Bot has uploaded the change for review Commit message go/ssa, cmd/deadcode: release type

unread,

[tools] go/ssa, cmd/deadcode: release type information once functions are built

Gerrit Bot has uploaded the change for review Commit message go/ssa, cmd/deadcode: release type

8:10 PM

Alan Donovan (Gerrit), Robert Griesemer (Gerrit)8

7:16 PM

[tools] go/analysis/passes/stringintconv: make tests run under go1.28

Alan Donovan submitted the change Change information Commit message: go/analysis/passes/stringintconv

unread,

[tools] go/analysis/passes/stringintconv: make tests run under go1.28

Alan Donovan submitted the change Change information Commit message: go/analysis/passes/stringintconv

7:16 PM

Alan Donovan (Gerrit), Robert Griesemer (Gerrit)4

7:15 PM

[tools] go/analysis/passes/stringintconv: use Cursor; split out checkCall

Alan Donovan voted and added 1 comment Votes added by Alan Donovan Hold +1 1 comment File go/analysis

unread,

[tools] go/analysis/passes/stringintconv: use Cursor; split out checkCall

Alan Donovan voted and added 1 comment Votes added by Alan Donovan Hold +1 1 comment File go/analysis

7:15 PM

Alan Donovan (Gerrit)

7:09 PM

[tools] go/analysis/passes/stringintconv: make first fix behavior-preserving

Attention needed from Robert Griesemer New activity on the change Open in Gerrit Related details

unread,

[tools] go/analysis/passes/stringintconv: make first fix behavior-preserving

Attention needed from Robert Griesemer New activity on the change Open in Gerrit Related details

7:09 PM

Gerrit Bot (Gerrit), … Gopher Robot (Gerrit)30

7:08 PM

[go] cmd/compile: fix switch head position with -N

Gopher Robot submitted the change Change information Commit message: cmd/compile: fix switch

unread,

[go] cmd/compile: fix switch head position with -N

Gopher Robot submitted the change Change information Commit message: cmd/compile: fix switch

7:08 PM

Neal Patel (Gerrit)2

6:57 PM

[go] html/template: recognize `yield` as regexp preceder keyword

Attention needed from Roland Shoemaker Neal Patel voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[go] html/template: recognize `yield` as regexp preceder keyword

Attention needed from Roland Shoemaker Neal Patel voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

6:57 PM

Liz Fong-Jones (Gerrit), Cherry Mui (Gerrit)2

6:57 PM

[go] runtime: don't describe tracebackcrash as restoring old behavior

Attention needed from Liz Fong-Jones and Michael Pratt Cherry Mui voted and added 1 comment Votes

unread,

[go] runtime: don't describe tracebackcrash as restoring old behavior

Attention needed from Liz Fong-Jones and Michael Pratt Cherry Mui voted and added 1 comment Votes

6:57 PM

David Chase (Gerrit), … Cherry Mui (Gerrit)4

6:50 PM

[go] simd/archsimd: remove mandatory panic for SVE vector length > 32.

Attention needed from David Chase Cherry Mui voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[go] simd/archsimd: remove mandatory panic for SVE vector length > 32.

Attention needed from David Chase Cherry Mui voted Code-Review+2 Code-Review +2 Open in Gerrit

6:50 PM

Fannie Zhang (Gerrit), … Liz Fong-Jones (Gerrit)16

6:46 PM

[go] runtime: optimize memmove using SIMD on arm64

Attention needed from Cherry Mui, Keith Randall and Vasiliy Leonenko New activity on the change Open

unread,

[go] runtime: optimize memmove using SIMD on arm64

Attention needed from Cherry Mui, Keith Randall and Vasiliy Leonenko New activity on the change Open

6:46 PM

Liz Fong-Jones (Gerrit)

6:46 PM

[go] runtime: use named registers in arm64 memmove

Attention needed from Cherry Mui, Keith Randall and Vasiliy Leonenko New activity on the change Open

unread,

[go] runtime: use named registers in arm64 memmove

Attention needed from Cherry Mui, Keith Randall and Vasiliy Leonenko New activity on the change Open

6:46 PM

Jonathan Amsterdam (Gerrit), Hyang-Ah Hana Kim (Gerrit)2

6:33 PM

[pkgsite] Revert "internal/postgres: clean generated buf.build modules"

Attention needed from Ethan Lee and Jonathan Amsterdam Hyang-Ah Hana Kim voted Code-Review+2 Code-

unread,

[pkgsite] Revert "internal/postgres: clean generated buf.build modules"

Attention needed from Ethan Lee and Jonathan Amsterdam Hyang-Ah Hana Kim voted Code-Review+2 Code-

6:33 PM

Liz Fong-Jones (Gerrit), … Michael Pratt (Gerrit)15

6:30 PM

[go] runtime: don't crash on a stuck traceback when errors are tolerated

Liz Fong-Jones added 1 comment File src/runtime/extern.go Line 214, Patchset 4 (Latest):

unread,

[go] runtime: don't crash on a stuck traceback when errors are tolerated

Liz Fong-Jones added 1 comment File src/runtime/extern.go Line 214, Patchset 4 (Latest):

6:30 PM

Alex Gaynor (Gerrit), Klaus Post (Gerrit)5

6:29 PM

[go] compress/flate: avoid generic sorts when generating Huffman codes

Attention needed from Joseph Tsai and Klaus Post Alex Gaynor added 1 comment Patchset-level comments

unread,

[go] compress/flate: avoid generic sorts when generating Huffman codes

Attention needed from Joseph Tsai and Klaus Post Alex Gaynor added 1 comment Patchset-level comments

6:29 PM

Alex Gaynor (Gerrit), … Gopher Robot (Gerrit)8

6:27 PM

[go] compress/flate: speed up the writeBlockHuff literal loop

Gopher Robot submitted the change Change information Commit message: compress/flate: combine codes in

unread,

[go] compress/flate: speed up the writeBlockHuff literal loop

Gopher Robot submitted the change Change information Commit message: compress/flate: combine codes in

6:27 PM

Gerrit Bot (Gerrit), … Gopher Robot (Gerrit)12

6:26 PM

[go] cmd/internal/pgo: accept CPU profiles from external tools like Linux perf

Gopher Robot submitted the change Change information Commit message: cmd/internal/pgo: accept CPU

unread,

[go] cmd/internal/pgo: accept CPU profiles from external tools like Linux perf

Gopher Robot submitted the change Change information Commit message: cmd/internal/pgo: accept CPU

6:26 PM

Rhys Hiltner (Gerrit), … Michael Pratt (Gerrit)9

6:16 PM

[go] runtime: interruptible sleep for spinning Ms

Attention needed from Michael Knyszek and Michael Pratt Rhys Hiltner added 1 comment File src/runtime

unread,

[go] runtime: interruptible sleep for spinning Ms

Attention needed from Michael Knyszek and Michael Pratt Rhys Hiltner added 1 comment File src/runtime

6:16 PM

Neal Patel (Gerrit)2

6:12 PM

[go] html/template: reset JS context for template expressions

Attention needed from Roland Shoemaker Neal Patel voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[go] html/template: reset JS context for template expressions

Attention needed from Roland Shoemaker Neal Patel voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

6:12 PM

Jonathan Amsterdam (Gerrit), … kokoro (Gerrit)11

6:11 PM

[pkgsite] internal/postgres: clean generated buf.build modules

Jonathan Amsterdam has created a revert of this change Open original change Related details Attention

unread,

[pkgsite] internal/postgres: clean generated buf.build modules

Jonathan Amsterdam has created a revert of this change Open original change Related details Attention

6:11 PM

Austin Clements (Gerrit), David Chase (Gerrit)13

6:04 PM

[go] simd/archsimd/_gen: plan for transitioning to spec

Attention needed from Austin Clements and Junyang Shao David Chase added 2 comments File src/simd/

unread,

[go] simd/archsimd/_gen: plan for transitioning to spec

Attention needed from Austin Clements and Junyang Shao David Chase added 2 comments File src/simd/

6:04 PM

Zhandos Zhandarbek (Gerrit), … Gopher Robot (Gerrit)11

6:00 PM

[go] text/template: avoid reflect.Value.Call for common builtins

Gopher Robot submitted the change Change information Commit message: text/template: call eq, not,

unread,

[go] text/template: avoid reflect.Value.Call for common builtins

Gopher Robot submitted the change Change information Commit message: text/template: call eq, not,

6:00 PM

Neal Patel (Gerrit)2

5:57 PM

[go] cmd/go: always verify toolchain downloads with sumdb

Attention needed from Roland Shoemaker Neal Patel voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[go] cmd/go: always verify toolchain downloads with sumdb

Attention needed from Roland Shoemaker Neal Patel voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

5:57 PM

Rhys Hiltner (Gerrit), … Michael Pratt (Gerrit)13

5:52 PM

[go] runtime: make sched.gcwaiting a uint32

Attention needed from Rhys Hiltner Michael Pratt voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[go] runtime: make sched.gcwaiting a uint32

Attention needed from Rhys Hiltner Michael Pratt voted Code-Review+2 Code-Review +2 Open in Gerrit

5:52 PM

Rhys Hiltner (Gerrit), … Gopher Robot (Gerrit)8

5:52 PM

[go] runtime: worldsema must be held during forEachP

Gopher Robot submitted the change Change information Commit message: runtime: worldsema must be held

unread,

[go] runtime: worldsema must be held during forEachP

Gopher Robot submitted the change Change information Commit message: runtime: worldsema must be held

5:52 PM

Rhys Hiltner (Gerrit), … Gopher Robot (Gerrit)9

5:52 PM

[go] runtime: send preemption signals without holding sched.lock

Gopher Robot submitted the change Change information Commit message: runtime: send preemption signals

unread,

[go] runtime: send preemption signals without holding sched.lock

Gopher Robot submitted the change Change information Commit message: runtime: send preemption signals

5:52 PM

Rhys Hiltner (Gerrit), … Gopher Robot (Gerrit)8

5:52 PM

[go] runtime: don't steal work when a STW is pending

Gopher Robot submitted the change Change information Commit message: runtime: don't steal work

unread,

[go] runtime: don't steal work when a STW is pending

Gopher Robot submitted the change Change information Commit message: runtime: don't steal work

5:52 PM

Search

Clear search

Close search

Google apps

Main menu