Groups

golang-codereviews

Contact owners and managers

1–30 of 108530

0 selected

Robert Griesemer (Gerrit), … Gopher Robot (Gerrit)11

8:16 PM

[go] cmd/compile: adjust compiler to allow for embedded field selectors

Gopher Robot submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

unread,

[go] cmd/compile: adjust compiler to allow for embedded field selectors

Gopher Robot submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

8:16 PM

Nicola Murino (Gerrit), … Dmitri Shuralyov (Gerrit)10

8:12 PM

[crypto] ssh: respect signer's algorithm preference in pickSignatureAlgorithm

Attention needed from Lonny Wong and Nicola Murino Dmitri Shuralyov added 1 comment Commit Message

unread,

[crypto] ssh: respect signer's algorithm preference in pickSignatureAlgorithm

Attention needed from Lonny Wong and Nicola Murino Dmitri Shuralyov added 1 comment Commit Message

8:12 PM

Rongrong (Gerrit), … Keith Randall (Gerrit)9

8:07 PM

[go/release-branch.go1.26] test/convert5: skip mipsle

Attention needed from Rongrong Keith Randall voted Hold+0 Hold +0 Open in Gerrit Related details

unread,

[go/release-branch.go1.26] test/convert5: skip mipsle

Attention needed from Rongrong Keith Randall voted Hold+0 Hold +0 Open in Gerrit Related details

8:07 PM

Robert Griesemer (Gerrit)3

7:55 PM

[go] spec: s/defined/declared/ in a handful of places (cleanup)

Attention needed from Alan Donovan Robert Griesemer voted and added 1 comment Votes added by Robert

unread,

[go] spec: s/defined/declared/ in a handful of places (cleanup)

Attention needed from Alan Donovan Robert Griesemer voted and added 1 comment Votes added by Robert

7:55 PM

Eyal Cohen (Gerrit)2

7:52 PM

[go] cmd/compile/internal/ssa: implement optimal SIMD boolean tree fusion via VPTERNLOG

Attention needed from David Chase and Jorropo Eyal Cohen added 1 comment Patchset-level comments File

unread,

[go] cmd/compile/internal/ssa: implement optimal SIMD boolean tree fusion via VPTERNLOG

Attention needed from David Chase and Jorropo Eyal Cohen added 1 comment Patchset-level comments File

7:52 PM

Gerrit Bot (Gerrit), … Fred Sauer (Gerrit)7

7:32 PM

[website] doc: update macOS PATH instructions for go install tools

Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #3 to this change. Open in Gerrit

unread,

[website] doc: update macOS PATH instructions for go install tools

Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #3 to this change. Open in Gerrit

7:32 PM

Jorropo (Gerrit), … Brad Fitzpatrick (Gerrit)16

7:23 PM

[go] runtime: use Uname version check for 64bits time on 32bits arch codepaths

Attention needed from Brad Fitzpatrick Jorropo added 1 comment Patchset-level comments File-level

unread,

[go] runtime: use Uname version check for 64bits time on 32bits arch codepaths

Attention needed from Brad Fitzpatrick Jorropo added 1 comment Patchset-level comments File-level

7:23 PM

Yahia Ben (Gerrit)

7:22 PM

[net] icmp: fix out-of-bounds read in parseTimeExceeded

Yahia Ben has uploaded the change for review Commit message icmp: fix out-of-bounds read in

unread,

[net] icmp: fix out-of-bounds read in parseTimeExceeded

Yahia Ben has uploaded the change for review Commit message icmp: fix out-of-bounds read in

7:22 PM

abner chenc (Gerrit), … Robert Griesemer (Gerrit)6

7:21 PM

[go] cmd/compile: skip race detector test failure for unsupported VMA

Robert Griesemer submitted the change Change information Commit message: cmd/compile: skip race

unread,

[go] cmd/compile: skip race detector test failure for unsupported VMA

Robert Griesemer submitted the change Change information Commit message: cmd/compile: skip race

7:21 PM

Ethan Lee (Gerrit), … Jonathan Amsterdam (Gerrit)9

7:20 PM

[pkgsite] all: add LatestVersion to ModuleInfo

Attention needed from Ethan Lee Jonathan Amsterdam added 1 comment File internal/latest.go Line 67,

unread,

[pkgsite] all: add LatestVersion to ModuleInfo

Attention needed from Ethan Lee Jonathan Amsterdam added 1 comment File internal/latest.go Line 67,

7:20 PM

Robert Griesemer (Gerrit)2

7:19 PM

[go] spec: predeclared types are named, not defined types

Attention needed from Alan Donovan, Ian Lance Taylor and Mark Freeman Robert Griesemer voted Code-

unread,

[go] spec: predeclared types are named, not defined types

Attention needed from Alan Donovan, Ian Lance Taylor and Mark Freeman Robert Griesemer voted Code-

7:19 PM

Meidan Li (Gerrit), … Dmitri Shuralyov (Gerrit)6

6:37 PM

[go] cmd/link/internal/loong64: remove the handling of R_CONST and R_GOTOFF from the internal linker

Attention needed from Meidan Li Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[go] cmd/link/internal/loong64: remove the handling of R_CONST and R_GOTOFF from the internal linker

Attention needed from Meidan Li Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit

6:37 PM

Brad Fitzpatrick (Gerrit), … Dmitri Shuralyov (Gerrit)9

6:31 PM

[build] maintner: add TrackGitHub method variant taking an oauth2.TokenSource

Attention needed from Brad Fitzpatrick Dmitri Shuralyov added 1 comment File maintner/github.go Line

unread,

[build] maintner: add TrackGitHub method variant taking an oauth2.TokenSource

Attention needed from Brad Fitzpatrick Dmitri Shuralyov added 1 comment File maintner/github.go Line

6:31 PM

Kevin Burke (Gerrit), … Dmitri Shuralyov (Gerrit)7

6:31 PM

[build] maintner, cmd/gerritbot: migrate to bartventer/httpcache

Attention needed from Kevin Burke Dmitri Shuralyov added 3 comments File cmd/gerritbot/gerritbot.go

unread,

[build] maintner, cmd/gerritbot: migrate to bartventer/httpcache

Attention needed from Kevin Burke Dmitri Shuralyov added 3 comments File cmd/gerritbot/gerritbot.go

6:31 PM

Nicholas Husin (Gerrit), Richard Miller (Gerrit)4

5:59 PM

[net] quic: avoid usage of net.ReadMsgUDPAddrPort in non-linux and darwin builds

Attention needed from Ethan Lee Nicholas Husin voted and added 1 comment Votes added by Nicholas

unread,

[net] quic: avoid usage of net.ReadMsgUDPAddrPort in non-linux and darwin builds

Attention needed from Ethan Lee Nicholas Husin voted and added 1 comment Votes added by Nicholas

5:59 PM

Junyang Shao (Gerrit), … Cherry Mui (Gerrit)40

5:56 PM

[arch] arm64/instgen: add assembler code generator for SVE

Attention needed from Cherry Mui and David Chase Junyang Shao added 1 comment File arm64/instgen/

unread,

[arch] arm64/instgen: add assembler code generator for SVE

Attention needed from Cherry Mui and David Chase Junyang Shao added 1 comment File arm64/instgen/

5:56 PM

Junyang Shao (Gerrit), … Cherry Mui (Gerrit)96

5:53 PM

[go] cmd/compile: add new arm64 assembler data structure

Attention needed from Alexander Musman, Cherry Mui and David Chase Junyang Shao added 1 comment File

unread,

[go] cmd/compile: add new arm64 assembler data structure

Attention needed from Alexander Musman, Cherry Mui and David Chase Junyang Shao added 1 comment File

5:53 PM

Julian Zhu (Gerrit), … Dmitri Shuralyov (Gerrit)11

5:51 PM

[go] cmd/compile: (mips64x) optimize float32(abs|sqrt64(float64(x)))

Attention needed from Julian Zhu Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[go] cmd/compile: (mips64x) optimize float32(abs|sqrt64(float64(x)))

Attention needed from Julian Zhu Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit

5:51 PM

Michael Matloob (Gerrit), Dmitri Shuralyov (Gerrit)2

5:43 PM

[go] debug/buildinfo: remove macho/elf DataStart fallback code

Attention needed from Cherry Mui Dmitri Shuralyov voted and added 3 comments Votes added by Dmitri

unread,

[go] debug/buildinfo: remove macho/elf DataStart fallback code

Attention needed from Cherry Mui Dmitri Shuralyov voted and added 3 comments Votes added by Dmitri

5:43 PM

Robert Griesemer (Gerrit), Mark Freeman (Gerrit)6

5:32 PM

[tools] internal/pkgbits: sync version.go with goroot

Robert Griesemer submitted the change with unreviewed changes Unreviewed changes 1 is the latest

unread,

[tools] internal/pkgbits: sync version.go with goroot

Robert Griesemer submitted the change with unreviewed changes Unreviewed changes 1 is the latest

5:32 PM

Robert Griesemer (Gerrit), Mark Freeman (Gerrit)8

5:32 PM

[go] cmd/compile: encode field selectors in UIR format for struct literals

Robert Griesemer submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

unread,

[go] cmd/compile: encode field selectors in UIR format for struct literals

Robert Griesemer submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

5:32 PM

Robert Griesemer (Gerrit), Mark Freeman (Gerrit)14

5:32 PM

[go] types2: implement arbitrary field selectors for struct literals

Robert Griesemer submitted the change with unreviewed changes Unreviewed changes 10 is the latest

unread,

[go] types2: implement arbitrary field selectors for struct literals

Robert Griesemer submitted the change with unreviewed changes Unreviewed changes 10 is the latest

5:32 PM

Sean Liao (Gerrit), … Michael Matloob (Gerrit)11

5:19 PM

[go] cmd/go/internal/help: reword packages and importpath docs

Attention needed from Sean Liao and t hepudds Michael Matloob voted Code-Review+1 Code-Review +1 Open

unread,

[go] cmd/go/internal/help: reword packages and importpath docs

Attention needed from Sean Liao and t hepudds Michael Matloob voted Code-Review+1 Code-Review +1 Open

5:19 PM

Gerrit Bot (Gerrit), … Dmitri Shuralyov (Gerrit)8

5:12 PM

[go] cmd/link: propagate Mach-O section alignment to symbol in loadmacho

Attention needed from Cherry Mui and Russ Cox Dmitri Shuralyov voted Code-Review+1 Code-Review +1

unread,

[go] cmd/link: propagate Mach-O section alignment to symbol in loadmacho

Attention needed from Cherry Mui and Russ Cox Dmitri Shuralyov voted Code-Review+1 Code-Review +1

5:12 PM

Olivier Mengué (Gerrit), … Michael Matloob (Gerrit)22

5:10 PM

[go] cmd/go/internal/base: reject an empty tool name

Michael Matloob submitted the change Change information Commit message: cmd/go: reject an empty tool

unread,

[go] cmd/go/internal/base: reject an empty tool name

Michael Matloob submitted the change Change information Commit message: cmd/go: reject an empty tool

5:10 PM

Cherry Mui (Gerrit), … Dmitri Shuralyov (Gerrit)3

5:06 PM

[go] cmd/link: skip special symbols for label symbol generation

Attention needed from Cherry Mui Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[go] cmd/link: skip special symbols for label symbol generation

Attention needed from Cherry Mui Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit

5:06 PM

Damien Neil (Gerrit), … Carlos Amedee (Gerrit)10

5:03 PM

[go] net/http: restore accidentally removed package doc

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] net/

unread,

[go] net/http: restore accidentally removed package doc

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] net/

5:03 PM

Ian Chen (Gerrit), … Carlos Amedee (Gerrit)12

5:02 PM

[go] net: correctly handle non-nil empty cmsg buffer on windows

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] net:

unread,

[go] net: correctly handle non-nil empty cmsg buffer on windows

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] net:

5:02 PM

Cuong Manh Le (Gerrit), … Carlos Amedee (Gerrit)20

4:59 PM

[go] cmd/compile/internal/typecheck: simplify tcSliceHeader

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] cmd/

unread,

[go] cmd/compile/internal/typecheck: simplify tcSliceHeader

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] cmd/

4:59 PM

Keith Randall (Gerrit), … Carlos Amedee (Gerrit)8

4:43 PM

[go] cmd/compile: fix bloop test

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] cmd/

unread,

[go] cmd/compile: fix bloop test

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] cmd/

4:43 PM

Search

Clear search

Close search

Google apps

Main menu