golang-codereviews - Google Groups

Groups

Contact owners and managers

1–30 of 112379

0 selected

shuang cui (Gerrit)2

1:18 AM

[tools] go/analysis/passes/modernize: preserve evaluation effects in slicessort

shuang cui voted and added 1 comment Votes added by shuang cui Commit-Queue +1 1 comment Patchset-

unread,

[tools] go/analysis/passes/modernize: preserve evaluation effects in slicessort

shuang cui voted and added 1 comment Votes added by shuang cui Commit-Queue +1 1 comment Patchset-

1:18 AM

Egon Elbre (Gerrit), … Egon Elbre (Gerrit)17

12:57 AM

[go] runtime,cmd/compile: specialize growslice for strings

Attention needed from Keith Randall, Keith Randall, Martin Möhrmann, Matthew Dempsky and t hepudds

unread,

[go] runtime,cmd/compile: specialize growslice for strings

Attention needed from Keith Randall, Keith Randall, Martin Möhrmann, Matthew Dempsky and t hepudds

12:57 AM

Srinivas Pokala (Gerrit)

12:49 AM

[build] dashboard: update owners for host-linux-s390x

Srinivas Pokala has uploaded the change for review Commit message dashboard: update owners for host-

unread,

[build] dashboard: update owners for host-linux-s390x

Srinivas Pokala has uploaded the change for review Commit message dashboard: update owners for host-

12:49 AM

Egon Elbre (Gerrit), … Egon Elbre (Gerrit)14

12:24 AM

[go] runtime,cmd/compile: specialize growslice for bytes

Attention needed from Keith Randall, Keith Randall, Martin Möhrmann, Matthew Dempsky and t hepudds

unread,

[go] runtime,cmd/compile: specialize growslice for bytes

Attention needed from Keith Randall, Keith Randall, Martin Möhrmann, Matthew Dempsky and t hepudds

12:24 AM

shuang cui (Gerrit), Jorropo (Gerrit)7

12:07 AM

[go] cmd/compile: fold x + (y - (x - z)) to y + z

Attention needed from Keith Randall, Martin Möhrmann and shuang cui Jorropo voted Auto-Submit +1 Code

unread,

[go] cmd/compile: fold x + (y - (x - z)) to y + z

Attention needed from Keith Randall, Martin Möhrmann and shuang cui Jorropo voted Auto-Submit +1 Code

12:07 AM

shuang cui (Gerrit)2

Aug 11

[tools] go/analysis: avoid panics on multi-valued call arguments

shuang cui voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

unread,

[tools] go/analysis: avoid panics on multi-valued call arguments

shuang cui voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

Aug 11

Gilbert Morgan (Gerrit), Keith Randall (Gerrit)4

Aug 11

[go] cmd/compile: match canonical constant position in Sub(Add) rules

Gilbert Morgan abandoned this change. View Change Abandoned Gilbert Morgan abandoned this change

unread,

[go] cmd/compile: match canonical constant position in Sub(Add) rules

Gilbert Morgan abandoned this change. View Change Abandoned Gilbert Morgan abandoned this change

Aug 11

shuang cui (Gerrit)2

Aug 11

[tools] go/analysis/passes/modernize: preserve timer calls on unrelated benchmarks

shuang cui voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

unread,

[tools] go/analysis/passes/modernize: preserve timer calls on unrelated benchmarks

shuang cui voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

Aug 11

Wanbiao Ye (Gerrit), … Robert Griesemer (Gerrit)5

Aug 11

[go] embed: return io.EOF for excessively big ReadAt offset

Attention needed from Jorropo and Wanbiao Ye Wanbiao Ye uploaded new patchset Wanbiao Ye uploaded

unread,

[go] embed: return io.EOF for excessively big ReadAt offset

Attention needed from Jorropo and Wanbiao Ye Wanbiao Ye uploaded new patchset Wanbiao Ye uploaded

Aug 11

shuang cui (Gerrit)2

Aug 11

[tools] go/analysis/passes/modernize: avoid breaking unkeyed struct literals

shuang cui voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

unread,

[tools] go/analysis/passes/modernize: avoid breaking unkeyed struct literals

shuang cui voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

Aug 11

Michael Matloob (Gerrit), … Gopher Robot (Gerrit)7

Aug 11

[go] cmd/dist: build one more toolchain when GOEXPERIMENT is set

Gopher Robot submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

unread,

[go] cmd/dist: build one more toolchain when GOEXPERIMENT is set

Gopher Robot submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

Aug 11

Michael Matloob (Gerrit), … Robert Griesemer (Gerrit)14

Aug 11

[go] cmd/dist: don't rebuild the toolchain with a clean cache

Michael Matloob added 1 comment Patchset-level comments File-level comment, Patchset 8 (Latest):

unread,

[go] cmd/dist: don't rebuild the toolchain with a clean cache

Michael Matloob added 1 comment Patchset-level comments File-level comment, Patchset 8 (Latest):

Aug 11

Gerrit Bot (Gerrit), … 张世杰 (Gerrit)8

Aug 11

[net] dict: fix unquote panic when backslash is the last character

Attention needed from Damien Neil, Ian Lance Taylor and Nicholas Husin 张世杰 added 2 comments Patchset-

unread,

[net] dict: fix unquote panic when backslash is the last character

Attention needed from Damien Neil, Ian Lance Taylor and Nicholas Husin 张世杰 added 2 comments Patchset-

Aug 11

shuang cui (Gerrit)2

Aug 11

[tools] go/analysis/passes/modernize: avoid changing assignment-form slicesbackward loops

shuang cui voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

unread,

[tools] go/analysis/passes/modernize: avoid changing assignment-form slicesbackward loops

shuang cui voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

Aug 11

qiu laidongfeng (Gerrit)

Aug 11

[go] text/template: update range documentation

qiu laidongfeng has uploaded the change for review Commit message text/template: update range

unread,

[go] text/template: update range documentation

qiu laidongfeng has uploaded the change for review Commit message text/template: update range

Aug 11

Ahmed Mohamed (Gerrit), Robert Griesemer (Gerrit)8

Aug 11

[go] go/types, types2: detect instantiation cycles in linear time

Attention needed from Keith Randall, Robert Findley and Robert Griesemer Message from Ahmed Mohamed

unread,

[go] go/types, types2: detect instantiation cycles in linear time

Attention needed from Keith Randall, Robert Findley and Robert Griesemer Message from Ahmed Mohamed

Aug 11

Damien Neil (Gerrit), Nicholas Husin (Gerrit)6

Aug 11

[go] internal/nettest: use TEST-NET-01 addresses by default

Damien Neil voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

unread,

[go] internal/nettest: use TEST-NET-01 addresses by default

Damien Neil voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

Aug 11

Gerrit Bot (Gerrit), … David Teather (Gerrit)7

Aug 11

[go] internal/strconv: check for digits first in readFloat

Attention needed from Robert Griesemer David Teather added 2 comments Patchset-level comments File-

unread,

[go] internal/strconv: check for digits first in readFloat

Attention needed from Robert Griesemer David Teather added 2 comments Patchset-level comments File-

Aug 11

Ian Lance Taylor (Gerrit), … Gopher Robot (Gerrit)25

Aug 11

[go] net: use readable JSON marshaling for IPNet, IPMask, HardwareAddr

Gopher Robot submitted the change Change information Commit message: net: use readable JSON

unread,

[go] net: use readable JSON marshaling for IPNet, IPMask, HardwareAddr

Gopher Robot submitted the change Change information Commit message: net: use readable JSON

Aug 11

Antonio Ballesteros (Gerrit), … Ian Lance Taylor (Gerrit)6

Aug 11

[go] main: Add pointer touch to potentially unused CGO generated function parameter

Attention needed from Antonio Ballesteros and David Chase Ian Lance Taylor added 1 comment File src/

unread,

[go] main: Add pointer touch to potentially unused CGO generated function parameter

Attention needed from Antonio Ballesteros and David Chase Ian Lance Taylor added 1 comment File src/

Aug 11

Nicholas Husin (Gerrit), Damien Neil (Gerrit)2

Aug 11

[net] internal/http3: delete invalid Content-Length if declared in server handler

Attention needed from Nicholas Husin Damien Neil voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[net] internal/http3: delete invalid Content-Length if declared in server handler

Attention needed from Nicholas Husin Damien Neil voted Code-Review+2 Code-Review +2 Open in Gerrit

Aug 11

Michael Pratt (Gerrit), … Damien Neil (Gerrit)17

Aug 11

[go] encoding/json/v2: document custom marshal option adherence

Attention needed from Joseph Tsai and Michael Pratt Damien Neil voted Code-Review+1 Code-Review +1

unread,

[go] encoding/json/v2: document custom marshal option adherence

Attention needed from Joseph Tsai and Michael Pratt Damien Neil voted Code-Review+1 Code-Review +1

Aug 11

Michael Pratt (Gerrit), Damien Neil (Gerrit)4

Aug 11

[website] _content/blog/json: update for encoding/json/v2

Attention needed from Joseph Tsai and Michael Pratt Damien Neil added 2 comments File _content/blog/

unread,

[website] _content/blog/json: update for encoding/json/v2

Attention needed from Joseph Tsai and Michael Pratt Damien Neil added 2 comments File _content/blog/

Aug 11

Damien Neil (Gerrit), Nicholas Husin (Gerrit)4

Aug 11

[text] encoding/japanese: document that decoding follows RFC 2237, not WHATWG

Damien Neil submitted the change Change information Commit message: encoding/japanese: document that

unread,

[text] encoding/japanese: document that decoding follows RFC 2237, not WHATWG

Damien Neil submitted the change Change information Commit message: encoding/japanese: document that

Aug 11

Michael Pratt (Gerrit), … Damien Neil (Gerrit)14

Aug 11

[website] WIP: _content/doc/jsonv2-migration: encoding/json/v2 migration guide

Attention needed from Joseph Tsai and Michael Pratt Damien Neil voted Code-Review+2 Code-Review +2

unread,

[website] WIP: _content/doc/jsonv2-migration: encoding/json/v2 migration guide

Attention needed from Joseph Tsai and Michael Pratt Damien Neil voted Code-Review+2 Code-Review +2

Aug 11

Achille Roussel (Gerrit)3

Aug 11

[go] simd/archsimd: report CPU features guaranteed by GOAMD64 as constants

Achille Roussel uploaded new patchset Achille Roussel uploaded patch set #3 to this change. Open in

unread,

[go] simd/archsimd: report CPU features guaranteed by GOAMD64 as constants

Achille Roussel uploaded new patchset Achille Roussel uploaded patch set #3 to this change. Open in

Aug 11

Josh Bleecher Snyder (Gerrit), Jorropo (Gerrit)2

Aug 11

[go] crypto/md5: delete loong64/ppc64x asm

Attention needed from Filippo Valsorda and Josh Bleecher Snyder Jorropo voted Code-Review+2 Code-

unread,

[go] crypto/md5: delete loong64/ppc64x asm

Attention needed from Filippo Valsorda and Josh Bleecher Snyder Jorropo voted Code-Review+2 Code-

Aug 11

Ian Alexander (Gerrit), Ethan Lee (Gerrit)3

Aug 11

[vulndb] devtools: add support for custom username during create

Ian Alexander abandoned this change. View Change Abandoned Ian Alexander abandoned this change

unread,

[vulndb] devtools: add support for custom username during create

Ian Alexander abandoned this change. View Change Abandoned Ian Alexander abandoned this change

Aug 11

Ian Alexander (Gerrit), Nicholas Husin (Gerrit)4

Aug 11

[vulndb] data/reports: review GO-2026-5668

Ian Alexander submitted the change Change information Commit message: data/reports: review GO-2026-

unread,

[vulndb] data/reports: review GO-2026-5668

Ian Alexander submitted the change Change information Commit message: data/reports: review GO-2026-

Aug 11

Ian Alexander (Gerrit), Nicholas Husin (Gerrit)11

Aug 11

[vulndb] data/reports: add 3 reports

Ian Alexander submitted the change Change information Commit message: data/reports: add 3 reports -

unread,

[vulndb] data/reports: add 3 reports

Ian Alexander submitted the change Change information Commit message: data/reports: add 3 reports -

Aug 11

Search

Clear search

Close search

Google apps

Main menu