Groups
Conversations
All groups and messages
Send feedback to Google
Help
Sign in
Groups
golang-codereviews
Conversations
About
golang-codereviews
1–30 of 85099
Mark all as read
Report abusive group
0 selected
Ian Lance Taylor (Gerrit)
,
Matthieu Baerts (Gerrit)
4
7:24 PM
[go] doc/go1.21: mention multipath TCP support
Attention is currently required from: Eli Bendersky, Matthieu Baerts. Patch set 1:Run-TryBot +1 View
unread,
[go] doc/go1.21: mention multipath TCP support
Attention is currently required from: Eli Bendersky, Matthieu Baerts. Patch set 1:Run-TryBot +1 View
7:24 PM
Gerrit Bot (Gerrit)
, …
Ian Lance Taylor (Gerrit)
9
7:20 PM
[go] errors: faster Error method for *joinError
Attention is currently required from: Damien Neil, Daniel Nephin, Sense As. View Change 1 comment:
unread,
[go] errors: faster Error method for *joinError
Attention is currently required from: Damien Neil, Daniel Nephin, Sense As. View Change 1 comment:
7:20 PM
Gerrit Bot (Gerrit)
, …
Ian Lance Taylor (Gerrit)
9
7:18 PM
[go] io: ReadFile: don't check for slice re-allocation in the first iteration
Attention is currently required from: Ian Lance Taylor, Russ Cox. Patch set 4:-Auto-Submit-Code-
unread,
[go] io: ReadFile: don't check for slice re-allocation in the first iteration
Attention is currently required from: Ian Lance Taylor, Russ Cox. Patch set 4:-Auto-Submit-Code-
7:18 PM
Gerrit Bot (Gerrit)
, …
Ian Lance Taylor (Gerrit)
6
7:11 PM
[go] math: support Clamp and Clamp01 methods
Ian Lance Taylor abandoned this change. View Change Abandoned Proposal 58146 was declined. To view,
unread,
[go] math: support Clamp and Clamp01 methods
Ian Lance Taylor abandoned this change. View Change Abandoned Proposal 58146 was declined. To view,
7:11 PM
Jonathan Amsterdam (Gerrit)
,
Ian Lance Taylor (Gerrit)
3
7:09 PM
[go] runtime: clarify Pinner doc
Attention is currently required from: Ansiwen, Jonathan Amsterdam, Michael Knyszek. Patch set 2:Code-
unread,
[go] runtime: clarify Pinner doc
Attention is currently required from: Ansiwen, Jonathan Amsterdam, Michael Knyszek. Patch set 2:Code-
7:09 PM
Ian Lance Taylor (Gerrit)
,
Akhil Indurti (Gerrit)
4
7:08 PM
[go] doc/go1.21: mention math.Compare and Compare32
Attention is currently required from: Akhil Indurti, Eli Bendersky. Patch set 1:Run-TryBot +1 View
unread,
[go] doc/go1.21: mention math.Compare and Compare32
Attention is currently required from: Akhil Indurti, Eli Bendersky. Patch set 1:Run-TryBot +1 View
7:08 PM
Cuong Manh Le (Gerrit)
, …
Ian Lance Taylor (Gerrit)
13
7:07 PM
[go] builtin: add documentation for min/max
Attention is currently required from: Cuong Manh Le, Ian Lance Taylor, Matthew Dempsky, Robert
unread,
[go] builtin: add documentation for min/max
Attention is currently required from: Cuong Manh Le, Ian Lance Taylor, Matthew Dempsky, Robert
7:07 PM
Gerrit Bot (Gerrit)
,
Ian Lance Taylor (Gerrit)
5
7:00 PM
[go] bufio.Reset: when argument io.Reader is nil, Reader initializes the internal buffer to the default size
Attention is currently required from: Brad Fitzpatrick, Robert Griesemer. View Change 1 comment:
unread,
[go] bufio.Reset: when argument io.Reader is nil, Reader initializes the internal buffer to the default size
Attention is currently required from: Brad Fitzpatrick, Robert Griesemer. View Change 1 comment:
7:00 PM
Gerrit Bot (Gerrit)
,
Ian Lance Taylor (Gerrit)
3
6:55 PM
[sys] unix: add Getresuid, Getresgid on linux
Attention is currently required from: Brad Fitzpatrick, Tobias Klauser. View Change 2 comments: File
unread,
[sys] unix: add Getresuid, Getresgid on linux
Attention is currently required from: Brad Fitzpatrick, Tobias Klauser. View Change 2 comments: File
6:55 PM
Gerrit Bot (Gerrit)
, …
Ian Lance Taylor (Gerrit)
4
6:49 PM
[go] cmd/cgo: add #cgo noescape/nocallback annotations
Attention is currently required from: DeJiang Zhu (doujiang), Dmitry Vyukov, Martin Möhrmann. View
unread,
[go] cmd/cgo: add #cgo noescape/nocallback annotations
Attention is currently required from: DeJiang Zhu (doujiang), Dmitry Vyukov, Martin Möhrmann. View
6:49 PM
Quim Muntal (Gerrit)
, …
Dmitri Shuralyov (Gerrit)
3
5:20 PM
[go] syscall: fix ComputerName on Windows
Attention is currently required from: Bryan Mills, Quim Muntal. Patch set 1:Code-Review +1 View
unread,
[go] syscall: fix ComputerName on Windows
Attention is currently required from: Bryan Mills, Quim Muntal. Patch set 1:Code-Review +1 View
5:20 PM
Peter Weinberger (Gerrit)
3
2:07 PM
[telemetry] counter: the first version of the counter package
Attention is currently required from: Peter Weinberger. Peter Weinberger uploaded patch set #3 to
unread,
[telemetry] counter: the first version of the counter package
Attention is currently required from: Peter Weinberger. Peter Weinberger uploaded patch set #3 to
2:07 PM
Gopher Robot (Gerrit)
, …
Dionna Glaze (Gerrit)
3
11:08 AM
[go] net/mail: Add implicit domain parsing to net/mail
Dionna Glaze has uploaded this change for review. View Change net/mail: Add implicit domain parsing
unread,
[go] net/mail: Add implicit domain parsing to net/mail
Dionna Glaze has uploaded this change for review. View Change net/mail: Add implicit domain parsing
11:08 AM
Gopher Robot (Gerrit)
, …
Zhe Dong (Gerrit)
5
11:08 AM
[tools] Add clarification in check printf message.
Attention is currently required from: Zhe Dong. Zhe Dong uploaded patch set #2 to this change. View
unread,
[tools] Add clarification in check printf message.
Attention is currently required from: Zhe Dong. Zhe Dong uploaded patch set #2 to this change. View
11:08 AM
Quim Muntal (Gerrit)
, …
Alex Brainman (Gerrit)
41
5:50 AM
[go] os, syscall: support ill-formed UTF-16 strings on Windows
View Change 1 comment: File src/syscall/syscall_windows.go: Patch Set #15, Line 590: e :=
unread,
[go] os, syscall: support ill-formed UTF-16 strings on Windows
View Change 1 comment: File src/syscall/syscall_windows.go: Patch Set #15, Line 590: e :=
5:50 AM
Gerrit Bot (Gerrit)
, …
Andrei Efanov (Gerrit)
13
5:28 AM
[go] cmd/list: fix -retracted flag description
Attention is currently required from: Bryan Mills, Michael Matloob. View Change 1 comment: Patchset:
unread,
[go] cmd/list: fix -retracted flag description
Attention is currently required from: Bryan Mills, Michael Matloob. View Change 1 comment: Patchset:
5:28 AM
Gerrit Bot (Gerrit)
,
Gopher Robot (Gerrit)
6
5:17 AM
[go] cmd/go/internal/modcmd/graph: add option for selected versions graph
Attention is currently required from: Bryan Mills, Michael Matloob. Gerrit Bot uploaded patch set #5
unread,
[go] cmd/go/internal/modcmd/graph: add option for selected versions graph
Attention is currently required from: Bryan Mills, Michael Matloob. Gerrit Bot uploaded patch set #5
5:17 AM
Gerrit Bot (Gerrit)
, …
Hajime Hoshi (Gerrit)
7
3:10 AM
[mobile] [golang/go#59803] update minimal javac version to 1.8
Attention is currently required from: Dmitri Shuralyov, Hyang-Ah Hana Kim. Patch set 1:-Code-Review
unread,
[mobile] [golang/go#59803] update minimal javac version to 1.8
Attention is currently required from: Dmitri Shuralyov, Hyang-Ah Hana Kim. Patch set 1:-Code-Review
3:10 AM
Gerrit Bot (Gerrit)
, …
Gopher Robot (Gerrit)
5
1:49 AM
[net] http2: Allow setting the maximum # of requests through a single connection
Gopher Robot abandoned this change. View Change Abandoned GitHub PR golang/net#161 has been closed.
unread,
[net] http2: Allow setting the maximum # of requests through a single connection
Gopher Robot abandoned this change. View Change Abandoned GitHub PR golang/net#161 has been closed.
1:49 AM
Michael Matloob (Gerrit)
6
May 28
[go] cmd/go: add support for vendoring in workspace mode
Attention is currently required from: Bryan Mills, Michael Matloob. Michael Matloob uploaded patch
unread,
[go] cmd/go: add support for vendoring in workspace mode
Attention is currently required from: Bryan Mills, Michael Matloob. Michael Matloob uploaded patch
May 28
Johan Brandhorst-Satzkorn (Gerrit)
11
May 28
[go] cmd/dist/test: add debug logging to net/http/pprof
Johan Brandhorst-Satzkorn abandoned this change. View Change Abandoned To view, visit change 491855.
unread,
[go] cmd/dist/test: add debug logging to net/http/pprof
Johan Brandhorst-Satzkorn abandoned this change. View Change Abandoned To view, visit change 491855.
May 28
Peter Weinberger (Gerrit)
,
kokoro (Gerrit)
4
May 28
[tools] internal/diff: fix lineEdits
Attention is currently required from: Peter Weinberger. Kokoro presubmit build finished with status:
unread,
[tools] internal/diff: fix lineEdits
Attention is currently required from: Peter Weinberger. Kokoro presubmit build finished with status:
May 28
Jonathan Amsterdam (Gerrit)
,
Zvonimir Pavlinovic (Gerrit)
2
May 28
[pkgsite-metrics] cmd/jobs: simplify upload logic
Attention is currently required from: Jonathan Amsterdam, Maceo Thompson. View Change 1 comment: File
unread,
[pkgsite-metrics] cmd/jobs: simplify upload logic
Attention is currently required from: Jonathan Amsterdam, Maceo Thompson. View Change 1 comment: File
May 28
Jonathan Amsterdam (Gerrit)
,
Zvonimir Pavlinovic (Gerrit)
3
May 28
[pkgsite-metrics] cmd/jobs: support starting a job
Attention is currently required from: Jonathan Amsterdam, Maceo Thompson. Patch set 2:Code-Review +2
unread,
[pkgsite-metrics] cmd/jobs: support starting a job
Attention is currently required from: Jonathan Amsterdam, Maceo Thompson. Patch set 2:Code-Review +2
May 28
Gerrit Bot (Gerrit)
, …
Gopher Robot (Gerrit)
4
May 28
[go] fmt.doc: formatting functions will round the number according to the specified precision
Gopher Robot abandoned this change. View Change Abandoned GitHub PR golang/go#60472 has been closed.
unread,
[go] fmt.doc: formatting functions will round the number according to the specified precision
Gopher Robot abandoned this change. View Change Abandoned GitHub PR golang/go#60472 has been closed.
May 28
Jordan Liggitt (Gerrit)
,
Dmitri Shuralyov (Gerrit)
9
May 27
[mod] zip: fix LICENSE file handling to match modfetch
Attention is currently required from: Bryan Mills, Jordan Liggitt. Patch set 5:Commit-Queue +1 View
unread,
[mod] zip: fix LICENSE file handling to match modfetch
Attention is currently required from: Bryan Mills, Jordan Liggitt. Patch set 5:Commit-Queue +1 View
May 27
Robert Griesemer (Gerrit)
3
May 27
[go] go/types, types2: use exact unification for component types
Attention is currently required from: Robert Findley, Robert Griesemer. Patch set 4:Run-TryBot +1Code
unread,
[go] go/types, types2: use exact unification for component types
Attention is currently required from: Robert Findley, Robert Griesemer. Patch set 4:Run-TryBot +1Code
May 27
Robert Griesemer (Gerrit)
4
May 27
[go] go/types, types2: add unifyMode to unifier, pass it through
Attention is currently required from: Robert Findley, Robert Griesemer. Patch set 3:Run-TryBot +1Code
unread,
[go] go/types, types2: add unifyMode to unifier, pass it through
Attention is currently required from: Robert Findley, Robert Griesemer. Patch set 3:Run-TryBot +1Code
May 27
Gerrit Bot (Gerrit)
May 27
[mobile] add path for termux on android 9+/arm64
Gerrit Bot has uploaded this change for review. View Change add path for termux on android 9+/arm64
unread,
[mobile] add path for termux on android 9+/arm64
Gerrit Bot has uploaded this change for review. View Change add path for termux on android 9+/arm64
May 27
Jamal Carvalho (Gerrit)
,
Hyang-Ah Hana Kim (Gerrit)
12
May 27
[telemetry] godev/devtools: create cloud storage emulator script
Attention is currently required from: Jamal Carvalho, Peter Weinberger. Jamal Carvalho uploaded patch
unread,
[telemetry] godev/devtools: create cloud storage emulator script
Attention is currently required from: Jamal Carvalho, Peter Weinberger. Jamal Carvalho uploaded patch
May 27