golang-codereviews - Google Groups

Groups

Contact owners and managers

1–30 of 111848

0 selected

Ian Alexander (Gerrit), Nicholas Husin (Gerrit)3

1:00 AM

[go] encoding/xml: fix depth processing in unmarshal

Attention needed from Ian Alexander Nicholas Husin added 3 comments Patchset-level comments File-

unread,

[go] encoding/xml: fix depth processing in unmarshal

Attention needed from Ian Alexander Nicholas Husin added 3 comments Patchset-level comments File-

1:00 AM

Nicholas Husin (Gerrit)

12:13 AM

[go] crypto/tls: avoid overflow in parseECHConfigList

Attention needed from Neal Patel, Nicholas Husin and Roland Shoemaker Message from Nicholas Husin Set

unread,

[go] crypto/tls: avoid overflow in parseECHConfigList

Attention needed from Neal Patel, Nicholas Husin and Roland Shoemaker Message from Nicholas Husin Set

12:13 AM

qiu laidongfeng (Gerrit)

Jul 21

[go] flag: add All iterators and Flag.IsSet

qiu laidongfeng has uploaded the change for review Commit message flag: add All iterators and Flag.

unread,

[go] flag: add All iterators and Flag.IsSet

qiu laidongfeng has uploaded the change for review Commit message flag: add All iterators and Flag.

Jul 21

Sean Liao (Gerrit), … Jorropo (Gerrit)8

Jul 21

[go] cmd/go/internal/cfg: pass arch specific envs as build tags

Jorropo added 1 comment Patchset-level comments File-level comment, Patchset 3 (Latest): Jorropo .

unread,

[go] cmd/go/internal/cfg: pass arch specific envs as build tags

Jorropo added 1 comment Patchset-level comments File-level comment, Patchset 3 (Latest): Jorropo .

Jul 21

Julian Zhu (Gerrit), Keith Randall (Gerrit)3

Jul 21

[go] cmd/compile: use RVV for RISCV64 LoweredMoveLoop

Attention needed from Keith Randall Julian Zhu added 1 comment Patchset-level comments File-level

unread,

[go] cmd/compile: use RVV for RISCV64 LoweredMoveLoop

Attention needed from Keith Randall Julian Zhu added 1 comment Patchset-level comments File-level

Jul 21

Jakub Ciolek (Gerrit), … Michael Matloob (Gerrit)6

Jul 21

[go] cmd/compile: order functions by IR node count

Attention needed from Jakub Ciolek Michael Matloob added 1 comment Patchset-level comments File-level

unread,

[go] cmd/compile: order functions by IR node count

Attention needed from Jakub Ciolek Michael Matloob added 1 comment Patchset-level comments File-level

Jul 21

Michael Matloob (Gerrit)2

Jul 21

[go] cmd/compile/internal/ssa/_gen: disallow op variable name

Attention needed from Keith Randall and Michael Matloob Michael Matloob voted Code-Review+1 Code-

unread,

[go] cmd/compile/internal/ssa/_gen: disallow op variable name

Attention needed from Keith Randall and Michael Matloob Michael Matloob voted Code-Review+1 Code-

Jul 21

Michael Matloob (Gerrit)4

Jul 21

[go] cmd/compile/ssa/_gen: add prep code for split op

Attention needed from Keith Randall and Michael Matloob Michael Matloob voted Code-Review+1 Code-

unread,

[go] cmd/compile/ssa/_gen: add prep code for split op

Attention needed from Keith Randall and Michael Matloob Michael Matloob voted Code-Review+1 Code-

Jul 21

Michael Matloob (Gerrit)3

Jul 21

[go] cmd/compile/internal/ssa: move Op to op package

Attention needed from Keith Randall and Michael Matloob Michael Matloob voted Code-Review+1 Code-

unread,

[go] cmd/compile/internal/ssa: move Op to op package

Attention needed from Keith Randall and Michael Matloob Michael Matloob voted Code-Review+1 Code-

Jul 21

Meng Zhuo (Gerrit), … Boyao Wang (Gerrit)10

Jul 21

[go] crypto/aes: block enable zvkned for riscv64

Attention needed from Filippo Valsorda, Joel Sing, Mark Ryan, Meng Zhuo and Pengcheng Wang Boyao Wang

unread,

[go] crypto/aes: block enable zvkned for riscv64

Attention needed from Filippo Valsorda, Joel Sing, Mark Ryan, Meng Zhuo and Pengcheng Wang Boyao Wang

Jul 21

Josh Bleecher Snyder (Gerrit), … Carlos Amedee (Gerrit)5

Jul 21

[go] cmd/compile: free doomed registers at loop headers

Josh Bleecher Snyder submitted the change Change information Commit message: cmd/compile: free doomed

unread,

[go] cmd/compile: free doomed registers at loop headers

Josh Bleecher Snyder submitted the change Change information Commit message: cmd/compile: free doomed

Jul 21

Alan Donovan (Gerrit)3

Jul 21

[tools] go/analysis/passes/modernize: document 'go fix' command

Attention needed from Hongxiang Jiang Alan Donovan voted Auto-Submit+1 Auto-Submit +1 Open in Gerrit

unread,

[tools] go/analysis/passes/modernize: document 'go fix' command

Attention needed from Hongxiang Jiang Alan Donovan voted Auto-Submit+1 Auto-Submit +1 Open in Gerrit

Jul 21

Hyang-Ah Hana Kim (Gerrit), kokoro (Gerrit)2

Jul 21

[pkgsite] cmd/internal/doc: update golang.org/x/pkgsite@v0.3.0

Attention needed from Hyang-Ah Hana Kim and Michael Matloob kokoro voted kokoro-CI+1 Kokoro presubmit

unread,

[pkgsite] cmd/internal/doc: update golang.org/x/pkgsite@v0.3.0

Attention needed from Hyang-Ah Hana Kim and Michael Matloob kokoro voted kokoro-CI+1 Kokoro presubmit

Jul 21

Madeline Kalil (Gerrit), Alan Donovan (Gerrit)12

Jul 21

[tools] go/analysis/passes/modernize: slicesbackward - skip is s[i] is mutated

Attention needed from Madeline Kalil Alan Donovan voted and added 3 comments Votes added by Alan

unread,

[tools] go/analysis/passes/modernize: slicesbackward - skip is s[i] is mutated

Attention needed from Madeline Kalil Alan Donovan voted and added 3 comments Votes added by Alan

Jul 21

Jean Barkhuysen (Gerrit), … Sean Liao (Gerrit)11

Jul 21

[pkgsite] internal/index: Format to nanoseconds for index URL.

Attention needed from Ethan Lee, Jonathan Amsterdam and Sean Liao Jean Barkhuysen added 1 comment

unread,

[pkgsite] internal/index: Format to nanoseconds for index URL.

Attention needed from Ethan Lee, Jonathan Amsterdam and Sean Liao Jean Barkhuysen added 1 comment

Jul 21

Ian Alexander (Gerrit)

Jul 21

[vulndb] data/reports: add 3 reports

Attention needed from Nicholas Husin Ian Alexander voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[vulndb] data/reports: add 3 reports

Attention needed from Nicholas Husin Ian Alexander voted Commit-Queue+1 Commit-Queue +1 Open in

Jul 21

rui xi (Gerrit), … Sean Liao (Gerrit)12

Jul 21

[go] cmd/go: include 'dist' in 'go tool' list

Attention needed from Michael Matloob, Michael Matloob, Prince Roshan, Russ Cox and Sean Liao rui xi

unread,

[go] cmd/go: include 'dist' in 'go tool' list

Attention needed from Michael Matloob, Michael Matloob, Prince Roshan, Russ Cox and Sean Liao rui xi

Jul 21

Kinson Nee (Gerrit), … Meng Zhuo (Gerrit)12

Jul 21

[go] test/codegen: add riscv64 checks for conditional subtractions

Meng Zhuo submitted the change Change information Commit message: test/codegen: add riscv64 checks

unread,

[go] test/codegen: add riscv64 checks for conditional subtractions

Meng Zhuo submitted the change Change information Commit message: test/codegen: add riscv64 checks

Jul 21

Gerrit Bot (Gerrit)

Jul 21

[go] regexp: avoid copying the input when ReplaceAllString finds no match

Gerrit Bot has uploaded the change for review Commit message regexp: avoid copying the input when

unread,

[go] regexp: avoid copying the input when ReplaceAllString finds no match

Gerrit Bot has uploaded the change for review Commit message regexp: avoid copying the input when

Jul 21

Ian Alexander (Gerrit)

Jul 21

[vulndb] data/reports: add 43 reports

Attention needed from Nicholas Husin Ian Alexander voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[vulndb] data/reports: add 43 reports

Attention needed from Nicholas Husin Ian Alexander voted Commit-Queue+1 Commit-Queue +1 Open in

Jul 21

Ian Alexander (Gerrit), Damien Neil (Gerrit)21

Jul 21

[text] secure/precis: fix short destination buffer handling in Nickname profile

Attention needed from Ian Alexander and Nicholas Husin Damien Neil voted and added 1 comment Votes

unread,

[text] secure/precis: fix short destination buffer handling in Nickname profile

Attention needed from Ian Alexander and Nicholas Husin Damien Neil voted and added 1 comment Votes

Jul 21

Damien Neil (Gerrit), … Gopher Robot (Gerrit)12

Jul 21

[image] vp8l: vp8l: avoid allocating many unused Huffman tree groups

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

unread,

[image] vp8l: vp8l: avoid allocating many unused Huffman tree groups

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

Jul 21

shuang cui (Gerrit), … Sean Liao (Gerrit)8

Jul 21

[go] simd: make function comment match function name

Attention needed from shuang cui Sean Liao voted Code-Review+0 Code-Review +0 Open in Gerrit Related

unread,

[go] simd: make function comment match function name

Attention needed from shuang cui Sean Liao voted Code-Review+0 Code-Review +0 Open in Gerrit Related

Jul 21

Gerrit Bot (Gerrit), … Ian Lance Taylor (Gerrit)5

Jul 21

[go] cmd/go: reject cgo -sectcreate linker flags by default

Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #3 to this change. Open in Gerrit

unread,

[go] cmd/go: reject cgo -sectcreate linker flags by default

Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #3 to this change. Open in Gerrit

Jul 21

Nicola Murino (Gerrit), … Cherry Mui (Gerrit)5

Jul 21

[crypto] ssh: reject certificate signature keys before recursing

Attention needed from Nicola Murino Cherry Mui voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[crypto] ssh: reject certificate signature keys before recursing

Attention needed from Nicola Murino Cherry Mui voted Code-Review+1 Code-Review +1 Open in Gerrit

Jul 21

Ian Chen (Gerrit), … Cherry Mui (Gerrit)7

Jul 21

[crypto] ssh: permit empty but non-nil HostKeyAlgorithms, KeyExchanges, Ciphers, MACs

Attention needed from Ian Chen Cherry Mui voted Code-Review+1 Code-Review +1 Open in Gerrit Related

unread,

[crypto] ssh: permit empty but non-nil HostKeyAlgorithms, KeyExchanges, Ciphers, MACs

Attention needed from Ian Chen Cherry Mui voted Code-Review+1 Code-Review +1 Open in Gerrit Related

Jul 21

Nicola Murino (Gerrit), … Cherry Mui (Gerrit)5

Jul 21

[crypto] ssh: drain stderr on forwarded TCP and Unix channels

Attention needed from Nicola Murino Cherry Mui voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[crypto] ssh: drain stderr on forwarded TCP and Unix channels

Attention needed from Nicola Murino Cherry Mui voted Code-Review+1 Code-Review +1 Open in Gerrit

Jul 21

Илья (Gerrit), … Gopher Robot (Gerrit)8

Jul 21

[go] cmd/dist: remove unused omitVariant field

Gopher Robot submitted the change Change information Commit message: cmd/dist: remove unused

unread,

[go] cmd/dist: remove unused omitVariant field

Gopher Robot submitted the change Change information Commit message: cmd/dist: remove unused

Jul 21

Gerrit Bot (Gerrit), … Gopher Robot (Gerrit)8

Jul 21

[go] debug: fix comment error

Gopher Robot submitted the change Change information Commit message: debug: fix comment error Change-

unread,

[go] debug: fix comment error

Gopher Robot submitted the change Change information Commit message: debug: fix comment error Change-

Jul 21

Gerrit Bot (Gerrit), … Jorropo (Gerrit)16

Jul 21

[go] cmd/compile: add subtraction cancellation rule x-(x-y)==y

Attention needed from Keith Randall, Keith Randall and Martin Möhrmann Jorropo voted and added 2

unread,

[go] cmd/compile: add subtraction cancellation rule x-(x-y)==y

Attention needed from Keith Randall, Keith Randall and Martin Möhrmann Jorropo voted and added 2

Jul 21

Search

Clear search

Close search

Google apps

Main menu