Groups

golang-codereviews

Contact owners and managers

1–30 of 106361

0 selected

Dmitri Shuralyov (Gerrit)2

3:47 PM

[tools] gopls/internal/cache: fix %q verb use with wrong type

Attention needed from Alan Donovan Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[tools] gopls/internal/cache: fix %q verb use with wrong type

Attention needed from Alan Donovan Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit

3:47 PM

Dmitri Shuralyov (Gerrit)2

3:38 PM

[build] all: fix %q verb uses with wrong type

Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is

unread,

[build] all: fix %q verb uses with wrong type

Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is

3:38 PM

Dmitri Shuralyov (Gerrit), Carlos Amedee (Gerrit)3

2:45 PM

[build] cmd/watchflakes: truncate very large issue body text

Attention needed from Dmitri Shuralyov Carlos Amedee voted and added 1 comment Votes added by Carlos

unread,

[build] cmd/watchflakes: truncate very large issue body text

Attention needed from Dmitri Shuralyov Carlos Amedee voted and added 1 comment Votes added by Carlos

2:45 PM

Brad Fitzpatrick (Gerrit), … Dmitri Shuralyov (Gerrit)5

12:39 PM

[go] doc/next: clean up some Go 1.26 release notes

Attention needed from Brad Fitzpatrick Dmitri Shuralyov added 1 comment File doc/initial/6-stdlib/99-

unread,

[go] doc/next: clean up some Go 1.26 release notes

Attention needed from Brad Fitzpatrick Dmitri Shuralyov added 1 comment File doc/initial/6-stdlib/99-

12:39 PM

Peter Weinberger (Gerrit), … Robert Findley (Gerrit)32

12:14 PM

[tools] gopls/mod: find references to required modules

Attention needed from Alan Donovan and Robert Findley Peter Weinberger added 1 comment File gopls/

unread,

[tools] gopls/mod: find references to required modules

Attention needed from Alan Donovan and Robert Findley Peter Weinberger added 1 comment File gopls/

12:14 PM

Gerrit Bot (Gerrit), Gopher Robot (Gerrit)3

12:10 PM

[tools] tools/gopls Support indexing table-driven subtests in test discovery

Message from Gopher Robot Congratulations on opening your first change. Thank you for your

unread,

[tools] tools/gopls Support indexing table-driven subtests in test discovery

Message from Gopher Robot Congratulations on opening your first change. Thank you for your

12:10 PM

Nicola Murino (Gerrit)2

10:46 AM

[crypto] ssh/agent: WIP restrict destinations

Nicola Murino uploaded new patchset Nicola Murino uploaded patch set #2 to this change. Open in

unread,

[crypto] ssh/agent: WIP restrict destinations

Nicola Murino uploaded new patchset Nicola Murino uploaded patch set #2 to this change. Open in

10:46 AM

Gerrit Bot (Gerrit), … Alan Donovan (Gerrit)3

10:32 AM

[tools] go/analysis/passes/printf: panic when function literal is assigned to the blank identifier

Alan Donovan voted and added 1 comment Votes added by Alan Donovan Auto-Submit +1 Code-Review +2

unread,

[tools] go/analysis/passes/printf: panic when function literal is assigned to the blank identifier

Alan Donovan voted and added 1 comment Votes added by Alan Donovan Auto-Submit +1 Code-Review +2

10:32 AM

Daniel Morsing (Gerrit), Alan Donovan (Gerrit)9

9:04 AM

[tools] go/analysis: add runtime.Cleanup pass

Daniel Morsing abandoned this change Related details Attention set is empty Submit Requirements: Code

unread,

[tools] go/analysis: add runtime.Cleanup pass

Daniel Morsing abandoned this change Related details Attention set is empty Submit Requirements: Code

9:04 AM

Filippo Valsorda (Gerrit)

9:04 AM

[go] crypto/tls: add TestInvalidHandshakeSignature

Attention needed from Daniel McCarney and Roland Shoemaker Filippo Valsorda has uploaded the change

unread,

[go] crypto/tls: add TestInvalidHandshakeSignature

Attention needed from Daniel McCarney and Roland Shoemaker Filippo Valsorda has uploaded the change

9:04 AM

Joel Sing (Gerrit), … Jorropo (Gerrit)15

8:59 AM

[go] test/codegen: fix shift tests on riscv64

Attention needed from Joel Sing and Meng Zhuo Jorropo voted Auto-Submit+1 Auto-Submit +1 Open in

unread,

[go] test/codegen: fix shift tests on riscv64

Attention needed from Joel Sing and Meng Zhuo Jorropo voted Auto-Submit+1 Auto-Submit +1 Open in

8:59 AM

Daniel Morsing (Gerrit), … Gopher Robot (Gerrit)8

8:54 AM

[go] runtime/secret: reorganize tests to fix -buildmode=shared

Gopher Robot submitted the change Change information Commit message: runtime/secret: reorganize tests

unread,

[go] runtime/secret: reorganize tests to fix -buildmode=shared

Gopher Robot submitted the change Change information Commit message: runtime/secret: reorganize tests

8:54 AM

Michael Knyszek (Gerrit), David Chase (Gerrit)10

8:54 AM

[go] Revert "runtime: update mkmalloc to make generated code look nicer"

David Chase abandoned this change Related details Attention set is empty Submit Requirements: Code-

unread,

[go] Revert "runtime: update mkmalloc to make generated code look nicer"

David Chase abandoned this change Related details Attention set is empty Submit Requirements: Code-

8:54 AM

David Chase (Gerrit), Filippo Valsorda (Gerrit)5

8:53 AM

[go] Revert "runtime/secret: implement new secret package"

David Chase abandoned this change Related details Attention set is empty Submit Requirements: Code-

unread,

[go] Revert "runtime/secret: implement new secret package"

David Chase abandoned this change Related details Attention set is empty Submit Requirements: Code-

8:53 AM

Filippo Valsorda (Gerrit), … Gopher Robot (Gerrit)5

8:53 AM

[go] src/runtime/_mkmalloc: fix log.Fatal formatting directive

Gopher Robot submitted the change Change information Commit message: runtime/_mkmalloc: fix log.Fatal

unread,

[go] src/runtime/_mkmalloc: fix log.Fatal formatting directive

Gopher Robot submitted the change Change information Commit message: runtime/_mkmalloc: fix log.Fatal

8:53 AM

Xie Yuchen (Gerrit), … Alan Donovan (Gerrit)4

6:25 AM

[tools] gopls/internal/golang: improve if-else folding range for vscode

Xie Yuchen abandoned this change Related details Attention set is empty Submit Requirements: Code-

unread,

[tools] gopls/internal/golang: improve if-else folding range for vscode

Xie Yuchen abandoned this change Related details Attention set is empty Submit Requirements: Code-

6:25 AM

Quim Muntal (Gerrit), … Alex Brainman (Gerrit)9

4:12 AM

[go] os,internal/syscall/windows: support O_* flags in Root.OpenFile

Alex Brainman voted and added 1 comment Votes added by Alex Brainman Code-Review +2 1 comment

unread,

[go] os,internal/syscall/windows: support O_* flags in Root.OpenFile

Alex Brainman voted and added 1 comment Votes added by Alex Brainman Code-Review +2 1 comment

4:12 AM

Quim Muntal (Gerrit), … Alex Brainman (Gerrit)5

3:39 AM

[go] os,internal/poll: don't call IsNonblock for consoles and Stdin

Alex Brainman voted and added 1 comment Votes added by Alex Brainman Code-Review +2 1 comment

unread,

[go] os,internal/poll: don't call IsNonblock for consoles and Stdin

Alex Brainman voted and added 1 comment Votes added by Alex Brainman Code-Review +2 1 comment

3:39 AM

Daniel Morsing (Gerrit), … David Chase (Gerrit)95

2:31 AM

[go] runtime/secret: implement new secret package

Daniel Morsing added 1 comment Patchset-level comments File-level comment, Patchset 47 (Latest):

unread,

[go] runtime/secret: implement new secret package

Daniel Morsing added 1 comment Patchset-level comments File-level comment, Patchset 47 (Latest):

2:31 AM

Gerrit Bot (Gerrit), … Xueqi Luo (Gerrit)6

1:37 AM

[go] cmd/internal/obj/riscv: add assembly support of Zbc extension

Attention needed from Joel Sing, Mark Ryan and Meng Zhuo Gerrit Bot uploaded new patchset Gerrit Bot

unread,

[go] cmd/internal/obj/riscv: add assembly support of Zbc extension

Attention needed from Joel Sing, Mark Ryan and Meng Zhuo Gerrit Bot uploaded new patchset Gerrit Bot

1:37 AM

胡玮文 (Gerrit), … Gopher Robot (Gerrit)7

1:29 AM

[go] internal/runtime/cgroup: stricter unescapePath

Gopher Robot submitted the change Unreviewed changes 5 is the latest approved patch-set. No files

unread,

[go] internal/runtime/cgroup: stricter unescapePath

Gopher Robot submitted the change Unreviewed changes 5 is the latest approved patch-set. No files

1:29 AM

Gerrit Bot (Gerrit), … Gopher Robot (Gerrit)4

1:19 AM

[go] Update File.Seek to use constants

Gopher Robot abandoned this change Related details Attention set is empty Submit Requirements: Code-

unread,

[go] Update File.Seek to use constants

Gopher Robot abandoned this change Related details Attention set is empty Submit Requirements: Code-

1:19 AM

胡玮文 (Gerrit), … Gopher Robot (Gerrit)16

1:10 AM

[go] internal/runtime/cgroup: fix path on non-root mount point

Gopher Robot submitted the change Change information Commit message: internal/runtime/cgroup: fix

unread,

[go] internal/runtime/cgroup: fix path on non-root mount point

Gopher Robot submitted the change Change information Commit message: internal/runtime/cgroup: fix

1:10 AM

Gerrit Bot (Gerrit), … Xueqi Luo (Gerrit)66

12:57 AM

[go] cmd/compile/internal/ssa: add codegen for Zicond extension on riscv64

Attention needed from Cherry Mui, Joel Sing, Keith Randall, Mark Ryan, Meng Zhuo and Michael Munday

unread,

[go] cmd/compile/internal/ssa: add codegen for Zicond extension on riscv64

Attention needed from Cherry Mui, Joel Sing, Keith Randall, Mark Ryan, Meng Zhuo and Michael Munday

12:57 AM

胡玮文 (Gerrit), … Gopher Robot (Gerrit)12

12:51 AM

[go] internal/runtime/cgroup: simplify escapePath in test

Gopher Robot submitted the change Change information Commit message: internal/runtime/cgroup:

unread,

[go] internal/runtime/cgroup: simplify escapePath in test

Gopher Robot submitted the change Change information Commit message: internal/runtime/cgroup:

12:51 AM

Michael Matloob (Gerrit), … David Chase (Gerrit)6

12:50 AM

[go] runtime: update mkmalloc to make generated code look nicer

David Chase has created a revert of this change Open original change Related details Attention set is

unread,

[go] runtime: update mkmalloc to make generated code look nicer

David Chase has created a revert of this change Open original change Related details Attention set is

12:50 AM

Ian Lance Taylor (Gerrit), … David Chase (Gerrit)7

Nov 26

[go] cmd/link: remove unused symbol kind SFUNCTAB

Attention needed from Ian Lance Taylor, Michael Hudson-Doyle and Than McIntosh David Chase voted and

unread,

[go] cmd/link: remove unused symbol kind SFUNCTAB

Attention needed from Ian Lance Taylor, Michael Hudson-Doyle and Than McIntosh David Chase voted and

Nov 26

David Chase (Gerrit), … David Chase (Gerrit)24

Nov 26

[go] cmd/cgo: handle implicitly-typed compound struct literals

David Chase added 2 comments Patchset-level comments File-level comment, Patchset 13 (Latest): David

unread,

[go] cmd/cgo: handle implicitly-typed compound struct literals

David Chase added 2 comments Patchset-level comments File-level comment, Patchset 13 (Latest): David

Nov 26

David Chase (Gerrit), … David Chase (Gerrit)16

Nov 26

[go] cmd/cgo: rewrite C.type composite literals to use keywords

David Chase uploaded new patchset David Chase uploaded patch set #13 to this change. Following

unread,

[go] cmd/cgo: rewrite C.type composite literals to use keywords

David Chase uploaded new patchset David Chase uploaded patch set #13 to this change. Following

Nov 26

David Chase (Gerrit), … Cherry Mui (Gerrit)5

Nov 26

[go] structs: improve doc comment for HostLayout

Attention needed from David Chase David Chase uploaded new patchset David Chase uploaded patch set #5

unread,

[go] structs: improve doc comment for HostLayout

Attention needed from David Chase David Chase uploaded new patchset David Chase uploaded patch set #5

Nov 26

Search

Clear search

Close search

Google apps

Main menu