golang-codereviews

Contact owners and managers

1–30 of 98871

0 selected

Michael Knyszek (Gerrit), Carlos Amedee (Gerrit)2

1:57 PM

[build] cmd/gomote: fix create -list when querying for non-LUCI builders

Attention needed from Michael Knyszek Carlos Amedee voted and added 1 comment Votes added by Carlos

unread,

[build] cmd/gomote: fix create -list when querying for non-LUCI builders

Attention needed from Michael Knyszek Carlos Amedee voted and added 1 comment Votes added by Carlos

1:57 PM

Michael Knyszek (Gerrit), Veronica Silina (Gerrit)3

1:57 PM

[website] internal/history: document Go 1.23.4 and 1.22.10 releases

Michael Knyszek submitted the change Change information Commit message: internal/history: document Go

unread,

[website] internal/history: document Go 1.23.4 and 1.22.10 releases

Michael Knyszek submitted the change Change information Commit message: internal/history: document Go

1:57 PM

Damien Neil (Gerrit)

1:56 PM

[net] http2: avoid extended CONNECT hang when connection breaks during startup

Attention needed from Jonathan Amsterdam Damien Neil voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[net] http2: avoid extended CONNECT hang when connection breaks during startup

Attention needed from Jonathan Amsterdam Damien Neil voted Commit-Queue+1 Commit-Queue +1 Open in

1:56 PM

Jonathan Amsterdam (Gerrit), … kokoro (Gerrit)14

1:47 PM

[pkgsite] tests/screentest: make tests work on staging

Attention needed from Hyang-Ah Hana Kim Jonathan Amsterdam voted Commit-Queue+1 Commit-Queue +1 Open

unread,

[pkgsite] tests/screentest: make tests work on staging

Attention needed from Hyang-Ah Hana Kim Jonathan Amsterdam voted Commit-Queue+1 Commit-Queue +1 Open

1:47 PM

Roland Shoemaker (Gerrit)2

1:45 PM

[build/luci-config] main.star: update go-internal branches

Attention needed from Dmitri Shuralyov and Michael Knyszek Roland Shoemaker voted Commit-Queue+1

unread,

[build/luci-config] main.star: update go-internal branches

Attention needed from Dmitri Shuralyov and Michael Knyszek Roland Shoemaker voted Commit-Queue+1

1:45 PM

Tobias Klauser (Gerrit), Ian Lance Taylor (Gerrit)6

1:45 PM

[net] route: remove unused sizeofSockaddr* consts on freebsd

Attention needed from Damien Neil, Ian Lance Taylor and Tobias Klauser Ian Lance Taylor voted and

unread,

[net] route: remove unused sizeofSockaddr* consts on freebsd

Attention needed from Damien Neil, Ian Lance Taylor and Tobias Klauser Ian Lance Taylor voted and

1:45 PM

Ian Lance Taylor (Gerrit), … Gopher Robot (Gerrit)6

1:44 PM

[sys] unix: define IfMsghdr2, IfData64, and RtMsghdr2 on darwin

Gopher Robot submitted the change Change information Commit message: unix: define IfMsghdr2, IfData64

unread,

[sys] unix: define IfMsghdr2, IfData64, and RtMsghdr2 on darwin

Gopher Robot submitted the change Change information Commit message: unix: define IfMsghdr2, IfData64

1:44 PM

Tim King (Gerrit)

1:44 PM

[tools] internal/gcimporter: require binary export data header

Tim King has uploaded the change for review Commit message internal/gcimporter: require binary export

unread,

[tools] internal/gcimporter: require binary export data header

Tim King has uploaded the change for review Commit message internal/gcimporter: require binary export

1:44 PM

Tim King (Gerrit)

1:44 PM

[tools] internal/gcimporter: update FindExportData to return a non-negative size

Tim King has uploaded the change for review Commit message internal/gcimporter: update FindExportData

unread,

[tools] internal/gcimporter: update FindExportData to return a non-negative size

Tim King has uploaded the change for review Commit message internal/gcimporter: update FindExportData

1:44 PM

Alan Donovan (Gerrit), … Gopher Robot (Gerrit)4

1:39 PM

[tools] gopls/internal/analysis/yield: add comment about dataflow

Gopher Robot submitted the change Change information Commit message: gopls/internal/analysis/yield:

unread,

[tools] gopls/internal/analysis/yield: add comment about dataflow

Gopher Robot submitted the change Change information Commit message: gopls/internal/analysis/yield:

1:39 PM

Gopher Robot (Gerrit), … Michael Knyszek (Gerrit)7

1:27 PM

[go/release-branch.go1.23] [release-branch.go1.23] go1.23.4

Gopher Robot submitted the change Change information Commit message: [release-branch.go1.23] go1.23.4

unread,

[go/release-branch.go1.23] [release-branch.go1.23] go1.23.4

Gopher Robot submitted the change Change information Commit message: [release-branch.go1.23] go1.23.4

1:27 PM

Carlos Amedee (Gerrit), … Gopher Robot (Gerrit)7

1:25 PM

[build] internal/coordinator/remote: remove SSH environment setup for swarming

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[build] internal/coordinator/remote: remove SSH environment setup for swarming

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

1:25 PM

Michael Knyszek (Gerrit)5

1:13 PM

[go] cmd/link/internal/ld: work around FreeBSD 14.1 cmd/cgo test link failure

Attention needed from Cherry Mui Michael Knyszek voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[go] cmd/link/internal/ld: work around FreeBSD 14.1 cmd/cgo test link failure

Attention needed from Cherry Mui Michael Knyszek voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

1:13 PM

Quim Muntal (Gerrit), Damien Neil (Gerrit)4

1:12 PM

[go] net/http: fix TestTransportIdleConnTimeout

Quim Muntal added 1 comment File src/net/http/transport_test.go Line 5503, Patchset 1 (Latest):

unread,

[go] net/http: fix TestTransportIdleConnTimeout

Quim Muntal added 1 comment File src/net/http/transport_test.go Line 5503, Patchset 1 (Latest):

1:12 PM

Tim King (Gerrit)

1:12 PM

[tools] cmd/compilebench: fix finding the end of exportdata

Attention needed from David Chase Tim King voted and added 1 comment Votes added by Tim King Commit-

unread,

[tools] cmd/compilebench: fix finding the end of exportdata

Attention needed from David Chase Tim King voted and added 1 comment Votes added by Tim King Commit-

1:12 PM

Tim King (Gerrit), … Alan Donovan (Gerrit)8

1:11 PM

[tools] internal/gcimporter: require archive files

Tim King voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is empty

unread,

[tools] internal/gcimporter: require archive files

Tim King voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit Related details Attention set is empty

1:11 PM

Robert Findley (Gerrit), Alan Donovan (Gerrit)3

1:09 PM

[tools] gopls/internal/golang: ignore effects for change signature refactoring

Attention needed from Robert Findley Robert Findley uploaded new patchset Robert Findley uploaded

unread,

[tools] gopls/internal/golang: ignore effects for change signature refactoring

Attention needed from Robert Findley Robert Findley uploaded new patchset Robert Findley uploaded

1:09 PM

Carlos Amedee (Gerrit), … Dmitri Shuralyov (Gerrit)5

1:05 PM

[build] all: update github.com/creack/pty to v1.1.23

Carlos Amedee submitted the change Change information Commit message: all: update github.com/creack/

unread,

[build] all: update github.com/creack/pty to v1.1.23

Carlos Amedee submitted the change Change information Commit message: all: update github.com/creack/

1:05 PM

Roland Shoemaker (Gerrit)

1:04 PM

[go] crypto/internal/fips140/bigmod: disable race detector on tight loops

Attention needed from Filippo Valsorda and Russ Cox Roland Shoemaker voted Code-Review+2 Code-Review

unread,

[go] crypto/internal/fips140/bigmod: disable race detector on tight loops

Attention needed from Filippo Valsorda and Russ Cox Roland Shoemaker voted Code-Review+2 Code-Review

1:04 PM

Robert Findley (Gerrit), Alan Donovan (Gerrit)2

1:03 PM

[tools] internal/refactor/inline: more precise redundant conversion detection

Attention needed from Robert Findley Alan Donovan added 22 comments Patchset-level comments File-

unread,

[tools] internal/refactor/inline: more precise redundant conversion detection

Attention needed from Robert Findley Alan Donovan added 22 comments Patchset-level comments File-

1:03 PM

Gopher Robot (Gerrit), … Dmitri Shuralyov (Gerrit)7

1:00 PM

[go/release-branch.go1.22] [release-branch.go1.22] go1.22.10

Gopher Robot submitted the change Change information Commit message: [release-branch.go1.22] go1.

unread,

[go/release-branch.go1.22] [release-branch.go1.22] go1.22.10

Gopher Robot submitted the change Change information Commit message: [release-branch.go1.22] go1.

1:00 PM

David Chase (Gerrit), Robert Griesemer (Gerrit)10

12:41 PM

[go] cmd/compile: add astdump debug flag

Attention needed from David Chase, Martin Möhrmann, Matthew Dempsky and Robert Griesemer Robert

unread,

[go] cmd/compile: add astdump debug flag

Attention needed from David Chase, Martin Möhrmann, Matthew Dempsky and Robert Griesemer Robert

12:41 PM

Gopher Robot (Gerrit), … Michael Knyszek (Gerrit)6

12:30 PM

[dl] dl: add go1.23.4

Gopher Robot submitted the change Change information Commit message: dl: add go1.23.4 Change-Id:

unread,

[dl] dl: add go1.23.4

Gopher Robot submitted the change Change information Commit message: dl: add go1.23.4 Change-Id:

12:30 PM

Gopher Robot (Gerrit), … Michael Knyszek (Gerrit)6

12:30 PM

[dl] dl: add go1.22.10

Gopher Robot submitted the change Change information Commit message: dl: add go1.22.10 Change-Id:

unread,

[dl] dl: add go1.22.10

Gopher Robot submitted the change Change information Commit message: dl: add go1.22.10 Change-Id:

12:30 PM

Andrey Bokhanko (Gerrit), … Keith Randall (Gerrit)4

12:13 PM

[go] cmd/compile: add type-based alias analysis

Attention needed from Andrey Bokhanko, Ian Lance Taylor and Keith Randall Keith Randall added 2

unread,

[go] cmd/compile: add type-based alias analysis

Attention needed from Andrey Bokhanko, Ian Lance Taylor and Keith Randall Keith Randall added 2

12:13 PM

shuang cui (Gerrit), … Gopher Robot (Gerrit)9

12:07 PM

[go] sort: add examples for SearchStrings, SliceIsSorted

Gopher Robot submitted the change Change information Commit message: sort: add examples for

unread,

[go] sort: add examples for SearchStrings, SliceIsSorted

Gopher Robot submitted the change Change information Commit message: sort: add examples for

12:07 PM

David Chase (Gerrit), Keith Randall (Gerrit)7

11:35 AM

[go] cmd/compile: loop alignment tweak for arm64

Attention needed from Martin Möhrmann and Robert Griesemer David Chase voted and added 1 comment

unread,

[go] cmd/compile: loop alignment tweak for arm64

Attention needed from Martin Möhrmann and Robert Griesemer David Chase voted and added 1 comment

11:35 AM

Junyang Shao (Gerrit), … Cherry Mui (Gerrit)5

11:23 AM

[go] cmd/compile: fix a premature-deallocation of state in loopreschedchecks

Junyang Shao submitted the change Change information Commit message: cmd/compile: fix a premature-

unread,

[go] cmd/compile: fix a premature-deallocation of state in loopreschedchecks

Junyang Shao submitted the change Change information Commit message: cmd/compile: fix a premature-

11:23 AM

Hongxiang Jiang (Gerrit), Alan Donovan (Gerrit)24

11:15 AM

[tools] internal/typesinternal: support union types in func TypeExpr

Attention needed from Hongxiang Jiang and Robert Findley Alan Donovan added 5 comments File internal/

unread,

[tools] internal/typesinternal: support union types in func TypeExpr

Attention needed from Hongxiang Jiang and Robert Findley Alan Donovan added 5 comments File internal/

11:15 AM

Damien Neil (Gerrit), … Gopher Robot (Gerrit)5

11:13 AM

[net] http2: fix benchmarks using common frame read/write functions

Gopher Robot submitted the change Change information Commit message: http2: fix benchmarks using

unread,

[net] http2: fix benchmarks using common frame read/write functions

Gopher Robot submitted the change Change information Commit message: http2: fix benchmarks using

11:13 AM

Search

Clear search

Close search

Google apps

Main menu