Groups

golang-codereviews

Contact owners and managers

1–30 of 105805

0 selected

Ian Lance Taylor (Gerrit)

6:55 PM

[go] cmd/cgo: strip top-level const qualifier from argument frame struct

Ian Lance Taylor has uploaded the change for review Commit message cmd/cgo: strip top-level const

unread,

[go] cmd/cgo: strip top-level const qualifier from argument frame struct

Ian Lance Taylor has uploaded the change for review Commit message cmd/cgo: strip top-level const

6:55 PM

Michael Munday (Gerrit)3

6:43 PM

[go] cmd/compile/internal/ssa: simplify riscv64 FCLASSD rewrite rules

Attention needed from Joel Sing, Keith Randall and Meng Zhuo Michael Munday voted Commit-Queue+1

unread,

[go] cmd/compile/internal/ssa: simplify riscv64 FCLASSD rewrite rules

Attention needed from Joel Sing, Keith Randall and Meng Zhuo Michael Munday voted Commit-Queue+1

6:43 PM

t hepudds (Gerrit)9

6:42 PM

[go] runtime: add freeSlice

Attention needed from Carlos Amedee, Michael Knyszek and Michael Pratt t hepudds voted Commit-Queue+1

unread,

[go] runtime: add freeSlice

Attention needed from Carlos Amedee, Michael Knyszek and Michael Pratt t hepudds voted Commit-Queue+1

6:42 PM

t hepudds (Gerrit), Michael Knyszek (Gerrit)42

6:40 PM

[go] runtime: add runtime.free, runtime.freesized, runtime.freetracked to reduce GC work

Attention needed from Carlo Alberto Ferraris and t hepudds t hepudds uploaded new patchset t hepudds

unread,

[go] runtime: add runtime.free, runtime.freesized, runtime.freetracked to reduce GC work

Attention needed from Carlo Alberto Ferraris and t hepudds t hepudds uploaded new patchset t hepudds

6:40 PM

t hepudds (Gerrit), Michael Knyszek (Gerrit)6

6:40 PM

[go] runtime: support runtime.free in noscan size-specialized mallocs

Attention needed from Michael Matloob and t hepudds t hepudds uploaded new patchset t hepudds

unread,

[go] runtime: support runtime.free in noscan size-specialized mallocs

Attention needed from Michael Matloob and t hepudds t hepudds uploaded new patchset t hepudds

6:40 PM

t hepudds (Gerrit)16

6:40 PM

[go] runtime: update runtime.free for heap objects with pointers to reduce GC work

Attention needed from Michael Knyszek t hepudds uploaded new patchset t hepudds uploaded patch set #

unread,

[go] runtime: update runtime.free for heap objects with pointers to reduce GC work

Attention needed from Michael Knyszek t hepudds uploaded new patchset t hepudds uploaded patch set #

6:40 PM

Michael Knyszek (Gerrit), … Gopher Robot (Gerrit)4

6:35 PM

[website] _content/doc/gc-guide: clarify space/time tradeoff example

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[website] _content/doc/gc-guide: clarify space/time tradeoff example

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

6:35 PM

Junyang Shao (Gerrit)4

6:29 PM

[go] cmd/compile: change testing.B.Loop keep alive semantic

Attention needed from Austin Clements, Cherry Mui and David Chase Junyang Shao added 1 comment File

unread,

[go] cmd/compile: change testing.B.Loop keep alive semantic

Attention needed from Austin Clements, Cherry Mui and David Chase Junyang Shao added 1 comment File

6:29 PM

Russ Cox (Gerrit), Cherry Mui (Gerrit)7

6:03 PM

[go] runtime: avoid append in printint, printuint

Russ Cox added 1 comment Patchset-level comments File-level comment, Patchset 1: Russ Cox . resolved

unread,

[go] runtime: avoid append in printint, printuint

Russ Cox added 1 comment Patchset-level comments File-level comment, Patchset 1: Russ Cox . resolved

6:03 PM

Michael Munday (Gerrit)2

5:55 PM

[go] cmd/compile: use FCLASSD for subnormal checks on riscv64

Michael Munday voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

unread,

[go] cmd/compile: use FCLASSD for subnormal checks on riscv64

Michael Munday voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

5:55 PM

Michael Knyszek (Gerrit), Michael Pratt (Gerrit)4

5:54 PM

[go] runtime: allow Stack to traceback goroutines in syscall _Grunning window

Michael Knyszek submitted the change Change information Commit message: runtime: allow Stack to

unread,

[go] runtime: allow Stack to traceback goroutines in syscall _Grunning window

Michael Knyszek submitted the change Change information Commit message: runtime: allow Stack to

5:54 PM

Michael Knyszek (Gerrit), Cherry Mui (Gerrit)3

5:50 PM

[go] runtime: don't panic in castogscanstatus

Michael Knyszek submitted the change Change information Commit message: runtime: don't panic in

unread,

[go] runtime: don't panic in castogscanstatus

Michael Knyszek submitted the change Change information Commit message: runtime: don't panic in

5:50 PM

Ian Lance Taylor (Gerrit), Than McIntosh (Gerrit)4

5:42 PM

[go] cmd/link: add comments for SymKind values

Attention needed from Cherry Mui Ian Lance Taylor uploaded new patchset Ian Lance Taylor uploaded

unread,

[go] cmd/link: add comments for SymKind values

Attention needed from Cherry Mui Ian Lance Taylor uploaded new patchset Ian Lance Taylor uploaded

5:42 PM

Alan Donovan (Gerrit)2

5:37 PM

[tools] internal/refactor/inline: make soleUse asymptotically faster

Attention needed from Robert Findley Alan Donovan voted Auto-Submit+1 Auto-Submit +1 Open in Gerrit

unread,

[tools] internal/refactor/inline: make soleUse asymptotically faster

Attention needed from Robert Findley Alan Donovan voted Auto-Submit+1 Auto-Submit +1 Open in Gerrit

5:37 PM

Alan Donovan (Gerrit), Robert Findley (Gerrit)8

5:22 PM

[tools] go/analysis/passes/modernize: newexpr: add //go:fix inline directives

Alan Donovan voted Auto-Submit+1 Auto-Submit +1 Open in Gerrit Related details Attention set is empty

unread,

[tools] go/analysis/passes/modernize: newexpr: add //go:fix inline directives

Alan Donovan voted Auto-Submit+1 Auto-Submit +1 Open in Gerrit Related details Attention set is empty

5:22 PM

Alan Donovan (Gerrit), Robert Findley (Gerrit)11

5:21 PM

[tools] internal/refactor/inline: check caller/callee file Go versions

Alan Donovan voted and added 1 comment Votes added by Alan Donovan Auto-Submit +1 Commit-Queue +1 1

unread,

[tools] internal/refactor/inline: check caller/callee file Go versions

Alan Donovan voted and added 1 comment Votes added by Alan Donovan Auto-Submit +1 Commit-Queue +1 1

5:21 PM

t hepudds (Gerrit)2

5:19 PM

[go] runtime: add more precise test of assist credit handling for runtime.free

Attention needed from Austin Clements, Carlos Amedee and Michael Pratt t hepudds uploaded new

unread,

[go] runtime: add more precise test of assist credit handling for runtime.free

Attention needed from Austin Clements, Carlos Amedee and Michael Pratt t hepudds uploaded new

5:19 PM

Russ Cox (Gerrit), Alan Donovan (Gerrit)7

5:06 PM

[go] internal/strconv: extract fixed-precision ftoa from ftoaryu.go

Attention needed from Russ Cox Alan Donovan added 8 comments File src/internal/strconv/ftoafixed.go

unread,

[go] internal/strconv: extract fixed-precision ftoa from ftoaryu.go

Attention needed from Russ Cox Alan Donovan added 8 comments File src/internal/strconv/ftoafixed.go

5:06 PM

Michael Pratt (Gerrit), … Michael Knyszek (Gerrit)3

5:06 PM

[go] .gitignore: ignore go test artifacts

Attention needed from Michael Pratt Michael Knyszek voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[go] .gitignore: ignore go test artifacts

Attention needed from Michael Pratt Michael Knyszek voted Code-Review+2 Code-Review +2 Open in Gerrit

5:06 PM

Ethan Lee (Gerrit), … Hongxiang Jiang (Gerrit)20

5:05 PM

[telemetry] internal/chartconfig: update config to add vulncheck codelens counter

Attention needed from Ethan Lee Hongxiang Jiang voted Code-Review +2 Hold +0 Open in Gerrit Related

unread,

[telemetry] internal/chartconfig: update config to add vulncheck codelens counter

Attention needed from Ethan Lee Hongxiang Jiang voted Code-Review +2 Hold +0 Open in Gerrit Related

5:05 PM

Ethan Lee (Gerrit), … Gopher Robot (Gerrit)34

5:05 PM

[tools] internal/server: add instrumentation to track vulncheck codelens usage

Gopher Robot submitted the change Change information Commit message: internal/server: add

unread,

[tools] internal/server: add instrumentation to track vulncheck codelens usage

Gopher Robot submitted the change Change information Commit message: internal/server: add

5:05 PM

Gerrit Bot (Gerrit), … Jonathan Amsterdam (Gerrit)9

5:02 PM

[go] log/slog: add Record.AttrsIter

Attention needed from Sean Liao Jonathan Amsterdam voted and added 2 comments Votes added by Jonathan

unread,

[go] log/slog: add Record.AttrsIter

Attention needed from Sean Liao Jonathan Amsterdam voted and added 2 comments Votes added by Jonathan

5:02 PM

Hongxiang Jiang (Gerrit)7

5:02 PM

[tools] gopls/internal/filewatcher: synthesize events after watching a dir

Hongxiang Jiang voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

unread,

[tools] gopls/internal/filewatcher: synthesize events after watching a dir

Hongxiang Jiang voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

5:02 PM

Michael Pratt (Gerrit), … Michael Knyszek (Gerrit)12

4:59 PM

[go] runtime: prefer to restart Ps on the same M after STW

Michael Pratt voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

unread,

[go] runtime: prefer to restart Ps on the same M after STW

Michael Pratt voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

4:59 PM

Gerrit Bot (Gerrit), … Michael Matloob (Gerrit)10

4:49 PM

[go] cmd/go: clear GOROOT for func ldShared when -trimpath is used

Attention needed from hongxu jia Michael Matloob added 1 comment Patchset-level comments File-level

unread,

[go] cmd/go: clear GOROOT for func ldShared when -trimpath is used

Attention needed from hongxu jia Michael Matloob added 1 comment Patchset-level comments File-level

4:49 PM

Gopher Robot (Gerrit), … Gerrit Bot (Gerrit)58

4:44 PM

[go] net/http: add context cancellation reason for server handlers

Attention needed from Damien Neil, Jes Cok and t hepudds Gerrit Bot uploaded new patchset Gerrit Bot

unread,

[go] net/http: add context cancellation reason for server handlers

Attention needed from Damien Neil, Jes Cok and t hepudds Gerrit Bot uploaded new patchset Gerrit Bot

4:44 PM

Michael Knyszek (Gerrit)

4:44 PM

[go] runtime: fix lock rank for work.spanSPMCs.lock

Attention needed from Michael Pratt Michael Knyszek voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[go] runtime: fix lock rank for work.spanSPMCs.lock

Attention needed from Michael Pratt Michael Knyszek voted Commit-Queue+1 Commit-Queue +1 Open in

4:44 PM

Gerrit Bot (Gerrit), … Michael Matloob (Gerrit)38

4:41 PM

[go] cmd/go: fix `-coverpkg` not ignoring special directories

Attention needed from Emmanuel Odeke, Funda Secgin, Ian Lance Taylor, Sam Thanawalla and Than

unread,

[go] cmd/go: fix `-coverpkg` not ignoring special directories

Attention needed from Emmanuel Odeke, Funda Secgin, Ian Lance Taylor, Sam Thanawalla and Than

4:41 PM

Youlin Feng (Gerrit), Keith Randall (Gerrit)45

4:38 PM

[go] cmd/compile/internal/ssa: more aggressive on dead auto elim

Attention needed from David Chase and Youlin Feng Keith Randall voted Code-Review+1 Code-Review +1

unread,

[go] cmd/compile/internal/ssa: more aggressive on dead auto elim

Attention needed from David Chase and Youlin Feng Keith Randall voted Code-Review+1 Code-Review +1

4:38 PM

Gerrit Bot (Gerrit), Keith Randall (Gerrit)3

4:34 PM

[go] runtime: amend doc for setPinned

Attention needed from Austin Clements and Martin Möhrmann Keith Randall voted Code-Review+1 Code-

unread,

[go] runtime: amend doc for setPinned

Attention needed from Austin Clements and Martin Möhrmann Keith Randall voted Code-Review+1 Code-

4:34 PM

Search

Clear search

Close search

Google apps

Main menu