Groups

golang-codereviews

Contact owners and managers

1–30 of 109092

0 selected

Hyang-Ah Hana Kim (Gerrit), Alan Donovan (Gerrit)2

Apr 8

[tools] gopls: add test cases for embedded fields in struct literals

Attention needed from Hongxiang Jiang and Hyang-Ah Hana Kim Alan Donovan added 5 comments Patchset-

unread,

[tools] gopls: add test cases for embedded fields in struct literals

Attention needed from Hongxiang Jiang and Hyang-Ah Hana Kim Alan Donovan added 5 comments Patchset-

Apr 8

Gerrit Bot (Gerrit), … Abhay Chaurasiya (Gerrit)6

Apr 8

[tools] gopls/completion: prepend space when completing right after "//" before a declaration

Attention needed from Alan Donovan Abhay Chaurasiya added 1 comment Patchset-level comments File-

unread,

[tools] gopls/completion: prepend space when completing right after "//" before a declaration

Attention needed from Alan Donovan Abhay Chaurasiya added 1 comment Patchset-level comments File-

Apr 8

Gerrit Bot (Gerrit), Ryan Currah (Gerrit)5

Apr 8

[go/release-branch.go1.26] [release-branch.go1.26] cmd/go: invalidate test cache when -coverpkg dependencies change

Ryan Currah added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Ryan

unread,

[go/release-branch.go1.26] [release-branch.go1.26] cmd/go: invalidate test cache when -coverpkg dependencies change

Ryan Currah added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Ryan

Apr 8

Quim Muntal (Gerrit), … abner chenc (Gerrit)6

Apr 8

[go] cmd/internal/tesdir: fix Test/codegen/switch on loong64

Attention needed from Keith Randall and Quim Muntal abner chenc voted Code-Review+2 Code-Review +2

unread,

[go] cmd/internal/tesdir: fix Test/codegen/switch on loong64

Attention needed from Keith Randall and Quim Muntal abner chenc voted Code-Review+2 Code-Review +2

Apr 8

Mateusz Poliwczak (Gerrit), Alan Donovan (Gerrit)19

Apr 8

[tools] gopls: add shadowed semantic token modifier

Attention needed from Mateusz Poliwczak Alan Donovan added 2 comments File gopls/internal/golang/

unread,

[tools] gopls: add shadowed semantic token modifier

Attention needed from Mateusz Poliwczak Alan Donovan added 2 comments File gopls/internal/golang/

Apr 8

Robert Findley (Gerrit)

Apr 8

[tools] gopls/internal/golang: pre-filter identifiers by name in localReferences

Robert Findley has uploaded the change for review Commit message gopls/internal/golang: pre-filter

unread,

[tools] gopls/internal/golang: pre-filter identifiers by name in localReferences

Robert Findley has uploaded the change for review Commit message gopls/internal/golang: pre-filter

Apr 8

Hyang-Ah Hana Kim (Gerrit), Robert Griesemer (Gerrit)6

Apr 8

[website] _content/doc/effective_go: update for Go 1.26 and concise warning

Attention needed from Robert Griesemer Hyang-Ah Hana Kim voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[website] _content/doc/effective_go: update for Go 1.26 and concise warning

Attention needed from Robert Griesemer Hyang-Ah Hana Kim voted Commit-Queue+1 Commit-Queue +1 Open in

Apr 8

Ian Lance Taylor (Gerrit)

Apr 8

[go] cmd/link: set the size of runtime.gcmask.* on AIX

Attention needed from Cherry Mui and Keith Randall Ian Lance Taylor has uploaded the change for

unread,

[go] cmd/link: set the size of runtime.gcmask.* on AIX

Attention needed from Cherry Mui and Keith Randall Ian Lance Taylor has uploaded the change for

Apr 8

Neal Patel (Gerrit)10

Apr 8

[go] crypto/sha3: ensure unwrapped *sha3.Digest are usable

Attention needed from Filippo Valsorda and Roland Shoemaker Neal Patel voted Commit-Queue+1 Commit-

unread,

[go] crypto/sha3: ensure unwrapped *sha3.Digest are usable

Attention needed from Filippo Valsorda and Roland Shoemaker Neal Patel voted Commit-Queue+1 Commit-

Apr 8

Kirill Kolyshkin (Gerrit), … David Chase (Gerrit)15

Apr 8

[sys] unix: add CPUSetDynamic for systems with more than 1024 CPUs

Kirill Kolyshkin submitted the change with unreviewed changes Unreviewed changes 3 is the latest

unread,

[sys] unix: add CPUSetDynamic for systems with more than 1024 CPUs

Kirill Kolyshkin submitted the change with unreviewed changes Unreviewed changes 3 is the latest

Apr 8

Robert Findley (Gerrit), Alan Donovan (Gerrit)5

Apr 8

[tools] gopls/internal/util/frob: change Codec.Decode to return the value

Attention needed from Robert Findley Robert Findley uploaded new patchset Robert Findley uploaded

unread,

[tools] gopls/internal/util/frob: change Codec.Decode to return the value

Attention needed from Robert Findley Robert Findley uploaded new patchset Robert Findley uploaded

Apr 8

Robert Findley (Gerrit)4

Apr 8

[tools] gopls/internal/cache: try pre func before getPackageHandles in forEachPackage

Attention needed from Alan Donovan Robert Findley voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[tools] gopls/internal/cache: try pre func before getPackageHandles in forEachPackage

Attention needed from Alan Donovan Robert Findley voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

Apr 8

Robert Findley (Gerrit), Alan Donovan (Gerrit)15

Apr 8

[tools] gopls/internal/filecache: add GetDecoded for caching decoded objects

Robert Findley voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

unread,

[tools] gopls/internal/filecache: add GetDecoded for caching decoded objects

Robert Findley voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

Apr 8

Mark Freeman (Gerrit), Robert Griesemer (Gerrit)3

Apr 8

[go] test: more tests for generic methods

Attention needed from Mark Freeman Robert Griesemer voted and added 5 comments Votes added by Robert

unread,

[go] test: more tests for generic methods

Attention needed from Mark Freeman Robert Griesemer voted and added 5 comments Votes added by Robert

Apr 8

Mark Freeman (Gerrit), … Gopher Robot (Gerrit)4

Apr 8

[tools] internal/gcimporter: rename ureader_yes.go to ureader.go

Gopher Robot submitted the change Change information Commit message: internal/gcimporter: rename

unread,

[tools] internal/gcimporter: rename ureader_yes.go to ureader.go

Gopher Robot submitted the change Change information Commit message: internal/gcimporter: rename

Apr 8

Hyang-Ah Hana Kim (Gerrit), … Dmitri Shuralyov (Gerrit)11

Apr 8

[dl] internal/version: set GOTOOLCHAIN=local+auto for gotip

Attention needed from Dmitri Shuralyov Hyang-Ah Hana Kim added 2 comments Commit Message Line 9,

unread,

[dl] internal/version: set GOTOOLCHAIN=local+auto for gotip

Attention needed from Dmitri Shuralyov Hyang-Ah Hana Kim added 2 comments Commit Message Line 9,

Apr 8

Nicholas Husin (Gerrit), Damien Neil (Gerrit)7

Apr 8

[go] wip: net/http: add support for running HTTP tests against HTTP/3

Attention needed from Nicholas Husin Nicholas Husin voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[go] wip: net/http: add support for running HTTP tests against HTTP/3

Attention needed from Nicholas Husin Nicholas Husin voted Code-Review+1 Code-Review +1 Open in Gerrit

Apr 8

Robert Findley (Gerrit)

Apr 8

[tools] gopls/internal/cache: store analyzeSummary fields on analysisNode

Robert Findley has uploaded the change for review Commit message gopls/internal/cache: store

unread,

[tools] gopls/internal/cache: store analyzeSummary fields on analysisNode

Robert Findley has uploaded the change for review Commit message gopls/internal/cache: store

Apr 8

Denis Melnikov (Gerrit), … Gopher Robot (Gerrit)21

Apr 8

[go] cmd/compile: improve stp merging for non-sequent cases

Gopher Robot submitted the change Change information Commit message: cmd/compile: improve stp merging

unread,

[go] cmd/compile: improve stp merging for non-sequent cases

Gopher Robot submitted the change Change information Commit message: cmd/compile: improve stp merging

Apr 8

Nicholas Husin (Gerrit), Damien Neil (Gerrit)5

Apr 8

[go] net/http/internal/http2: prevent alloc when writing status code for responses

Nicholas Husin submitted the change Change information Commit message: net/http/internal/http2:

unread,

[go] net/http/internal/http2: prevent alloc when writing status code for responses

Nicholas Husin submitted the change Change information Commit message: net/http/internal/http2:

Apr 8

Quim Muntal (Gerrit), … Damien Neil (Gerrit)10

Apr 8

[go] cmd/link: fallback to older minimum Windows target version on older C GNU toolchains

Attention needed from Alex Brainman, Jason Donenfeld and Quim Muntal Damien Neil voted and added 1

unread,

[go] cmd/link: fallback to older minimum Windows target version on older C GNU toolchains

Attention needed from Alex Brainman, Jason Donenfeld and Quim Muntal Damien Neil voted and added 1

Apr 8

Nicholas Husin (Gerrit), Damien Neil (Gerrit)6

Apr 8

[go] wip: net/http/internal/http3: add golang.org/x/net/internal/http3 bundle

Nicholas Husin submitted the change Change information Commit message: all: update to x/net@056ac74

unread,

[go] wip: net/http/internal/http3: add golang.org/x/net/internal/http3 bundle

Nicholas Husin submitted the change Change information Commit message: all: update to x/net@056ac74

Apr 8

t hepudds (Gerrit)

Apr 8

[go] runtime: estimate starting stack sizes by calculating percentiles of scanned sizes

t hepudds uploaded new patchset t hepudds uploaded patch set #4 to this change. Open in Gerrit

unread,

[go] runtime: estimate starting stack sizes by calculating percentiles of scanned sizes

t hepudds uploaded new patchset t hepudds uploaded patch set #4 to this change. Open in Gerrit

Apr 8

Jonathan Swinney (Gerrit)3

Apr 8

[go/dev.simd] [dev.simd] cmd/internal/obj/arm64: add indexed element operand patterns for VFMLA/VFMLS/VFMUL

Jonathan Swinney abandoned this change. View Change Abandoned replaced by CL764224 Jonathan Swinney

unread,

[go/dev.simd] [dev.simd] cmd/internal/obj/arm64: add indexed element operand patterns for VFMLA/VFMLS/VFMUL

Jonathan Swinney abandoned this change. View Change Abandoned replaced by CL764224 Jonathan Swinney

Apr 8

Jonathan Swinney (Gerrit)3

Apr 8

[go] [dev.simd] cmd/internal/obj/arm64: add indexed element operand patterns for VFMLA/VFMLS/VFMUL

Jonathan Swinney has uploaded the change for review Commit message cmd/internal/obj/arm64: add

unread,

[go] [dev.simd] cmd/internal/obj/arm64: add indexed element operand patterns for VFMLA/VFMLS/VFMUL

Jonathan Swinney has uploaded the change for review Commit message cmd/internal/obj/arm64: add

Apr 8

Jonathan Swinney (Gerrit)2

Apr 8

[go] [dev.simd] cmd/internal/obj/arm64: fix VFCM* compare-against-zero to accept $0

Attention needed from Cherry Mui Jonathan Swinney uploaded new patchset Jonathan Swinney uploaded

unread,

[go] [dev.simd] cmd/internal/obj/arm64: fix VFCM* compare-against-zero to accept $0

Attention needed from Cherry Mui Jonathan Swinney uploaded new patchset Jonathan Swinney uploaded

Apr 8

Jonathan Swinney (Gerrit), Alexander Musman (Gerrit)8

Apr 8

[go/dev.simd] [dev.simd] cmd/internal/obj/arm64: add scalar pairwise and reduction operand patterns

Attention needed from Cherry Mui Jonathan Swinney uploaded new patchset Jonathan Swinney uploaded

unread,

[go/dev.simd] [dev.simd] cmd/internal/obj/arm64: add scalar pairwise and reduction operand patterns

Attention needed from Cherry Mui Jonathan Swinney uploaded new patchset Jonathan Swinney uploaded

Apr 8

Jonathan Swinney (Gerrit)3

Apr 8

[go/dev.simd] [dev.simd] cmd/internal/obj/arm64: fix VFCM* compare-against-zero to accept $0

Jonathan Swinney abandoned this change. View Change Abandoned Replaced with CL764221 Jonathan Swinney

unread,

[go/dev.simd] [dev.simd] cmd/internal/obj/arm64: fix VFCM* compare-against-zero to accept $0

Jonathan Swinney abandoned this change. View Change Abandoned Replaced with CL764221 Jonathan Swinney

Apr 8

Jonathan Amsterdam (Gerrit), … kokoro (Gerrit)18

Apr 8

[pkgsite] internal/api: set cache-control headers

Jonathan Amsterdam submitted the change with unreviewed changes Unreviewed changes 3 is the latest

unread,

[pkgsite] internal/api: set cache-control headers

Jonathan Amsterdam submitted the change with unreviewed changes Unreviewed changes 3 is the latest

Apr 8

Gerrit Bot (Gerrit), … Jorropo (Gerrit)5

Apr 8

[go] cmd/link: add Cortex-A53 erratum 843419 workaround for arm64

Jorropo voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

unread,

[go] cmd/link: add Cortex-A53 erratum 843419 workaround for arm64

Jorropo voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

Apr 8

Search

Clear search

Close search

Google apps

Main menu