Groups
Sign in
Groups
golang-codereviews
Conversations
About
Send feedback
Help
golang-codereviews
Contact owners and managers
1–30 of 95123
Mark all as read
Report group
0 selected
Than McIntosh (Gerrit)
,
Dmitri Shuralyov (Gerrit)
8
7:39 PM
[website] go.mod: update x/build to CL 596477
Than McIntosh submitted the change with unreviewed changes Unreviewed changes 2 is the latest
unread,
[website] go.mod: update x/build to CL 596477
Than McIntosh submitted the change with unreviewed changes Unreviewed changes 2 is the latest
7:39 PM
Tatiana Bradley (Gerrit)
, …
Tim King (Gerrit)
6
7:10 PM
[vulndb] internal/report,data/osv: add explanation of non-Go versions
Attention needed from Ian Cottrell and Tatiana Bradley Tim King added 1 comment Patchset-level
unread,
[vulndb] internal/report,data/osv: add explanation of non-Go versions
Attention needed from Ian Cottrell and Tatiana Bradley Tim King added 1 comment Patchset-level
7:10 PM
Tatiana Bradley (Gerrit)
,
Tim King (Gerrit)
6
7:09 PM
[website] _content/doc/security/vuln: add section on non-Go versions
Attention needed from Ian Cottrell, Roland Shoemaker and Tatiana Bradley Tim King added 8 comments
unread,
[website] _content/doc/security/vuln: add section on non-Go versions
Attention needed from Ian Cottrell, Roland Shoemaker and Tatiana Bradley Tim King added 8 comments
7:09 PM
Cherry Mui (Gerrit)
,
Than McIntosh (Gerrit)
4
6:43 PM
[go] cmd/link: don't disable memory profiling when pprof.WriteHeapProfile is used
Cherry Mui submitted the change Change information Commit message: cmd/link: don't disable memory
unread,
[go] cmd/link: don't disable memory profiling when pprof.WriteHeapProfile is used
Cherry Mui submitted the change Change information Commit message: cmd/link: don't disable memory
6:43 PM
Than McIntosh (Gerrit)
, …
Gopher Robot (Gerrit)
5
6:23 PM
[build/luci-config] main.star: mark x/oscar as a PT.TOOLS repository
Gopher Robot submitted the change Change information Commit message: main.star: mark x/oscar as a PT.
unread,
[build/luci-config] main.star: mark x/oscar as a PT.TOOLS repository
Gopher Robot submitted the change Change information Commit message: main.star: mark x/oscar as a PT.
6:23 PM
Manuel Sabin (Gerrit)
,
Russell Webb (Gerrit)
14
6:12 PM
[go] crypto: add tests for the Block interface
Attention needed from Filippo Valsorda and Manuel Sabin Russell Webb voted and added 8 comments Votes
unread,
[go] crypto: add tests for the Block interface
Attention needed from Filippo Valsorda and Manuel Sabin Russell Webb voted and added 8 comments Votes
6:12 PM
Manuel Sabin (Gerrit)
,
qiu laidongfeng2 (Gerrit)
5
5:58 PM
[go] crypto: add tests for the cipher.Stream interface
Attention needed from Manuel Sabin, Russell Webb and qiu laidongfeng2 Manuel Sabin uploaded new
unread,
[go] crypto: add tests for the cipher.Stream interface
Attention needed from Manuel Sabin, Russell Webb and qiu laidongfeng2 Manuel Sabin uploaded new
5:58 PM
Than McIntosh (Gerrit)
, …
Gopher Robot (Gerrit)
5
5:44 PM
[build] devapp/owners: add rsc as owner of x/oscar
Gopher Robot submitted the change Change information Commit message: devapp/owners: add rsc as owner
unread,
[build] devapp/owners: add rsc as owner of x/oscar
Gopher Robot submitted the change Change information Commit message: devapp/owners: add rsc as owner
5:44 PM
Than McIntosh (Gerrit)
, …
Gopher Robot (Gerrit)
5
5:43 PM
[build] repos: add oscar
Gopher Robot submitted the change Change information Commit message: repos: add oscar Change-Id:
unread,
[build] repos: add oscar
Gopher Robot submitted the change Change information Commit message: repos: add oscar Change-Id:
5:43 PM
Hongxiang Jiang (Gerrit)
,
Hyang-Ah Hana Kim (Gerrit)
6
5:39 PM
[telemetry] godev/cmd/worker: add readCount method and unit test
Attention needed from Hongxiang Jiang and Robert Findley Hyang-Ah Hana Kim added 4 comments File
unread,
[telemetry] godev/cmd/worker: add readCount method and unit test
Attention needed from Hongxiang Jiang and Robert Findley Hyang-Ah Hana Kim added 4 comments File
5:39 PM
Nick Ripley (Gerrit)
, …
Cherry Mui (Gerrit)
8
5:38 PM
[go] runtime: aggregate records with identical stacks in MutexProfile
Attention needed from Felix Geisendörfer, Nick Ripley and Rhys Hiltner Cherry Mui added 5 comments
unread,
[go] runtime: aggregate records with identical stacks in MutexProfile
Attention needed from Felix Geisendörfer, Nick Ripley and Rhys Hiltner Cherry Mui added 5 comments
5:38 PM
Manuel Sabin (Gerrit)
6
5:35 PM
[go] crypto: add tests for the cipher.BlockMode interface
Attention needed from Filippo Valsorda and Russell Webb Manuel Sabin uploaded new patchset Manuel
unread,
[go] crypto: add tests for the cipher.BlockMode interface
Attention needed from Filippo Valsorda and Russell Webb Manuel Sabin uploaded new patchset Manuel
5:35 PM
Manuel Sabin (Gerrit)
, …
Filippo Valsorda (Gerrit)
24
4:48 PM
[go] crypto: add common tests for the hash.Hash interface
Attention needed from Filippo Valsorda, Roland Shoemaker and qiu laidongfeng2 Manuel Sabin added 7
unread,
[go] crypto: add common tests for the hash.Hash interface
Attention needed from Filippo Valsorda, Roland Shoemaker and qiu laidongfeng2 Manuel Sabin added 7
4:48 PM
Quan Tong (Gerrit)
, …
Michael Matloob (Gerrit)
6
4:12 PM
[go] cmd/go: stamp VCS info when building .go files directly
Attention needed from Bryan Mills, Michael Matloob, Quan Tong and Vegard Stikbakke Michael Matloob
unread,
[go] cmd/go: stamp VCS info when building .go files directly
Attention needed from Bryan Mills, Michael Matloob, Quan Tong and Vegard Stikbakke Michael Matloob
4:12 PM
Hongxiang Jiang (Gerrit)
, …
Hyang-Ah Hana Kim (Gerrit)
10
4:00 PM
[telemetry] godev/cmd/worker: add unit test for normalizeCounterName
Hongxiang Jiang submitted the change Change information Commit message: godev/cmd/worker: add unit
unread,
[telemetry] godev/cmd/worker: add unit test for normalizeCounterName
Hongxiang Jiang submitted the change Change information Commit message: godev/cmd/worker: add unit
4:00 PM
Sameer Ajmani (Gerrit)
3:36 PM
[oscar] initial commit
Attention needed from Russ Cox Sameer Ajmani voted Code-Review+2 Code-Review +2 Open in Gerrit
unread,
[oscar] initial commit
Attention needed from Russ Cox Sameer Ajmani voted Code-Review+2 Code-Review +2 Open in Gerrit
3:36 PM
David Chase (Gerrit)
,
Keith Randall (Gerrit)
8
3:22 PM
[go] cmd/compile: add memory-less pure call and rewrite to static call
Attention needed from Martin Möhrmann and Matthew Dempsky David Chase uploaded new patchset David
unread,
[go] cmd/compile: add memory-less pure call and rewrite to static call
Attention needed from Martin Möhrmann and Matthew Dempsky David Chase uploaded new patchset David
3:22 PM
David Chase (Gerrit)
, …
Cherry Mui (Gerrit)
5
3:22 PM
[go] cmd/compile: enable CSE of pure calls.
Attention needed from Martin Möhrmann David Chase uploaded new patchset David Chase uploaded patch
unread,
[go] cmd/compile: enable CSE of pure calls.
Attention needed from Martin Möhrmann David Chase uploaded new patchset David Chase uploaded patch
3:22 PM
Rhys Hiltner (Gerrit)
, …
Carlos Amedee (Gerrit)
5
3:17 PM
[go] internal/trace: make Reader output deterministic
Attention needed from Michael Knyszek and Rhys Hiltner Carlos Amedee voted Code-Review+1 Code-Review
unread,
[go] internal/trace: make Reader output deterministic
Attention needed from Michael Knyszek and Rhys Hiltner Carlos Amedee voted Code-Review+1 Code-Review
3:17 PM
Dmitri Shuralyov (Gerrit)
2
3:13 PM
[website] cmd/golangorg: fix package link URLs
Attention needed from Russ Cox Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit
unread,
[website] cmd/golangorg: fix package link URLs
Attention needed from Russ Cox Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit
3:13 PM
Ian Lance Taylor (Gerrit)
, …
Gopher Robot (Gerrit)
4
3:02 PM
[go] cmd/cgo: read CGO_LDFLAGS environment variable
Gopher Robot submitted the change Change information Commit message: cmd/cgo: read CGO_LDFLAGS
unread,
[go] cmd/cgo: read CGO_LDFLAGS environment variable
Gopher Robot submitted the change Change information Commit message: cmd/cgo: read CGO_LDFLAGS
3:02 PM
Cuong Manh Le (Gerrit)
, …
Cherry Mui (Gerrit)
18
2:45 PM
[go] cmd/compile: fix ICE when compiling global a, b = f()
Attention needed from Cuong Manh Le, Keith Randall and Than McIntosh Cherry Mui voted and added 1
unread,
[go] cmd/compile: fix ICE when compiling global a, b = f()
Attention needed from Cuong Manh Le, Keith Randall and Than McIntosh Cherry Mui voted and added 1
2:45 PM
Dmitri Shuralyov (Gerrit)
, …
Gopher Robot (Gerrit)
6
2:32 PM
[wiki] CreatingSubRepository: update for migration to LUCI
Gopher Robot submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved
unread,
[wiki] CreatingSubRepository: update for migration to LUCI
Gopher Robot submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved
2:32 PM
Clide Stefani (Gerrit)
, …
Russell Webb (Gerrit)
4
2:28 PM
[go] cryto/tls: WIP Add noTLSFlags to bogo_shim_test
Attention needed from Clide Stefani and Filippo Valsorda Russell Webb voted Code-Review+1 Code-Review
unread,
[go] cryto/tls: WIP Add noTLSFlags to bogo_shim_test
Attention needed from Clide Stefani and Filippo Valsorda Russell Webb voted Code-Review+1 Code-Review
2:28 PM
Garrett (Gerrit)
, …
Filippo Valsorda (Gerrit)
10
2:22 PM
[crypto] sha3: Avo implementation of keccakf_amd64.s
Attention needed from Clide Stefani, Esra Al, Garrett, Manuel Sabin, Michael McLoughlin, Roland
unread,
[crypto] sha3: Avo implementation of keccakf_amd64.s
Attention needed from Clide Stefani, Esra Al, Garrett, Manuel Sabin, Michael McLoughlin, Roland
2:22 PM
Cuong Manh Le (Gerrit)
, …
Keith Randall (Gerrit)
35
2:20 PM
[go] cmd/compile: fix mis-compilation when switching over channels
Cuong Manh Le abandoned this change Related details Attention set is empty Submit Requirements: Code-
unread,
[go] cmd/compile: fix mis-compilation when switching over channels
Cuong Manh Le abandoned this change Related details Attention set is empty Submit Requirements: Code-
2:20 PM
Cuong Manh Le (Gerrit)
,
Keith Randall (Gerrit)
4
2:07 PM
[go] cmd/compile: prevent un-necessary wrapping in switch statement
Attention needed from Cuong Manh Le Keith Randall voted Code-Review+1 Code-Review +1 Open in Gerrit
unread,
[go] cmd/compile: prevent un-necessary wrapping in switch statement
Attention needed from Cuong Manh Le Keith Randall voted Code-Review+1 Code-Review +1 Open in Gerrit
2:07 PM
Cherry Mui (Gerrit)
,
Than McIntosh (Gerrit)
8
1:26 PM
[go] cmd/link: don't let dsymutil delete our temp directory
Attention needed from Cherry Mui Than McIntosh voted Code-Review+2 Code-Review +2 Open in Gerrit
unread,
[go] cmd/link: don't let dsymutil delete our temp directory
Attention needed from Cherry Mui Than McIntosh voted Code-Review+2 Code-Review +2 Open in Gerrit
1:26 PM
Cuong Manh Le (Gerrit)
, …
Cherry Mui (Gerrit)
7
1:17 PM
[go] cmd/compile: correct RewriteMultiValueCall fatal message
Attention needed from Keith Randall Cuong Manh Le voted Auto-Submit +1 Commit-Queue +1 Open in Gerrit
unread,
[go] cmd/compile: correct RewriteMultiValueCall fatal message
Attention needed from Keith Randall Cuong Manh Le voted Auto-Submit +1 Commit-Queue +1 Open in Gerrit
1:17 PM
Hyang-Ah Hana Kim (Gerrit)
,
Robert Findley (Gerrit)
6
1:08 PM
[telemetry] cmd/gotelemetry: fix chart x-axis time interval display
Attention needed from Robert Findley Hyang-Ah Hana Kim added 4 comments File cmd/gotelemetry/internal
unread,
[telemetry] cmd/gotelemetry: fix chart x-axis time interval display
Attention needed from Robert Findley Hyang-Ah Hana Kim added 4 comments File cmd/gotelemetry/internal
1:08 PM