[go] syscall: make plan9 Errno implement the error interface

0 views
Skip to first unread message

Brad Fitzpatrick (Gerrit)

unread,
Mar 4, 2026, 12:35:52 PM (yesterday) Mar 4
to Brad Fitzpatrick, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Dmitri Shuralyov, Damien Neil, Tobias Klauser, Ian Lance Taylor, Go LUCI, Gopher Robot, golang-co...@googlegroups.com

Brad Fitzpatrick submitted the change

Change information

Commit message:
syscall: make plan9 Errno implement the error interface

The Errno type was added to plan9 in CL 750680 but without methods,
so it didn't satisfy the error interface. Add Error, Temporary, and
Timeout methods to match all other platforms and the Go 1 API contract
(api/go1.txt's "pkg syscall, method (Errno) Error() string", etc).

And add a test that all platforms have Errno, implementing error.
Change-Id: Ie96fe03a31940d52c5bb7828aa1b743d15a9c4ee
Reviewed-by: Tobias Klauser <tobias....@gmail.com>
Reviewed-by: Damien Neil <dn...@google.com>
Reviewed-by: Ian Lance Taylor <ia...@golang.org>
Auto-Submit: Damien Neil <dn...@google.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Files:
  • M src/syscall/syscall_plan9.go
  • M src/syscall/syscall_test.go
Change size: XS
Delta: 2 files changed, 8 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dmitri Shuralyov, +2 by Tobias Klauser, +2 by Ian Lance Taylor, +2 by Damien Neil
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ie96fe03a31940d52c5bb7828aa1b743d15a9c4ee
Gerrit-Change-Number: 751100
Gerrit-PatchSet: 2
Gerrit-Owner: Brad Fitzpatrick <brad...@golang.org>
Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Tobias Klauser <tobias....@gmail.com>
Gerrit-CC: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-CC: Gopher Robot <go...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages