[go] archive/tar, compress/bzip2: base64 some troublesome testdata files

1 view
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Dec 15, 2025, 11:34:20 AM (23 hours ago) Dec 15
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Knyszek, David Chase, Joseph Tsai, t hepudds, Go LUCI, Matthew Dempsky, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
archive/tar, compress/bzip2: base64 some troublesome testdata files

This avoids complaints from scanners that look for and open
tar and bz2 files, and complain if they look weird.
In this case, they do look weird, because they are intentionally strange.
This kind of thing shouldn't be necessary, but we already have the machinery
to do it so it's easy enough.

Fixes #76799
Change-Id: Ib302b3aef30108a1325f91fcb2d166f8e1863792
Reviewed-by: David Chase <drc...@google.com>
Auto-Submit: Ian Lance Taylor <ia...@golang.org>
Reviewed-by: Michael Knyszek <mkny...@google.com>
Reviewed-by: Joseph Tsai <joe...@digital-static.net>
Files:
  • M src/archive/tar/reader_test.go
  • D src/archive/tar/testdata/gnu-sparse-big.tar
  • A src/archive/tar/testdata/gnu-sparse-big.tar.base64
  • D src/archive/tar/testdata/neg-size.tar
  • A src/archive/tar/testdata/neg-size.tar.base64
  • D src/archive/tar/testdata/pax-sparse-big.tar
  • A src/archive/tar/testdata/pax-sparse-big.tar.base64
  • D src/archive/tar/testdata/writer-big-long.tar
  • A src/archive/tar/testdata/writer-big-long.tar.base64
  • M src/archive/tar/writer_test.go
  • M src/compress/bzip2/bzip2_test.go
  • D src/compress/bzip2/testdata/fail-issue5747.bz2
  • A src/compress/bzip2/testdata/fail-issue5747.bz2.base64
Change size: L
Delta: 13 files changed, 414 insertions(+), 17 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Joseph Tsai, +1 by Michael Knyszek, +1 by David Chase
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ib302b3aef30108a1325f91fcb2d166f8e1863792
Gerrit-Change-Number: 729780
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Joseph Tsai <joe...@digital-static.net>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: t hepudds <thepud...@gmail.com>
Gerrit-CC: Matthew Dempsky <mat...@go.dev>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages